GitLab

components_perftests and views_perftests run on the CQ
and use run_performance_tests_wrapper.py. This changelist
migrates them to use run_performance_tests.py. This migration
unblocks deleting run_gtest_perf_test.py (and then all the
perf tests use run_performance_tests.py as their runner,
which then allows us to finally delete
run_performance_tests_wrapper.py.)

Note that I also needed to add a slash at the end of
a target for components/BUILD.gn since I was getting the
error
"Input directory [...]src/components/subresource_filter/
core/common/perftests/data must have a trailing slash
"

CC=​​​​​​tapted@chromium.org
R=johnchen@chromium.org,eyaich@chromium.org
TBR=blundell@chromium.org

Bug: 924351
Change-Id: I9f4542c22b72d45176574d379ed4eaedf6eb8e92
Reviewed-on: https://chromium-review.googlesource.com/c/1428090
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625429}

UrlFetchRequestBase::WriteFileData was using an invalid
base::StringPiece object. This was because the StringPiece
passed to OnDataReceived is only guaranteed to be valid
for the duration of the call, but was being posted to
another task runner. This fixes this bug by creating a copy
of the file data.

Bug: 905097
Change-Id: I335d4ddce29b21f4b7fcd6d686b1de20d3bdad47
Reviewed-on: https://chromium-review.googlesource.com/c/1431692Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#625428}

Currently the All Sites page |siteGroupMap| will not repopulate when we
click the back button from the Site Details page. This CL populates the
site list data whenever the All Sites route is navigated.

This CL also simplifies the |siteGroupMap| updating mechanism. Since the
site list sent from the backend will always include permissions and
storage, we can simply in-place update the |siteGroupMap| when a new list
is fetched.

BUG=835712

Change-Id: If8c6d8ae5092cfaa7b85dd49527c478243cddf86
Reviewed-on: https://chromium-review.googlesource.com/c/1428622Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625427}

Follow-up work includes adding "setUpOnlineDemoMode" in oobe.py.

oobe.py uses md_login_shared.js instead of oobe.js as the entry point
for autotests.

Bug: 870049
Change-Id: I97afc5e5aac16c8ff83f168af4c63b0e0439f3d2
Reviewed-on: https://chromium-review.googlesource.com/c/1431479Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625426}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f9f137868bd..80e56cb3f138


Created with:
  gclient setdep -r src-internal@80e56cb3f138

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6e4614f5e3d16c03edb451e97dc5d41ea74e548f
Reviewed-on: https://chromium-review.googlesource.com/c/1432513Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625425}

shouldInterceptRequest callback should not be called for special
android URLs, unless they fail to load. Special android urls are
urls such as "file:///android_asset/", "file:///android_res/"
or "content:" scheme urls.

Fixed tests:
-AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingAsset
-AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingContentUrl
-AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingResource

BUG=893566,841556

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: I1fd6275194d2ee2d09822896f53626e96789ff32
Reviewed-on: https://chromium-review.googlesource.com/c/1424892Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625424}

There is no way for a FlingingRenderer (which corresponds 1:1 with a
video playing remotely on a cast device) to signal to WMPI that an
external device has paused/resumed the video.

This CL adds the necessary plumbing for FlingingRenderer to send state
changes back to media::Pipeline, via the RendererClient interface.

Two follow up CLs are planned: adding OnRemotePlayStateChange to
Pipeline::Client, and adding the logic to keep WMPI's play/pause state
in sync with the externally playing video.

Bug: 790766
Change-Id: I85bb77d85000d7913bc9e7f52048daf527e1c8c7
Reviewed-on: https://chromium-review.googlesource.com/c/1412806Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625423}

It is very similar to the one in current StubbedProvider

Bug: 728297
Change-Id: I6df1af44ac2746acdc23d5ae0f095ced5951132c
Reviewed-on: https://chromium-review.googlesource.com/c/1419857
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625422}

safety_net_id field is still unset.
Added a TODO for that.

R=drubery

Bug: 907280
Change-Id: Ic6b78615aeb79e7cb5e07c741d30a312e50e6640
Reviewed-on: https://chromium-review.googlesource.com/c/1422741
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625421}

This reverts commit cb521877.

Reason for revert: causing compile errors on ios bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/112397

Original change's description:
> CC: Support YUV images in PaintImage and GpuImageDecodeCache
> 
> This patch modifies PaintImage to have an interface to indicate
> that the underlying image is YUV pixel format and adds a
> corresponding DecodeYuv() method.
> 
> In GpuImageDecodeCache, this change adds "is YUV" variables/getters to
> DecodedImageData, UploadedImageData (has_yuv_planes()), and ImageData,
> as well as base:Optional arrays for the SkImages and GL texture IDs for
> each Y, U, and V plane in the relevant places.
> 
> The YUV decoding path will initially be implemented for in-process
> GPU rasterization and later for OOPR (Out of Process Rasterization).
> Changes that affect WebP decoding in Blink will be hidden behind a flag called
> kDecodeLossyWebPImagesToYUV.
> 
> Finally, because this decides whether to YUV decode based on
> the result of PaintImageGenerator::QueryYUVA8, we separately modified
> JPEGImageDecoder::CanDecodeToYUV (crrev.com/c/1400764) and
> VideoImageGenerator::QueryYUVA8 (crrev.com/c/1418322)
> to return false in order to avoid prematurely going down the YUV decode path.
> 
> See bit.ly/webp-decoding-into-yuv for the design document and
> crrev.com/c/1338461 for a working prototype CL.
> 
> Bug: 900672
> Change-Id: I14f60d83cc2da2382e3da296fab598597b7e8ec8
> Reviewed-on: https://chromium-review.googlesource.com/c/1368687
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625406}

TBR=scroggo@chromium.org,ccameron@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,khushalsagar@chromium.org,jvanverth@chromium.org,ericrk@chromium.org,andrescj@chromium.org,mbarowsky@chromium.org

Change-Id: I5b67ca61424074b5d51c33692071a4306803c283
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900672
Reviewed-on: https://chromium-review.googlesource.com/c/1432878Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625420}

Remove kcarattini@ and miguelg@, and instead, add hkamila@ and engedy@
for the following histograms:

Permissions.Action.*
ContentSettings.PermissionRequested*

Bug: None
Change-Id: I015402bf77edcf5e6a250ea3f2244eb87638a37a
Reviewed-on: https://chromium-review.googlesource.com/c/1430240Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625419}

- Add helper functions to differentiate getting preconfigured share
  paths for both dropdown and premount modes.

Bug: chromium=878502
Test: compiles
Change-Id: I62f5811e2f320a54b783abfdb9b0ffd719abc68a
Reviewed-on: https://chromium-review.googlesource.com/c/1407658
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625418}

https://pdfium.googlesource.com/pdfium.git/+log/3dfb55b889fd..3e873fa0184f


git log 3dfb55b889fd..3e873fa0184f --date=short --no-merges --format='%ad %ae %s'
2019-01-23 thestig@chromium.org Fix a bad memset() in FPDFTextEmbedderTest.
2019-01-23 thestig@chromium.org Wrap a couple CPDFSDK_FormFillEnvironment methods inside ifdefs.
2019-01-23 thestig@chromium.org Fix some g++ -Werror=switch errors.


Created with:
  gclient setdep -r src/third_party/pdfium@3e873fa0184f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib8a1b346103f7d910b3f783c0bcddeb8df670841
Reviewed-on: https://chromium-review.googlesource.com/c/1431834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625417}

Fixes VR tests failing on Vega due to the special TestVrShellDelegate
construction done via reflection on Vega devices not being updated
when the TestVrShellDelegate's constructor had an extra parameter added

TBR=mthiesse@chromium.org

Bug: 924696
Change-Id: Ib48f64609fad549a2af8078d376bab1601c1da13
Reviewed-on: https://chromium-review.googlesource.com/c/1431837
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625416}

https://chromium.googlesource.com/catapult.git/+log/42be5d65ef03..b9dbf6c17c96


git log 42be5d65ef03..b9dbf6c17c96 --date=short --no-merges --format='%ad %ae %s'
2019-01-23 aluo@chromium.org Add UseWebViewProvider context manager.


Created with:
  gclient setdep -r src/third_party/catapult@b9dbf6c17c96

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:914553
TBR=sullivan@chromium.org

Change-Id: Iba2db89240c9e112fc7f65a33fc57d2609934a40
Reviewed-on: https://chromium-review.googlesource.com/c/1431912Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625415}

 - postInvalidate after exiting tab switcher. This ensures a new texture
   is captured immediately.
 - don't allow a texture to be captured while the NTP is scrolled.

BUG=922909,916561

Change-Id: I08de5bd7f6d948c1574ec17e7967fef2dcf5ed06
Reviewed-on: https://chromium-review.googlesource.com/c/1432372Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625414}

As per UX review

Bug: 913646
Change-Id: I94977a6e79f4759c56a1f3fa75da549407a63602
Reviewed-on: https://chromium-review.googlesource.com/c/1415257Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#625413}

It does not make sense to disable the entire preview for a printer
fetch failure. Update the cloud print state if there is a 403 error,
and otherwise ignore these failures in app.js and let DestinationStore
handle them.

Bug: 923914
Change-Id: Ie0dc8596c30397ad531354a4a80345a4299c64f8
Reviewed-on: https://chromium-review.googlesource.com/c/1428059
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625412}

The root of this bug was that the parent bfc, and child with clearance
were fighting as to what the BFC block offset should be.

The child was always returning true within:
NeedsAbortOnBfcBlockOffsetChange
... as the floats bfc offset was never equal to the child bfc offset,
as the child got affected by clearance.

This fix is to adjust the FloatsBfcBlockOffset by clearance to check
if we need to relayout or not.

Additionally we were performing more layouts than we should be,
when propagating the BFC block offset up the tree upon an abort. We
should be checking if the child got affected by clearance, and if so
adjust the resolved BFC offset accordingly.

Bug: 923271
Change-Id: Id39905a5445a0fe502c16b956b92d6db13885d36
Reviewed-on: https://chromium-review.googlesource.com/c/1423929Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625411}

Change-Id: If1acff58705ce3bb7bd07e23a2eb4de24d0dd968
Reviewed-on: https://chromium-review.googlesource.com/c/1432492Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625410}

Purpose is to have manifest changes reviewed so that unexpected changes
can't sneak into the merged manifest (ex. adding an aar dep that needs
extra permissions).

Any deviations from the golden files are printed for release builds
and will fail the build if the GN arg
check_android_configuration = true.

Bug: 882528
Change-Id: I3fee0546004df18ada0fc33077c978edaa64f127
Reviewed-on: https://chromium-review.googlesource.com/c/1409406
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625409}

Previously, if the alert severity was anything other than NONE, the
tooltip on the app menu prompted the user that an upgrade was available.
But alerts are used for other things too (like an extension that has
been disabled) so now we display a generic alert tooltip for non-upgrade
situations.

Bug: 889779
Change-Id: I952bc7803d09fbd7076b4c0636eb619085aee689
Reviewed-on: https://chromium-review.googlesource.com/c/1431475Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625408}

This reverts commit 0cee3055.

Reason for revert: This change makes app icons bleed outside of the overflow when there are too many of them.

Original change's description:
> CrOS Shelf: Remove overflow shelf clip
> 
> Remove overflow shelf clip so that inkdrop ripples can propagate
> outside the overflow bubble.
> 
> The mask isn't really useful in the first place anyway.
> 
> See before/after screenshots here:
> 
>     https://bugs.chromium.org/p/chromium/issues/detail?id=631240#c14
> 
> Bug: 631240
> Change-Id: Iaa1d2f4e2e74bff34a708fa9e2cd7be5ed9a52fa
> Reviewed-on: https://chromium-review.googlesource.com/c/1429639
> Auto-Submit: Manu Cornet <manucornet@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625234}

TBR=xiyuan@chromium.org,manucornet@chromium.org

Change-Id: I51a004caf0a1b516fd21251621e9f716a241ca14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 631240
Reviewed-on: https://chromium-review.googlesource.com/c/1432732Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625407}

This patch modifies PaintImage to have an interface to indicate
that the underlying image is YUV pixel format and adds a
corresponding DecodeYuv() method.

In GpuImageDecodeCache, this change adds "is YUV" variables/getters to
DecodedImageData, UploadedImageData (has_yuv_planes()), and ImageData,
as well as base:Optional arrays for the SkImages and GL texture IDs for
each Y, U, and V plane in the relevant places.

The YUV decoding path will initially be implemented for in-process
GPU rasterization and later for OOPR (Out of Process Rasterization).
Changes that affect WebP decoding in Blink will be hidden behind a flag called
kDecodeLossyWebPImagesToYUV.

Finally, because this decides whether to YUV decode based on
the result of PaintImageGenerator::QueryYUVA8, we separately modified
JPEGImageDecoder::CanDecodeToYUV (crrev.com/c/1400764) and
VideoImageGenerator::QueryYUVA8 (crrev.com/c/1418322)
to return false in order to avoid prematurely going down the YUV decode path.

See bit.ly/webp-decoding-into-yuv for the design document and
crrev.com/c/1338461 for a working prototype CL.

Bug: 900672
Change-Id: I14f60d83cc2da2382e3da296fab598597b7e8ec8
Reviewed-on: https://chromium-review.googlesource.com/c/1368687Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625406}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b1be6763f6f3..86d0d9be254a


git log b1be6763f6f3..86d0d9be254a --date=short --no-merges --format='%ad %ae %s'
2019-01-23 afdx@google.com Refactored reducer so that the 'finding' functionality of a reduction pass are separated from the generic functionality for tracking progress of a pass.  With this change, we now have a ReductionOpportunityFinder abstract class, with many subclasses for each type of reduction, and just one ReductionPass class, which has an associated finder. (#2321)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@86d0d9be254a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I58a795f2caba2d6f251c2e15b85b6bc4f692c929
Reviewed-on: https://chromium-review.googlesource.com/c/1431839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625405}

The current amd64-generic builder has thin-lto and cfi disabled by default
for build cycle time reasons. Chromeos-chrome ebuilds use them both however,
so changes might slip in that break the ebuild but pass on the cq.

This will add a CI bot (and an optional trybot) that has them both enabled.

Bug: 924192
Change-Id: I371e4c6606c0e2e28112750add47208e9dcfd899
Reviewed-on: https://chromium-review.googlesource.com/c/1431515Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625404}

Fix VolumeManager unittest by forcing the flag to be enabled and
changing the volume id to the new id.

Bug: 873539
Change-Id: Ibb230220486cd6b91eadbe7b7e0b35972a45a695
Reviewed-on: https://chromium-review.googlesource.com/c/1428001
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625403}

In https://crrev.com/dbd4eed1920a2aafbc87236db7efb98f108ba063 I moved
around some fragment scrolling code to simplify and clean it up. As part
of that, I made focusing and scrolling happen at the same time.

Unfortunately, as noted in [1], this violates the lifecycle assumptions
since focus() can synchronously execute an event handler - script is
forbidden in the entire lifecycle, not just within layout.

This CL undoes the loosening of the ScriptForbiddenScopes from the CL
above. To do that, FragmentAnchor splits up the application of focus
from scrolling and tries to apply focus at the time of FragmentAnchor
creation (i.e. during parsing/navigation). If we can't apply it then
(because rendering is blocked) it'll be applied at BeginFrame time,
before rAF callbacks are executed.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5BJSTl-FMGY

Change-Id: If2c4c638f3f0faa7dab23e7e129c196357076fad
Bug: 795381
Reviewed-on: https://chromium-review.googlesource.com/c/1408217Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625402}

The SynchronizeVisualProperties() method is called from the IPC handler
to apply some of the IPC message. The code for page scale factor is
moved out to the IPC handler to act on it directly.

It is also called by a number of methods for tests, which apply various
properties to the RenderWidget. Page scale is not ever changed by these
test methods, so they do not depend on it being inside
SynchronizeVisualProperties().

It is also also called from the screen metrics emulator, but since the
emulator does not change the page scale factor, it also does not depend
on this code being in SynchronizeVisualProperties().

The notification of the page scale factor change to each
RenderFrameProxy is dramatically reordered with respect to the other
properties of RenderWidget changing. This is okay because the
notification is only to pass the value over IPC up to the browser and
down to the child RenderWidget, so it does not depend on the ordering.

This reduces the test-only method dependency footprint on the
VisualProperties structure. Left a TODO about changing the routing
of this page scale property to go

blink->RenderView->RenderViewHost->{All RenderWidgets}

instead of the current

blink->RenderView->RenderWidget->
  {All RenderFrameProxy->RenderWidgetHost->RenderWidgets}

Other page-level properties could benefit from this path as well
but are much trickier since they
a) do not go through RenderFrameProxy today and instead seem to
propagate through the browser code, which is good, except
b) are treated identically in child RenderWidgets as in the main
frame,

whereas the page scale factor has clear behaviour differences for
child RenderWidgets. So this could be useful for exploring and
establishing this pattern.

R=ajwong@chromium.org
TBR=avi

Change-Id: I4af9b114e729c26e8356e69ecb9569337d653cb3
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1427466
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625401}

Session restoration completion code was moved from
didCommitNavigation to didStartProvisionalNavigation.
This change will allow the user to start interacting with
web contents without waiting until the first post-restore
navigation is complete.

There will be no committed URL until the first post-restore
navigation is complete, but user should be able to load new
pages and perform back forward navigations.

Bug: 877671
Change-Id: Iceeeff857aee36bf4151f247815c0705ac377e73
Reviewed-on: https://chromium-review.googlesource.com/c/1407909
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625400}

AppCacheFrontend is only used in AppCache's browser-side
implementation. Having it in content/common/appcache_interfaces.h is
misleading, as it suggests that the class is shared with the renderer.

Bug: 611938
Change-Id: I68865d63ee38841d59b61866664716c0ec8c2c39
Reviewed-on: https://chromium-review.googlesource.com/c/1429247
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625399}

This redraw used to be

  if (params.needs_resize_ack)
    delegate_->Redraw();

Which was there to cause a paint (pre compositing) or a composite (post
compositing) in order to send an ack after a resize. We no longer need
to make this redraw happen to get the appropriate ACK as
664698a6 converted us to ACKing to SynchronizeVisualProperties
(which replaced Resize) directly, and now ACKing is tied to surface
synchronization and local surface IDs.

R=avi@chromium.org

Change-Id: Id1c0e3e5534b41767ce36fb2298af56a639fa677
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1431213Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625398}

Message added under Browsing Reporting section on Desktop
with "Chrome Reporting Extension (cloud or OnPrem)" installed
for each of the following policies:
  * report_machine_id_data (true for cloud reporting)
  * report_user_id_data (true for cloud reporting)
  * report_version_data (true for cloud reporting)
  * report_policy_data (true for cloud reporting)
  * report_extensions_data (true for cloud reporting)
  * report_safe_browsing_data (true for cloud reporting)
  * report_system_telemetry_data
  * report_user_browsing_data

Bug: 921698
Change-Id: Icccf744acb775be9723e38b61829ffb42fc2053c
Reviewed-on: https://chromium-review.googlesource.com/c/1423116
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625397}

This CL adds a number of deps to the target
//chrome/browser/safe_browsing:safe_browsing
It also adds the safe_browsing target to allow_circular_includes_from
for //chrome/browser:browser, since these are tightly coupled. The
remaining gn check errors are only due to circular dependencies with:
  //chrome/browser/ui:ui
  //chrome/browser/extensions:extensions
Both of which will be fixed in future CLs

Bug: 919683
Change-Id: Iec1c1737aceef070aca082260b587dc96250bc16
Reviewed-on: https://chromium-review.googlesource.com/c/1428480Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625396}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6aa6bc44417e..5f9f137868bd


Created with:
  gclient setdep -r src-internal@5f9f137868bd

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icce4c91cf17d385e89919647ab3b5ca4332b44eb
Reviewed-on: https://chromium-review.googlesource.com/c/1431832Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625395}

Two changes:
- Remove the IS_OFFICIAL_BUILD check (don't require official builds to
  be signed for app shims to run at all).
- Construct a custom designated requirement to verify the app shim,
  which checks its identifier and that its certificate matches the
  browser's.

For now, keep failures log-only.

This reverts commit add2f7a1.

Bug: 913362, 923612
Change-Id: I1c536e2172519dbf8e5b36a2dd9b5f1b26fb8302
Reviewed-on: https://chromium-review.googlesource.com/c/1427385Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625394}

BUG=762641
TBR=michaelpg@google.com

Change-Id: Ia4ebed15d53163eace05eaa2997a8111e9f0a6ff
Reviewed-on: https://chromium-review.googlesource.com/c/1429199Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625393}

https://android.googlesource.com/platform/external/perfetto.git/+log/a824c339c217..3eabfafdae1e


git log a824c339c217..3eabfafdae1e --date=short --no-merges --format='%ad %ae %s'
2019-01-23 lalitm@google.com Merge "trace_processor: add support for polled oom_score_adj"
2019-01-23 treehugger-gerrit@google.com Merge "profiling: Log on pipeline stall."


Created with:
  gclient setdep -r src/third_party/perfetto@3eabfafdae1e

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I1bda3ef94d7f99044c6e5f7116410da7a27d5539
Reviewed-on: https://chromium-review.googlesource.com/c/1431455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625392}

Bug: None
Test: locally build and run
Change-Id: Ifdb6e31b926da18c6da47e7a2a5540f58e9fa9a9
Reviewed-on: https://chromium-review.googlesource.com/c/1423620Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625391}

FireWebUIListener(name, ...) is essentially an alias for:

  CallJavascriptFunction("cr.webUIListenerCallback", base::Value(name), ...);

Using it reduces the amount of times we paste "cr.webUIListenerCallback" and
generally reduces the amount of parallel paths for notifying running web
UI pages.

R=aee@chromium.org
BUG=none

Change-Id: Id3ee2622949c0fd1bba9705655de4cb0faf386f4
Reviewed-on: https://chromium-review.googlesource.com/c/1431293Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625390}