- 23 Nov, 2020 40 commits
-
-
Ian Barkley-Yeung authored
Prevent duplicate and unwanted JavaScript error reports by: * Allowing pages that report errors in other ways -- or that we just don't care about -- to disable WebUI JS Error Reporting. * Blocking reports from other frames. If a WebUI page has an iframe containing another WebUI page, both WebUIMainFrameObservers will see the errors for either page. Only report errors for the main frame of this WebUI. * Blocking non-chrome:// URLs. WebUI pages with chrome-untrusted:// frames may host non-Chrome content which we don't want error reports from. This is the heart of "step 5" in the design document. Remaining work includes calling DisableJavaScriptErrorReporting for the essential apps & essential inputs that would otherwise double-report, and possibly carving out exceptions from these blockers for pages that have a good reason (such as chrome-untrusted:// pages that still expect to only serve up Chrome-owned content.) Bug: chromium:1121816 Change-Id: I57005c9a85b5700ead7d1123627191f1cbfda33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535490Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830136}
-
Henrik Boström authored
In https://crbug.com/1148964 it was discovered that assumptions that SampleBufferTransformer was making did not always hold. For example, SBT assumed that if the camera produced pixel buffers then those pixels buffers would contain IOSurfaces, but this was not always the case. This was fixed so now I'm looking at other assumptions. Similarly, SBT assumes that if the camera produces a SampleBuffer that doesn't have a pixel buffer, this must be the MJPEG case. This CL promotes a DCHECK for this into a CHECK so that we don't run the risk of having hard-to-debug crashes happening if there are any cameras out there in the wild where this does not hold (hopefully not). Bug: chromium:1148964 Change-Id: I3e063dd7ed48962d31c7fd46a9a66de7e8337498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554597 Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#830135}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34a1660229e0..3583a63a0f86 2020-11-23 mathias@chromium.org TypeScriptify platform/utilities.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie568986f4141eab51af0d63754b1e060e3e81c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830134}
-
Alexander Hendrich authored
TBR=yukishiino@chromium.org Bug: 1151861 Change-Id: I5ffe50d52c18ba5126ea644d8dd40619ba778405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554562 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830133}
-
Nazerke authored
This CL updates the switch to the active webstate according to the tapped tab in the TabStrip. This CL doesn't update the tabstrip UI, i.e doesn't highlight the selected tab. Bug: 1128249 Change-Id: I89041c22d27df2d171821c6d5fc7342c99ab06db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550711Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#830132}
-
Fredrik Söderqvist authored
The new class DrawInfo packages the various parameters used when drawing an SVGImage - container size, zoom and URL. The intent is to reduce the amount of arguments that needs to be passed around as well as prepare for better (more centralized) handling of the container size to get better control of the various representations used (FloatSize, LayoutSize, IntSize). Also move DrawNeedsLayer() closer to its user and perform minor tweaks to DrawPatternForContainer() (reorder matrix setup; return PaintRecord directly to MakePaintRecord). Change-Id: Id231682c9d85a322a3c585a75b2793a68628c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550915Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#830131}
-
Clemens Arbesser authored
Before this change, the progress bar for trigger scripts would flakily not show the progress correctly due to missing change notifications. Bug: b/173790448 Change-Id: I4bb51ceee69f81ad41d69739a20f0c4b1e38d60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550918 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#830130}
-
Denis Kuznetsov authored
This call was only used to update passwords for legacy supervised users. Bug: 1150430 Change-Id: Ib313d42f103aeebbf845570443c8dfaddaf92de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550904 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830129}
-
Daniel Hosseinian authored
Bug: 1026195 Change-Id: I6bd42a7c4611dac978f812af701317c5f50660f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553870 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830128}
-
Mirko Bonadei authored
By default, absl/flags are disabled on mobile platforms. This is a problem for some test binaries. The best way to avoid ODR is to define ABSL_FLAGS_STRIP_NAMES=0 at build level. Since Chromium doesn't use absl/flags, this CL just default to flags always ON (they only affect test code). Bug: None Change-Id: Ie51744937125fbb89be39eacf388f43d6054d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552391Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5d21335f147..eaff47190b82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hendrich@google.com Change-Id: I2e3203c695c418d022be4ce1a840383cefda4b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554418Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830126}
-
Alice Wang authored
This CL adds SigninPreferencesManager to the new signin.services target. The old class will be removed after we migrate first the usage of SigninPreferencesManager in clank to avoid build crash. Bug: 1150862 Change-Id: I11285422d0d8b2ee779084c14ad60c9d7a3a6a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550678 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#830125}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91c1a7c2dc0a..cb4bb2088ad7 2020-11-23 mbonadei@chromium.org Add .vpython file for histogram_proto.py. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: sadrul@google.com Change-Id: I26a7fbc451a44c9bd74fdfdcdd2ae5f37810a584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554420Reviewed-by:
-
Clemens Arbesser authored
Users may manually disable the proactive help setting while the trigger script is being run. In that case, the trigger script should immediately exit. Bug: b/173786671 Change-Id: Ib6ff4bcb12ccc75f0054bb87098367071346b433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550680Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#830123}
-
Sigurd Schneider authored
Bug: chromium:1011811 Change-Id: I868f1024ca24013817c1039c5bbdd6523750bcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550916Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#830122}
-
Luciano Pacheco authored
Add group() for Polymer elements JS modules to make easier to refer to them. Run `git cl format --js ui/file_manager` as pointed by presubmit. Bug: 1133186 Change-Id: Ib0f92ec10da1418f2c949f2b82dccdd40b107bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554201 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830121}
-
Alexander Hendrich authored
failing since https://crrev.com/c/2529950 virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values.html virtual/controls-refresh-hc/fast/forms/color-scheme/file/file-appearance-basic.html failing since https://crrev.com/c/2509029 virtual/controls-refresh-hc/fast/forms/color-scheme/media/video-overlay-menu.html TBR=almaher@microsoft.com Bug: 1151844 Change-Id: I5cb1d6f6943562f29ef0a8dc57a0b4558f5ae812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553545Reviewed-by:
-
Alexander Hendrich authored
TBR=rogerta@chromium.org, rsorokin@chromium.org Bug: 1151851 Change-Id: I1516aa2ded9edc45e26be8fc54d375cbda840a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553546Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/854885046bca..34a1660229e0 2020-11-23 aerotwist@chromium.org Bumps bl to 4.0.3, adds karma-spec-reporter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf3a6fead11c3da8ba7ab4b57ed0b2105efbc90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554416Reviewed-by:
-
Alexander Hendrich authored
TBR=sammiequon@chromium.org, afakhry@chromium.org Bug: 1151856 Change-Id: Ie131d72ec0f53d26d61aef0f83608fc0990140d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554538Reviewed-by:
-
Henrik Boström authored
This is part of debugging https://crbug.com/1148964. Crashes have been observed when InCaptureConvertToNv12 is enabled, which means we would be using a CVPixelBufferPool in non-passthrough cases (e.g. external webcam capturing in MJPEG or other non-NV12 pixel format). The crash seems to be happening because GpuMemoryBufferImplIOSurface::CreateFromHandle() returns null. But unless the io_surface is missing, the only way this should be possible is if the IOSurface's width or height is less than the size we expect from our handle. How could this be? The test added in this CL demonstrates that if we have a bug with how we handle IOSurface-backed gfx::GpuMemoryBuffer's and don't increment/decrement the IOSurface's use count correctly, we could observe a new IOSurface with a recycled ID. This could also happen if we do use the use counts correctly, but have any assumptions about old and new handles with matching IDs have the same resolution. This could trip us up if our handle thinks that this ID maps to a buffer in one size when in fact the new IOSurface sharing the old ID has a different resolution. Bug: chromium:1148964 Change-Id: Ic909f408d7ea9e443efa45b28b9e7b3a9450d8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550807 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ic32cf98d4ba1c52b193082840dc891ca0c56a888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552819Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830115}
-
Benedikt Meurer authored
Tbr: yangguo@chromium.org Bug: chromium:1151285 Change-Id: Ia5019c6ac2be8a2b908e79ab6d96c2df7dbf8095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553542 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#830114}
-
Alexander Hendrich authored
This reverts commit 40d807ac. Reason for revert: https://crbug.com/1151842 Original change's description: > [Reland] capture_mode: Hook to policy and locked fullscreen mode > > This is a reland of https://crrev.com/c/2548880 which was reverted > due to a flaky test. The flakiness root cause was resolved in > https://crrev.com/c/2552921. Therefore, there're no changes in this > CL from the original. > > TBR=jamescook@chromium.org, poromov@chromium.org, isandrk@chromium.org, bmalcolm@chromium.org > > Original CL description: > Capture Mode should be disabled when the `kDisableScreenshots` policy > is disabled. > It also should be disabled when a tab requests to be in a locked > fullscreen mode, and any on going recording should be interrupted. > > BUG=1150585 > TEST=Existing, and added a new test. > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548880 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Reviewed-by: Brian Malcolm <bmalcolm@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#829390} > Change-Id: If427589bcaf9837d0def703dbeff6fc03b8167cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552215 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829927} TBR=jamescook@chromium.org,afakhry@chromium.org,isandrk@chromium.org,poromov@chromium.org,bmalcolm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150585 Change-Id: I99f8819ba2534bd8d6510a5091cc6d6b6dee4c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553544Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606089386-260a0b5b2f863e489966f04b1fedc1aa4f716d07.profdata to chrome-mac-master-1606110698-ec2190f26d45d9121b82315791a0ce2334cbfdfd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic6f378e7f5f2efa42dcb3f7c0a8d8c573aaa2eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554414Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606089386-1100858bd739b2cdd53e6f084f74316be20c2045.profdata to chrome-linux-master-1606110698-4a9b21f116e6eb433edc251fc3084d03e39a6c23.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic82c393eba887ddcb3b726011beeba6b274011c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554413Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/667511e44111..c5d21335f147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: Id04b72e38a7cca226363f1b3206b1e6c93f6ed18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553517Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830110}
-
Kevin McNee authored
This is redundant since a class already has access to its own members. Bug: None Change-Id: I567ae3d63d3fc81b06a3dc73723c7df6c88d6aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551251 Commit-Queue: Ben Wells <benwells@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#830109}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/639fb024beb2..7d5a4b4a64eb 2020-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from de9e649438ed to 6d612051c083 (4 revisions) 2020-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 777749aafaac to ebf890fcf9f3 (12 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Test: Test: Test: LEGO MECTest: Test: angle_perftests --gtest_filter="*google_maps*"Test: Test: angle_perftests --gtest_filter="*lego_legacy*" Change-Id: I388b30aa486552d7053f31b250d5b08c5def2e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553519Reviewed-by:
-
Sam McNally authored
ExtensionRegistry uses the underlying BrowserContext for incognito contexts. Thus, for incognito uses, the ProcessManager can be destroyed without the KeepAliveImpl being notified. Observe ProcessManager shutdowns directly to ensure KeepAliveImpls are cleaned up when a ProcessManager is shut down. Bug: 1149177 Change-Id: I39a0cf54bcf8cf0d58e36560935b8d2f79399cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548585 Auto-Submit: Sam McNally <sammc@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=benwells@chromium.org Bug: 1145565 Change-Id: I797bd54b97c8b3059fc5d824fff85f1ee296d4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548002 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
-
Melissa Zhang authored
This CL calls the parent class OnKeyEvent so that KeyEvents don't get swallowed by Sharesheet. This was preventing other keyboard shortcuts such as alt+shift+i for the feedback window to work. Bug: 1133817 Change-Id: I06e9eeaa593d15aa3079a13b3ef44f6be03025d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551898Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830105}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6eed66a65984..854885046bca 2020-11-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I45055ae26897f19439682d4c21b6a023eaf85b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554410Reviewed-by:
-
Melissa Zhang authored
Bug: 1151774 Change-Id: Ia985922e0368d96e70e25138fb9cd36390da5d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554199Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606077424-ec0f84a9c2a3c633b1c20d4d880b1629a0383891.profdata to chrome-win64-master-1606089386-838f65aaa60be12e40b29c2cb3db20695d2661d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4cb67a0b5377a61f1c236cd2f9a126c18134cc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553513Reviewed-by:
-
Zhaoliang Ma authored
Create VEA need to wait for the encoder support known since querying of VEA supported profile is async, this CL fix the issue. Bug: 1119636 Change-Id: I0a4a6e088808fc87bc5bf5b159c7a4490032f742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486452 Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830101}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c5fd74567279..79348b55df90 2020-11-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4b8443c6..cbb40ac3 (829974:830083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I062cbbe6f99f982eb9ce210ae85dbbc2c8101123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553851Reviewed-by:
-
Morten Stenshorne authored
This fully enables NGPhysicalBoxFragment::PositionForPoint(). If it's disabled, we'll typically only use the aforementioned method in inline formatting contexts. Correct support for block children is work in progress. The plan is to fix the remaining issues over the next few days, and enable LayoutNGFullPositionForPoint for stable. We can disable it again if it turns out that it causes regressions not covered by any tests. There will be some behavior changes, most notably the fact that we'll always use the nearest box (and calculate this accurately - as opposed to what we do in LayoutBlock::PositionForPoint()). Bug: 1150362 Change-Id: Ic4e9257a70fbbb7ff321f3ee5d417186a9a67839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550833Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830099}
-
Bao-Duy Tran authored
- Add tranbaoduy@ as primary owner of InputMethod.ID2 histogram. - Add dvallet@ as primary owner of all other CrOS histograms where there are no owners from the current team yet. - Retain ex-team members as secondary owners of all CrOS histograms. - Add team alias as secondary owner for all CrOS histograms. - Keep owners of all non-CrOS histograms intact. Also, drive-by: Fix "units" for InputMethod.CommitLength. Bug: None Change-Id: I27b3338bb46c7c0ea768976530604bba0f5f7df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545861 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
-
Nicholas Hollingum authored
This is done by AppServiceAppWindowCrostiniTracker::GetShelfAppId before this point always, and the subsequent call will always return the same thing. The claim in the comment is probably legacy, as empty-app-id windows will be filtered out by AppServiceAppWindowLauncherController::OnWindowVisibilityChanged. Bug: b/172979315 Change-Id: I38121c68cb48c9840831b83665fdf7e33285cc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552327Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#830097}
-
