GitLab

This CL adds a few debug lines to investigate flakiness. There's no
behavioral change and the commit will get reverted once the
investigation is over.

Bug: 997629
Change-Id: I55a19c467affdaed1ed62ea8fb2545dc570b2877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026734
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737264}

The MathML CG decided that unknown elements in the MathML namespace with
a math display should behave like an <mrow> element [1] [2]. This CL
ensures that a MathMLRowElement is created for unknown MathML elements
in order to make that possible. It does not seem necessary to create a
specific MathMLUnknownElement C++ class at that point. Whether a
specific MathMLUnknownElement IDL is needed is still open [1][3].

[1] https://github.com/mathml-refresh/mathml/issues/139
[2] https://mathml-refresh.github.io/mathml-core/#new-display-math-value
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=1021837

Bug: 6606
Change-Id: Ia493392ee8bfe9a7073e2ea6f1ce65927ec7fcae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007738
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737263}

This reverts commit 9b92a6a2.

Reason for revert: Multiple ExtensionsMenuViewBrowserTest cases failing on Linux bots.

Bug:1047630

Original change's description:
> Hide extensions container when none are installed
> 
> This change makes ExtensionsToolbarContainer invisible by default. It
> turns visible when any extension is added and goes invisible if the last
> extension is removed.
> 
> Bug: chromium:943702
> Change-Id: Ia64d8db55d3cd53beff450941d1b7d2cba282ca0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956186
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Caroline Rising <corising@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737171}

TBR=rdevlin.cronin@chromium.org,pbos@chromium.org,corising@chromium.org

Change-Id: I012b5f1137c5af73af2cbe1ac2e4b0a123cd2759
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:943702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032108Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737262}

Changes the name of a variable used in the enterprise enrollment
screen in OOBE. 'last_auth_' was replaced with 'next_auth_'. The
author intention with 'last_auth_' was probably 'last_auth_to_try_'.
'next_auth_' makes it easier to understand the code's logic.

Change-Id: If1b8ffbfc17767b5a4a4f725856522338231f32b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939805
Auto-Submit: Renato Silva <rrsilva@google.com>
Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737261}

If the time container is seeked to a large enough value, we will end up
truncating it to SMILTime::Latest(), which is the largest value that
isn't one of the two special values ("indefinite" and "unresolved").
When trying to derive other values from this value - like if we have an
interval begin at it - we can end up in a loop since any the result of
any additions will yield the same value, leading to the element being
rescheduled at the same point in time, hanging UpdateIntervals().
This mechanism can also be used to implement the "once" animation-policy
in a slightly nicer way. This will be done as a follow-up.

Bug: 1039886
Change-Id: If13d7d7d3c44c4f586d15852eb05105879f44918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030885Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#737260}

This introduces a feature LayoutNGFragmentTraversal, which will make us
perform layout read operations (painting, hit-testing) by traversing the
NG physical fragment tree instead of the LayoutObject tree.

This CL only adds basic support for painting, and only for nodes that
generate just one fragment. Painting is still driven from PaintLayer
(which is LayoutObject-centric -- we probably want to fix that in the
future), and the near-term plan there is to collect each physical
fragment and pass to NGBoxFragmentPainter. For now we just pick the one
and only fragment, and enter fragment traversal for painting, where
possible.

Note that this feature is still actively disabled inside multicol. We
need to get rid of the "artificial" paint layers for the flow thread and
multicol container (and still calculate FragmentData correctly) before
we can turn it on.

Added a virtual testsuite. The tests in fast/block/ will mainly verify
that the new code works, and the ones in fast/table/ will mainly verify
that we fall back to legacy painting correctly.

What remains (roughly) after this CL: Hit-testing, support for multiple
fragments, overflow calculation for fragments, and actual support for
block fragmentation (multicol).

Bug: 1043787
Change-Id: I1f61bb15458e7162ad61960c317e50891bd13e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002879
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737259}

https://chromium.googlesource.com/infra/infra/+log/37a855b64d59b7f079c9a0e5368f2757099d14d3..8c17d4a7b01d6257e927c629cc623ebc6a6b3711

This is to take crrev.com/f4a945468e0c8498fdf7ea9fdffb2a152e1b2ef6

Bug: 984869
Change-Id: I7ba172d97df7be96bf07faeebb3d467506d8cec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032482
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737258}

Using wpt-import in Chromium 122b074f.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I26fea3682c7ff55c16341d492f6e054b60e61289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031908Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737257}

Add new graphics for error screen, adapt text so that error screen can
be used in conjunction with automated enrollment.

Fixed: 987903, 1024844
Change-Id: I44907b7c931f75323b033737003ee1ad11e6ea7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944388
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737256}

To keep current behavior, max_concurrency <= 1.

TestSupportingGC & TimerTest need CompleteSweep to prevent dangling
Job across tests.

From local benchmarks:
blink-gc-complete-sweep: 15-25% improvement
blink-gc-sweep-background: 15% regression
blink-gc-sweep-foreground: 2-8% improvement

Pinpoint:
https://pinpoint-dot-chromeperf.appspot.com/job/14b95f88620000

As the first Jobs API use case, we can now lift experimental::
namespace which is done in a follow-up:
https://chromium-review.googlesource.com/c/chromium/src/+/2028287

Bug: 1046343

Change-Id: Idb1c6f44ee19e03039f1f7fa6c18e3591a8fbdcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935836
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737255}

This CL changes FrameHostMsg_UpdateUserActivationState so that
it is implemented in the LocalFrameHost interface and removes
WebLocalFramClient::UpdateUserActivationState.

Bug: 1044304
Change-Id: I046493809ab76acfe97173bec2a13b199c49c6e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026841
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737254}

Before the new byte-for-byte checking, credentials_mode was set to
kInclude for imported scripts. However,
ServiceWorkerSingleScriptUpdateChecker sets the flag to kOmit because
it's missed from the current spec. This CL is to correct the mode to
fix the unintentional change.
Spec issue: https://github.com/w3c/ServiceWorker/issues/1497

Bug: 1042159
Change-Id: I553d7bec015eb4cb80f7f59c640f26491fa02b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032689Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737253}

Since there may be multiple instance of DWriteFontProxyImpl instantiated
for multiple RenderProcessHosts, and
DWriteFontProxyImpl::GetUniqueNameLookupTable may access
DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from
separate threads, there may be race conditions around the
pending_callbacks_ member of DWriteFontLookupTableBuilder.

Sequentialise and guard access to pending_callbacks_ with a separate
sequenced task runner.

Fixed: 1047054
Change-Id: Ib7d7a385273bd82eb4d1acf720dac5d688a3435e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030864
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737252}

Currently network_isolation_key is not set for signed exchange cert fetch.
So, even if the signed exchange and the certificate were prefetched,
the certificate is fetched again while navigation when
SplitCacheByNetworkIsolationKey is enabled.

Bug=1047110

Change-Id: I524df1da097c6f544777f20cca5a3e53246693cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029564Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737251}

This CL changes the APIs of the SecurityBlockingPageFactory interface
to return unique_ptrs rather than raw pointers to codify the fact that
they are passing ownership of the created objects to the caller. The
motivation for making this change now is to do so before adding a new
factory implementation in //weblayer.

This CL chose a reasonable cutpoint for stopping the propagation of the
change; followup could pursue this change through the places in this CL
that invoke base::WrapUnique() or call release() on the created
unique_ptrs.

Bug: 1030692
Change-Id: I26e1b695c5b66c775860c196b4509545527da788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030867Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737250}

This CL moves following ScheduleDeleteAndStartOver() calls to
ServiceWorkerRegistry so that we can reduce ServiceWorkerContextCore
dependency from ServiceWorkerStorage.
* DidGetRegistrationsForOrigin
* DidGetAllRegistrations
* DidStoreRegistration
* DidDeleteRegistration

Bug: 1039200
Change-Id: I06860107927c77431d17637a2f8e406d94d1f5e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032744Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737249}

This CL introduces blink::MenuListInnerElement, which will replace the
anonymous block in LayoutMenuList. For now, we just add the element to
UA shadow tree with display:none. So this CL doesn't have any changes
on SELECT rendering.

* UpdateUserAgentShadowTree()
 Add MenuListInnerElement as the first child of ShadowRoot
 if UsesMenuList().
 Otherwise, remove it from the UA shadow tree.

* Update some test expectations for the new shadow element.

Bug: 1040828
Change-Id: I6c59c45dcc41baa41ff0e0ab060c14c2eefb6cff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032645Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737248}

show in the webrtc-internals page that you are using SDP munging
BUG=823036

Change-Id: I874bc4575f7718355336507d84c7616971c30e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953635
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737247}

This CL moves ScheduleDeleteAndStartOver() call from
ServiceWorkerStorage::DidFindRegistration() to ServiceWorkerRegistry
so that we can reduce ServiceWorkerContextCore dependency from
ServiceWorkerStorage. DidFindRegistration() is removed as a
consequence of this change because it just called
ScheduleDeleteAndStartOver() and converted status.

Bug: 1039200
Change-Id: I0af1314ab774617cacb7847a026c117835f77754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032447Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737246}

This will allow the WorkerTaskProvider to do accurate bookkeeping on
running dedicated workers, even though it dynamically subscribe and
unsubscribe to the DedicatedWorkerService while some workers are already
running.

Bug: 1041093
Change-Id: I96e75274d938324fe178a0999ff7968b030b8827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018143
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737245}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d65a6015c6a6..8fa7c321f46b


Created with:
  gclient setdep -r src-internal@8fa7c321f46b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I7df7a5d42ee2f59781cda26502f96217d1aa6d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032849Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737244}

The hotseat affects the position of the PIP window, so this CL
includes the following changes to take it into consideration in
collision detection.

- Add the hotseat to collision rects. We adjust the bounds of the
  hotseat a bit so that we can slide the PIP window along the
  hotseat smoothly.
- Make hotseat state change trigger a system ui area change event
  in workspace layout manager.

Note we still have the PIP initial bounds issue as Android still
doesn't know the correct initial position.
BUG=b:147790853
TEST=Manually confirmed the PIP window was placed at the correct
TEST=position (once dragged) and was moved smoothly.
TEST=Manually confirmed toggling in-app state properly adjusted the
TEST=PIP window.

Change-Id: Idefc2877aa4aaf8996a016b64721bae4a74b3cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014357Reviewed-by: Mitsuru Oshima (slow in TOK) <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737243}

This reverts commit 139567ba.

Reason for revert: Regression, HW encoder is not utilized on sarien b/148625570

Original change's description:
> content/renderer/media: Query GPU process HW encoder capabilities
>
> Originally GpuVideoAcceleratorFactoriesImpl get HW encoder
> capabilities by referencing values stored GpuInfo instance.
> However, the values are not updated after GPU process boots up.
> Even if a new hw encoder is available after GPU process is
> initialized, the hw encoder is not detected.
>
> This fixes the problem by querying GPU process the hw encoder
> capabilities when a render process is created. e.g. open the
> page.
>
> Bug: b:147404923
> Test: HW encoder is used at appr.tc
> Test: tast run webrtc.* on krane
> Change-Id: Ibca82b6e54e9b5d585037c8e63f4c663d085db0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994849
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735339}

TBR=sandersd@chromium.org,dominickn@chromium.org,hiroh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:147404923
Bug: b:148625570
Change-Id: I75bfe87b97505f400d1fb5c27facff507495cfb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032454Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737242}

This CL allows developers to use header files ending with 'mojom-forward.h'
in public directories.
Traditionally, we use 'mojom-shared.h' files, but we now have 'mojom-forward.h'
filed and it is better to use forward header files.
This is discussed here:
https://chromium.slack.com/archives/CGGGVPSQ4/p1580370782044400

Bug: n/a
Change-Id: I2bd1bd3d304d8a46e8df5bfd3ebc0d49f5497d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032686Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#737241}

When policy templates are changed, syntax_check_policy_template_json.py is run as part of the presubmit checks. It should also be run when changes to the file itself were made.

Bug: 1045930
Change-Id: Ic8870bd748d80d87b99b93889640cf2ebbbf0b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022794Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Anina Koehler <aninak@google.com>
Cr-Commit-Position: refs/heads/master@{#737240}

Improves the overlay dialogs shown on OOBE ARC terms of service screen
to match MD specs.

Fixed: 1030466, 1032914
Change-Id: If10fcdec926d724f43c08034519dac5b14eb55c4
Bug: 1030466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953740Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Renato Silva <rrsilva@google.com>
Auto-Submit: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#737239}

This reverts commit 0ea41733.

Reason for revert: In this CL, GetOverlayMailbox() calls BufferQueue::GetCurrentBuffer(). Unfortunately, it turns out there are cases where this causes the GPU to draw to a buffer that's being scanned out (see https://crbug.com/1047030 for an example). It may also cause problems with damage tracking. Reverting this CL to try to fix the issue before the M81 branch point :(

Original change's description:
> Viz/Ozone/DRM: Provide NativePixmap for the primary plane
> 
> Plumb mailbox for the primary plane to OverlayProcessorOzone and use
> SharedImageInterface to obtain the corresponding NativePixmap.
> 
> Bug: 756454
> Change-Id: Ic537d05253bc68c27a8fed961de8547ace359e82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016327
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Commit-Queue: Saman Sami <samans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736065}

TBR=rjkroege@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 756454
Change-Id: I6f42b94d1939597f7c34f0d0433d45a02716aa58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031723Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737238}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Ife76dd9a8bfd16e43b5936a1829ccf1945b58760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032193Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737237}

We'll now put *all* fragments generated from a node into a vector in
LayoutBox, instead of pointing to (at most) one fragment (was only
stored if the fragment was cacheable).

When a fragment is regenerated (after a relayout), we'll overwrite
entries in the vector. Each fragment now has a "sequence number", which
is stored in the break tokens. We need this to tell the fragments apart.
Block fragmentation may cause a node to generate multiple fragments, and
multicol balancing [1] and rebalancing [2] may go back and relayout and
overwrite fragments for the current column row (until everything fits
nicely). Then we need to know at which fragment indices to store the new
fragments (and nuke the old ones following, if any).

The sequence number will also be used for other purposes in an upcoming
CL, for example to cache the drawing of each fragment; see
ScopedDisplayItemFragment. At least we'll need this as long as we don't
create a unique DisplayItemClient for each fragment.

This is in preparation for NG fragment traversal (for painting and
hit-testing), which is needed by block fragmentation. This CL, however,
should not affect behavior in any way (but is filed as a separate CL
nevertheless, due to its size) - hence the unit tests. We already have a
bunch of block fragmentation tests in ng_column_layout_algorithm_test,
but I put the new tests in a new file, since they aren't really about
testing the column layout algorithm, but rather block fragmentation in
general (and the same can be said for many of the tests in
ng_column_layout_algorithm_test, BTW).

In an upcoming CL, PaintLayer will walk through these fragments and
paint them separately. The list of fragments will also be used to map to
FragmentData entries. In the future, we might also consider making
FragmentData an (optional) member of NGPhysicalFragment, since there is
a 1:1 relationship between NGPhysicalFragment and FragmentData.

[1] See NGColumnLayoutAlgorithm::CalculateBalancedColumnBlockSize()
[2] See the exit condition for the outer loop in LayoutRow().

Bug: 829028
Change-Id: I2e0b678c378327ea21d60a5c306845ce7b6e9e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030949Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737236}

This CL re-writes a breakpoint web test using a new SourcesTestRunner
helper introduced in https://crrev.com/c/2027427.

This should not only prepare the test for the upcoming source map
asyncification but also reduce the overall flakiness of breakpoint
web tests.

R=sigurds@chromium.org

Bug: chromium:1032016
Change-Id: I1002384ffa6bbc330cd3132c183e356e5b1f59ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029368
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737235}

For "cheap" checks of state in the streams implementation, use CHECKs
instead of DCHECKs. This will improve robustness against logic errors.

BUG=1045931

Change-Id: I01af9c21feca586c74e354faa8f919fbb7565c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032471Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737234}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a161f0c9091d..d65a6015c6a6


Created with:
  gclient setdep -r src-internal@d65a6015c6a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I02c5f142fb69151a1ea789f9e3df7183b46b10c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032846Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737233}

Bug: 982194
Change-Id: I1b55db65d9fae0903d91d0fb682da5c15ac0891c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028876Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737232}

https://chromium.googlesource.com/angle/angle.git/+log/e196bc85ac2d..088b1baa948a

git log e196bc85ac2d..088b1baa948a --date=short --first-parent --format='%ad %ae %s'
2020-01-31 ynovikov@chromium.org Change uuid attributes to declspec in winrt.

Created with:
  gclient setdep -r src/third_party/angle@088b1baa948a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: tobine@google.com
Change-Id: Ied6ebb542bb12063bb6de5c21815417af2d929b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032844Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737231}

In chromium code audio_utility.cc we just need to use PI constant from
//base instead from local file.
This is some polishing.

Change-Id: I71d7042a9ed40c563c67bab2237b267c822a6961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027367Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737230}

Add call site for AwContents state of AwContentsLifecycleNotifier.

Bug: 1042048
Change-Id: I6d59b2b956fe8b1dbf2f208a3f2881fdc6f4d778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023400
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737229}

Given that there are so few printing-specific features, have them all
in one file instead of multiple very small files for each OS.

ChromeOS did not use the printing::features namespace for the flags
before, so update that throughout for consistency.

Change-Id: I30d062236d404d7f53c212333ddfcc8c27968503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031867
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737228}

With the removal of Harfbuzz subsetter the only printing/common
features left are related to XPS printing on Windows.

As discussed in [1] move these out of common so that they can be
included as part of the regular printing component.

[1] https://crrev.com/c/1988767/5

Bug: 1008222
Change-Id: I5b5c096eaa50cf53cfe62c1f12319cb506c6fc7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026369
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737227}

Bug: 941354
Change-Id: Iaf0b1ca9e8a4898333dead2ba4b4a38cbee00b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028880Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737226}

When adding a new user, although IsMultiProfileAvailable return true,
MultiUserWindowManagerHelper::GetWindowManager is still null. So add a
check for MultiUserWindowManagerHelper::GetWindowManager. When
MultiUserWindowManagerHelper::GetWindowManager is still null, we don't
need set owner for windows, because multiple user window manager is not
ready yet.

BUG=1047376

Change-Id: Idb527b24e0f7d66714b6f408b08f20e50b6f8c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032486Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737225}