- 08 Jun, 2018 18 commits
-
-
Sadrul Habib Chowdhury authored
The component-id for BEGIN_RWH component is currently generated from the process-id and routing-id of the associated RenderWidgetHostImpl, so that it is possible to find the RenderWidgetHostImpl from the LatencyInfo after gpu-swap happens. However, the BEGIN_RWH component is unused at that time (only LatencyInfos that have snapshot requests are processed after gpu-swap, and the snapshot requests already carry the identifier for the RenderWidgetHostImpl separately), except for in a test. So, the changes in this CL: . Use zero as the component-id for BEGIN_RWH component. . Introduce a SetLatencyInfoProcessorForTesting() method to install a callback that receives all the LatencyInfo after a gpu-swap happens, and use that in the tests that needed this. BUG=849729 Change-Id: I19beb790931cfe8e708d0eb4223a3ba23d51e4c1 Reviewed-on: https://chromium-review.googlesource.com/1089583Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#565488}
-
Xing Liu authored
This CL adds field trial testing config for downloads location change feature. TBR=nyquist@chromium.org Change-Id: I249063d963cd46ff47940c6fd04ebbb65fca0712 Reviewed-on: https://chromium-review.googlesource.com/1081683 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#565487}
-
Michael Giuffrida authored
The SafeSearchURLChecker didn't depend on //chrome. Move it to a new safe_search_api component. We will reuse safe_search_api::URLChecker in a later CL for filtering URLs based on the SafeSearch API (a generalization of SupervisedUserURLFilter). Because we're creating a namespace, we can drop the SafeSearch prefix and move the Classification enum out of the URLChecker class. Also clean up presubmit issues in changed lines. Bug: 819405 Change-Id: Iaf411b1232eb937f93056d8e3553435fb7779bee Reviewed-on: https://chromium-review.googlesource.com/1081892Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#565486}
-
Jialiu Lin authored
Refine the style of chrome://reset-password page to make is as close as chrome://interstitials/captiveportal Added responsive layouts to adjust to different window sizes. To test, run with flag --enable-features=ForceEnableResetPasswordWebUI then navigate to chrome://reset-password Bug: 848023 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I38d460ec56198176775643c75aa6e6571f1b269f Reviewed-on: https://chromium-review.googlesource.com/1081665 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#565485}
-
Xiaohan Wang authored
Bug: 542697 Test: Reenable tests on ChromeOS Change-Id: I8aaf97da6af5658760405c64b130f48f2dd0386a Reviewed-on: https://chromium-review.googlesource.com/1087950Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565484}
-
liberato@chromium.org authored
For some reason, we were setting the service ID to 1 unconditionally when creating an AbstractTexture in the validating decoder. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I809e1aa2c23d6bebe999dae7abd70eb4cbfba719 Reviewed-on: https://chromium-review.googlesource.com/1091647Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#565483}
-
Chris Blume authored
Currently, we statically link to the Vulkan library. We want to dynamically link it and not require a developer to have the Vulkan SDK installed. This requires using function pointers instead of directly calling the library's functions. This CL adds function pointers, dynamically links to the Vulkan library, and updates all existing function calls to function pointer calls. BUG=848104 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I68a5030b5f8bfe6a04b1e60c2fbdacd69dcd3ef3 Reviewed-on: https://chromium-review.googlesource.com/1080237Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Nigel Tao authored
Command line: python tools/json_schema_compiler/compiler.py \ chrome/common/extensions/api/file_system_provider.idl \ --root=. --generator=externs \ > third_party/closure_compiler/externs/file_system_provider.js Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I146dd9125ee575e7ea6592cf6805a5f9eec194b7 Reviewed-on: https://chromium-review.googlesource.com/1089595Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565481}
-
Eric Willigers authored
We serialize the east-asian-variant-value, then east-asian-width-value, then 'ruby'. Spec: https://drafts.csswg.org/css-fonts/#propdef-font-variant-east-asian BUG=850370 Change-Id: I7c5d68f772cc91aa96cd04aa2f0b89b47be62329 Reviewed-on: https://chromium-review.googlesource.com/1090528Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#565480}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/840fa58..531d6f8 git log 840fa58..531d6f8 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 dgarrett@google.com cros tryjob: Use --git-cache-dir for local tryjobs. 2018-06-07 gbiv@chromium.org Stop generating AFDO profiles for non-r1 Chrome versions Created with: gclient setdep -r src/third_party/chromite@531d6f8 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:849881 TBR=chrome-os-gardeners@chromium.org Change-Id: I7b435ec35584eee7204c82fb4233e9557a09536d Reviewed-on: https://chromium-review.googlesource.com/1091811Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565479}
-
Fadi Meawad authored
navigator.sendBeacon should be allowed during the onfreeze callback, there was no changes in the code needed to enable it since it is implemented using fetch-keepalive, that is already allowed. This CL adds a test to make sure that this does not regress. Bugi: chromium:838684 Change-Id: I71b628ccce4dfbf1f2bd012c24866cd908f56d30 Reviewed-on: https://chromium-review.googlesource.com/1091638Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565478}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea17575..e1a057e git log ea17575..e1a057e --date=short --no-merges --format='%ad %ae %s' 2018-06-07 geofflang@chromium.org Fully format some files. 2018-06-07 lfy@google.com GLES1: Texture environments setup Created with: gclient setdep -r src/third_party/angle@e1a057e The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8aa7ee5e208f52c3f1c7f182ffd6b974851fcdf7 Reviewed-on: https://chromium-review.googlesource.com/1091930Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565477}
-
edchin authored
Bug: 804589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic87877e2e9c3e1a8ddf619abea5fb83af250f7ea Reviewed-on: https://chromium-review.googlesource.com/1089821 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565476}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e89dcf7..efe4f89 git log e89dcf7..efe4f89 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 ehmaldonado@chromium.org gclient: Add a test to make sure we're syncing CIPD dependencies. Created with: gclient setdep -r src/third_party/depot_tools@efe4f89 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:849374 TBR=agable@chromium.org Change-Id: I5b70b1e191787949884678824983971244c978ea Reviewed-on: https://chromium-review.googlesource.com/1091509Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565475}
-
Kyle Horimoto authored
This is necessary for a follow-up CL which much inject a FakeTimerFactory. Bug: 824568, 752273 Change-Id: I3575778517c5768074e970604f95729c1fb761ae Reviewed-on: https://chromium-review.googlesource.com/1091657 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#565474}
-
Karan Bhatia authored
The Declarative Net Request Page Whitelisting API uses initiator checks to guess the main frame url for a main-frame subresource request. This CL adds UMA to enumerate how often the different cases occur. This should help reason about the correctness of these checks. BUG=811460 Change-Id: Id72c05041477d05825fbe7e0ff7fecbf39fda861 Reviewed-on: https://chromium-review.googlesource.com/1089475Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#565473}
-
Tao Bai authored
The log can be enabled by run setprop log.tag.AwAutofillManager DEBUG Bug: 843277 Change-Id: I136d300b4fa11e42b3acce0f41ad832b56ff9938 Reviewed-on: https://chromium-review.googlesource.com/1091302Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#565472}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/81327d5..ed51a6e git log 81327d5..ed51a6e --date=short --no-merges --format='%ad %ae %s' 2018-06-07 gustaf@webrtc.org AEC3: Avoid static initializers 2018-06-07 peah@webrtc.org AEC3: Delay stabilization after a delay change 2018-06-07 peah@webrtc.org AEC3: Added filter preprocessing to avoid low frequency artefacts 2018-06-07 magjed@webrtc.org Android: Throw exception in CallSessionFileRotatingLogSink if dir is null 2018-06-07 gustaf@webrtc.org AEC3: Improved anti-aliasing filter for DSF 4 2018-06-07 mbonadei@webrtc.org Removing warning suppression flags from test/. 2018-06-07 mbonadei@webrtc.org Re-enabling SanitizerTest.MsanUninitialized. 2018-06-07 srte@webrtc.org Fixing issue where pacer budget increased in congestion. 2018-06-07 asapersson@webrtc.org Remove unused methods in VCMDecoderDataBase. 2018-06-07 nisse@webrtc.org Delete unused stats for preferred_bitrate. 2018-06-07 gustaf@webrtc.org AEC3: Move decimator filters to the new notation 2018-06-07 nisse@webrtc.org Delete RTP-specific values from the VideoCodecType enum. Created with: gclient setdep -r src/third_party/webrtc@ed51a6e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:846615,chromium:850451,chromium:848231,chromium:b/106732994,chromium:846615,chromium:none,chromium:846615,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fa6c8ebdf457e84a74bc440a044f50ba4915e21 Reviewed-on: https://chromium-review.googlesource.com/1091287Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565471}
-
- 07 Jun, 2018 22 commits
-
-
dpapad authored
Need to override |_forwardHostPropV2| method for Polymer 2. |_forwardParentProp| and |_forwardParentPath| can be removed after Polymer 2 migration is done. Bug: 849788 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic77854582a5184fa41fe5dca02724c9f2cc7dc7d Reviewed-on: https://chromium-review.googlesource.com/1091653Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565470}
-
Mark Cogan authored
This CL makes the background separators for the segmented control transparent (by making the background view itself transparent). It also adds an alpha parameter for the background color in anticipation of making the background itself somewhat transparent. Bug: 849647, 849646 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia17c32297a73de9de2a4903a84829f6c5f4dae75 Reviewed-on: https://chromium-review.googlesource.com/1091536Reviewed-by:
-
Kyle Horimoto authored
This class is used to prioritize incoming connection requests according to their priority and time that they were received. This CL will be used in the upcoming BleAdvertiser class, but it is named generically so that it can be easily reused for future connection mediums that require shared resources. Bug: 824568, 752273 Change-Id: I9a21997f3e03cc439412c3bb8db398a5a448e146 Reviewed-on: https://chromium-review.googlesource.com/1088152Reviewed-by:
-
Min Qin authored
The filename and URL may contain special characters that require escaping Or otherwise the json file won't open BUG=850734 Change-Id: Ic4164cd0512c0ba288b6039b2b4bd8dc4f63bb0d Reviewed-on: https://chromium-review.googlesource.com/1091391Reviewed-by:
-
Xiaohan Wang authored
This CL adds more detailed test case for EncryptedMediaTest.PolicyCheck when using Widevine key system. Note that the test is bypassed on ChromeOS since Widevine CDM on ChromeOS doesn't support this API yet. Bug: 849846 Test: Add more detailed test case. Change-Id: Iae08027f8fae25710dd5b997ff4942c234c04192 Reviewed-on: https://chromium-review.googlesource.com/1087438 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Fix DCHECK in NetworkServiceTestHelper on network process shutdown because bindings are destructed on the wrong thread. Bug: 846445 Change-Id: I765b613ea68201382da3f437e9f6a57904839bba Reviewed-on: https://chromium-review.googlesource.com/1091806Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565465}
-
danakj authored
Instead of creating and destroying the ClientResourceProvider with the LayerTreeFrameSink, create it once and keep it around until the LayerTreeHostImpl is destroyed. This allows ResourceIds to remain valid when the LayerTreeFrameSink is replaced while software compositing (which can happen if the viz service crashes). We add a method ShutdownAndReleaseAllResources() on ClientResourceProvider that will release any exported resources, marking them as lost, instead of doing so in the destructor, so that the owner of the class can control the timing more without needing to heap-allocate the class. We also take away the allowance for importing a ResourceId and not removing it before destroying the ClientResourceProvider (or calling ShutdownAndReleaseAllResources()). Instead we have it DCHECK() if this occurs, reporting the stack trace from where the resource was imported. We do this because marking resources that are not exported as lost is silly, since they were imported they could have been removed. A bunch of unit test changes are done to remove resources that were imported because of this. Two unit tests that tested the case of destroying the ClientResourceProvider while imported resources were present are removed since it is no longer supported. When the CompositorFrameSink is lost, the LayerTreeHostImpl loses the ability to receive back resources it had previously exported. We add a method ReleaseAllExportedResources() on ClientResourceProvider to handle this case, which removes the export count on all resources, releasing any marked for deletion previously. When software compositing, they do not need to be marked lost, but when gpu compositing they do since the display compositor modifies texture metadata in order to use them. Tests for the new method are added, as well as to verify that in LayerTreeHostImpl, when the CompositorFrameSink is replaced, that the ResourceIds are not kept around. The software-resources-aren't-lost distinction is not important in this CL, since LayerTreeHostImpl destroys all its resources regardless when it tears down the ResourcePool and RasterBufferProvider. However for external clients which provide a resource through TextureLayer, the ResourceId can remain valid in software compositing. R=piman@chromium.org Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I85a867c2830c31d39796ff971e01a221e5716812 Reviewed-on: https://chromium-review.googlesource.com/1083617Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Trent Apted authored
Opening an entire bookmark folder with more than 20 bookmarks in it from the bookmarks bar using Cmd+Click on a Cocoa browser is currently broken. This happens in the bookmark draggable button's action. The action may run a nested loop, which may see the mouse "up" event and cause the action to be performed again, inside the nested loop. We also need to ensure the bookmark button doesn't enter its _own_ nested run loop, since the mouse up has already been eaten by the nested run loop inside the action. Failure to do so causes the action to happen twice, which results in the nested run loop of the action spawning another, nested, run loop within itself, which never exits. This puts the browser into a very weird state. TEST=On Mac (chrome://flags/#views-browser-windows DISABLED), have a folder on the bookmarks bar with >20 items and Cmd+Click it. Accept the dialog. Bookmarks should open. Bug: 849135, 840387 Change-Id: I7e1eaf57dff956647cbdcf2cb449bb971cada074 Reviewed-on: https://chromium-review.googlesource.com/1090513 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#565463}
-
Nick Harper authored
Prior to crrev.com/c/1026630, SSLConfig.channel_id_enabled defaulted to true, meaning that the proxy SSLConfig had Channel ID enabled. That CL flipped SSLConfig.channel_id_enabled to default to false, but only set channel_id_enabled on the server config, not also the proxy config. This change should restore the behavior of Channel ID on proxies to what it was before crrev.com/c/1026630. Bug: 848953 Change-Id: Ibfde08309803e4bebac622b0d6366a2256ff2b58 Reviewed-on: https://chromium-review.googlesource.com/1089859Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#565462}
-
danakj authored
R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I15e59cebabd9b8fd018c1342d5d3658f847a3627 Reviewed-on: https://chromium-review.googlesource.com/1089663Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#565461}
-
Xianzhu Wang authored
There are still cases that LayoutSVGEllipse asks LayoutSVGShape for ShapeDependentStrokeContains() when it decided to bypass the path for optmization in UpdateShapeFromElement(). Bug: 850659 Change-Id: If8f8fd512183477ec7472ebb5b28c7d8333aa0bd Reviewed-on: https://chromium-review.googlesource.com/1091871 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#565460}
-
Brian Anderson authored
Sources that run on BeginFrames can delegate their skipped frame logic to SkippedFrameTracker. SkippedFrameTracker handles the following corner cases: 1) when non-consecutive BeginFrames are received. 2) when the producer is not trying to produce. Bug: 790759 Change-Id: I99d4067d4eab79f220b892256d8d3d49d1af1209 Reviewed-on: https://chromium-review.googlesource.com/1070994 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Theresa authored
Add an instrumentation test that checks for element visibility when the default search engine is toggled. BUG=841928 Change-Id: I878a4b486b988310899fcc3f88a751e90a97ee3e Reviewed-on: https://chromium-review.googlesource.com/1091188Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#565458}
-
Esmael El-Moslimany authored
Bug: 849811 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib034544b40403e47e1c7c538b70b93e9d3f6ee8c Reviewed-on: https://chromium-review.googlesource.com/1087783 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Lei Tian authored
UrlUtilities.getTelNumber crash if the url param does not contain ":", add a check to the function preventing from crash. Bug: 830086 Change-Id: Icb82df469986f329a5fdaf6ce3b20624a0530acb Reviewed-on: https://chromium-review.googlesource.com/1091885 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#565456}
-
kylechar authored
We don't increment the crashed UMA for GPU_PROCESS_KIND_UNSANDBOXED. Don't increment the launched UMA either. Bug: 846333 Change-Id: I3f5845c3bd1b221640a11098ed7c5b7b1da2148b Reviewed-on: https://chromium-review.googlesource.com/1091492Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#565455}
-
Ian Vollick authored
With this change, package_arcore will be true for dev and canary builds. Bug: 841881 Change-Id: Ib2a75e5a87cdc9776c674cc24293017966a56fe5 Reviewed-on: https://chromium-review.googlesource.com/1091642 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565454}
-
Daniel Nicoara authored
Provides more insight on the overlay state in the logs. Typically this is used to signal that a video should be visible on Chromecast. This only triggers on changes, so it should be infrequent enough not to spam the log, but useful enough for developers to know when overlays are in use. BUG=b/79195588 TEST=Ran on device and verified the state change is shown in logs. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8af803ee1b28d9588d3cf9baee1af0804b5ece92 Reviewed-on: https://chromium-review.googlesource.com/1090795Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#565453}
-
Stephen Martinis authored
Bug: 612667 Change-Id: I6bd52794bf6122813770338a93509d295bf4a7cb Reviewed-on: https://chromium-review.googlesource.com/1060458Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#565452}
-
James Wallace-Lee authored
This adds the Utility class ApiHelperForO. It moves references to RenderProcessGoneDetail, which was added in O, into a separate class. On pre-O devices, this reduces log spam caused by a NoClassDefFoundError. It also improves startup time. Bug: 791099, 838702 Test: adb logcat | grep 'Failed resolution of' Test: run_webview_instrumentation_test_apk -f org.chromium.android_webview.test.AwContentsClientOnRenderProcessGoneTest#* Change-Id: Iee47d5d5553b6eb339123fbea238dcbf9969de49 Reviewed-on: https://chromium-review.googlesource.com/1089477 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565451}
-
Michael Thiessen authored
Disabling overscroll glow in the way we did (in https://codereview.chromium.org/2632493005) caused pull-to-refresh to break. VR UX folks want overscroll glow anyways now, so let's just turn it back on and un-break pull-to-refresh. (Pull-to-refresh was broken because the overscroll controller wasn't receiving Animate calls, so when the glow got 'shown' it never animated away so the code thought it was always visible, and therefore prevented pull-to-refresh) Bug: 838679 Change-Id: I06fdbaadedfec702d43bf1915f3b05703da3d039 Reviewed-on: https://chromium-review.googlesource.com/1091658Reviewed-by:
-
Becca Hughes authored
Adds a DisplayCutoutHost mojo interface that is implemented by WebContentsImpl. When ViewportFitChanged is called by the renderer we fire the ViewportFitChanged method on WCO. This allows the browser to change the UI based on the ViewportFit state. On the Blink side changes to ViewportFit bubble up through Document which will call the DisplayCutoutHost Mojo interface. BUG=838400 Change-Id: I701f8c367167c5d630800f9d41004b88d95f63f3 Reviewed-on: https://chromium-review.googlesource.com/1038786 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#565449}
-
