- 27 Oct, 2020 40 commits
-
-
Victor Costan authored
This CL replaces smart pointers (scoped_refptr) with references where the pointers are guaranteed to be non-null, and the objects are only used during the method call. This removes the test's reliance on QuotaClient being ref-counted, which will come in handy when QuotaClient gets mojofied. Bug: 1016065 Change-Id: I03493aa3e62d8cac2b8b9d81ace5d44dbfa75915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496744Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821427}
-
James Cook authored
Prior to this CL, files downloaded in Lacros would "disappear" -- they would not show up in the file manager. The downloads code would choose its default directory using the Chrome for Linux path provider, which does not know about Chrome OS paths, and the files would end up in a directory the file manager can't navigate to. Add chrome_paths_lacros.cc to supply the correct paths. Because Lacros does not support Chrome OS multi-signin, we make the decision that lacros-chrome does not need to know about the under-the- hood /home/chronos/u-{hash} multi-signin profile directories. It uses the hard-linked /home/chronos/user path for the system primary profile. This avoids exposing knowledge of the hash to Lacros. Bug: 1139082 Change-Id: I8836760632fd9a1a8f9d49d7f03f1e6f6dfb0841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500278Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#821426}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 655d04d4. With Chromium commits locally applied on WPT: 6eb4060f "Add WP test for referrer policy inheritance when navigating back" a9818a74 "Add epislon to matrix tests to fix 0 = -0 problem" 655d04d4 "Fix referrer policy inheritance WPT for javascript: URLs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I43dfa9e6e04f3e251945589b674b0b1bef42dff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503428Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821425}
-
Jimmy Gong authored
- This change fixes a bug where we previously did not actually attach PhoneStatusProcessor as an observer to MultiDeviceSetupClient::Observer - Fixes a bug where the phone name was not being displayed in the phone hub tray Bug: 1106937 Fixed: 1141642 Test: chromeos_components_unittests Change-Id: I4a7b04e34a5b7950b63a4b32dc633fece7c52e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501063 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821424}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1142671 Change-Id: I2be70e691cb316d4ac5ae5c48b309758d30cfd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500493 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821423}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hanxi@chromium.org Bug: 1142671 Change-Id: I527f1a4dda878d289ac3542336b87737bd377f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500590 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821422}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hanxi@chromium.org Bug: 1142671 Change-Id: I28b7b2eb82e87e409f370d044f1aa2e4845d764d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500605 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821421}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibfca948636ea19a4da798f38d5056088e93f1772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504028Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821420}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/25eeaa3d39af..6b087819dd1e 2020-10-27 cwallez@chromium.org s/OutputAttachment/RenderAttachment/g If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I14b1a1e9a97bbc6870e8346ffd2cb8970c412970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821419}
-
ckitagawa authored
This CL restricts the number of outbound requests to the paint preview compositor for processing bitmaps to 4. This should limit the peak memory usage and might reduce OOM crashes. This CL also makes it possible to cancel queued requests. As a result, when flinging or zooming where many requests are made at once, it is possible to clear pending requests for tiles that exit the viewport before the request is served. Bug: 1142545 Change-Id: I8f4859c61e5ffd1fa017dd840fac57fe8deb79ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497825 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821418}
-
Dave Tapuska authored
Move the allocation of the shared memory segment for ukm smoothness from RenderWidget to LocalFrameClientImpl. BUG=1097816 Change-Id: Ib95690ed560e80a4bd43da5be534ae82a5370fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495612 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821417}
-
Maggie Chen authored
From https://codepen.io/wesselkroos/pen/KKpGReq, we can clear see the blur the area modify by the blur effect is actually 3x of the blur radius. See the screen shot in crbug.com/1117235. Bug: 1117235 Change-Id: Ib38b70b28bc4bc181ea6366d9d84ad7f7e60b08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493983Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821416}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0fb0eb3e80c0..ee24eb66d23f 2020-10-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0cbcb123..473d43b3 (821065:821175) 2020-10-27 philipp.hancke@googlemail.com unify "control reaches end of non-void function" style 2020-10-27 ssilkin@webrtc.org Change SPS/PPS id update strategy to SPS_LISTING. 2020-10-27 terelius@webrtc.org Revert "Reland "Default enable WebRTC-SendSideBwe-WithOverhead."" 2020-10-27 fabien.vallee@netgem.com Fix "control reaches end of non-void function" warnings 2020-10-27 philipp.hancke@googlemail.com getstats: fix inbound-rtp audio level range 2020-10-27 hta@webrtc.org Make SdpOfferAnswerHandler be owned, not contained. 2020-10-27 asapersson@webrtc.org test::CreateVideoStreams: Use default unconfigured VideoStream if layer is missing in config. 2020-10-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cd03b6f1..0cbcb123 (820940:821065) 2020-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 437e5d9a..cd03b6f1 (820819:820940) 2020-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4d9dbbae..437e5d9a (820701:820819) 2020-10-26 danilchap@webrtc.org Make ScalableVideoController::OnRatesUpdated pure virtual 2020-10-26 sprang@webrtc.org Tweaks videocodec_test threshold for arm vp8 simulcast 2020-10-26 hta@webrtc.org Const-declare 3 more PC member variables 2020-10-26 kron@webrtc.org Signaling for low-latency renderer algorithm 2020-10-26 jakobi@webrtc.org Reland "Default enable WebRTC-SendSideBwe-WithOverhead." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111273,chromium:1138888,chromium:1142626 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idb9d274c08946a2fe3381c73fded1b5dd16c860f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821415}
-
Tom Anderson authored
This CL removes usage of XLookupString() that was temporarily introduced by [1]. The issue is that the XKB keyboard map wasn't being used when XKB was available -- the core keyboard map was always being used. This meant that XKB-specific features like keyboard groups and fifth-level shift became unsupported. This CL separates the XKB and non-XKB codepaths into 2 classes: XkbKeyboardState and CoreKeyboardState. This CL also moves the keyboard-related code out of connection.cc into keyboard_state.cc. [1] https://source.chromium.org/chromium/chromium/src/+/a2fd175c6a692351827aacd8e1285d2190ccd4e4 R=sky BUG=1066670 Change-Id: I26023f87c396f5728ce32c0d1fb0275e0335db15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464786 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821414}
-
Ioana Pandele authored
The editor should now be launched directly by tapping on the password entry in Settings > Password. This CL also separates the editing-specific tests from PasswordSettingsTest.java. Only integration tests that actually rely on PasswordSettings are left there. Bug: 1141409, 1122310 Change-Id: Ie8d742d64e40b9881b35bf24a333d59c9b4cef02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494922 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#821413}
-
Tom Anderson authored
This is required as a prerequisite for landing: https://chromium-review.googlesource.com/c/chromium/src/+/2464786/ BUG=1066670 R=yhodique@google.com,johnwedig@google.com,dpranke@chromium.org Change-Id: Id69ddf2b22f31d93b003a632b64f938b0ce3a55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500268Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821412}
-
John Delaney authored
What: Use a single LazyThreadPoolSequencedTaskRunner for all conversion storage operations. Why: Conversion Storage doesn't have strong ordering guarantees regarding databases being torn down and recreated for the same profile. E.g. Profile closed -> delete posted to task runner A Profile opened -> create posted to task runner B We assume that task runner A will finish executing the delete, freeing the database prior to task runner B trying to open it. However, if task runner A has a long running operation already sequenced, this isn't necessarily true. Using a unified task runner removes this edge case. This also removes the need to do any dependency injection which is discouraged for task runners. Bug: 1114783 Change-Id: If09d0a9a68ec0d461321744f2734c28b0ccbe068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490256Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#821411}
-
Natalie Chouinard authored
This change is necessary to roll downstream GMS Core, which includes new proguard rules added via META-INF/proguard in google_play_services_basement_java. Change-Id: I0883ffe043a8dae267fa2e82757996e64cefd37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503813Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821410}
-
Steven Bennetts authored
This replaces the restricted_connectivity property to a more versitale portal_state property and enum. Bug: 1133376 Change-Id: I2229e2675b95ceea7184bdfd773b85be12e3217d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490252 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#821409}
-
Tim Song authored
This CL implements 3 histograms for the phone connected screen: * Ash.PhoneHub.NotificationOptInEvents * Ash.PhoneHub.QuickActionResult.* * Ash.PhoneHub.TabContinuationChipClicked BUG=1138137,1106937 Change-Id: Ic6cb37d5dd5208a09dee1249540c8f3c877be3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491243Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821408}
-
Maggie Chen authored
A wrong transform metrix is picked when calling AddSurfaceDamageToDamageList(). Bug: 1117235 Change-Id: Icf6529448f6973395068ee0601ec975f5c5bdb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500311Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821407}
-
spdonghao authored
This CL makes startSurfaceToolbar act as if it's scrolling with start surface. And once the omnibox is scrolled up to the top, the real search box is pinned. Please see this doc for more information: http://doc/1m7MBIKFt1qPuv7grxgllAhb6Umaur_T6pwegeWHuDNI#heading=h.xcr03ehfori3 Following work needed to do: - Add an animation for showing the toolbar container view when omnibox is disappearing. - Remove the progress bar that sometimes shows. crbug.com//1136599 Bug: 1113852, 1041123 Change-Id: I7909bc2fe3caa46758c73e5a4d952ccfdec4fd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426730 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821406}
-
Ievgen Rysai authored
This fix gives assistive software a fine-grained control over selection. In Safari this attribute is settable. Bug: 1139106 Change-Id: Ibff2665ee0bd2db77ce692385eb7f4965f15626b AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478782 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821405}
-
Greg Thompson authored
The cleanup code was removed in r819537. This CL removes the handling of the --cleanup command line switch. BUG=none R=gab@chromium.org Change-Id: Iba5e9cd057378ccf2712f12f37589d6b84b0f7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502161 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#821404}
-
Solomon Kinard authored
Bug: 1133624 Change-Id: Ifc584797d31485ef53dbc5f29cbc7f97213705bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476516 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821403}
-
Alexander Cooper authored
Screen Capture on Android hasn't been updated since it was only exposed via getUserMedia. This change: * Adds a UI flag to enable the feature * Expands the DCHECK to allow getDisplayMedia calls to work * Removes a DCHECK that width/height are even * There was no comment for this DCHECK and if there were a technical limitation, it appears to have been removed. With this change (and the flag enabled) getDisplayMedia seems to work, at least for a simple golden-path scenario. Bug: 487935 Change-Id: Ic340345d15798947ba22e9962d5a83a83a974a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495823Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#821402}
-
Meilin Wang authored
This CL polishes the interstitial screen including: - Makes progress bar the same width as the bubble. - Updates constants to spec. Screenshot: https://screenshot.googleplex.com/73uEHo56GiKENdQ.png Misc: removes unused |AddSeparator| function. BUG=1106937,1126208 Change-Id: If44bd19b8347a0385dd0be975fd42189eb4a4a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495977 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821401}
-
Gang Wu authored
This CL add a new shape, round corner rectangle IPH for ChipView. There will be a follow up CL for renaming the turnOnHighlight to turnOnCircularHighlight and turnOnRectangularHighlight in ViewHighlighter to unify the name in the class. Bug: 1136169 Change-Id: I1c8efefb788942905f8142e04621b350b2c602a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500274Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821400}
-
Viktor Semeniuk authored
Before allowing users to use another password, we should warn users that they should trust the current website because of the security risk Bug: 1137459 Change-Id: Id4d003ea1d747862041ce6a521f0f884f63df3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476154 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821399}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: Id999e5a86a548e874879714e91a13a9475cf3c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503549 Commit-Queue: Matt Mueller <mattm@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821398}
-
Mohammad Refaat authored
The flag for the previous window was reset too early before the incognito session was restored, and that caused the problem of not migrating incognito sessions Bug: 1139894 Change-Id: I40384b3f2051a79f18cdd0fc755cc01b402cdd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499177 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#821397}
-
Nicolás Peña Moreno authored
There is a reported crash in cases where InsertPerformanceEntry is called, so add a DCHECK to make debugging easier and determine whether this is indeed the problem or if it's something else. Also cleanup the method. Bug: 1141666 Change-Id: I9d15ff62255b4830ce7abf9fd7569b15195b6524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495343Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821396}
-
Elvin Hu authored
Bug: 1138715, 1141522, 1141524, 1141523 Change-Id: I6a41af31af14fa20a13ffe93ef99f6ba6fc44a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488748 Commit-Queue: Elvin Hu <elvinhu@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#821395}
-
Rahul Goyal authored
Bug: b/171025821 Change-Id: I8cee9bdce4f72e670dfe6e34e0c77bcf59baa8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502689Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#821394}
-
Bailey Berro authored
This change introduces a DiagnosticsUI::BindInterface specialization for SystemDataProvider. Bug: 1128204 Change-Id: I565ad6a77761004de132cb7ca8884d4b50db4289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495796Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#821393}
-
ckitagawa authored
If a native page is shown as the first thing after startup it is possible a preview will be shown. This CL avoids that scenario. Bug: 1142856 Change-Id: Id309d58a810b0f58649dc4b11dba8398fcb8e1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502391Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#821392}
-
Fredrik Söderqvist authored
Change-Id: I0f7eac3f7af6a1763024a844d01c66a043d074a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502479 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#821391}
-
Jan Wilken Dörrie authored
This change replaces remaining usages of autofill::PasswordForm with password_manager::PasswordForm in /chrome/browser and /chrome/renderer. TBR=treib Bug: 1067347 Change-Id: Ia168707c1cfcd084dcae921b7bc8811a2866743c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499441Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#821390}
-
Henrique Nakashima authored
Inline action "MobileTabSwitched". All other code is to record "Tab.RestoreUserPersistence", which is obsolete. Bug: 1138653 Change-Id: I86b0701713a541d2d448cfb602b86c9b043ee632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476958Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#821389}
-
Dan Harrington authored
There are some of these directives being brought in through the internal roll. Change-Id: I9fa30dd0ab859e8f80b5bc3b203ef720afbea837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503191Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#821388}
-