GitLab

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150654

Review URL: https://chromiumcodereview.appspot.com/10830072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150863 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150862 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150861 0039d316-1c4b-4281-b951-d872f2087c98

(GTK only) For internal chrome pages display only a bubble with an info string instead of the Website Settings popup.


BUG=140450
TEST=For internal chrome pages like chrome://settings only a small bubble with an info string is displayed.
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150857 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10836175/
Review URL: https://chromiumcodereview.appspot.com/10832223

TBR=robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/10834258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150856 0039d316-1c4b-4281-b951-d872f2087c98

+++ REVERT NOTICE +++
Test should pass on QA bots now that a new official build is available.
+++ +++

BUG=141410
TEST=Ran on chrome-qa bot to witness failing steps identified in the bug.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10826206

TBR=dyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150855 0039d316-1c4b-4281-b951-d872f2087c98

Clicking on a maximizer dialog button and dragging out of the dialog left the phantom window open

BUG=141438
TEST=Visual


Review URL: https://chromiumcodereview.appspot.com/10836176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150854 0039d316-1c4b-4281-b951-d872f2087c98

When a fling happens at the end of a scroll, instead of generating both a scroll-end
and a fling-start event, generate only fling-start event. Unfortunately, WebKit still
requires an explicit scroll-end gesture before a fling, so continue to do that as a
special case.

BUG=141460,141309

Review URL: https://chromiumcodereview.appspot.com/10826209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150852 0039d316-1c4b-4281-b951-d872f2087c98

Both java.gypi and apk_test.gypi expect the jar path in
input_jars_paths. This means that we were specifying the dependence in
both 'dependencies' and 'input_jars_paths'. This change makes it so that
we don't need that redundancy.

Also, make java.gypi use input_jars_paths in its input so that we
actually rebuild targets when we should.

BUG=136756


Review URL: https://chromiumcodereview.appspot.com/10837143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150850 0039d316-1c4b-4281-b951-d872f2087c98

This removes prior solution where a duplicate web_contents for the NTP was
stored in the search_tab_helper.  Replaces that solution with this where the
main browser window's web view is reparented into the search overlay when the
search overlay is active and displaying the NTP.  When the NTP is dismissed or
navigated away, the web view is reparented back to the main browser_view's
contents container as per usual.

BUG=133529
TEST=--enable-instant-extended-api, load NTP, click on a most visited link.  Expect navigation in main browser window.
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150849 0039d316-1c4b-4281-b951-d872f2087c98

Fixes page cycler netsim test on Linux.

BUG=133069
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10829259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150848 0039d316-1c4b-4281-b951-d872f2087c98

Rather than excluding safe_browsing dependencies for non-safe_browsing
builds only include them when needed. This is a baby-step towards a
safe_browsing component.

This is part of Android upstreaming (smhasher isn't used).

BUG=137571


Review URL: https://chromiumcodereview.appspot.com/10825226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150846 0039d316-1c4b-4281-b951-d872f2087c98

Fix reference to WebContentsDelegate and make the entire
ShellWindow implementation private.

R=jianli@chromium.org
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150845 0039d316-1c4b-4281-b951-d872f2087c98

R=mangini@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150844 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150843 0039d316-1c4b-4281-b951-d872f2087c98

Removes support for v8Locale. ChromeOS has already moved to new v8Intl.

BUG=28604
TEST=v8Locale should not exist. ChromeOS should build properly.


Review URL: https://chromiumcodereview.appspot.com/10837152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150842 0039d316-1c4b-4281-b951-d872f2087c98

CrOS Aura: Fix pinning Chrome Web Store to Launcher

When requesting to load the extension icon, we now check whether the ext. resource is empty. If so, we request DONT_CACHE (instead of CACHE). Caching fails two DCHECKS when the ext. resource is empty. Also the key involved in caching would be an empty string when the ext. resource is empty.

Earlier solution, later abandoned (reverted):
Icons are not required in extension or app manifests. Modified
Extension::HasCachedImage and Extension::SetCachedImage to not fail
a DCHECK nor to cache an image, if the ExtensionResource is empty.

See also the now obsolete: http://codereview.chromium.org/10823115/

BUG=124865
TEST=Click on Apps icon in the Launcher;
     Right click on Chrome Web Store;
     Select Pin to Launcher;
     Observe no DCHECK on Debug build on linux desktop

Review URL: https://chromiumcodereview.appspot.com/10830123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150841 0039d316-1c4b-4281-b951-d872f2087c98

We are missing some debugging flags in the make which prevents us from getting
debugging info in the SDK.

This CL only affects the SDK (specifically SDK examples and user libs) and not Chrome.

BUG=141227
R=binji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150840 0039d316-1c4b-4281-b951-d872f2087c98

The script currently does not run tries, since the try mechanism rejects
the entire request if any requrest bot is bogus.
Review URL: https://chromiumcodereview.appspot.com/10854028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150839 0039d316-1c4b-4281-b951-d872f2087c98

Import pyauto_errors.JavascriptRuntimeError so that
AddDomMutationObserver can raise it correctly.

BUG=None
TEST=
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10824237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150837 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150836 0039d316-1c4b-4281-b951-d872f2087c98

The implementation of this method is basically noop in platforms other than ios and it is put in the header file; this change adds inline annotation to avoid duplicate symbol link error on other platforms.

BUG=NONE


Review URL: https://chromiumcodereview.appspot.com/10837182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150831 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150829 0039d316-1c4b-4281-b951-d872f2087c98

used.

TBR=jamescook@chromium.org
BUG=chromium-os:33223,chromium:129052
TEST=built

Review URL: https://chromiumcodereview.appspot.com/10831236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150828 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10834193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141639
TEST=Visual, if you look carefully.


Review URL: https://chromiumcodereview.appspot.com/10855078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150826 0039d316-1c4b-4281-b951-d872f2087c98

Properly notify the handle verifier when a handle is passed around. This CL fixes issues introduced by r150508.

BUG=134694


Review URL: https://chromiumcodereview.appspot.com/10855061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150825 0039d316-1c4b-4281-b951-d872f2087c98

The number of calles of FindEntryByPathSync() is reduced from 17 to 15.

BUG=10831212,126634
TEST=Copying a file (and a hosted document) on Drive works before from file manager

Review URL: https://chromiumcodereview.appspot.com/10828219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150824 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150823 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10836175/
Review URL: https://chromiumcodereview.appspot.com/10832223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150822 0039d316-1c4b-4281-b951-d872f2087c98

Sync the client (Chrome) version of the SafeBrowsing csd protocol buffer definition with the version we have on the server.

This change adds a couple of fields which will be used by Chrome on
Android to display custom SafeBrowsing warnings.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10827231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150821 0039d316-1c4b-4281-b951-d872f2087c98

I added another histogram into the DuplicateContentResourceHandler. The histogram is meant to keep track of all the ResourceTypes of resources coming through the handler to see the distribution of ResourceTypes.
R=gavinp@chromium.org,darin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150820 0039d316-1c4b-4281-b951-d872f2087c98

R=robertshield
BUG=None
TEST=None
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/10854042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150819 0039d316-1c4b-4281-b951-d872f2087c98

The README has been updated with info about preview.py.

BUG=141034

Review URL: https://chromiumcodereview.appspot.com/10831225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141497
TEST=test works again


Review URL: https://chromiumcodereview.appspot.com/10855074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150817 0039d316-1c4b-4281-b951-d872f2087c98

While the use of gmock's InSequence is unfortunate (read: brittle tests), it does help capture the call sequences for various pipeline operations. You may notice in the original incarnation of these tests in http://codereview.chromium.org/10828045/ didn't need InSequence. I'm aiming to remove InSequence after I'm done rewriting the guts of Pipeline.

BUG=110228

Review URL: https://chromiumcodereview.appspot.com/10832197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles

Review URL: https://chromiumcodereview.appspot.com/10828052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150814 0039d316-1c4b-4281-b951-d872f2087c98

Failing on the ChromiumOS Dbg Bots.

BUG=141497,139117
TEST=none
TBR=jochen

Review URL: https://chromiumcodereview.appspot.com/10837188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150813 0039d316-1c4b-4281-b951-d872f2087c98