- 29 Aug, 2018 40 commits
-
-
Marc Treib authored
This adds support for starting Sync-the-transport even when there is no primary (aka signed-into-Chrome aka blessed-for-Sync-the-feature) account. This is implemented by SyncAuthManager listening for OnAccountsInCookieUpdated, and using the first cookie account if there is no primary account and we have a refresh token for the first cookie account. This also makes it necessary to cache the current Sync account, so that we can detect changes to it. IsSyncFeatureEnabled now also checks that the current account is the primary one, so that we don't accidentally enable full Sync for a secondary account. Bug: 871221 Change-Id: I07c7db04cc92e9a40126c89c0fcfea49e03117d1 Reviewed-on: https://chromium-review.googlesource.com/1162174 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#587082}
-
Koji Ishii authored
Following bot results are included. 9223 9228 9235 9251 9264 9268 9274 9275 9278 9285 1 lines were removed and 2 lines were deflaked by consecutive results since 9215. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0e6c616d4f1301f6f6b45bbf048b0da272612301 Reviewed-on: https://chromium-review.googlesource.com/1192569 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#587081}
-
Yoshifumi Inoue authored
This patch change |NGPaintFragmet| ref-counted instead of managed by |std::unique_ptr<T>| to resolve life time issue between |LayoutText| and |NGPaintFragment|. Before this patch, paint fragment can live longer than |LayoutText| and causes heap-use-after tree in |NGAbstractTextBox::WillDestroy()|. Bug: 874588 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2982f2099b6ab2ccdf20bf11fd5ddb07e59209dd Reviewed-on: https://chromium-review.googlesource.com/1193868 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL adds the boolean schema attribute 'sensitiveValue' to the known schema attributes. This attribute is used to mask sensitive values with a replacement value, which can be displayed in the UI. Bug: 856901, 873641, 849657 Change-Id: I8afb2c3255d483737db8380abd898cd15d62e84a Reviewed-on: https://chromium-review.googlesource.com/1183235 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#587079}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 822afc4f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23580 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I35812aa74055e6773a083c0464177496734a0b67 Reviewed-on: https://chromium-review.googlesource.com/1195157 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#587078}
-
Yoshifumi Inoue authored
This patch marks following tests as Leak: - editing/selection/modify_extend/extend_by_character.html - editing/selection/modify_move/move_right_word_09_ltr_multi_line.html - virtual/threaded/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js https://ci.chromium.org/p/chromium/builders/luci.chromium.try/layout_test_leak_detection/48 TBR=yosin@chromium.org Bug: 878724,878727 No-Try: true Change-Id: Ia1d4552df60ef18dc56e780b82c430615d61012e Reviewed-on: https://chromium-review.googlesource.com/1194029Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587077}
-
Christian Biesinger authored
R=kojii@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idba8c1996227f385628c48cd6fb04bb7f727e8f6 Reviewed-on: https://chromium-review.googlesource.com/1194499 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f1c12b11..1cb2de3a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I683689e6e65221ca13dac8f181d9e739f08e8a3b Reviewed-on: https://chromium-review.googlesource.com/1195158Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587075}
-
Justin Cohen authored
This reverts commit bd98c9e0. Reason for revert: Breaks https://ci.chromium.org/buildbot/internal.bling.main/iphone10-simulator/14654 Original change's description: > Re-land "[ios] Add highlight animation state to fake omnibox." > > This reverts commit 167f9450. > > Correct test to scroll from the middle of the screen. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ie0d4822e3d44eb0ff2441d0e375dc82bcae97437 > Reviewed-on: https://chromium-review.googlesource.com/1194470 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587009} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I32afd822bde6bfe8cdca5a21e63f96d29069ddb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1194952Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587074}
-
Noel Gordon authored
Querying file list elements with .dim-offline class collects the files that could be rendered with 'offline' style: it does not mean they are rendered with 'offline' style. Fix that by requesting .dim-offline elements and their CSS opacity and checking the opacity has is the expected value for an offline rendered file list row entry (opacity 0.4 currently). Test: browser_tests --gtest_filter="*fileDisplayDriveOffline*" Bug: 878260 Change-Id: I636f7a6fc4e85d32c77094ed7e72e0244bf30303 Reviewed-on: https://chromium-review.googlesource.com/1193703Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587073}
-
Yuta Kitamura authored
This reverts commit 73315d63. Reason for revert: Caused ASan bot failure (heap-use-after-free) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28777 Original change's description: > Re-land "Get Chrome App frame immersive mode closer to working in Mash" > > This relands commit 58a77e66. > This reverts commit a6b39a98. > > The fix is in ImmersiveFullscreenController, which listens for destruction > of |top_container_|. > > Original change's description: > > Get Chrome App frame immersive mode closer to working in Mash > > > > Removes the ImmersiveFullscreenController from > > ChromeNativeAppWindowViewsAuraAsh and relies on the default one provided > > by Ash. Also: > > > > 1. Remove the WindowStateDelegate from ChromeNativeAppWindowViewsAuraAsh > > - Listen for fullscreen changes in order to keep system fullscreen > > state and AppWindow fullscreen state in sync. > > - RestoreAlwaysOnTop should just work without the special delegate > > implementation, as the taskbar handling in AppWindow is Windows- > > specific. Tested by > > WorkspaceLayoutManagerSoloTest.FullscreenSuspendsAlwaysOnTop > > - Fold non-delegate functionality into main class > > > > 2. Remove the default Ash WindowStateDelegate (i.e. that created in > > non_client_frame_view_ash.cc) which only overrode ToggleFullscreen. > > The default implementation, ::wm::SetWindowFullscreen, works as > > intended. > > > > 3. Add window properties to allow the client to enter/exit immersive mode, > > get the position of the reveal view, and disable some ways of automatically > > triggering immersive. > > > > TODO: propagate window properties across processes so that they work in OopAsh > > TODO: In OopAsh, listen for window state changes into/out of fullscreen. (This > > will replace the functionality that the frame gets from > > WindowStateObserver::OnPostWindowStateTypeChange in classic Ash). > > Change-Id: If6f4994ed2dbb2f0c0bd92a784f3f1ec6023ab56 > Reviewed-on: https://chromium-review.googlesource.com/1194874 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586934} TBR=sky@chromium.org,estade@chromium.org Change-Id: I01a50f00939a034368bc3b0ef507094f7fc22ae9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1195291Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#587072}
-
Koji Ishii authored
This patch rebaselines reasonable failures from a manual review with eae@chromium.org. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibac34e8edf41fc9586aba79ed8bfc7b728faef59 Reviewed-on: https://chromium-review.googlesource.com/1195403 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Balazs Engedy authored
Move all PNG files that are used as illustrations in the WebAuthn dialog from //chrome/browser/resources to //chrome/app/theme, and reference them in theme_resources.grd instead, to take advantage of the built-in logic to select the 1x/2x versions based on the current DPI setting. Bug: 849323 Change-Id: Ic43e71aec7ba6c5d31519eb916b9d99999f25ad6 Reviewed-on: https://chromium-review.googlesource.com/1193944 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587070}
-
Hiroki Nakagawa authored
For a while, we need to keep 3 shared worker script loading paths: classic, S13nServiceWorker, and NetworkService. To clarify which function arguments are used for which loading path, we should give more specific names to them. Bug: 715632 Change-Id: Ic566b8bc8d79424d1ac497048455cfb0b0fcbee2 Reviewed-on: https://chromium-review.googlesource.com/1194807 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#587069}
-
Alexander Hendrich authored
This Cl is part of a larger clean-up operation and removes unnecessary features and data types, which are not supported by both schema and value validation. This CL also adds documentation about the supported subset of JSON schema features. Bug: 873641, 856901 Change-Id: I8d464ab7b6404bde5b0f1372cb04a92a0e07080f Reviewed-on: https://chromium-review.googlesource.com/1183186 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Bug: 833797 Test: browser_tests --gtest_filter="*CrSettingsPeoplePageAccountManagerTest*" Change-Id: I4ead93ea730ce04cb3f4b511ceef1d116f964666 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1190522 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587067}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a687812c7087..9427f48f598c git log a687812c7087..9427f48f598c --date=short --no-merges --format='%ad %ae %s' 2018-08-29 mbonadei@webrtc.org rtc_executable should depend on //build/win:default_exe_manifest. Created with: gclient setdep -r src/third_party/webrtc@9427f48f598c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iafa15ce96dbed9735e3a7c3dcd5d167b86c3c411 Reviewed-on: https://chromium-review.googlesource.com/1195117Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587066}
-
Yuta Kitamura authored
This reverts commit 07a159d0. Reason for revert: caused LSan bot failure (leak). https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28776 Original change's description: > views: enable some tests with mus and cleanup comments > > tooltip_controller_unittest and window_reorder_unittest mostly just > work with mus. There are a couple of things that need to be disabled, but > for the most part they just work. > > Also adds comment as to why some tests are not in views_mus_unittests. > > BUG=615033 > TEST=this is a test only change > > Change-Id: I2e77b2624557fa7e27f4f2abb0f4de86a2b3e772 > Reviewed-on: https://chromium-review.googlesource.com/1194259 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586902} TBR=xiyuan@chromium.org,sky@chromium.org Change-Id: I9145b351d92f2a54aca08c9f93b2a1335a3364b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 615033 Reviewed-on: https://chromium-review.googlesource.com/1195404Reviewed-by:
-
Jun Choi authored
When BluetoothAdapter is powered on either manually or programmatically, continue scanning for nearby FIDO devices if scanning is not already in process. Note that while this change ultimately prepares for WebAuthN Cable/BLE UI flow, the expected change is also preferred for WebAuthN request without UI. That is, WebAuthN request using Cable/BLE security keys should work even when the request is received with BLE adapter powered off initially and user turns on the Bluetooth adapter afterwards. Bug: 877344 Change-Id: Icca842082aa7e22a4383c3abc4426c60bd569d30 Reviewed-on: https://chromium-review.googlesource.com/1187892 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#587064}
-
Jan Krcal authored
This CL adds a test for the common scenario that the sync server sends an empty update for the wallet data model type. This should have no impact on local data. Bug: 853688 Change-Id: Ib9699c0c0f531c0608f470ab59111da68253e3c2 Reviewed-on: https://chromium-review.googlesource.com/1193885 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#587063}
-
John Lin authored
This is because onBackPressedAsync() and loadUri() are both merged. Bug: 843161 Change-Id: I6bd72be3732d8e337ab7c6f97db605f219deccbd Reviewed-on: https://chromium-review.googlesource.com/1180208 Commit-Queue: John Lin <chuanl@google.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587062}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b18e8eb867ec..6443c8dade1c git log b18e8eb867ec..6443c8dade1c --date=short --no-merges --format='%ad %ae %s' 2018-08-29 nastasoiuf@google.com Integrated bar chart: single metric, multiple stories, Created with: gclient setdep -r src/third_party/catapult@6443c8dade1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I562c50d2f89a2d6e9a51f7b6a7ab85018b042ab0 Reviewed-on: https://chromium-review.googlesource.com/1195119Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587061}
-
Eric Seckler authored
TBR=gab@chromium.org Bug: 878356, 867421 Change-Id: I6e79125e93207696a6df3165e4c5bc968b364e14 Reviewed-on: https://chromium-review.googlesource.com/1193931Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#587060}
-
Rob Buis authored
Improve xhr/setrequestheader-content-type.htm result by doing two fixes: - Apply Content-Type processing steps for Documents, just like for Strings [1]. - Apply Content-Type processing steps also for empty Content-Type value [2]. This matches Firefox and WebKit. [1] https://xhr.spec.whatwg.org/#the-send()-method 4.4.1 [2] https://xhr.spec.whatwg.org/#the-send()-method 4.4 Bug: 626703 Change-Id: Ie09df6e711b04a30b6181914f3b59bb8cf4e6a49 Reviewed-on: https://chromium-review.googlesource.com/1189602Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#587059}
-
Momoko Sumida authored
CascadeOrder is used only for V0 Shadow DOM cascading order and will be removed once V0 Shadow DOM implementation is gone. In this CL, CascadeOrder is renamed ShadowV0CascadeOrder in order to make its role clearer and avoid potential confusion. Change-Id: I36b32ec6222a4701986434295d161e9facadaa9c Reviewed-on: https://chromium-review.googlesource.com/1195251Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Momoko Sumida <momon@google.com> Cr-Commit-Position: refs/heads/master@{#587058}
-
Uladzimir Miniailau authored
Importing data from IE 7+ is no longer possible after removing PasswordStoreWin in https://crrev.com/c/1131495. Also removing support for importing from IE 6, because it has low benefit relative to its code complexity cost. Design doc: https://crbug.com/456119#c13 Bug: 456119, 257100 Change-Id: Ib662401b794a1f2ef0abe0eaf3cba851b985e8ec Reviewed-on: https://chromium-review.googlesource.com/1174711 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587057}
-
Juan Antonio Navarro Perez authored
Stories are also failing on all remaining Android bots. TBR=nednguyen@google.com NOTRY=true Bug: 877648 Change-Id: I906b895b2a483db372a1d1bc3107cfdc80831900 Reviewed-on: https://chromium-review.googlesource.com/1193889Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#587056}
-
Vaclav Brozek authored
LoginHandler::password_manager_ caches the address of PasswordManager which existed when the LoginHandler was created. This is later used to pass credentials obtained from the user to the PasswordManager instance. This can happen with a significant delay and it is plausible that PasswordManager might have been destroyed in between. Therefore, this CL removes the cached pointer and queries the address of PasswordManager in a way which will return null if it is destroyed, clearly signalling that it is no longer safe to use. Bug: 875481 Change-Id: I2e7df0a2d1e6e8eb4c68901eccc8c447eaf5b93e Reviewed-on: https://chromium-review.googlesource.com/1193844Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587055}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ead0e0e..f1c12b11 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id751a9859323e238d86ea29627e497f8f19c757e Reviewed-on: https://chromium-review.googlesource.com/1195115Reviewed-by:
-
Mohamed Amir Yosef authored
This CL enables the MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BookmarkBar bookmarks integration test to run against USS Bug: 516866 Change-Id: Ia9bf1fa5d26dd9d0e2e2ae10c2375d505c945e83 Reviewed-on: https://chromium-review.googlesource.com/1194009Reviewed-by:
-
Ned Nguyen authored
Interestingly, this property is an actual dict in LUCI, and a string JSON in buildbot. LUCI: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8936878256900261392/+/steps/performance_webview_test_suite_on_Android_device_gobo/0/stdout Buildbot: https://logs.chromium.org/v/?s=chrome%2Fbb%2Ftryserver.chromium.perf%2Fobbs_fyi%2F485%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_tests_without_chrome_on__none__GPU_on_Linux__with_patch_%2F0%2Fstdout (search for "buildbucket" in both log) Bug:878389 Change-Id: I2aafae6cc51120c83d5a522d501dc726889218ec TBR=simonhatch@chromium.org, jbudorick@chromium.org Change-Id: I2aafae6cc51120c83d5a522d501dc726889218ec Reviewed-on: https://chromium-review.googlesource.com/1195156Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#587052}
-
Alexander Hendrich authored
This CL is part of a larger clean-up operation and moves the schema validation from json_schema_validator.h/cc into schema.h/cc. json_schema_constants.h/cc is moved to components/policy/core/common. Also removes src/components/json_schema. Final clean-up of schema/value validation will follow in the next CL. Bug: 873641 Change-Id: I2275e5e91c8e75204528d9a6a7ee5eba447e4bfc Reviewed-on: https://chromium-review.googlesource.com/1181426Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
-
Max Morin authored
I've placed it in media/webrtc as that made the most sense. I considered making it its own taget (i.e. //media/webrtc:audio_processor) but it was a bit cumbersome and other parts of media don't seem to do that. This change includes moving some flags from content:: to media:: since they need to be accessible by both audio processor implementations. The new AudioProcessor code is similar to MediaStreamAudioProcessor, but I've tried to simplify it as much as possible. It seems like the decisions made for the old implementation were made under different circumstances than we have now. The old implementation will run whenever the "APM in Audio Service" feature isn't active. This'll ensure we're not changing any behavior outside of the experiment. The AudioProcessor is protected by a build flag to make sure it isn't built on platforms where we don't have a sandboxed audio service. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iec4cd2dd983b484921d5d0701d4a08bca21793b4 Reviewed-on: https://chromium-review.googlesource.com/1169463 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#587050}
-
Yuta Kitamura authored
These tests seem just slow. Marking them as Slow to give a longer timeout. TBR=nednguyen@chromium.org,foolip@chromium.org Bug: 877104 Change-Id: I970267eead46b3e40c1e8e04a8b95a2df2563336 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1195127Reviewed-by:
-
Yuta Kitamura authored
This test sometimes crashes on all platforms. TBR=nednguyen@chromium.org,tmathmeyer@chromium.org Bug: 878535 Change-Id: I0c8a04432bc04ab2e96179e8f4fd60cf255bcf26 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1195126Reviewed-by:
-
Jan Wilken Doerrie authored
This change implements observing the radio powered state in WinRT. This allows notifying observers about external changes. Bug: 821766 Change-Id: I41edfa74964341d02ab290114d3675c719cf5996 Reviewed-on: https://chromium-review.googlesource.com/1188468 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#587047}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5b92e78e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23579 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic72592d10da7c09b5fdb16c147a2ee469560f07d Reviewed-on: https://chromium-review.googlesource.com/1195154 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Leo Zhang authored
Add feature kImeServiceConnectable and use it to turn on/off the IME Mojo interface registration in Extension process. Bug: 837156 Change-Id: I28c24c2029aeddd275c5d8c7e6c2db9be35378bc Reviewed-on: https://chromium-review.googlesource.com/1195250Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#587045}
-
Yuta Kitamura authored
This test seems slow even on release bots. TBR=nednguyen@chromium.org Bug: 878650 Change-Id: I56377cff5409adfa0dc1b580650ca2f76939fd0c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1195125Reviewed-by:
-
Jun Choi authored
Currently, Cable/Ble transports are removed from available transport list when BluetoothAdapter::SetPowered() invokes failure callback. Change this so that Cable/Ble is only removed from available transport if BluetoothAdapter is not present. Bug: 877344 Change-Id: I4f736154824cceeb6be08d9ca0390f7d9dc20766 Reviewed-on: https://chromium-review.googlesource.com/1192135 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587043}
-
