- 02 Sep, 2020 40 commits
-
-
Matt Menke authored
The newer ones take StringPieces, which is generally safer, and more user friendly for the consumers that already have StringPieces or std::strings. Bug: 1123179 Change-Id: Ida1aec4de6609db104702c3121c7eb03ef6582d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382485Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#803891}
-
Oleh Lamzin authored
Bug: b:158566609 Change-Id: I9f198d00a40738e69b2240e8972aff60cd8b66f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388622 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#803890}
-
Richard Knoll authored
Adds a missing test for when the active profile is stored on disk but not currently loaded. This is only relevant for Chrome browser as this doesn't happen on CrOS. Bug: None Change-Id: I4f691f97ed7de882ec8f7f0886f6ebfff762a899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388624Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803889}
-
ckitagawa authored
To avoid possible IO task runner contention during show-on-startup this CL defers auditing by a couple of minutes. Change-Id: Ie01b66427bf7eca4c8a4570ff5679250b512e822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386416Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803888}
-
Patrick Noland authored
This reverts commit cdb7f942. Reason for revert: Causes tablet instrumentation tests to fail Original change's description: > [ToolbarMVC] Hide MenuButton interactions in toolbar.top behind MenuButtonCoordinator > > Most method calls are translated 1:1 by forwarding the call to the equivalent MenuButton or View method. A notable exception is handling of the tab switcher animation, which currently requires a view in order to perform canvas translation before drawing the button in its animated state. In this case, we provide a direct accessor for the view. > > Bug: 1086676 > Change-Id: I172c7bb5d9eeee307a153ad355a2a93702d139ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356690 > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803701} TBR=mdjones@chromium.org,pnoland@chromium.org Change-Id: I17dfd57363490e97da7f686e88dff1d9556db827 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391003Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#803887}
-
Nnamdi Theodore Johnson-Kanu authored
- Adds new icons - current UI https://imgur.com/nnyirs2 - UI spec https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7dc3c1fe01_5_115 Bug: 1093185 Change-Id: I2b11a74364f06c4b0667e0dc8351577f36f94890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382016Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#803886}
-
Richard Knoll authored
crbug.com/1123934: Handle errors in WebUI crbug.com/1123942: Pass attachments to WebUI crbug.com/1123943: Pass contact name to WebUI Bug: None Change-Id: I5b6c1552f730733408337373f995ad05c10e9dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389204Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4855aad4994b..c9886cc22e82 2020-09-02 adithyas@chromium.org Portals: Fix for duplicate messages after activation 2020-09-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-02 sigurds@chromium.org [ts] Add helpers to assert element type 2020-09-02 jacktfranklin@chromium.org Tidy up runtime CSS component server code 2020-09-02 jacktfranklin@chromium.org Fix 404 layoutPane.css in unit tests 2020-09-02 tvanderlippe@chromium.org Typecheck ui/Fragment.js with TypeScript 2020-09-02 petermarshall@chromium.org [typescript] TypeScript-ify accessibility/AccessibilityNodeView.js 2020-09-02 aerotwist@chromium.org Update Closure Compiler and fix associated errors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1069487 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I149566baa71f3468575be70478447fe8b4d7bd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803884}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7642c19404f..3ffd1d826be3 2020-09-02 dproy@google.com Merge "metrics: Add a way to serialize descriptors in memory" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5ee972d4fe91ea91dec5e00507675060e2ed0e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390424Reviewed-by:
-
Danila Kuzmin authored
Now UpdateScreen observes power changes only when it is shown. Bug: 1124201 Change-Id: Ic67f2e3c4fc6c6fb528235d74faa2f2929c819b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390220 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803882}
-
Maria Kazinova authored
FormInputAccessoryMediator is fetching suggestions from Autofill and PasswordManager when the keyboard state changes, even in cases when the keyboard becomes invisible and the user is not seeing any of the fetched suggestions. If the user wants to see suggestions, he has to open the keyboard, and then suggestions are fetched again. This is leading to a bug in a password generation flow, when the keyboard is hidden prior to a submission of form with generated password, and a request to refetch suggestions breaks the flow. Bug: 1122049 Change-Id: Ia65489304333e3887d35a7976b83874f892fe033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377813Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#803881}
-
Dan H authored
Bug: 1108983 Change-Id: I1db76c911fb0ddef7fe42a8d7ee23714bd42319e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389121Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#803880}
-
Nico Weber authored
It's a remnant of the old Windows-only MSVC-based PGO attempt. Bug: 309849 Change-Id: I353b848b79399bbdc1d3f1d183dc04a610a63e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390940 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#803879}
-
Nicholas Verne authored
Fixed: 1121856 Change-Id: Ief6974393a44b737e1c0a75a2c0fcd6855e60d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389524 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Claude van der Merwe authored
Adds a feature line item with icon in multidevice start setup page indicating that better together can sync wifi network configurations with a connected android phone Screenshot https://screenshot.googleplex.com/98RHfUE9EgjKYy6 Bug: 1117619 Change-Id: I051a8085ea65368aba8fdf5089eb33ada0291262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380326 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#803877}
-
Domenic Denicola authored
Fixed: 1103866 Change-Id: Id72de11128df96f28895460ae468ca7307c84e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367740Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803876}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/000948ecdba8..b7642c19404f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic4d946dffb5a6f75e169181090297511075241e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390520Reviewed-by:
-
Michele Mancina authored
Bug: 1123958 Change-Id: Ie0ba79cc3ace8d7a115dac30888b2430972239d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390205 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#803874}
-
Stephen Nusko authored
This reverts commit 1180542b. Reason for revert: Breaks android perf bots. Original change's description: > Remove BlockThirdPartyCookies preference > > The boolean BlockThirdPartyCookies preference was replaced by > CookieControlsMode enum. Existing settings were migrated since M83. > Since all usage of the preference has been removed, the preference > can be removed and existing settings cleared. > > Bug: 1104836 > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803844} TBR=gab@chromium.org,engedy@chromium.org,dullweber@chromium.org Change-Id: Id0b1094a32d0c4f8f2ab60ad3744c0e71b8dc085 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391120Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803873}
-
OlivierLi authored
This is a reland of 40efa001 Original change's description: > Inhibit hang watching during views::DesktopDragDropClientWin::StartDragAndDrop > > The nested loop process the native events but not the tasks which looks > like a hang if not inhibited. > > Bug: 806174, 1120381 > Change-Id: Ie298b16a4e0f8cdd6c4ba398d71a7fee02b9d46d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369253 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800626} Bug: 806174 Bug: 1120381 Change-Id: I43fbc7d2d1c1ea2200b8df214389cb40dd65c683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386198Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#803872}
-
Oriol Brufau authored
By mistake the specification used to say that, for items spanning multiple tracks, the growth limits of the tracks with an intrinsic max track sizing function should grow to accommodate the minimum contribution of the item. But this was a mistake, because an intrinsic max track sizing function can only be min-content or max-content. So instead of distributing the minimum contribution, it should be the min-content contribution. The spec has been fixed and there is a CSSWG resolution in https://github.com/w3c/csswg-drafts/issues/4790 This patch fixes the problem by reverting r424527. The change is likely web compatible, since it only affects a rare edge case with 'minmax()' where the min sizing function is 'auto' or a fixed value smaller than the min-content contribution, the max sizing function is 'min-content', and an item whose minimum contribution is forced to be different than the min-content contribution, and spans multiple tracks. Bug: 1122084 TEST=external/wpt/css/css-grid/layout-algorithm/grid-intrinsic-track-sizes-001.html TEST=fast/css-grid-layout/grid-intrinsic-maximums.html Change-Id: I1efd6e48b55fc71f37f8303c731bfbf601ca4c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377499Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#803871}
-
Morten Stenshorne authored
Column balancing failed when column-count was auto (and column-width was non-auto). The ResolveUsedColumnCount() function that takes a ComputedStyle parameter forgot to set column_count to 0 if computed column-count was auto. The other ResolveUsedColumnCount() function expects this, or it will pretend that column-count is 1 (since that would be what's passed). ResolveUsedColumnInlineSize() has this right, and we also have unit tests that pass 0 when column-count is supposed to be auto. Fixes 20 tests. Bug: 829028 Change-Id: I47f790ca6aa8566d74b99bdaa16f857d29c2084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388282 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#803870}
-
Rakina Zata Amni authored
Currently we only update the history info on renderer on CommitNavigation calls and some cases where we're deleting navigation entries. When restoring a page from the back-forward cache, we would not call CommitNavigation on it (we call SetPageLifecycleState instead), so the history info might be stale after restoring. This CL adds history offset & length along with the pre-existing param navigation_start as PageRestoreParams to send with the SetPageLifecycleState calls to restore the page, so that the history offset & length can be updated in that case too. Bug: 1122508 Change-Id: Ia480fe199c7836c923fd9d786610a991ce7c8a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379393 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803869}
-
Mikhail Khokhlov authored
The text open mode caused proto trace corruption on Windows. Change-Id: Idafef92472125a83352ffe8c4ee1484f45c1c561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390161 Auto-Submit: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Deep Roy <dproy@chromium.org> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803868}
-
Becca Hughes authored
This will be used to refetch the credentials if they have expired. BUG=1124021 Change-Id: I69abebdb549122c3a928df5eff312bb5ad7f53ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388942Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803867}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5ffc1e1adb9b..e9bc506e0ab0 2020-09-02 cwallez@chromium.org TextureVk: Add a couple TODOs related to barriers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib9559db06282853ef170820bd43e12986001d054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390047Reviewed-by:
-
Carlos Santa authored
This test requires the --use-drm flag otherwise it segfault when calling into the gbm buffer management apis. BUG: None TEST= wayland_color_space --use-drm=i915|amdgpu Signed-off-by:
Carlos Santa <carlos.santa@intel.com> Change-Id: I7ec7032fcc6f93f78bdd3e36b270567cf320f549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384329 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#803865}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/581fdd9f..b9e466df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f6e800dd6f3ab1c6fb045683474e62494304117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390012Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803864}
-
Peng Huang authored
This reverts commit b71115a3. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac%20Pro%20FYI%20Release%20%28AMD%29/9566 Original change's description: > media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation > > Avoid a CPU side copy to account for mismatched strides between the > decoded video frame and GPU texture created for uploading the frame. > GL_UNPACK_ROW_LENGTH allows specifying the stride for glTexSubImage2D, > and is part of the GL_EXT_unpack_subimage extension implemented by the > command buffer on the client side. > > Also includes a pixel test with a VP8 video with a GL incompatible > stride that doesn't match the video's coded size (992 vs 962). > > Bug: 1077211 > Change-Id: I62753234bde3b92e64089c92a59e65ae2bc1c84c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386671 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803696} TBR=dalecurtis@chromium.org,zmo@chromium.org,sunnyps@chromium.org Change-Id: I706630e9ff04f75baf3f45933739cab38bffb173 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390960Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803863}
-
Titouan Rigoudy authored
Extract the checks that need not be run on each iteration of the loop. Given the constant size of kValidationHeaders, this does not meaningfully improve complexity, only readability (hopefully). Change-Id: Ic14796c1a76426f0bbb3f40247744ba5b98318f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386739 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#803862}
-
Sylvain Defresne authored
shutil.rmtree fails if asked to delete a single file, so change build/config/ios/hardlink.py to use os.unlink/shutil.rmtree based on the output type (directory, file, symlink, ...). Bug: none Change-Id: I861c215e91b455e5b24f8159e162f21644a4bd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390183 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#803861}
-
Owen Min authored
Using 'future_on' list instead of 'future' flag for the following policies: SystemProxySettings PinUnlockAutosubmitEnabled EmojiSuggestionEnabled Except SystemProxySettings, all policies will be filter out in Beta and Stable. Bug: 1117637 Change-Id: Idd0365f087ad387d646f23cc65767c5a82516a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379954Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803860}
-
Mark Pearson authored
Bug: 1104993 Change-Id: I4c63e36a41c39f94bb87991aa4144c1aa1035a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358602 Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#803859}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Use cases of these functions in TTS Engine are updated to use the new APIs. This CL does not change any behavior. Bug: 1060940 Change-Id: I8b5c3c4386e8d5c82172a5d34e0c4dc25b40257f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388124Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#803858}
-
David Bienvenu authored
Also fix some cpp lint warnings. Bug: 1010217 Change-Id: I5bb165e80cadfb435b417d80b438ac26a184add6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388905Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803857}
-
Alexander Surkov authored
Bug: 1115489 Change-Id: I6e63b50875abf7ee1296b72818c23d0c20cd2009 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365977 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803856}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598939551-51febd9296737e06a064f51f5c719578c85be72c.profdata to chrome-win64-master-1599025789-3a109ab6fe2db36da4d9ead01eda119b5774b91d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Iaf67bd4fb667af648b20ee9f10a17b28e5fbb75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389783Reviewed-by:
-
Antonio Gomes authored
... and use WTF::HashMap instead. BUG=787252 R=guidou@chromium.org Change-Id: I4950b6fc9b677cdb0c26814373955f4addc68251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364216 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#803854}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc53046b29f8..121d985642fd 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 86334243 to 09df13c2 (356 revisions) 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f1315472247d to b0337a548273 (2 revisions) 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8a0ebd40f86d to c278dada96d9 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8ca08b0592b867a2f05c316a855b28af655d5323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390041Reviewed-by:
-
Raphael Kubo da Costa authored
WakeLockTest.LossOfDocumentActivity has been flaky since r803272 ("[HeapMojo] Make HeapMojoWrapperMode::kWithContextObserver default"), but that CL simply uncovered a bug in MockWakeLock: when the ExecutionContext is destroyed, MockWakeLock::OnConnectionError() may be called before we call MockWakeLock::WaitForCancelation(), in which case the latter will loop forever. Bail out early if |receiver_| is not bound, which indicates that there has been a Mojo connection error and MockWakeLock::CancelWakeLock() has already been called. Bug: 1123879 Change-Id: Ia2f29fe560a3d7ca49b083dfec01fdcd6c48a504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390065 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#803852}
-
