GitLab

If the battery status is unknown, the charging time should be
0 instead of Infinity. The reason being that in that case, the
battery status is reflected as a plugged and fully charged battery.

BUG=122593

Review URL: https://codereview.chromium.org/203693003

git-svn-id: svn://svn.chromium.org/blink/trunk@170338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357520

Review URL: https://codereview.chromium.org/216843002

git-svn-id: svn://svn.chromium.org/blink/trunk@170337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit fada04e1ba92f2e951341da3ef52145dc96297bf.

This change affected the behavior of flash on google maps. I'm reverting this
for now to get rid of this regression. I hope to address this in a future change
by altering this behavior only for non-Flash PPAPI applications.

BUG=324351,356089
TBR=eseidel

Review URL: https://codereview.chromium.org/212893005

git-svn-id: svn://svn.chromium.org/blink/trunk@170336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to set zero page logical height in LayoutState when column
height is unknown (when the columns haven't yet been
balanced). There's code that assumes that non-zero page height means
that page height is known. Lying about this makes the pagination code
believe that every top margin is adjacent to a column break, which
makes it eat and ignore all top margins.

This should be cleaned up, but it's easier to wait until the old
multicol code has been removed.

BUG=353587

Review URL: https://codereview.chromium.org/209863003

git-svn-id: svn://svn.chromium.org/blink/trunk@170335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=loislo@chromium.org

Review URL: https://codereview.chromium.org/216833002

git-svn-id: svn://svn.chromium.org/blink/trunk@170334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Breaks front-end compilation.

TBR=pan.deng

Review URL: https://codereview.chromium.org/216723003

git-svn-id: svn://svn.chromium.org/blink/trunk@170333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When GraphicsContext is given a NULL canvas, it should disable painting.
This patch amends a few operations where this check wasn't done. Most
notably, we no longer record display lists when painting is disabled.

BUG=357572

Review URL: https://codereview.chromium.org/216553003

git-svn-id: svn://svn.chromium.org/blink/trunk@170332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/214443003

git-svn-id: svn://svn.chromium.org/blink/trunk@170330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It will be lazily initialized when user activates find on page functionality.

First part of this patch that adds TextIterator.{h,cpp} files is here:
https://codereview.chromium.org/181003010

BUG=348972

Review URL: https://codereview.chromium.org/181013007

git-svn-id: svn://svn.chromium.org/blink/trunk@170329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a simple follow-up CL for r170298.
We should initialize the vector in the constructor and avoid calling resize().

Review URL: https://codereview.chromium.org/216173006

git-svn-id: svn://svn.chromium.org/blink/trunk@170328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik
BUG=357494

Review URL: https://codereview.chromium.org/216693003

git-svn-id: svn://svn.chromium.org/blink/trunk@170327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements perspective as defined in CSS Transforms[1]. Behavior is
similar to -webkit-perspective, but numbers without units are not
valid. In both variants we accept zero although Gecko and spec
require a positive value.

The animation system is modified to avoid running animations and
transitions on both the prefixed and unprefixed variants at the same
time. Internally, animations are mapped to the unprefixed variant.
As animations operate directly on the RenderStyle storage the result
of specifying an animation/transition on either property is the same.

Transitions now track the specified transition-property such that
the end event may reference it. (eg. transition:
-webkit-perspective; will fire an end  event with
propertyName == '-webkit-perspective'). As transitions operate on
changes to values within a RenderStyle, 'transition: all;' only
ever starts transitions on the unprefixed variants.

Note, this property is guarded by the CSSTransformsUnprefixed runtime
feature (enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Review URL: https://codereview.chromium.org/211233003

git-svn-id: svn://svn.chromium.org/blink/trunk@170326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec now defines a pair of ImageData constructors,

  http://www.whatwg.org/specs/web-apps/current-work/#imagedata

Provide an implementation of both here.

R=
BUG=338804

Review URL: https://codereview.chromium.org/196343032

git-svn-id: svn://svn.chromium.org/blink/trunk@170325 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=277205
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/215193002

git-svn-id: svn://svn.chromium.org/blink/trunk@170324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A bit more simplification, while we're at it.
We don't need a class for the tests: we're just calling a function once.
This removes a lot of OO boilerplace (lots of 'self') and makes the code
very functional
(an object with a main() method is a code smell).
Also simplify path handling (we already know Source/ for Python includes,
so we don't need to ask the source control system for it).

R=haraken
BUG=341748

Review URL: https://codereview.chromium.org/216663004

git-svn-id: svn://svn.chromium.org/blink/trunk@170323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Events need to provide the V8Event binding their interface name (by
overriding Event::interfaceName) and set up wrapper info (by calling
ScriptWrappable::init.) Make InstallPhaseEvent follow the rules.

BUG=356021

Review URL: https://codereview.chromium.org/216603003

git-svn-id: svn://svn.chromium.org/blink/trunk@170322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No new failures since the speculative fix was committed.

BUG=333880

Review URL: https://codereview.chromium.org/212763007

git-svn-id: svn://svn.chromium.org/blink/trunk@170321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements backface-visibility as defined in CSS Transforms[1]. Behavior is
identical to -webkit-backface-visibility.

Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
(enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

NOTRY=true
BUG=154772

Review URL: https://codereview.chromium.org/211213002

git-svn-id: svn://svn.chromium.org/blink/trunk@170320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r170314 broke oilpan's build. This CL fixes it.

TBR=ager

Review URL: https://codereview.chromium.org/216433005

git-svn-id: svn://svn.chromium.org/blink/trunk@170319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "grid-template-areas" property is a computable area, defined in the
CSSComputedStyleDeclaration class with an specific computed value. However,
it's not shown by the Web Inspector in the corresponding Computed tab.

It seems that the root cause of this issue is that the property is not
present in the CSSComputedStyleDeclaration::staticComputableProperties.


BUG=79180

Review URL: https://codereview.chromium.org/200263003

git-svn-id: svn://svn.chromium.org/blink/trunk@170318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman,apavlov

Review URL: https://codereview.chromium.org/214443005

git-svn-id: svn://svn.chromium.org/blink/trunk@170317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/216193003

git-svn-id: svn://svn.chromium.org/blink/trunk@170316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The use of filecmp:
* speeds up r-b-t by 23% (if no diffs): (885 ms vs. 1.150 sec)
* uses only 1 process (if no diffs): 30 => 1
* if diffs, same speed
(can't measure difference, because filecmp is basically instantaneous on my machine)

Also some cleanup:
* remove dead code
* simplify temp file handling (caused build bot failures previously)
* don't catch exceptions, so easier to debug errors in CG
(because it's just one process now)

Currently r-b-t launches a separate diff(1) process for each file it compares.
Python has a built-in diff facility, which is extremely fast and avoids other processes.
This should make a big difference on Windows, meaning faster uploads for
Windows developers and less load on build bots.

Also a lot of the code is no longer necessary, after Terry's simplifications.
We can eliminate all the redundant temp file handling, and just need a simple
temp dir class.

R=haraken
BUG=341748

Review URL: https://codereview.chromium.org/216753002

git-svn-id: svn://svn.chromium.org/blink/trunk@170315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enables Media Query evaluation inside the preload scanner, without joining the main thread.
That is to enable resource fetching based on the media attribute, without hampering future resource fetching improvements.

Major changes:
* Added a MediaValues class that "freezes" the various media values needed for MQE when it is initialized.
* Initialize MediaValues and provide them to the PreloadScanner during its initialization.
* Run MQE inside the PreloadScanner, according to provided MediaValues.
* Removed mediaAttribute passing to the HTMLResourcePreloader, that runs on the main thread.

BUG=

Review URL: https://codereview.chromium.org/201813002

git-svn-id: svn://svn.chromium.org/blink/trunk@170314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a new flag to begin experimentation with the Subresource
Integrity specification[1], and begins adding the minimal amount of
functionality so we can test that the flag is working. That turns out to
be the 'integrity' attribute on various HTML elements that we'll use
later in order to do the actual verification.

Intent to Implement at [2].

[1]: http://w3c.github.io/webappsec/specs/subresourceintegrity/
[2]: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hTDUpMk_TV8/t_rjlkKfgGgJ

BUG=355467

Review URL: https://codereview.chromium.org/208423011

git-svn-id: svn://svn.chromium.org/blink/trunk@170313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r170168 I made pushing the parent scopes lazy for Elements, but I
didn't make it lazy for ShadowRoot. This meant that you could trigger a
style recalc on a single element in a ShadowRoot and then we'd push the
scopes out of order, where we'd push all the ShadowRoots on the way down
and then push all the elements at the end.

I wasn't able to show any rendering errors, but by inspection it's wrong
and it appears it was making us go through the
ScopedStyleTree::resolveStyleCache code path more often than needed.

Review URL: https://codereview.chromium.org/216283003

git-svn-id: svn://svn.chromium.org/blink/trunk@170312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes a problem where Resources can be taken out of the cache but not
deleted (if their handle count is not 0 for example).

BUG=290193

Review URL: https://codereview.chromium.org/179943002

git-svn-id: svn://svn.chromium.org/blink/trunk@170311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be tested by a Chromium browsertest. Service Worker plumbing that would make this possible to test in Blink isn't fitted yet.

BUG=356021

Review URL: https://codereview.chromium.org/214413004

git-svn-id: svn://svn.chromium.org/blink/trunk@170310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Make SourcesView shortcut work when it is shown in drawer and move "save" shortcut into it.

R=pfeldman@chromium.org, apavlov, lushnikov, pfeldman
BUG=322632, 349428

Review URL: https://codereview.chromium.org/212623013

git-svn-id: svn://svn.chromium.org/blink/trunk@170309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimelineFlameChart: fix for exception in highlightTimeRange which happens when entryIndex is incorrect.

It happens when newly recorded timeline has fewer elements than the old timeline.
So we need to reset FlameChart when we start the new recording session.

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/216713002

git-svn-id: svn://svn.chromium.org/blink/trunk@170308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352557
NOTRY=true

Review URL: https://codereview.chromium.org/216693002

git-svn-id: svn://svn.chromium.org/blink/trunk@170307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Continuing the work to make StyleAdjuster cheaper we can skip all the work
related to overflow adjustment in the common case when overflow is visible.

Review URL: https://codereview.chromium.org/214413011

git-svn-id: svn://svn.chromium.org/blink/trunk@170306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements transform-style as defined in CSS Transforms[1]. Behavior is
identical to -webkit-transform-style.

Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
(enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Review URL: https://codereview.chromium.org/211123002

git-svn-id: svn://svn.chromium.org/blink/trunk@170305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These functions are always called with string literals, so having the
functions accept Strings means all callers have to perform implicit
conversions.
By modifying the signatures to use 'const char*' for these cases, these
conversion can be avoided (in the callers) and only be performed in the
functions themselves.
This reduces code size by ~70kB (Linux, x86-64, gcc-4.8.2).

Review URL: https://codereview.chromium.org/216633002

git-svn-id: svn://svn.chromium.org/blink/trunk@170304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The removal has caused more trouble than expected on Android, because
usage is higher there and the UseCounter data from Windows was used in
the "Intent to Remove" thread.

Restore the API behind a flag so that it can more easily be turned on
and off. It's off by default, but likely it will have to be enabled on
at least the upcoming M35 branch.

BUG=346236

Review URL: https://codereview.chromium.org/213193010

git-svn-id: svn://svn.chromium.org/blink/trunk@170303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Logic to split keyframe animations into multiple players was required before
Web Animations supported per-keyframe easings.

CSS Animations were updated to use per-keyframe easings in r169119[1], but this
logic remained.

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=169119

BUG=346590

Review URL: https://codereview.chromium.org/214603002

git-svn-id: svn://svn.chromium.org/blink/trunk@170302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Inside method updateImplicitGridColumn() of test
fast/css-grid-layout/implicit-position-dynamic-change.html we define a
variable gridItem that is not used. This patch removes it.

Review URL: https://codereview.chromium.org/213423009

git-svn-id: svn://svn.chromium.org/blink/trunk@170301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Enable V8 Promises.
This CL sets --harmony-promises flag.
When V8 Promises are shipped, I will remove it.

BUG=352597, 352552

Review URL: https://codereview.chromium.org/209853010

git-svn-id: svn://svn.chromium.org/blink/trunk@170300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the code branch handling "numCharacters == 1"
case leaving only the 'memcpy' call inside the 'WTF::copyChars'
function's body.

The reason for it is that the branch made the code more complex
giving the minor performance benefit: there was no benefit if the
'source' arg was static, otherwise the difference was just two
extra asm calls ('testq' and 'je') which should not give impact
to the real use cases performance (tested with GCC 4.6.3).

Review URL: https://codereview.chromium.org/213073002

git-svn-id: svn://svn.chromium.org/blink/trunk@170299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL changes OwnPtr<OwnPtr<InterporableValue>[]> in InterpolableValueList to Vector<OwnPtr<InterporableValue>>. As far as I see the code, I don't think this change will affect performance.

BUG=340522

Review URL: https://codereview.chromium.org/212213007

git-svn-id: svn://svn.chromium.org/blink/trunk@170298 bbb929c8-8fbe-4397-9dbb-9b2b20218538