GitLab

This reverts commit 6eb61402.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 662924 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZlYjYxNDAyYzFiMWI0MzAxNzYyYzZhYWFlYTI4YjI5MjFjYmY0YzIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-archive-rel/136

Sample Failed Step: compile

Original change's description:
> Removes ui/platform_window/mojo as it is not used by anyone.
> 
> This is to remove the ref to some types under ui/base/ime/mojo, which will be removed later.
> 
> Bug: 965908
> Change-Id: I7979524066104c829b4f4e287a0ab87c9365f124
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626055
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Shu Chen <shuchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662924}


Change-Id: I529c9c9f28c32d2799af6a9c7d8a95d6606755ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628221
Cr-Commit-Position: refs/heads/master@{#662945}

It doesn't seem to have point.

Bug: None
Change-Id: I5e8131578c1191be9f0c27a5196425669470319c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626920
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662944}

MainMenu.xib primarily consisted of unusable menu items. This CL pulls out the
essentials, and drops support for the rest.

This CL intentionally keeps the logic simple with no additional abstraction
layers. While it would be reasonably simple to reuse chrome's
main_menu_builder.h or to pull out common functionality into builder functions,
the actual lines of code saved would be small and I'd like to avoid unnecessary
abstractions.

Change-Id: I3de68bd6fe3e064b7f83b038688cfbaf0bc4e9e1
Bug: 965663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627242Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662943}

Bug: 966636
Change-Id: I74b428b24b3ea76d3ed9150c25b34d458652e5c4
Tbr: crouleau@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628236Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662942}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d390b317dcf7..a541b28d4eba


git log d390b317dcf7..a541b28d4eba --date=short --no-merges --format='%ad %ae %s'
2019-05-24 bpastene@chromium.org Add 'X in tuple()' support to gclient conditionals.


Created with:
  gclient setdep -r src/third_party/depot_tools@a541b28d4eba

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:947531
TBR=agable@chromium.org

Change-Id: I5ce9b6d87cd29ce18967bfe3e376ce78cb7fb8ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627583Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662941}

https://swiftshader.googlesource.com/SwiftShader.git/+log/48c8a180b599..8a2441d37d80


git log 48c8a180b599..8a2441d37d80 --date=short --no-merges --format='%ad %ae %s'
2019-05-24 bclayton@google.com vkCmdUpdateBuffer: Make a copy of the data.
2019-05-24 chrisforbes@google.com Fix OpAtomicUMin, OpAtomicUMax
2019-05-24 chrisforbes@google.com Substitute integer 1 for missing 4th component of integer vertex attribute
2019-05-23 bclayton@google.com VkPipeline: Fix unsigned integer underflows in computePrimitiveCount()
2019-05-23 bclayton@google.com VulkanUnitTests: Free / Destroy all Vulkan objects.
2019-05-23 bclayton@google.com ComputeProgram: Don't hold on to the SpirvRoutine.


Created with:
  gclient setdep -r src/third_party/swiftshader@8a2441d37d80

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/133127573,chromium:b/118619338,chromium:b/118383648,chromium:b/133399620,chromium:b/133127573
TBR=swiftshader-team+autoroll@google.com

Change-Id: I7b102c0712a090cc6961d18f653e40f0d9b5c894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662940}

These were all variations of the same issue, so just fix them rather
than do the suppression + fix dance. EmbeddedTestServer callbacks run on
a background thread, so shared state needs to be synchronized.

Bug: 966370
Change-Id: I84dcd747ffaf5d66c09a1b7e10d6bca5ac148231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626180
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662939}

Tested in Nexus 5X and iPhone X.

Bug: 925072
Change-Id: I8172fd7ac30f9e1a9466b41f196fd2a92f449546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584933
Commit-Queue: Ce Chen <cch@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662938}

This CL splits the interface to two parts so that WebRequestProxyingWebSocket or
extensions proxy only handshake of WebSocket:

interface WebSocketHandshakeClient {
  OnStartOpeningHandshake(WebSocketHandshakeRequest request);
  OnFinishOpeningHandshake(WebSocketHandshakeResponse response);
  OnAddChannelResponse(string selected_protocol, string extensions);
};

interface WebSocketClient {
  OnDataFrame(bool fin, WebSocketMessageType type, array<uint8> data);
  OnFlowControl(int64 quota);
  OnDropChannel(bool was_clean, uint16 code, string reason);
  OnClosingHandshake();
  OnFailChannel(string reason);
};

Performance gain of receive-arraybuffer-1MBx100.html:
Mine: 1050 ms
ToT : 1221 ms

Bug: 865001, 942989
Change-Id: Ia364afd96005a77b1dadf2c95896be5a12827f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599819Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662937}

Bug: 965395
Change-Id: Ia183ca2e01733612f1228f1905450bfb980ffd6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627380Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662936}

2 small fixes for OriginTrialContext:
* only exit early from InitializePendingFeatures if there are
  no enabled features, and no navigation features
* ensure OriginTrialContext::IsFeatureEnabled (which is invoked
  via RuntimeEnabledFeatures, for OT features) returns true if
  a feature was activated via navigation.

These were discovered while writing tests as part of
https://chromium-review.googlesource.com/c/chromium/src/+/1601980.


Change-Id: Ia8e711ab61dc4bf14a6e3c12a52faf5e1f096bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618175Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662935}

Fixes nits from thestig@ and compilation failure on Windows. PS#1 is the
original change, later PSs are with the fixes.

------------------------------
These raw files were large and are slowing down the fuzzer process;
this saves 13,416,948 bytes. I've confirmed via MD5 hashes that
the decode path and the yuv path generate the same output data.

BUG=960139
TEST=verify MD5 hashes between compressed and uncompressed variables.
TBR=hiroh,inferno

Change-Id: I32ca1c3162c7bbffcc334b98491bad60ed0b25fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606595Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662934}

Bug: none
Change-Id: Iff7d64dd0ede989f260622c9249983530f55deb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622483Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662933}

It stopped being used in
https://chromium-review.googlesource.com/c/chromium/src/+/1570826 but
the declaration in the header file was never removed.

Bug: 953649
Change-Id: I84d709a33ee7f2eb437ee8235958e8f3962e9c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627244
Auto-Submit: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662932}

This will help us better understand the perf difference between users
who encounter pages with OOPIFs and users who don't.

Bug: 946575
Change-Id: I021d1759f0c3c5b0863b9230d5f8d8aacad47e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625842
Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662931}

This reverts commit b664d732.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 662925 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I2NjRkNzMyNjQ1Mjc4NmIzMTY4ZjM0ZDIxY2UyNGNiZDMwNjVkYzYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-rel/623

Sample Failed Step: compile

Original change's description:
> Remove ime.mojom and the code on the client side for Mojo-based IMF.
> 
> Bug: 965908
> Change-Id: I83aec36d10247ef7dd08ef58a04f0f2362a8d495
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626053
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Shu Chen <shuchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662925}


Change-Id: I3805d9ef6da85e60c980f78bf36b3a9a2353548a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628312
Cr-Commit-Position: refs/heads/master@{#662930}

This reverts commit 8afc180c.

Reason for revert: broke build on GPU FYI Win x64 debug builder:
https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20Builder%20(dbg)/13152?blamelist=1#blamelist-tab

Original change's description:
> Add scaffolding for structured GPU command buffer fuzzer
> 
> This CL contains a basic fuzzer for WebGL shaders that shows some
> essential design ideas:
> 
> 1) a protobuf spec defines how shaders will be generated
> 2) conversion from protobuf message to shader string is
>    provided in its own library that has unit tests
> 3) we add a basic fuzzer to compile shader programs using libANGLE
> 
> This is by no means complete and serves as a foundation for the fuzzer
> so subsequent CLs will be easier to review. Later CLs will slowly complete
> the core grammar for GLSL before incorporating some more complex testcases
> from the Khronos compliance suite.
> 
> BUG=900487
> 
> Change-Id: I67df52a73926d22637afad9a966790f34011175c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623556
> Commit-Queue: Ned Williamson <nedwill@google.com>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662832}

TBR=pkasting@chromium.org,kbr@chromium.org,piman@chromium.org,xyzzyz@chromium.org,nedwill@google.com

Change-Id: I91debbc67cebc46ecdcaa06b6b1cf587fae781f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627825Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662929}

https://dawn.googlesource.com/dawn.git/+log/eea209106803..c391fb7c69fd


git log eea209106803..c391fb7c69fd --date=short --no-merges --format='%ad %ae %s'
2019-05-23 enga@chromium.org Use single 64bit atomic refcount for Dawn objects
2019-05-23 shaobo.yan@intel.com Dynamic Buffer Offset : Metal Backend


Created with:
  gclient setdep -r src/third_party/dawn@c391fb7c69fd

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Change-Id: I7660c20ff4e49fafc57b1a8cb9e0e285018fd2bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662928}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/4744a43b6fc4..0ddc03340688


git log 4744a43b6fc4..0ddc03340688 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 thomasanderson@chromium.org Remove non-source sources from binary targets


Created with:
  gclient setdep -r src/native_client@0ddc03340688

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:964411
TBR=mseaborn@chromium.org

Change-Id: I09c8d1655b6156e84b2697048b6b534a4df83b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662927}

During ForceClose, a closing connection could cause the active request
to 'complete', triggering the rest of the requests to execute. Since
the connections are cleared after-the-fact in ForceClose(), this caused
a UAF.

Instead having specialized weakptr factories here, this change creates
a |force_closing_| variable which is set in ForceClose(), which is used
to ensure reentry doesn't occur.

R: pwnall@chromium.org
Bug: 966557
Change-Id: Iaaf678853431c35299dc9289b505fdf66c19a88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627707
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662926}

Bug: 965908
Change-Id: I83aec36d10247ef7dd08ef58a04f0f2362a8d495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626053Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662925}

This is to remove the ref to some types under ui/base/ime/mojo, which will be removed later.

Bug: 965908
Change-Id: I7979524066104c829b4f4e287a0ab87c9365f124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626055Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662924}

Before this CL, all inflight tasks can be retained in
Worklet::pending_tasks_set_ even after context destruction, and that causes
dcheck failures in the destructor of Worklet. This CL fixes it by aborting them
in Worklet::ContextDestroyed().

In addition, this CL adds test coverage of addModule() calls on a detached
iframe. In the tests, LayoutWorklet is used for testing main thread worklets
instead of PaintWorklet because PaintWorklet will be switched to
off-the-main-thread worklets (see https://crbug.com/829967).

Bug: 962355
Change-Id: I7da71e7f4bdcbfa20125853832122a733c118a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626062Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662923}

Remove the line break from this string, and create a duplicate string
IDS_PRINT_PREVIEW_INVALID_PRINTER_SETTINGS that contains the line break
for Print Preview. The alert dialog that can also display this string
does not correctly render the HTML <br> tag.

Bug: 954772
Change-Id: If3d1cba8546d2bcaf02c5cc7ecb1e992d1f53fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627925Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662922}

TBR=meacer@chromium.org

Change-Id: I4243ef07501e63803d8411a0e3a4e9d2a3494868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628230
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662921}

UI improvements for focus mode window:
Adjust title bar height to match the toolbar height in a regular chrome
window. Increase the inkdrop area for the hosted app menu button. All
changes only apply to Focus Mode window (but not PWA) for testing
purpose.

Bug: 963650
Change-Id: Ica03e44f92ec52900f11435d17d946ccae3dba2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620780
Commit-Queue: Yining Wang <yiningwang@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662920}

Bug: 881215
Change-Id: Idce875648aa8736e8c025f266f6c8d06f32be345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623646
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662919}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/94515755316b..d390b317dcf7


git log 94515755316b..d390b317dcf7 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@d390b317dcf7

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: If47b8899a6d5aa89710e44b20563876b42327b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662918}

Prevent tests from getting into a failed state on various OSes, by
running the tests on the bots instead of only as a presubmit.

Tests take a few seconds locally on Linux and Windows.

Bug: 961359
Change-Id: I71fabf230d611de5cd06380832085558521de83d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614698Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662917}

The crashing is caused by trying to get or set the anchor view which is gone. To fix this we get the bubble's bounds when the anchor view is set.

Bug: 965642
Change-Id: I0b2a788d09f04e09f51c5db1d723484b88f0bcd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625487
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662916}

Bug: 965609
Change-Id: I148d5fe8b7371a529b612ed2e9b407ced0062f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623139
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662915}

This roll brings in the enum value for a new Smart Dim model.

Mojoms rolled with:
cp ~/chromiumos/src/platform2/ml/mojom/*.mojom \
  chromeos/services/machine_learning/public/mojom/
sed --in-place --regexp-extended \
  's~^import "ml~import "chromeos/services/machine_learning/public~g' \
  chromeos/services/machine_learning/public/mojom/*.mojom

Then updated .cc references to renamed Mojom names.

Bug: 937063
Change-Id: Ifff0796739ef7fe55878c8f25a27d6ce39f4f897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626835Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662914}

https://swiftshader.googlesource.com/SwiftShader.git/+log/e2cb4e0573e3..48c8a180b599


git log e2cb4e0573e3..48c8a180b599 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 bclayton@google.com CMakeLists: Pass sanitizer flags to the linker too.
2019-05-23 bclayton@google.com Reimplement vk::Query using sw sync primitives.


Created with:
  gclient setdep -r src/third_party/swiftshader@48c8a180b599

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/133127573,chromium:b/133127573
TBR=swiftshader-team+autoroll@google.com

Change-Id: Idc02c0d54a445b5fb231e8250c66f3adf4ccec2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627865Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662913}

This is a simple reordering of the omnibox icons to better match UX mocks.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394824&signed_aid=nOrbTUMOlIuDq7tSR80dhA==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394825&signed_aid=QDyPSKCoGB59hyh48HHkcQ==&inline=1

Bug: 966304
Change-Id: I612f63f0c39ef923dc6f327f4921ca57e8b9d4a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626202Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662912}

Bug: 778674
Change-Id: I3a5f6665970cf92cd881926271a00e4bf4a537ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627731Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662911}

Some gpu bugs are related to the monitor refresh rate. Adding this display
information will help us on gpu debugging.

This CL is for Windows only.

Bug: 964095
Change-Id: Ic00471897f0f7c655dbe29e3b33b5b7782cab6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621328Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662910}

This patch fixes the placement and color of image buttons in
search_box_view. Previously, the right padding was not calculated and
close button was using search box color.

Bug: 941524
Test: manual
Change-Id: I201b21257a11e188490136b05ac68dc5e15cebcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626735Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662909}

Adapter now keeps track of number of model iterations and only starts changing
brightness based on min_model_iteration_count.

Bug: 881215
Change-Id: Ie9dcf15090f2e808630ad82a2bd2cfebad7cf00a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621477
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662908}

This CL:
(1) Adds a base OtaActivator class along with an OtaActivatorImpl
    implementation and a FakeOtaActivator for tests.
(2) Adds a test for OtaActivatorImpl.
(3) Updates some definitions from cellular_setup.mojom; specifically,
    this CL changes the ActivationResult enum.
(4) Updates cellular_setup_service_unittest.cc to reflect the changes in
    part 3 above.

Bug: 961084
Change-Id: I2d4bd9cd454014106f120144e28238f07b32a318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604213Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662907}

I checked if you run like this:
./run_benchmark ... --pageset-repeat=3 --pageset-repeat=1
then the second argument overrides the first.

Bug: 894254
Change-Id: Ib7138966dfa5336697a7a5c02084557f315aac4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628161Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662906}