- 15 Oct, 2019 40 commits
-
-
Koji Ishii authored
This patch fixes a case where |NGLineBreaker| loops infinitely when there is a negative margin. The case was a regression by r701601 (crrev.com/c/1826063). Handling combinations of a) trailable items, b) empty spans, and c) negative margins together is becoming more complex as we fix issues. This patch revises how we handle them. One of the complexities is open tags being ambiguous; e.g., this open tag is not trailable and thus breaks before it: <span>text but these open tags are trailable: <span> text <span></span>text <span> </span>text and it can even nest more, contain floating/out-of-flow objects, or have negative margins. Before this patch, |NGLineBreaker| tries to stop as early as possible, rewind, and consume trailable items. The last part (consuming trailable items) is scarly because rewind loops can occur if we try to rewind again. The new approach is to try to consume possibly trailable items before it rewinds, and avoids consuming after rewind. There might be cases where the new approach consumes more, but `blink_perf.layout` is neutral: https://pinpoint-dot-chromeperf.appspot.com/job/11fdf216c20000 In the test, case 2 and 5 fail in legacy, because the legacy behavior is based on a bug (crbug.com/979894) or the new behavior makes more sense, and the new behavior is interoperable with Edge/Gecko. Note, this change should be able to eliminate |kTrailable| state, and that eliminate consuming after rewind completely, but we still need it in a few places. It is for future patches to clean them up. Bug: 10118167 Change-Id: Ic915a26f1ee570ebe999ffbeee680659dcbd9789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849737 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705844}
-
Julie Jeongeun Kim authored
This CL converts JpegEncodeAccelerator to new Mojo types using PendingReceiver. Bug: 955171 Test: Pass libjea_test Change-Id: Ib4ebdbe3a2f8d41808aad1179233a61b578fb2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849691Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#705843}
-
Noel Gordon authored
location.rootType is evaluated every time it is referenced. Store root type in a local variable for speed. Update routine comments. No change in behavior, no new tests. Bug: 992819 Change-Id: I3bedd5bbe8bdd0098ded33b081ae65e26c0525b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859794Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705842}
-
Nicholas Verne authored
A call to UpgradeContainer can start off a long-running upgrade process via the Cicerone daemon. A dbus signal UpgradeContainerProgressSignal is used to communicate progress to Chrome, including the final success or failure of the upgrade itself. Bug: 930901 Change-Id: Ibdbd1a9be4ac852c93dd98257b387417c85b5dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850688Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#705841}
-
Yutaka Hirano authored
...instead of IsSameSchemeHostPort. This is observable when fetch() is called on an extension that has a permission to the destination URL. Bug: 1010030 Change-Id: I2f5a3bdc0e73493df9737b260e4557c72db9fbde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846428 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#705840}
-
Fumitoshi Ukai authored
Bug: 1008249 Change-Id: I97a14141af0268682a466134a423d51be2aabdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846425 Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#705839}
-
Andres Calderon Jaramillo authored
Some unit tests were failing on grunt because https://crrev.com/c/1803802 broke the initialization of JPEG decode acceleration for the camera capture path. This CL fixes that to disable JPEG decode acceleration only for the still image decode acceleration path. Note that this CL also refactors the way we determine the VA-API implementation: instead of directly exposing the vendor string through VaapiWrapper, we compute the implementation type in VASupportedProfiles while we know that the VADisplay is initialized. Bug: 974438,b:141152942 Test: jda tests pass on grunt. Change-Id: I5c53423d0d82774ec9a3ab9b2a1c00662228a669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827956 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#705838}
-
Julie Jeongeun Kim authored
This CL converts NetworkServiceTest from network_service_test.mojom to new Mojo types using Remote. It updates NetworkServiceTestHelper with new Mojo types. Bug: 955171 Change-Id: Ifa4b40a69740ab90aef7a2abe03bafd72e605c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847691Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#705837}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1007760 Change-Id: Ib302b0078a29a271d7093b42b948f878753ece28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849481Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705836}
-
Shao-Chuan Lee authored
Change-Id: I55257b4ad0c965b0bf3313e6f0ae733b736c9799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859808 Auto-Submit: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705835}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd101fc3. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3283ed9a9593c61d397ec5bdbc12fffea7a556cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860782Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705834}
-
Roman Sorokin authored
TBR=antrim@chromium.org Bug: 1000606 Change-Id: I456f4cf60ae6a3ce2c6c9c6462d5555b27c6bfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859958Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705833}
-
Lei Zhang authored
MediaQueriesReducedMotionOverride, MediaQueriesColorSchemeOverride, and MediaQueriesChangeNavigationControls sometimes fail. TBR=futhark@chromium.org Bug: 1014380 Change-Id: Iba85874c2f149c3c3d277f41f394eef7be00b8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861515Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705832}
-
Roman Sorokin authored
Used by assisstan and multidevice dialogs Bug: 1000606 Change-Id: I77d3d920693f4a9bce605b955017931434ce713b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857322Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705831}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b3653782e33..8ea4f73b725e git log 0b3653782e33..8ea4f73b725e --date=short --no-merges --format='%ad %ae %s' 2019-10-15 dberris@chromium.org Stop using means of results from attempts Created with: gclient setdep -r src/third_party/catapult@8ea4f73b725e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1011273 Change-Id: Id0de02b489e914f7ed81cbdf68d8a570b26f87aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705830}
-
Hiroki Nakagawa authored
This is a follow-up for https://crrev.com/c/1859805 This test is flaky on multiple bots. See the issue for details. Bug: 1014325 Change-Id: I54d1444ff09919c0ed34fb4f3c28ef92adc733d9 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861438 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#705829}
-
Hiroki Nakagawa authored
This is flaky (CRASH, PASS) on Win bots. See the issue for details. Bug: 1014325 Change-Id: I1da135cbe637eec059f2300df1a584fe90dc04f7 Tbr: mkwst@chromium.org, falken@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859805Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#705828}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/acf66fdd4e87..2d0e5b554d4f git log acf66fdd4e87..2d0e5b554d4f --date=short --no-merges --format='%ad %ae %s' 2019-10-15 mihu@microsoft.com GL_EXT_multisampled_render_to_texture extension. Part 2. Created with: gclient setdep -r src/third_party/angle@2d0e5b554d4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I93705dbe2ad5e6d552bfcac0a0a680798750837f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860288Reviewed-by:
-
Alex Keng authored
This change implements the flat end for the value bar based on the latest design. Instead of using drawRoundRect to draw rounded value bar, this change uses drawRect to draw the flat end and uses clipRRect to have rounded corners at both ends of the track. This change also addresses the issue where the value bar is not rendered correctly when the value is very small (see the associated bug for details) Bug: 997873 Change-Id: I2f6e9704e6092ea274c9cb9dbe7b2d7b8a7b8c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858437Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705826}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/88b8e3962362..9d77d68d79fa git log 88b8e3962362..9d77d68d79fa --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org cros_build_lib: rewrite GetRandomString 2019-10-15 vapier@chromium.org parser: elog: fix sorting bug 2019-10-15 vapier@chromium.org cts_helper_unittest: fix invalid osutils import Created with: gclient setdep -r src/third_party/chromite@9d77d68d79fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7a054de0a22d269a8245db63596d5a66b1956f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860287Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ba9e1ff86fa4..d59fec5d706e git log ba9e1ff86fa4..d59fec5d706e --date=short --no-merges --format='%ad %ae %s' 2019-10-15 hao.x.li@intel.com Skip LargeBufferFails test with NVIDIA for enabling Vulkan validation layers on Windows 2019-10-15 jiawei.shao@intel.com ASSERT object is not nullptr in DeviceBase::ValidateObject Created with: gclient setdep -r src/third_party/dawn@d59fec5d706e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I41a064df0061742f4bdd85d8674436fc4c03b709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860286Reviewed-by:
-
Ian Kilpatrick authored
Change-Id: I7abb36ffc616e6d92bdf10649b6860b1941d35dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859648 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705823}
-
Fabrice de Gans-Riberi authored
This was causing the code to not be executed in non-dcheck builds. Change-Id: Ib1257333ae0683c7b068e9837f7d1a5b36848628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861104 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705822}
-
Hiroki Nakagawa authored
This test is flaky on multiple platforms. See the following link for details. https://bugs.chromium.org/p/chromium/issues/detail?id=923627#c10 Bug: 923627 Change-Id: I89f94f1cdbca08251bcbf03a55679124beb6bca7 Tbr: mcnee@chromium.org, tdresser@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861434 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch removes |out_floats_for_min_max| from |NGLineBreaker|. The caller instead computes the list of unpositioned floats from |NGLineInfo::Results()|. This change is needed for fixes for crbug.com/10118167 and crbug.com/1001000, but does not fix them. Fixes some cases of |ComputeContentSize()| DCHECK failures in crbug.com/976304, but maybe not all. |out_floats_for_min_max| was originally added in r619070 (crrev.com/c/1365984) to keep track of unpositioned floats. But today, |NGLineInfo::Results()| has all unpositioned floats. Furthermore, changing rewind logic for crbug.com/10118167 caused several tests to fail because we don't adjust |out_floats_for_min_max| when we rewind. This patch avoids mismatch of the two lists by unifying them. blink_perf.layout looks neutral: https://pinpoint-dot-chromeperf.appspot.com/job/108a2986c20000 Current assumption is that looping items isn't too expensive, but we could add a flag to |NGLineInfo| if this loop turned out to be more expensive in some cases. Bug: 976304, 10118167, 1001000 Change-Id: I4a5cb98f5dc6d331a699991390d7bd97ce51cd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857844 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f056de19cad1..d0b7b0ccae01 Created with: gclient setdep -r src-internal@d0b7b0ccae01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I51cb9eae8053ab2e1e363dd4ac04e7c4559b548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860285Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705819}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I9d5ed8edec28f5d0da934d625d2a5b2aa086836b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859908Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705818}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40e1e14c..517b740d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I64b40b7b168e9f8068b84c6d0fbf199748c8c190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705817}
-
Gary Kacmarcik authored
We need to update the permissions check dialog to handle the new Screen Recording permission added in Mac OX 10.15. Bug: 1012826 Change-Id: I3d062a76b44267746091a9b21163edefb4d312de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860278Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#705816}
-
chrome://test/dpapad authored
Also bring back |extraLibraries| override in welcome_browsertest.js (along with a new explanatory comment), which was removed in a previous CL. Bug: None Change-Id: Ib3ed274af8519bbc541eeb435c6cc37abfa3611f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860149 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705815}
-
Yue Zhang authored
This CL adds a check in TabGridDialogMediator to skip saving title when group no longer exists, i.e. the group becomes a single tab or the last tab in group is closed. Also, some unit tests are added for this check. Bug: 1013973 Change-Id: Id6cab4bec07ffbdbbe2daf12fe792d281fcb84af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860394 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705814}
-
Dan Beam authored
Conjoins omnibox's transparency UI and the NTP realbox's removal UI on omnibox::kOmniboxSuggestionTransparencyOptions. Note: this leaves the keyboard shortcut (Shift+Delete) intentionally enabled, as this is what Omnibox does. R=mahmadi@chromium.org Bug: 1002689 Change-Id: Iffdbd7a94567fce3352c0b7611229f9ddb4846b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861275Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705813}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2527379a1c2..88b8e3962362 git log e2527379a1c2..88b8e3962362 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 mmortensen@google.com Update unit test so that it works inside and outside the SDK. 2019-10-15 saklein@chromium.org binhost controller: Cleanup parallel postsubmit binhost. 2019-10-15 cjmcdonald@chromium.org Remove bug link for new parallel_emerge Created with: gclient setdep -r src/third_party/chromite@88b8e3962362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I29f4ffc8ba099840b459a2cb0a20d51191cc778a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860283Reviewed-by:
-
Meredith Lane authored
Enabled by default in stable for awhile now, so safe to remove. BUG=860016 Change-Id: I2deea943849ce11a3db2a98e85df6c6aee5d38cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850689Reviewed-by:
-
Dan Beam authored
Pressing unmodified Delete is currently throwing. R=mahmadi@chromium.org Fixed: 1013833 Change-Id: Ia895d0977595562e8ea636a063a88bd663a0ebad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861113 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts XRRuntimePtr and mojo::Binding<XRRuntime> in chrome and device to the new Mojo type, and use pending_remote<XRRuntime> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I663f37d58678d7175a9ce15a4d5244c7a142ceda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847707Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#705809}
-
Miyoung Shin authored
This CL converts TCPServerSocket{Ptr, Request} in chrome, components, content, extensions and services to the new Mojo type, and uses pending_receiver<T> in network_context.mojom and tcp_socket.mojom and pending_remote<T> in viz_main.mojom. Bug: 955171 Change-Id: I5c2fb8e46d35d57a3358c92d132053f71377161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851884 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Asanka Herath authored
Currently the HttpAuthHandlerNegotiate::Factory() is responsible for determining the maximum token size on Windows. This is done prior to constructing the HttpNegotiateAuthSystem. Conceptually the maximum token length is a property of the Negotiate auth "system" (really should be called "mechanism"). Someone constructing this should not have to know the token size. That's the kind of thing that this abstraction layer is supposed to enapsulate. Moreover, the "NegotiateLibrary" (i.e. the platform interface) currently needs to be understood at both above and below the HttpNegotiateAuthSystem abstraction layer. In addition, to being an abstraction violation, having the library be known above the HttpNegotiateAuthSystem layer means that the functionality of the library needs to be accessible outside the HttpNegotiateAuthSystem. In order for us to cleanly cleave out privileged token operations out of the network process, we need to make sure such functionality is neatly tucked away on one side of a single abstraction. This is issue 991265. Furthermore, having library access scattered outside HttpNegotiateAuthSystem makes it difficult to move time consuming SSPI operations into a separate thread. This is issue 711186. To address these issues this CL moves the token size determination into HttpNegotiateAuthSystem. Things still aren't quite there yet, but it's a step in the right direction. This change results in a behavior change. Currently the availability of the Negotiate authentication mechanism is determined when constructing the first HttpAuthHandlerNegotiate. With this change, the decision moves to GenerateAuthToken(). Fortunately for us Chromium is not supported on any Windows platform which doesn't have the Negotiate authentication package. Hence there should not be any observable behavior change. Bug: 991265, 711186 Change-Id: I9a30db15c6332a1304bc29112a0c26105a35282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814621Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705807}
-
Maggie Cai authored
This CL adds PWA implementation for |LaunchAppWithIntent|. BUG=853604 Change-Id: I6257f8d473d1368f0e769b1cca332cc72808bf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851628 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705806}
-
Maggie Cai authored
Add Intent URL launch source for web apps. BUG=853604 Change-Id: I226c941c9ea2a96be6fed9d4b0598862a750e15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855541Reviewed-by:
-
