GitLab

Issue: Predictive completions in some IMEs are not working properly
when typing in a webpage.

Cause: Appkit <-(sync)-> RWHVCocoa <-(async)-> Blink

In an IME composition commit, RWHV commits the text to Blink
through an async mojo call. Later when Blink finishes commit, it updates
the text in RWHV through a separate mojo call.

For predictive completions to work, IMEs calls RWHV's
|attributedSubstringForProposedRange:| to retrieve some text
as the context for prediction. Oftentimes the call happens before
Blink's async update to RWHV, resulting in a wrong predictive context.

This issue troubles both Chromium and Firefox but not Safari/Webkit.
Webkit is using an undocumented async IME API.

Also after macOS 10.12+, IMEs expect |selectedRange:| to return a empty
range positioned at the end of the committed text. If not respected the
predictive completions won't work.

Solution:
- Temporarily insert the committed text to RWHV's available text
- Follow the |selectedRange:| requirement

Bug: 710101
Change-Id: I3e4267362ea3e0a6b9f7cebce23fe59d1a6ece6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606140Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845832}

Previous CL split PasswordProtectionRequest into base and derived classes.
A weakptr_factory was added to the derived class, but this is not
necessary. We can use base::AsWeakPtr(&derived) to get a weak ptr to
the derived instance.

Bug: 1147967
Change-Id: I7df37dbe13448a7359707238fbfb8ca18b62ed65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642744Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845831}

https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..5b36fbc5ed2b

2021-01-21 capn@google.com Target macOS 10.12 when building LLVM
2021-01-21 capn@google.com Use aligned allocation for classes with aligned members
2021-01-21 nicolascapens@google.com Enable and require C++17 compilation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I986f61efb56c3c3ca18b0100ae6ca3dfee2fed7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845830}

Bug: 1159169
Change-Id: I9a23bed470b544d5da3938a6889b28fd2375201c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643700Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845829}

This reverts commit 6674e06c.

Reason for revert: Failing on android-pie-x86-rel:

PolicyTestWebXRImmersiveAR.CheckImmersiveARWorksWhenNotSet

PolicyTestWebXRImmersiveAR.CheckImmersiveARWorksWhenEnabled

Original change's description:
> WebXR: add enterprise policy for immersive-ar sessions
>
> This CL adds new enterprise policy that is used to gate access to
> immersive-ar sessions in WebXR Device API. The enterprise policy is
> per-profile, and is implemented by propagating the pref value from
> browser process to blink via WebPreferences.
>
> Additionally, the CL also introduces new AndroidBrowserTest that
> exercises the added glue code, with the assumption that the enterprise
> policy code that controls the pref is correct.
>
> Other changes:
> - add manifest entry in test jinja template in order for them to work on
>   newer Android versions
> - add DVLOGs in WebXR code paths to assist with debugging
>
> Bug: 1159067
> Change-Id: I27eba5fc0e7bae3dca2d47ca3fb2e935facbd37c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627778
> Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845521}

TBR=dcheng@chromium.org,tedchoc@chromium.org,zmin@chromium.org,bialpio@chromium.org,alcooper@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Iac63a792c5d243d01bb3307983de25113cbe614d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1159067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643625Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845828}

The CQ for infra/config changes often only run the chromium_presubmit
builder and when there are outages that affect the builders that share
machines with chromium_presubmit, it means that changes to attempt to
address the outage may experience long pending times and/or require
skipping the presubmit. Increasing the priority will allow us to keep
the safety provided by the presubmit while still being able to land
changes quickly to address outages.

Bug: 1168201
Change-Id: I828ffcf74a162a6ebdaba0075e6d66ffb31ab2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643407
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845827}

This cl changes the software backend used for
running viz_unittests and cc_unittests from
SwiftShader GL to SwANGLE (ANGLE on SwiftShader
Vulkan). Other tests suites may be affected.

From this cl, performance expectations for test
runs will likely change. For example, cc_unittests
appears to run faster, while viz_unittests and
views_unittests appear to run slower. Note that
this is still using the validating command decoder,
and once the OOP Raster tests can run on the
passthrough command decoder, we'll be able to use
it and gain some performance on all these test runs.

TBR=kbr@chromium.org
TBR=weiliangc@chromium.org
TBR=eugenis@chromium.org
Reason for TBR: These changes were already reviewed here https://chromium-review.googlesource.com/c/chromium/src/+/2532042

Bug: chromium:1060139
Change-Id: Idb0048d3a8e0dfe6855e1700ed26fb076be0c4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580360
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Evgenii Stepanov <eugenis@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845826}

The presubmit check uses the most recent version, which was resulting in
different output for cq-builders.md. It also ow warns about
crbug.com/1054172 being an unknown experiement.

Change-Id: I323a9474df1824bfbc61a892aad75899a0055945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642188
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845825}

This reverts commit 1935a9b5.

Reason for revert: Strongly suspected cause of crbug.com/1167118

Original change's description:
> [Controls Refresh] Bug fix for Datalist uses wrong colors for HC black
> and HC white
>
> This CL fixes an issue in which, when in ForcedColors mode, the data
> list control uses an the default color scheme
>
> Bug: 1157185
> Change-Id: I5103d371fe69226be4ee495f237dd23c874f23f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623150
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Sam Sebree <sasebree@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#842778}

TBR=ellyjones@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,sasebree@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1157185
Change-Id: I67167385980f3dca8a35e0b72f3ed6b00bc7d647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643459Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845824}

This class updates the "Inhibited" property of the Cellular device.
When some SIM-related operations are performed, properties of the
Cellular device can change to a temporary value and then change back.
To prevent churn in these properties, Shill provides the "Inhibited"
property to inhibit any scans.

This class is intended to be used when performing such actions to ensure
that these transient states never occur. Because this operation is
expected to be performed often, we encapsulate it within this class.

Note that this CL does not add any clients for the new class; this will
occur as part of follow-up CLs.

Bug: 1093185
Change-Id: I5776c5c4a47db3645951d639b2917d8c5769c45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640314
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845823}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af0dca3dc983..02e777d04e20

2021-01-21 vadimsh@chromium.org [lucicfg] Update v1.21.0 => v1.21.5.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I206c84d499aa5e160aad385596687ec6e446ddd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643461Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845822}

The MessagePort conversion functions are no longer used outside of
WebEngine, now that previous clients have migrated to
use //components/cast/message_port instead.

Remove vestigial dep on now-removed 'message_port' target.

Bug: 1081525
Change-Id: Ie3629ff1542b96bfe9594cc5dcb1ef15c671c9c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643398
Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845821}

This reverts commit 3f26aff3.

Reason for revert:
This handles merged_json correctly in run_swarming_go.

Added test in https://crrev.com/c/2642838 detects previous breakage.

Original change's description:
> Revert "Reland "trigger_scripts: support go client in chromeos_device_trigger""
>
> This reverts commit 487e7412.
>
> Reason for revert:
> https://ci.chromium.org/p/chrome/builders/ci/Win%207%20Nvidia%20GPU%20Perf/17285
>
> Original change's description:
> > Reland "trigger_scripts: support go client in chromeos_device_trigger"
> >
> > This reverts commit 78d95924.
> >
> > Reason for revert:
> > This fixes previous failure and has a test
> >
> > Original change's description:
> > > Revert "trigger_scripts: support go client in chromeos_device_trigger"
> > >
> > > This reverts commit 3fd9ba25.
> > >
> > > Reason for revert:
> > > https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071
> > >
> > > Original change's description:
> > > > trigger_scripts: support go client in chromeos_device_trigger
> > > >
> > > > This scripts needs json conversion similar to
> > > > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62
> > > > when using go client.
> > > >
> > > > This is fix for breakage like
> > > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159
> > > >
> > > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> > > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> > > > Bug: 1127205
> > > > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275
> > > > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#844979}
> > >
> > > TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com
> > >
> > > Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1127205
> > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#844987}
> >
> > # Not skipping CQ checks because this is a reland.
> >
> > Bug: 1127205
> > Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233
> > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#845499}
>
> TBR=kbr@chromium.org,tikuta@chromium.org,bsheedy@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com
>
> Change-Id: I94525d422ea33245c3142696752cbf64f02e841a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1127205
> Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639349
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845511}


# Not skipping CQ checks because this is a reland.

Bug: 1127205
Change-Id: I8871ab029c1870e7edb7cf4e86350422d9beca62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643676
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845820}

Bug: None
Change-Id: Ibe70a59070de6596e10620688c2daa5c35133e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640402
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845819}

All of the testcases from the
IsPotentiallyTrustworthy.LegacyOriginUtilTests test were already covered
by the IsPotentiallyTrustworthy.Url test (which also covers some
additional testcases).

Bug: 1153336
Change-Id: I05f64324a40f81a7e8b52781b91946d6f859ee7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630297
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845818}

Empty size inputs for SetViewport* functions means the wp_viewport
cropping/scaling will not apply. |crop_rect_| and |display_size_px_|
should be empty and exit early.

Change-Id: I5f4ec85d89835daf5d9f7c46815a18dc4b6c279f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641326
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#845817}

ANGLE performs it's own driver bug workaround flushing internally
resulting in 3 layers (command decoder, skia, ANGLE) all flushing
frequently.

This is a speculative fix to improve the crash rate seen in
bind_with_flush_on_mac when ANGLE is used on Mac.

Bug: chromium:1090584, chromium:1011460
Change-Id: I856d36ea48ad36a61603b726ea61e3e8943c8b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643056Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845816}

Tests insert a timeout on RunLoop in order to find slow or flaky tests
but the current error message only reports where the timeout is enabled
and not which RunLoop was currently running. Example:

../../content/public/test/browser_test_base.cc:701: Failure
Failed
RunLoop::Run() timed out.
Stack trace:

We will now include the Location where the RunLoop::Run() call happens
in order to report where the test is actually timing out. The new error
looks like:

../../content/test/content_browser_test_test.cc:341: Failure
Failed
RunLoop::Run() timed out. Timeout set at ../../content/public/test/browser_test_base.cc:701.
Stack trace:

Notably the file and line number where the "Failure" is reported
(in the first line) are where the RunLoop is Run().

R=gab@chromium.org

Bug: 1145280
Change-Id: Ia5e39dbbfb47fd4c9f831cb77889061c4cd3060f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518125Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845815}

We were logging metrics to the wrong (non-existent) histogram.

This CL changes a constant so that we log to the correct histogram.

Bug: 1154341
Change-Id: I20bb0cc735e1f8e6d75e5f6d2c988c5188341509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642957Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Cr-Commit-Position: refs/heads/master@{#845814}

Before this CL, WidgetBase uses per-thread CompositorTaskRunner.

After this CL, WidgetBase will use per-ASG CompositorTaskRunner.

Bug: 1105403
Change-Id: I6809f79f69541c5a6d12a54ce39e49024bfdc96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626677Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845813}

Navigation icons should be mirrored (resume, prev/next sentence/paragraph). Also left/right keyboard shortcuts should be reversed for sentence navigation.

Bug: 1168802
Change-Id: I03e54c5e98fb086cc86c2a8bd06455f35631a6e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640927
Commit-Queue: Joel Riley <joelriley@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845812}

Bug: 1164416
Change-Id: Ie30d03a446c57f27af03aaccb8f199c9ce8c24cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623152
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845811}

Since r798292 NativeWidgetMacTest.WindowModalSheet has checked for
the presence of a special child window that macOS 11 splices into the
window tree to do the "blur" sheet visual effect. During one of the
later betas it appears that the system stopped adding this child
window, which broke this test.

Bug: 1169225
Change-Id: I8a31e8c6b9ab31c54c9f1a7f819510c1175ea23c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643517Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845810}

BUG=1168437
TEST=Manual

Change-Id: Ic9f719f660bea1f5d50c2ee77e0053e9186ec57b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639800
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845809}

Bug: 1152279
Change-Id: I7512620397af04415592611083c4aba2b21e4a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642372
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845808}

This header uses size_t  and should include something to get it.
This happens to work in the default libc++ config, but  can
cause a build failure in builds with libstdc++.

Change-Id: I1fd3af74bc19b491ae9f4c3529a536f0b93735ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640578
Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845807}

There's 2 things that were wrong. We were not initializing the
VAEncryptionParameters structure we were using, causing bad values to be
present.  We also had a regression error where we then were resubmitting
the VAEncryptionParameters during decode of full sample content. This
fixes both of those.

BUG=b:178039332
TEST=Full sample H264 protected content plays on volteer

Change-Id: I47b82a5f022292290151178cc26266c55b9dff42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643536
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845806}

Previously we rasterized fully recorded tiles only, requiring that
blink must expand the recording rect by at least the tile size, which
was fragile.

CompositeAfterPaint calculates cull rect before painting and compositing
so we don't know the bounds of a composited layer and how it intersects
with the visible area, and we don't know which paint chunk will be
indirectly composited later, so we can't ensure we meet the recording
rect expansion requirement for every composited layer.

Allowing rasterization of partially recorded tiles will remove the
requirement, and this allows more flexibility of blink recording rect
expansion and cc tile size.

Bug: 1046544
Change-Id: Ibfe86eeecd46925deacc7a74afa2fee789e65867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628491Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845805}

This reverts commit 17de3187.

Reason for revert: the root cause of crbug.com/1164610 has been fixed
by https://chromium-review.googlesource.com/c/chromium/src/+/2636883.

This is a clean reland of the original CL.

Original change's description:
> Revert "Cleanup for LayoutView overflow clips"
>
> This reverts commit 49dd6b58.
>
> Reason for revert: The scale of the devtool override frame size seems
> incorrect, causing crbug.com/1164610.
>
> Original change's description:
> > Cleanup for LayoutView overflow clips
> >
> > 1. Move the code checking requirement of overflow clip for printing
> >    from PaintPropertyTreeBuilder into LocalFrame::ClipsContent().
> >
> > 2. Combine LocalFrameView::ClipPaintRect() into
> >    LayoutView::ViewRect(), so that all code paths calling ViewRect()
> >    (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport
> >    overriding aware. This means that the overriding viewport is
> >    reflected in the paint property tree, and
> >    CompositedLayerMapping::RecomputeInterestRect() no longer needs to
> >    apply the viewport clip separately.
> >
> > Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388
> > Reviewed-by: Stefan Zager <szager@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#841701}
>
> Bug: 1164610
>
> TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I18249c79339935b381ae3a05984d5f139d5194a7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622514
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#842140}

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Bug: 1164610
Change-Id: I38bd98f55387ac85e441ab3cfa4dc7a310e1c9e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628315
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845804}

The desugaring thing is more nuanced than it sounds, and now affects only
Android L & M, and so is less relevant.

Change-Id: I27e6e38644590b320fc60047806bed9389fe8203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642962
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845803}

When a policy conflicts with another and their values are the same, the
policy page now displays a message under the status "Info", as well as
labeling the conflict as "Superseding". The wording of the conflict
status messages is also adjusted to increase clarity. Screenshot SHAs
depicting the new labels and messages are included in this CL.

In addition, support for various conflict types is implemented by adding
a new EntryConflict class. The conflict type is determined based on the
two conflicting policies' values. If the values are equal, the conflict
is treated as superseding. Otherwise, the conflict is overriding.

Policy table before update: http://screen/7RMnvFaR3S3xcC6
Policy table after update: http://screen/5JE3yrUsn5JKsVT

Bug: 1104043
Change-Id: I36dea4b14f8068854d8d7713892187d930956e23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625896
Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845802}

Roll Chrome Mac PGO profile from chrome-mac-master-1611230296-dcf016b3b57961245ab4f6b250bc80f143758478.profdata to chrome-mac-master-1611251835-293c4fab8514e5eb6bd360b905bded2a6927bf71.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If066f9a38e8f411cff37e77ce46852ca690fa9c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643141Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845801}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4e306939..bba017b4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4bb26531b0421e425cb341f83dfc5f8cfcf3a71b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642642Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845800}

DOMAgent’s OnUIElementRemoved() DCHECKs if the UIElement to be removed
exists. Yet, elements of a bubble are currently being removed twice,
breaking this DCHECK.

The first removal is in WidgetElement::OnWidgetDestroyed(). The second
is in WidgetDelegate::DeleteDelegate(), where eventually
ViewElement::OnChildViewRemoved() is called. Because the whole DOM tree
is removed in the first call, the DCHECK fails in the second call.

This change removes the above DCHECK and sends the removal request only
when the node exists in the DOM.


Bug: 1167240
Change-Id: Ia6fc327a8fc5004dce7333f232b323f7b677fbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639134
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845799}

Change-Id: Id92fbd938838b8c52fae59ff07d1d0ed9e060e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640744Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#845798}

Bug: 1160820, 1160821, 1160822
Change-Id: Iaa846223faf3201598625d93299a3d93bb9796c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642753
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845797}

This CL adds a PRESUBMIT check on document policy code generation
to compare the generated .cc file with the reference file.

Note: the test is suffixed with '_presubmit_only', so that it will
be excluded from 'run_blinkpy_tests.py' task, where jinja2 module
is not available.

Bug: 1166698
Change-Id: I4d2a1f3a9960c79e79d526ab8445d0ade74b4143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633734
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845796}

Change WebRect -> gfx::Rect.

BUG=738465

Change-Id: I8603045e47cbfa5a2549f724b29de5521cef4dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641081
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845795}

No behavioral changes intended.

BUG=738465

Change-Id: I6849f610370625fec5cec7267404e1fb56c70da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639223
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845794}

These data members were carried over from GLRenderer but are never
actually used. This is a no-op change.

Bug: 1161653
Change-Id: I2167b728b754a36200a21a7d18b461cec35e1cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643437Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845793}