- 18 Jun, 2020 40 commits
-
-
Todd Sahl authored
This change adds two new group policies. The first policy accepts a list of protocols that may be launched by the browser without prompting the user. The second policy, if used, accepts a list of origin patterns that restrict the behavior of the first policy to just those origin patterns. The rules for origin pattern matching are described publicly here: http://www.chromium.org/administrators/url-blacklist-filter-format "/path" and "@query" patterns cannot be used as part of origin patterns, and this is noted in the policy description. Bug: 911605 Change-Id: Icb3aa769d5f0010225cb21097e3bb635085ad7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225522 Commit-Queue: Todd Sahl <toddsahl@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779701}
-
My Nguyen authored
Mock screenshot: https://screenshot.googleplex.com/n6jPyLOGHoZ Actual view: https://screenshot.googleplex.com/xho3q7phQr8 Note the actual view is because emoji suggestion can be managed by enterprise policy Bug: 1093650 Change-Id: Ie9bf4b4bdc1a51b44b60cf76feebe479334243a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237835 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#779700}
-
Wei Lee authored
Bug: 980846 Test: None Change-Id: I2621e011ba544c42ee1fc5029df8cb69b5dd8ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249213 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#779699}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Iea589d4d9bba82b1a88041791d7e5901b9270a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250477 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#779698}
-
Daniel Rubery authored
This CL adds a metric recording the results of the malware scan when an Advanced Protection user uploads a file for deep scanning. This will be useful to quantify the benefits of deep scanning at launch time. Bug: 1020418 Change-Id: I4d184ad0859c5fe2bf870f8f3aba2e23a322880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240410 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779697}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592444957-71678dbb85583180f0a866ae4da634fc0e847777.profdata to chrome-win64-master-1592452187-d8b5060216a94a83da3c0624280c3c37a480cfb4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0fcd0bdda642354ceaacb93b9e2c3fe08f24e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779696}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592441973-8f9a4741d5f9fee5ba7748f102e2fb2e80661b9c.profdata to chrome-win32-master-1592452187-94708d6f0067ad9e590c4843569525b02efba040.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iaec2923a17584a2c14b9e934e98a042e5640cfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251349Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/622ed3fe6f3f..13d717d087e2 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8ee3be9c507533b8e1ecc4170bf0fea6f8f60fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251356Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b623d84fd3d3..2878b9ea5ed3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1012448 Tbr: kinuko@google.com Change-Id: I885754ea07a42277a1e6395b3df129b32c7fd402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779693}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67237c14a6db..53f973c22a26 2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 763957e6b4fc to 7a1d99d0be42 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ifc41b6d0c86ac19a2160cac6508b09148a5f14d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251355Reviewed-by:
-
Regan Hsu authored
The navigator.language must be explicitly passed into the time formatter for ES-419 formatted time to be displayed. This also corrects the additional zero shown in single digit hours. Bug: 1076309 Change-Id: Idd09e744e72a5d0cbaaa1ec92e4d1b88a8683105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250473Reviewed-by:
-
Noel Gordon authored
The files app drag drop chip is rendered in a #drag-container element, that must be visible to the browser, but hidden with z-index:-1 behind the files app #dialog-container (invisible to users). The files-ng drag drop chip differs from non-files-ng in its CSS style and also its HTML structure. Prefix existing #drag-container CSS with body:not(.files-ng). Move the #drop-label CSS into that group, add the same prefix and TODO comments about removing the #drop-label element. Add a CSS body.files-ng #drag-container group, used to style drag drop container structure for the files-ng case. Add renderThumbnailFilesNg_ to create that structure. Add notes to remove renderThumbnail_ used by non-files-ng case. Update to code to render the files-ng or non-files-ng drag thumbnails. For the files-ng RTL case, move the drag image grab point to the right by its clientWidth, scaled by the device pixel ratio, to satisfy dragStartEvent.dataTransfer.setDragImage(element, x, y) whose x,y co-ords work in screen units, rather than device independent co-ords like CSS pixel (px) units. For touch initiated drags, there is no need to reposition in the y-direction since the files-ng design has enough room to avoid a finger obscuring the drag drop chip content. Add code comments about "dropping directories on themselves", and code a plain for-loop over the selection Array rather than Array.find(). It is easier to reason about, and it is faster. Saves a function call per loop iteration and it helps if the code is fast since it's called from a drag event handler. Bug: 1002394 Change-Id: I1befcb6f69eca1c7f64591fbf0aca6bb0a69448e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247987Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779690}
-
Arnaud Mandy authored
Test to verify screen id. adding 3 displays to display vector. getScreens() should return 3 screens with ids 0,1,2. removing middle display from display vector. getScreens() should return 2 screens with ids 0,1. removing last display from display vector. getScreens() should return 1 screen with id 0. Bug: 1075656 Change-Id: Ib671b760353766d21330b95833b983c9b5e4737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238112Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#779689}
-
Hesen Zhang authored
Bug: 1087476 Change-Id: If941947a498da55e0e5d0809cdef276d16f5ae50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248863Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779688}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If4336e492c4d9dee0163b6d1b8473681dc5d9212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251359Reviewed-by:
-
Joel Hockey authored
The related bug shows that infobar is using the wrong color for non-tabbed PWAs. Infobar takes its color from the active tab color, and non-tabbed PWAs are currently setting active tab color to the theme color (rather than alt color) in order to get the desired NTP page during page load. The fix here is to roll back some of crrev.com/c/2094484 and set active tab color back to the alt color, and then to separate NTP and active tab colors so that NTP can be kept with the desired theme color. All other clients of BrowserThemePack are unchanged since ntp_color is taking active tab color in GetAutogeneratedThemeColors. Only AppBrowserController is changing for non-tabbed PWAs to set alt color for active_tab (fixes bug relating to info bar), but can now keep the theme color for NTP so as not to regress crbug.com/1059696. For reference the previous changes for AppBrowserController: crrev.com/c/2045278 crrev.com/c/2064164 crrev.com/c/2094484 Screenshots: crbug.com/1096027#c1 Bug: 1096027 Change-Id: I7db5a2836fef381116b4082b1fde219ba8bdec95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248391Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#779686}
-
Kazuki Takise authored
We are still actively monitoring these metrics. Bug: 1052913 Bug: 1052914 Test: builds Change-Id: I19fbeb7c77c6a43b0fba00f0624a26fe6e4f55af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247425Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#779685}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4147.33-1591609027-benchmark-85.0.4170.0-r1 to 85-4161.0-1592216902-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibaaea16b4630d5bacac330d4168ac525d65a8ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251353Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a3a9da74308f..67237c14a6db 2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5af39e89 to 2adbb514 (484 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ic3ccd36e489a9e8a9b69ffeb71460cb04b854ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251342Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d56d2c282f22..622ed3fe6f3f 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Icae1f13873710c5ec8cec04d78edc741884aac75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251343Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4147.33-1591609549-benchmark-85.0.4170.0-r1 to 85-4163.0-1592215894-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3ccfc6bc70c4a8b83af4154299ce7d79884923d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251352Reviewed-by:
-
Alexis Savery authored
Add UMA histograms "Platform.StatefulTrim.TimeBetweenTrim" and "Platform.StatefulTrim.TrimmedAmount" to track the amount of time between trims and the amount of data that is trimmed by chromeos-trim. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2236859 Bug: chromium:1063105 Test: ran validate_format.py Change-Id: I9fd71492804000c1ec73cd5944a5894a4ef63c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237047 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:
-
Peter Kasting authored
This eliminates the need for implementations to override the getters. Bug: none Change-Id: I3df33cd593c3c600739b5b0546270d89342394aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250822 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779679}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4161.0-1591613309-benchmark-85.0.4170.0-r1 to 85-4163.0-1592214946-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic74c65068c943da594a0fe5077cd715a5bf4f273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251351Reviewed-by:
-
Jeevan Shikaram authored
Add jshikaram@chromium.org to the owners file for b/chromeos/apps for work on apk_web_app_service*. Change-Id: I98b7e3302bbbf786ace2a6b533d38ffde842df1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248394Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592434762-d0256013ebfb9b66f1c9d30375481125009d55f6.profdata to chrome-win64-master-1592444957-71678dbb85583180f0a866ae4da634fc0e847777.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9bd0a0dbcfa20193cd0193e392fe62ea87c79e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251338Reviewed-by:
-
My Nguyen authored
As per enterprise review, make emoji suggest addition defaulted to false. Default value does not support DICTIONARY type so created new pref value instead. Bug: 1077629 Change-Id: I0e153d72973188a89521ee8700c87ae3cd202747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239434 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#779675}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3e4e7b5c94f34b1a5ad15edd38a71567b27fa660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251318Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779674}
-
Kyle Horimoto authored
Was forgotten in the original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2233898 Bug: b/154866535 Change-Id: I49b7d808ef62c1ebd9537043f1a0e61fc7c7fb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250472 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#779673}
-
Victor Costan authored
The test has a few sync wrappers for QuotaClient's async methods. The wrappers store the async method results as test fixture members. This scope is unnecessarily large, which is an unnecessary mental burden on folks who need to understand the test. This CL stores each async method result as a local variable in the method's sync wrapper and removes the member variables. DeleteOriginData() is also changed to pass through the async result. This will produce more informative messages if the tests fail. Change-Id: Ia5afba6a532593a610f52beba13efe376dbf46d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250709 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779672}
-
Leonid Baraz authored
Bug: b:153364303 Change-Id: I7355fcf9ffc717983b1c8ea3808cbec86a95f55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242472 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#779671}
-
Tarun Bansal authored
Refactor detection of offline connections for the purpose of offline indicator to a separate class. This class also handles the logic of waiting for 2 seconds after the connection is offline before notifying the offline indicator class. If the connection is online, then the indicator class is notified immediately. In the next CL, this class would also handle the logic of holding on to the notification when Chrome is brought to the foreground (see crbug.com/1093574) Change-Id: I3368fce894b1fa2dfda3efce3fef5c3764c7217b Bug: 1084740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240899 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#779670}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a286a8469b97..22e7befe144d 2020-06-18 chonggu@google.com [Fuchsia] Add Tracing Support for Fuchsia in Telemetry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1088033 Tbr: eseckler@google.com Change-Id: I73a05fde41e8cb0b92a787a51f4b857eeb200ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250817Reviewed-by:
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: I25aa5a0d12c1a13f1b7c4e3a816e8ce34c1d2e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248387 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: Ic985380972ba755b68226072ff3da1c29a71abab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249429 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
alanlxl authored
Update the tf native code of neural palm detection. Model description: 1. Trained with kohaku + meowth data, the auc on basking data is 0.9478. 2. Feature vector is the same as the old one, feature size = 193. Bug: 1095874 Test: deployed and tested on a kohaku device Change-Id: Id62f14f82dfc9d0895aba88765b44407cd35db6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249279Reviewed-by:
Rob Schonberger <robsc@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#779666}
-
Yi Xu authored
Test case fast/canvas/canvas-composite-text-alpha.html is flaky on Mac, linux and windows platform. The expected outcome of the test is Pass or Timeout. Bug: 1093836 Change-Id: I0f9c8e4ce891cb12ca0be72fd0e506ff3c3b4c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249438 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779665}
-
Meilin Wang authored
This CL is splitted from the original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2199870 with all files changed on ambient/. side. Bug: b/156531168 Test: unittests. Change-Id: I4f84277c74c95419ac96e6cfaaa48081c407b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248878 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779664}
-
Kent Tamura authored
This CL adds base::Feature for LayoutNGRuby runtime flag. We can disable the feature by Finch when we find a critical bug of the feature. Bug: 1069817 Change-Id: I93385fd2e6a67acad7af3e45310e254b6692f504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250140 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#779663}
-
Kent Tamura authored
ComputeAnnotationOverflow() produced annotation overflow values even without any ruby annotation text because text fragment height can be taller than line-height. Such annotation overflow values extended line spacing. This CL fixes this issue. Bug: 1069817 Change-Id: I044cf909567b549cec38d1b97de36e6dde836dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251139 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779662}
-
