- 24 Apr, 2018 40 commits
-
-
Timothy Loh authored
This patch removes a DCHECK in CrostiniRegistryService::GetRegistration that checks the id is a valid extension id. While app list ids are currently expected to be extension ids, this is incidental and it's better to not have more checks for this. Change-Id: I46c252c047780cafd5be7eb8cd4296fe0d01989f Reviewed-on: https://chromium-review.googlesource.com/1025331Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552997}
-
Xiaocheng Hu authored
LayoutObjectFromPosition() is a hacky utility function to set |RenderedPosition::layout_object_| when |inline_box_| is nullptr. With previous refactoring, there is no usage of |layout_object_| when |inline_box_| is nullptr, so we no longer need to set a non-null |layout_object_| for null |inline_box_|. Hence, this patch removes the call sites in RenderedPosition. Note: the function cannot be removed because it is still indirectly called by AX via LayoutObjectContainsPosition(). A follow-up patch will move it to AX. Bug: 822575 Change-Id: I720193c9926212153c56552115b5be9619ea20bc Reviewed-on: https://chromium-review.googlesource.com/1025034Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552996}
-
Jianzhou Feng authored
Set the VK Aura Window to be transparent. Otherwise WindowOcclusionTracker will set the Web Page Aura Window state to be occluded and user can not see the committed input texts after VK turns fullscreen. See conditions defined in VisibleWindowIsOpaque. Bug: 826617 Change-Id: Idd8c525f205e608fe53fb59f85d302175b7a6246 Reviewed-on: https://chromium-review.googlesource.com/1023380 Commit-Queue: Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#552995}
-
Noel Gordon authored
Move private parts of the FileManagerBrowserTestBase API to the class private: area. Add TODO comments or for other work needed. Bug: 833834 Change-Id: I1070df30a09adbdec24dc6dfa4d0168777f92dca Reviewed-on: https://chromium-review.googlesource.com/1025432Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#552994}
-
Xianzhu Wang authored
With it we no longer need to save backface_hidden in PaintChunkProperties thus paint chunks can use RefCountedPropertyTreeState as their properties. Also make the flag tri-state to implement the current SPv1*'s behavior that we ignore backface visibility values on some non-plane-creating elements. The kInherited value means that the transform node doesn't create a new backface visibility context. For now only ObjectPaintProperties::Transform() will create a new backface visibility context (using kHidden or kVisible values of BackfaceVisibility). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I89a1327a96b991b3c2e1714dad23390b20b1f4e3 Reviewed-on: https://chromium-review.googlesource.com/1014192 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552993}
-
Xiaocheng Hu authored
SelectionMofidierWord uses RenderedPosition instances without using the bidi-related functionalities. Since RenderedPosition is a wrapper of InlineBoxPosition with bidi utility functions added, this patch changes SelectionModifierWord to use InlineBoxPosition directly for simplicity. Bug: 822575 Change-Id: I96d7294814e425fc17ae9d774b68019dca974400 Reviewed-on: https://chromium-review.googlesource.com/1025021Reviewed-by:
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I790f32af9bc563089695e92d609298a1e1d11b23 Reviewed-on: https://chromium-review.googlesource.com/1025120Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552991}
-
rbpotter authored
Adds the "more settings" action link, and shows and hides sections based on the link and their availability. Note: This CL does not add the height animation used to show and hide sections in the existing UI. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I09ddc9239ad252e151f973a793d0f57884cba5e3 Reviewed-on: https://chromium-review.googlesource.com/1019571Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#552990}
-
David Valleau authored
GetPrinterInfo was omitting the autoconf field which was causing a "NOTREACHED" to be hit when attempting to edit an autoconf printer. This change adds this field and also moves the GetPrinterInfo function to be a free function in printer_translator so that it can be tested more easily. BUG=chromium:834911 R=michaelpg@chromium.org, skau@chromium.org Change-Id: I37145b71228afdeb6de9628365bf311d2e98b190 Reviewed-on: https://chromium-review.googlesource.com/1023118 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#552989}
-
Dmitry Gozman authored
Instead, we have a MainThreadFetchers() collection directly in ResourceFetcher. This also allows to remove singleton behavior from leak detector and migrate it to StrongBinding. Bug: none Change-Id: I9ae638c8feec9f4fab7275ec73c5c0f30c6fb008 Reviewed-on: https://chromium-review.googlesource.com/1014343Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552988}
-
James Zern authored
rolls up local cherry-picks and adds a few more sse4 optimizations for lossless Bug: 834150 Change-Id: Ic05c47407fa873b22744bb1af41729c076ee9ad2 Reviewed-on: https://chromium-review.googlesource.com/1018361 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552987}
-
Malay Keshav authored
This patch replaces ui scales for zoom factors to allow the clients to compute the ideal content scale. This patch also adds more scale factor enums to aura shell interface. Bug: 835030,836054 Component: aura shell Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1024920 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552986}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I31e4c60a1ab888d8e368b199694be93dcaf05914 Reviewed-on: https://chromium-review.googlesource.com/1025057Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552985}
-
Chris Harrelson authored
Bug:826189 Change-Id: Iba551320694d12c63ed352e9cf55f19471a75f59 Reviewed-on: https://chromium-review.googlesource.com/1025219Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552984}
-
https://pdfium.googlesource.com/pdfium.git/+log/4e4147eccd25..2dca1cbf5956 $ git log 4e4147ecc..2dca1cbf5 --date=short --no-merges --format='%ad %ae %s' 2018-04-23 dsinclair Cleanup CFX_XMLParser initialization 2018-04-23 rharrison Pre-allocate more string buffers in barcode code Created with: roll-dep src/third_party/pdfium BUG=chromium:834630 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If2eb29c9bd23bb4d07f64549fcf72626d3c6bff6 Reviewed-on: https://chromium-review.googlesource.com/1025226 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552983}
-
Yoichi Osato authored
This patch fixes the regression that was introduced by crrev.com/c/890574 ([LayoutNG] Refactor RenderedPosition::ComputeCompositedSelection) We should consider text affinity so that we show selection handles at appropriate position. Bug: 815099 Change-Id: I7796933ee8cbcc70e80c9fa373aab9cc08a6f138 Reviewed-on: https://chromium-review.googlesource.com/1023358Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia577756f3468bbc975afb8b3ed1e91aaffe3b02b Reviewed-on: https://chromium-review.googlesource.com/1025266Reviewed-by:
-
sczs authored
- Makes the VC conform to UISearchResultsUpdating and UISearchBarDelegate. - Migrates the filter and delete logic from the LegacyHistory implementation. - Removes isSearching property since we can directly ask the SearchController. Screenshots: https://drive.google.com/open?id=1fYgO7PiJ0tKZgAKXAnt2vzW7Exlcz0En https://drive.google.com/open?id=160AsFrm8Z71JUc5ADpvIsaT4YKYVigNd Bug: 805192 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I74f0465ee3aff13a4cbe3d72277e10c6d1f87b19 Reviewed-on: https://chromium-review.googlesource.com/1022529 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552980}
-
Dominick Ng authored
BUG=782120,811578 Change-Id: I24d1129b61bf16b800331e1c512191bce529f5b1 Reviewed-on: https://chromium-review.googlesource.com/1020620 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#552979}
-
Scott Chen authored
This CL does a couple things to match design mock: - when not signed in, the account row should always show banner and text prompt (with regular font-size) on top of the account row. - when signed in, the turn-off button is not present within the sync-page. - use an optimized .svg for banner instead. Bug: 800972 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70be2803e3abecbc5cf127b657740d793bc0db55 Reviewed-on: https://chromium-review.googlesource.com/986983 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#552978}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6267b449..8fecf0ef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia901a5cd2f18672b9acbeae97bb02e77ff9ab2c7 Reviewed-on: https://chromium-review.googlesource.com/1024811Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552977}
-
siyua authored
Right now the autofill upstream save credit card promp explanation is "save this card". To clarify what is actually being saved, we would like to change it to "save your card and billing address" Bug: b/78175540 Change-Id: I8169f48e9e83b0f5e3025b0effcb748ff6f82355 Reviewed-on: https://chromium-review.googlesource.com/1025114 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#552976}
-
Zhiling Huang authored
Bug: 790520 Change-Id: Ic4cbdc04d22f9d266022a734a0344c7816875912 Reviewed-on: https://chromium-review.googlesource.com/1025044Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#552975}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: I904bb128c562a93c29e6c48104ebd498d354d398 Reviewed-on: https://chromium-review.googlesource.com/1024726Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#552974}
-
Adam Rice authored
WebSocketEndpointLockManager has a comment about being thread-incompatible. This was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1009962, so the comment no longer applies. Remove it. BUG=450518 Change-Id: I4753ea735842cbe92402afc954a24bb380141260 Reviewed-on: https://chromium-review.googlesource.com/1023573Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#552973}
-
Xiaohui Chen authored
Test: build locally with upreved libassistant Bug: None Change-Id: I3db67f5a77824fcf0831447f353baba6167b0801 Reviewed-on: https://chromium-review.googlesource.com/1025268Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552972}
-
Xi Cheng authored
This is a reland of 850001f3, which caused a pre-submit deadlock for chrome/browser/notifications/OWNERS. This is now safe to land as the following CL has been landed: https://chromium-review.googlesource.com/c/chromium/src/+/1024633 Original change's description: > Move notification_helper/ to chrome/notification_helper/ > > ... plus all the necessary code migration. A follow-up CL will be used > to update relevant comments. > > Bug: 734095 > Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b > Reviewed-on: https://chromium-review.googlesource.com/1022957 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Xi Cheng <chengx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552762} Bug: 734095 Change-Id: Id4e0818d7e3ea2b0ea7633e883bc5cea42705167 Reviewed-on: https://chromium-review.googlesource.com/1024744 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#552971}
-
Lei Zhang authored
ASAN bits remain. BUG=605605 Change-Id: I57252e03f569e8f605bdaa01e0aaf97455e5e761 Reviewed-on: https://chromium-review.googlesource.com/1014955Reviewed-by:
-
David Valleau authored
The "Add Printer" button on the cups printers settings page will be disabled if the enterprise printer policy is set so that users are not allowed to configure their own native printers. Bug: 827015 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id501e2f667c435f6d7bd503ab7c343cccf4b3abd Reviewed-on: https://chromium-review.googlesource.com/987626Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This reverts commit bcb0488a. Reason for revert: Bug fixed Original change's description: > Revert "Reland "Only retry failed tests for layout tests"" > > This reverts commit c24c2363. > > Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1018590 broke webkit > > Original change's description: > > Reland "Only retry failed tests for layout tests" > > > > This reverts commit 23ea7f24. > > > > Reason for revert: Issue fixed > > > > Original change's description: > > > Revert "Only retry failed tests for layout tests" > > > > > > This reverts commit ecb97ada. > > > > > > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid > > > > > > Original change's description: > > > > Only retry failed tests for layout tests > > > > > > > > Recently layout tests have been fairly flaky; this is causing extra load > > > > on the CQ. Every time layout tests fails, they are retried without patch > > > > to determine if the failure is a flake or a failure at tip of tree. This > > > > means that layout tests are running more than other test suites, and > > > > since layout tests take a long time to run, we end up consuming more > > > > capacity from our swarming pool than we should. > > > > > > > > Isolated script tests don't have the ability to retry only the tests > > > > that failed, which is what other test suites do. This CL changes that so > > > > that layout tests, when re-run without the patch, retry on the tests that > > > > fail, which should significantly reduce swarming load and cycle time for > > > > running layout tests without patch. > > > > > > > > Bug: 533481 > > > > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423 > > > > Reviewed-on: https://chromium-review.googlesource.com/1015843 > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#551821} > > > > > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > > > > > Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 533481 > > > Reviewed-on: https://chromium-review.googlesource.com/1018161 > > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#551877} > > > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 533481 > > Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f > > Reviewed-on: https://chromium-review.googlesource.com/1022552 > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#552482} > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > Change-Id: Ibd7819d1adb43895e33b74622438aa61517a036d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 533481 > Reviewed-on: https://chromium-review.googlesource.com/1022558 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552484} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 533481 Change-Id: I87279f430e6bee58068bad4f3bce71d1923e0834 Reviewed-on: https://chromium-review.googlesource.com/1024719Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#552968}
-
Kyle Horimoto authored
This property is needed so that ash can bind to Mojo services specific to a given user. This functionality will be used in a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1022470. Change-Id: I734d6e1f42fb2832cfdbc959d4d733b0bdd59727 Reviewed-on: https://chromium-review.googlesource.com/1022834 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#552967}
-
Kent Tamura authored
* Merge webkitpy into blinkpy except for add_blinkpy.py * Rename webkitpy.layout_tests to blinkpy.web_tests * path_finder.py: - Remove get_scripts_dir() and path_from_tools_scripts() - Change _webkit_base() to _blink_base() * android.py, fuchsia.py: Use path_finder.py instead of sequences of '..' * Move Tools/webkitpy/pylintrc to tools/blinkpy/ * Move Tools/apache_config to tools/ blinkpy.web_tests.port depends on it. * Move Tools/Scripts/webkitruby/PrettyPatch to tools/blinkruby blinkpy/common/prettypatch.py depends on it. * Remove blinkpy.common.add_webkitpy * Drop webkitpy from test-webkitpy targets Bug: 829697 Change-Id: Idb5c25e62b906f763adddb11b6e876135ce3488f Reviewed-on: https://chromium-review.googlesource.com/1023620 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#552966}
-
Raymond Toy authored
AudioParam has a new attribute, automationRate, to allow the user to choose whether the AudioParam is "a-rate" or "k-rate". Add support for setting and getting the attribute. Update all AudioParams to support a-rate and k-rate when allowed. Spec: https://webaudio.github.io/web-audio-api/#dom-audioparam-automationrate Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/extLjVzLw7s/9XUZvQqcBQAJ Bug: 828947 Change-Id: Ibb9fe8bc0dedf3cfdcf33727734b5d66e5a7ca2f Reviewed-on: https://chromium-review.googlesource.com/945076 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#552965}
-
Yutaka Hirano authored
The spec issue is now fixed, and this CL follows the spec change[1]. 1: https://github.com/whatwg/fetch/commit/14858d3e9402285a7ff3b5e47a22896ff3adc95d Bug: 791324 Change-Id: Ic3e3955f43578b38fc44a5a6b2a1b43d56a2becb Reviewed-on: https://chromium-review.googlesource.com/1023613Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#552964}
-
Kenichi Ishibashi authored
The current threshold came from my local experiments and it wouldn't be necessarily an appropriate value. Make the threshold configurable so that we can run experiments in the real world. Bug: 776665 Change-Id: I6ae896439eb50985221258b9109f6f06e3aea178 Reviewed-on: https://chromium-review.googlesource.com/1022410 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Removes API getWebContents/getContainerView from ContentViewCore. ContentViewCore object is passed around in numerous cases just to get WebContents/container view from it. Embedders already has access to its container view (through Tab instance for Chrome, AwContents for WebView). So passing WebContents instead is enough. And content layer gets the active container view through WebContents.getViewAndroidDelegate added by https://crrev.com/c/994500. Bug: 598880 Change-Id: Ic3abd837a8751be6f1aacbe3364901e92db8b1cc Reviewed-on: https://chromium-review.googlesource.com/1015457 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552962}
-
Wang Qing authored
Fix LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets has 3474 pixel differences on Loongson. Set percentage_pixels_large_error on Loongson. BUG= 819110 R= fsamuel@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I680f9c5f2eb36f8387bf4e5edf5cfe19da2108e3 Reviewed-on: https://chromium-review.googlesource.com/1023710Reviewed-by:
enne <enne@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#552961}
-
Wang Qing authored
Set percentage_pixels_large_error on Loongson. BUG= 819075 R= fsamuel@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I684f2aa6c27e521212ca0f4faac3b966bb3064d9 Reviewed-on: https://chromium-review.googlesource.com/1023002Reviewed-by:
-
Xiaocheng Hu authored
This patch removes a leftover "/*" from the copyright header of the file. Notry: True Change-Id: I2d44da15a07e9003756647dfc631a8e813259380 Reviewed-on: https://chromium-review.googlesource.com/1025180Reviewed-by:
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib5b868a0a581ad8e66bd49208b3262dc79251b4f Reviewed-on: https://chromium-review.googlesource.com/1023157Reviewed-by:
-
