GitLab

These were disabled on Mac, but are flaking everywhere.

TBR=mmenke
BUG=130404
NOTRY=true

Review URL: https://codereview.chromium.org/698003007

Cr-Commit-Position: refs/heads/master@{#302568}

BUG=406404

Review URL: https://codereview.chromium.org/686013002

Cr-Commit-Position: refs/heads/master@{#302567}

Fixed bug on Ubuntu Linux where the AppInfoDialog was outliving the
ExtensionSettingsHandler, causing Chrome to crash when the browser
window was closed while the dialog was open. This used to only happen
on Mac (where the dialog is disabled), but now happens on Linux Unity
due to Unity's always-accessible close/minimise/maximise toolbar.

TEST=Make Chrome fullscreen on Ubuntu with Unity enabled, then navigate
to chrome://extensions, click Details next to an app, and close Chrome
by clicking the X in Unity's fullscreen toolbar (not in Chrome). Chrome
should close gracefully and not crash.
BUG=427506

Review URL: https://codereview.chromium.org/683763003

Cr-Commit-Position: refs/heads/master@{#302566}

Added startPairing with pairing method parameter.
Changed some naming in gcd_private.idl
Changed PrivetV3Session from delegates to Callback. This makes code smaller and more readable.

Review URL: https://codereview.chromium.org/695253002

Cr-Commit-Position: refs/heads/master@{#302565}

While deflaking some SimpleIndex tests, it became clear we needed a
variation net::TestCompletionCallback that worked work base::Closure
rather than a net::CompletionCallback.

R=jkarlin@chromium.org
BUG=255775

Review URL: https://codereview.chromium.org/699693002

Cr-Commit-Position: refs/heads/master@{#302564}

Revert of Make extensions that desire to act pop out if in overflow (patchset #6 id:200001 of https://codereview.chromium.org/675023002/)

Reason for revert:
Suspect this patch of causing errors on linux valgrind for LocationBarControllerUnitTest.NavigationClearsState.

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/31337

Sample valgrind output:
Suppression (error hash=#606630BA25518095#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Unaddressable
fun:_ZN16ExtensionService21NotifyExtensionLoadedEPKN10extensions9ExtensionE
fun:_ZN16ExtensionService12AddExtensionEPKN10extensions9ExtensionE
fun:_ZN10extensions12_GLOBAL__N_129LocationBarControllerUnitTest12AddExtensionEbRKSs
fun:_ZN10extensions12_GLOBAL__N_156LocationBarControllerUnitTest_NavigationClearsState_Test8TestBodyEv
}

Original issue's description:
> Make extensions that desire to act pop out if in overflow
>
> If an extension desires to act, it should pop itself out of
> the overflow menu.  There should also be a visual queue for
> extensions that are already visible, but what exactly that
> should be is still being discussed.
>
> BUG=417441
>
> Committed: https://crrev.com/d604171517135387ca3b4c33d7f1774c8d2d38b0
> Cr-Commit-Position: refs/heads/master@{#302511}

TBR=finnur@chromium.org,pkasting@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417441

Review URL: https://codereview.chromium.org/700453003

Cr-Commit-Position: refs/heads/master@{#302563}

Before this change, the data reduction proxies were added to the
list of acceptable proxies for a URL, if the effective proxy
configuration resolved to direct for it. This change further checks
that the effective configuration is not the data reduction proxy's.

BUG=425826

Review URL: https://codereview.chromium.org/653313003

Cr-Commit-Position: refs/heads/master@{#302562}

This code conditionally stashes a sync point for buffer types that require it for the destruction phase.

BUG=416873

Review URL: https://codereview.chromium.org/654223006

Cr-Commit-Position: refs/heads/master@{#302561}

A static code analyzer reports an error in usb_midi_output_stream.cc, which
is a message_size_table buffer overflow. This CL fixes the code.
Note that the reported error never happens and hence the fix doesn't change
the behavior.

BUG=427616

Review URL: https://codereview.chromium.org/694733002

Cr-Commit-Position: refs/heads/master@{#302560}

BatteryStatusServiceTest.AddCallbackAfterUpdate
BatteryStatusServiceTest.RemoveOneCallback
BatteryStatusServiceTest.TwoCallbacksUpdate

These tests fail on DrMemory bots and locally on Windows.

NOTRY=true
TBR=timvolodine
BUG=429942

Review URL: https://codereview.chromium.org/699823002

Cr-Commit-Position: refs/heads/master@{#302559}

The AppCacheUpdateJob::URLFetcher cancels redirects in general.
This change allows redirects that are generated by the data
reduction proxy bypass mechanism. This is a workaround until
crbug.com/429505 is resolved.

BUG=429011

Review URL: https://codereview.chromium.org/695193002

Cr-Commit-Position: refs/heads/master@{#302558}

We are going to use this property from the JS side to know whether a task is generated from generic file handler or not.
Generic file handler is a file handler which can handle any type of file.

e.g.
These are generic handlers.
"types": ["*/*"]
"types": ["*"]
"types": ["*/*", "image/jpeg"]
"extensions": ["*"]
"extensions": ["*", "jpg"]

These are not generic handlers.
"types": ["image/jpeg"]
"types": ["image/*"]
"extensions": ["jpg"]
"extensions": ["jpg", "png"]

BUG=414566
TEST=out/Release/unit_tests --gtest_filter=FileManagerFileTasksTest.IsGenericFileHandler:FileManagerFileTasksComplexTest.FindFileHandlerTask_Generic

Review URL: https://codereview.chromium.org/686393002

Cr-Commit-Position: refs/heads/master@{#302557}

This fixes the call of device.PushChangedFiles; see example of correct usage here: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/provision_devices.py&q=PushChangedFiles

This change should fix the breakage of the chrome-proxy tests that was
introduced in https://codereview.chromium.org/656383002/.

BUG=429313

Review URL: https://codereview.chromium.org/689213002

Cr-Commit-Position: refs/heads/master@{#302556}

Review URL: https://codereview.chromium.org/703433003

Cr-Commit-Position: refs/heads/master@{#302555}

BUG=390086

Review URL: https://codereview.chromium.org/693433002

Cr-Commit-Position: refs/heads/master@{#302554}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a6ca5a0..7c11aad

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/699813002

Cr-Commit-Position: refs/heads/master@{#302553}

The MacViews "chrome" compile regressed in r301203

This adds a stub that just returns
scoped_ptr<ConstrainedWindowViewsClient>(nullptr) and fixes some
NativeWindow/NativeView inconsistencies (popup_manager->GetHostView()
returns a view).

The component is compiled on MacViews, since it will eventually be
needed. At link time for `chrome`, everything except the a pure virtual
destructor call will be culled since they are unused, but this approach
keeps component usage consistent with the test targets, which do have
the whole component.

note that components_unittests ConstrainedWindowViewsTest.* all pass on
a MacViews build except for one check against a dialog size
(constrained_window_views_unittest.cc line 142).

BUG=390755, 410499

Review URL: https://codereview.chromium.org/699553002

Cr-Commit-Position: refs/heads/master@{#302552}

https://codereview.chromium.org/699643002 moved
gpu_memory_buffer_factory_x11.cc to *_linux.cc. Since Ozone provides its
own implementation there are multiple definitions of the same symbol.

BUG=none
NOTRY=true
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/688493003

Cr-Commit-Position: refs/heads/master@{#302551}

It2me is currently behind a flag on Chrome OS.  This CL enables It2me on Chrome
OS in the webapp when the flag is enabled.  It also removes the function
remoting.runningOnChromeOS() which does exactly the same thing as
remoting.platformIsChromeOS().

Review URL: https://codereview.chromium.org/695363002

Cr-Commit-Position: refs/heads/master@{#302550}

BUG=427707
NOTRY=true
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/684253005

Cr-Commit-Position: refs/heads/master@{#302549}

This makes adb_reverse_forwarder.py a little more convenient
to use.

BUG=429859

Review URL: https://codereview.chromium.org/684383004

Cr-Commit-Position: refs/heads/master@{#302548}

Retrieve font metrics from skia if DirectWrite is enabled for font metrics calculations in the chrome browser UI.

The previous patch for getting the correct font metrics from DirectWrite https://codereview.chromium.org/692633003/
was wrong as it did not return the correct font metrics in all cases.

Getting the metrics from skia ensures that we get the same font metrics which would be used by skia for rendering.

Changes in this patch are as below:-
1. Removed DirectWrite factory code from PlatformFontWin. The PlatformFontWin::ConvertGDIFontToDirectWriteFont
   function has been replaced by the CreateHFontRefFromSkia function. This function is called if DirectWrite is
   enabled in the browser which sets a static bool on the PlatformFontWin class.

BUG=428645,427804,427802

Review URL: https://codereview.chromium.org/696913002

Cr-Commit-Position: refs/heads/master@{#302547}

BUG=

R=mmenke, rdsmith, jwd

TEST=NetInternalsTest.netInternalsTourTabs
     NetInternalsTest.netInternalsExport*/Import*
     NetInternalsTest.netInternalsSdchView*

Review URL: https://codereview.chromium.org/423813002

Cr-Commit-Position: refs/heads/master@{#302546}

BUG=429915
NOTRY=true

Review URL: https://codereview.chromium.org/705483002

Cr-Commit-Position: refs/heads/master@{#302545}

This should get the v2 launch test to start passing again.

BUG=424690

Review URL: https://codereview.chromium.org/703453003

Cr-Commit-Position: refs/heads/master@{#302544}

Review URL: https://codereview.chromium.org/685983004

Cr-Commit-Position: refs/heads/master@{#302543}

Most changes are updates to the mojom syntax for modules.

R=viettrungluu@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/698883005

Cr-Commit-Position: refs/heads/master@{#302542}

The reauth is needed to acquire the user's password to add a new cryptohome
key for sign-in.

BUG=409427

Review URL: https://codereview.chromium.org/668213003

Cr-Commit-Position: refs/heads/master@{#302541}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c51b33e..fca5a7c

TBR=morrita@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/695403005

Cr-Commit-Position: refs/heads/master@{#302540}

visa-mdpi is missing, so it's a placeholder for now.

NOTRY=true
TBR=dtrainor@chromium.org
BUG=400904

Review URL: https://codereview.chromium.org/698173002

Cr-Commit-Position: refs/heads/master@{#302539}

Move the Developer Website and Licenses links in the App Info dialog to
below the description, if they exist. Change the 'View in Webstore' link
to always display directly under the app name, even if a developer
website is already provided.

BUG=423252

Review URL: https://codereview.chromium.org/691253002

Cr-Commit-Position: refs/heads/master@{#302538}

This is a temporary fix to a bug where the popup is shown then immediately
hidden as a result of the keyboard showing. Reverting to the old two click
behavior, on Android only, until we can fix the underlying issue.

BUG=423464

Review URL: https://codereview.chromium.org/695953003

Cr-Commit-Position: refs/heads/master@{#302537}

I misunderstood how ObjectiveC handled pointers declared with __weak.
This change resolves the issue by nil'ing things out in
[TabController dealloc], the standard solution.

Introduced by: https://codereview.chromium.org/688523002/

BUG=429605

Review URL: https://codereview.chromium.org/699013002

Cr-Commit-Position: refs/heads/master@{#302536}

This pulls in the following Native Client changes:

r14010: (shyamsundarr) allow 16 bit xadd (including atomic version) in ia32.
r14013: (hidehiko) Non-SFI mode: Add MSG_TRUNC and MSG_CTRUNC to sys/socket.h
r14014: (yyanagisawa) Exponential backoff sleep time on WindowsError.
r14015: (shyamsundarr) enable 16 bit cmpxchg in ia32.
r14017: (maruel) Normalize paths in pnacl/driver/driver_tools.py.
r14019: (mcgrathr) toolchain_build: Switch gcc to 4.9 branch

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/698973002

Cr-Commit-Position: refs/heads/master@{#302535}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/37dd331..a6ca5a0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/701593003

Cr-Commit-Position: refs/heads/master@{#302534}

The TitleCondensed string property is now used to pass strings
for accessibility.  This gets around the inability to
set the content description normally for the custom menus.

BUG=293658

Review URL: https://codereview.chromium.org/691113005

Cr-Commit-Position: refs/heads/master@{#302533}

Add a new FindTextData class to store the index to avoid all the size_t
to int casts.

BUG=416696

Review URL: https://codereview.chromium.org/691273003

Cr-Commit-Position: refs/heads/master@{#302532}

Review URL: https://codereview.chromium.org/690213004

Cr-Commit-Position: refs/heads/master@{#302531}

BUG=397019

Review URL: https://codereview.chromium.org/687323003

Cr-Commit-Position: refs/heads/master@{#302530}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=429837

Review URL: https://codereview.chromium.org/687723005

Cr-Commit-Position: refs/heads/master@{#302529}