- 18 Jul, 2017 40 commits
-
-
xiaochengh authored
This CL constructs the DOM-to-TextContent offset mapping of a block. It adds the following API: NGOffsetMappingResult NGInlineNode::BuildOffsetMapping() const; See ng_offset_mapping_result.h for information about NGOffsetMappingResult. See ng_inline_node_offset_mapping_test.cc for examples. Note 1: The patch can be made cleaner if we do not write whitespace-collapsed strings back to LayoutText after layout. Note 2: The built offset mapping is wrong when text-transform expands/removes characters (e.g., ß => SS) BUG=699017 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2963093002 Cr-Commit-Position: refs/heads/master@{#487489}
-
Geoff Lang authored
BUG=668223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Icaa5c0f7cf3130770d89b34eb46afbfd8379bee9 Reviewed-on: https://chromium-review.googlesource.com/574688Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487488}
-
Hector Dearman authored
After crrev.com/c/565510 the PID is received asynchronously after the start of a service. It is possible to get a dump request between the point when a client process is started and the point when the PID is received. In this case just temporarily skip that client's dumps. Bug: 744722 Change-Id: I69a70747408232063a1d57933d8d0ff985e153c9 Reviewed-on: https://chromium-review.googlesource.com/575127 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487487}
-
xunjieli authored
This CL adds a build flag (INCLUDE_TRANSPORT_SECURITY_STATE_PRELOAD_LIST) for //net embedders to configure whether to include the preload list (~258KiB) in their binary. BUG=603597 Review-Url: https://codereview.chromium.org/2906633003 Cr-Commit-Position: refs/heads/master@{#487486}
-
Daniel Bratell authored
MediaControlsImplTest and MediaControlsOrientationLockDelegate use the same class names for Mock classes. Such as MockChromeClient and StubLocalFrameClient. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the class names unique suffixes so that media_controls tests don't have to be excluded from jumbo. Bug: 745732 Change-Id: I6c3a4d5d92ae690ece53aa093ffb4039eb79137e Reviewed-on: https://chromium-review.googlesource.com/575140 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487485}
-
liberato@chromium.org authored
ContentVideoView uses both an alpha channel and a transparent background at the same time. AndroidOverlay will need only the former. Currently, they're set together in CompositorImpl. This CL separates them with SetRequiresAlphaChannel, and updates CVV callers to call both. Bug: 744706 Change-Id: I7c9e5d258e68fa35c7a5f8a611d942dc9c460389 Reviewed-on: https://chromium-review.googlesource.com/574640Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#487484}
-
Bernhard Bauer authored
The observer references in the UI config caused memory leaks after the bottom sheet was closed and (to a lesser extent) when cards were scrolled out of view. Also, drop thumbnail bitmaps from cards when they get recycled. This also avoids (non-discardable) references to bitmaps staying around after a comes stops being visible. Bug: 718925 Change-Id: I6e59dd6d68b559eeab63dc6e172c42eddf427e33 Reviewed-on: https://chromium-review.googlesource.com/574373 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#487483}
-
Quinten Yearsley authored
Bug: 710535 Change-Id: I6ce8350af1f1bad0ef1577b67b927381f1c4842f Reviewed-on: https://chromium-review.googlesource.com/575031Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#487482}
-
Gabriel Charette authored
This fixes hangs in https://codereview.chromium.org/2890853002/. New regression test hangs without matching test_browser_thread.cc changes. We support adding a TestBrowserThreadBundle on top of an explicit ScopedTaskEnvironment (i.e. to add named threads in unit tests that already otherwise inherit a ScopedTaskEnvironment or need to provide a custom one). However if the ScopedTaskEnvironment uses a QUEUED mode, trying to flush it in ~TestBrowserThreadBundle() results in a hang. Flushing TaskScheduler when it's not managed by that TestBrowserThreadBundle was wrong anyways. Bug: 708584, 689520 Change-Id: I3087537ad4f1065fc974170b00c25a676ff5e4c9 Reviewed-on: https://chromium-review.googlesource.com/575593Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#487481}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b56b94be..1c7f2213 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If56fcb26c5ecde062ad923553f459c55a6946f8a Reviewed-on: https://chromium-review.googlesource.com/575874Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487480}
-
Daniel Bratell authored
Both PresentationReceiverTest and RemotePlaybackTest use a local test class named MockEventListener. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes so that no tests have to be excluded from jumbo. Bug: 745732 Change-Id: Ic9a5e4e896b226d5ef7f99f2549cd3d4bb66fc42 Reviewed-on: https://chromium-review.googlesource.com/575141 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487479}
-
Etienne Pierre-Doray authored
This CL adds Zucchini utilities related to patch manipulation, along with tests. Details: - PatchHeader struct - ElementPatchHeader struct - Encode/Decode varint functions Bug: 729154 Change-Id: I081752542cb8b6ffe35c7dde079df70c19ca71e5 Reviewed-on: https://chromium-review.googlesource.com/572306 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#487478}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6fc5e4196940..26f2e66be57e $ git log 6fc5e4196..26f2e66be --date=short --no-merges --format='%ad %ae %s' 2017-07-18 perezju [devil] Replace logging with custom logger object Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I52a93ca2f43d12c86bdd9ed4022fb755cdf8517f Reviewed-on: https://chromium-review.googlesource.com/576052 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487477}
-
Becca Hughes authored
Add an internal WebUI interface at chrome://media-engagement for viewing scores stored in the Media Engagement service. BUG=734525 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9300479df06f48b98049026c9016084bd0abb902 Reviewed-on: https://chromium-review.googlesource.com/549297 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487476}
-
Daniel Bratell authored
Both AudioContextTest and BaseAudioContextTest use a local test class named MockWebAudioDevice. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes so that no tests have to be excluded from jumbo. Bug: 745732 Change-Id: Ie736a0541082c56af745d51061897a081d2d1da5 Reviewed-on: https://chromium-review.googlesource.com/575142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487475}
-
Mircea Trofin authored
Updated location of some dependencies; moved expected failures due to flag requirements to "NeverFixTests" Bug: Change-Id: I88d25a20b811ab8c8e9961aca3b77b79ec0cbcc1 Reviewed-on: https://chromium-review.googlesource.com/573141 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487474}
-
Peter Beverloo authored
OpenSplitModeExtensionOptionsPageIncognito flaked six times today, in builds 61651-61654, 61658 and 61659, e.g.: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61659 TBR=catmullings@chromium.org BUG=745729 Change-Id: I15a827faea250f5bbda74c791b2141f00df3d594 Reviewed-on: https://chromium-review.googlesource.com/575051 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#487473}
-
Jonathan authored
Some of the BrowserTest suite was flaky, and disabled. The various sources of the flakes have been since addressed. I'm turning them back on the FYI bot to verify. TBR=sky@chromium.org TEST=BrowserTest in mash_browser_tests Bug: 707195 Change-Id: I36f3bf2c98135842a68217b6bf2982065f9dec3b Reviewed-on: https://chromium-review.googlesource.com/574613 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#487472}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ffbc0d9a08f8..61a3cb81a298 $ git log ffbc0d9a0..61a3cb81a --date=short --no-merges --format='%ad %ae %s' 2017-07-18 dsinclair Roll third_party/freetype/src cf8d9b4ce..38bdf22bf (9 commits) Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I83441d830d700c984e5a77966740ec84c950be20 Reviewed-on: https://chromium-review.googlesource.com/576051 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487471}
-
Hidehiko Abe authored
This is preparation to remove MockCryptohomeClient, as preparation to replace Callback by OnceCallback in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: I77b9dfed9ce8662530e40e2dda085eb2852ae171 Reviewed-on: https://chromium-review.googlesource.com/569902 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#487470}
-
Christian Dullweber authored
Change-Id: Ifccf02402e0513c9e2c96dad335d05ab23b705ef Reviewed-on: https://chromium-review.googlesource.com/574919Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#487469}
-
Yipeng Wang authored
Bug: 683256 Change-Id: I7dc24bcae81a2ca43f3f82427d5b654b5ebe5b1f Reviewed-on: https://chromium-review.googlesource.com/575019Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#487468}
-
jdoerrie authored
This change renames |GetAffiliations| to |GetAffiliationsAndBranding| and also changes the name of related methods. Bug: 628988 Change-Id: Id3e38a209d63a8e07903eccf4005f70186b34a09 Reviewed-on: https://chromium-review.googlesource.com/574370 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#487467}
-
Primiano Tucci authored
Some developers seem to be hitting a DHCECK that suggests that two clients with the same PID reply to memory dumps. Temporarily removing the DCHECK while investigating as this seem to be hit at startup by some developers. BUG=744722 Change-Id: I82c06b424661110c31c26aea56420f177a23b237 Reviewed-on: https://chromium-review.googlesource.com/574854Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487466}
-
Alexandr Ilin authored
Navigation to chrome://predictors cause a crash if it's the first navigation after profile creation. The reason is that ResourcePrefetchPredictor is initialized only after the first commited navigation excluding a navigation to NTP. On the other hand, WebUI predictors handler doesn't check that the predictor was initialized before accessing the field that is nullptr in uninitialized state. This CL turns on the initialization of ResourcePrefetchPredictor after the navigation to NTP and adds a check for a uninitialized state in WebUI handler. Bug: 715525 Change-Id: I9382e892ce713d2b0beb406be344df64e2d5dd3d Reviewed-on: https://chromium-review.googlesource.com/575989 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487465}
-
Dan Elphick authored
On the way to creating a BackgroundFetchDelegate, factor out the thread-crossing and Core part of BackgroundFetchJobController into BackgroundFetchDelegateProxy. Ultimately this will have very little business logic but that will come in a follow-up. TBR=avi@chromium.org Change-Id: Iaa4cc9491a1758b8cd3c64a31cc41407c701ebaa Reviewed-on: https://chromium-review.googlesource.com/571801 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#487464}
-
Jinho Bang authored
This is an initial implementation of AbortPaymentEvent in WebIDL level. Related spec change: https://github.com/w3c/payment-handler/pull/170 Bug: 736745 Change-Id: I5cdf6b8e6a8019121aed4e10d33e884076bb519b Reviewed-on: https://chromium-review.googlesource.com/571345 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487463}
-
Vitalii Iarko authored
This CL adds SubscriptionManager interface and renames the current implementation to SubscriptionManagerImpl. Bug: 745383 Change-Id: I1cbbb2b77e987a1d300f5926ae5bef8d20839dc1 Reviewed-on: https://chromium-review.googlesource.com/576027Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487462}
-
Peter Marshall authored
We would like to increase the max string size in v8, but this test fails if we do so. The test generates a huge string as a response, which is then fed into a string object via v8::String::Concat in chunks. This works for the current string size but is slow (hence why the test is marked as 'Slow') but with an increased limit, this approach no longer works. V8 already includes a test in test-api.c -> StringConcatOverflow for the contract that Concat should return an empty handle rather than throw when the concat would produce a too-large string. Bug: v8:6148 Change-Id: I7879b0c5a284fea73273085a33ffb0722f8b70b7 Reviewed-on: https://chromium-review.googlesource.com/576089Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#487461}
-
Mark Cogan authored
This CL removes use of IDC_NEW_TAB and IDC_NEW_INCOGNITO_TAB. Call sites were already using NewTabCommand instead of the raw command_ids, but there were still plenty of plumbing changes needed to switch over to calling dispatcher methods. The commands are now split into a BrowserCommands method, -openNewTab:, and an ApplicationsCommands method, -switchModesAndOpenNewTab:. Both methods take a NewTabCommand as their argument. Since NewTabCommand includes a flag to indicate if an incognito tab should be opened, there's no separate methods for that. If the BVC gets an openNewTab: whose incognito-ness (incognition?) doesn't match the BVC, it sends -switchModesAndOpenNewTab: instead. The application command endpoint (MainController) then switches active BVCs and sends the newly-active one a new openNewTab: command on its dispatcher, passing the same NewTabCommand. BVC also exposed a special -newTab: method for various classes to use instead of sending tedious ChromeCommands. That's gone, and all of the callers of -newTab: now use openTab: on a dispatcher like everyone else. Removing -newTab: as a public BVC method meant some tests had to change, too. Tab now needs a dispatcher handed to it, so it can send commands. It only needs to do this for its ManageAccountsDelegate methods, so when they are moved out of Tab, the dispatcher can go away as well. It's not feasible to attach a dispatcher to each Tab as it's created, since that happens (ideally) outside of the UI layer where the dispatchers live. Thus, the BVC attaches a dispatcher to the tab in -installDelegatesForTab:. TabStripController, TabSwitcherController, TabSwitcherPanelController, and TabSwitcherPanelOverlayView all have a dispatcher plumbed into them. NewTabButton no longer sets its own target/action. It's only used in the Stack View, and should probably be moved into that directory. StackViewController now sets the right target/action on it. Menu items that have selectors defined -- that is, those that are triggering commands that will be sent via dispatcher -- now take care of sending those selectors themselves in an -executeCommandWithDispatcher: method. This means that the new tab menu items can take care of creating the necessary NewTabCommand internally. Bug: 738881 Change-Id: Ic63da24612906b5c9bfe7ef2bb92181233c8198c Reviewed-on: https://chromium-review.googlesource.com/567987 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#487460}
-
Jérôme Lebel authored
Simplyfing mediator API TBR=sdefresne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661794 Change-Id: Iee39a518e2f958a093467b5d1f1663a7210b33f8 Reviewed-on: https://chromium-review.googlesource.com/575969Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487459}
-
Daniel Bratell authored
NotificationDataTest, NotificationImageLoaderTest and NotificationResourceLoaderTest all use constants, such as kBaseDir, with the same name. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the constants will collide. This patch gives the constants unique prefixes so that the tests don't have to be excluded from jumbo. Change-Id: Ib01d88e75cdc876a58c52a6ee3b49a942ccb19ab Reviewed-on: https://chromium-review.googlesource.com/576088Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487458}
-
Bernhard Bauer authored
Bug: 728558 Change-Id: Ie0d82eba52ecbd0ba397c6b28f8a5bb33050a67b Reviewed-on: https://chromium-review.googlesource.com/570024 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#487457}
-
tzik authored
This CL removes all dependencies to BrowserThread::FILE in sync_file_system, and replaces them with base/task_scheduler's ones. Change-Id: Idd3ffb66d2d3079f3b6b680bde8b016d696ce268 Reviewed-on: https://chromium-review.googlesource.com/575735 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#487456}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/001e72263fee..0aa492d0f47d $ git log 001e72263..0aa492d0f --date=short --no-merges --format='%ad %ae %s' 2017-07-18 fmalita Remove leftover Android ctable reference Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I800af2f73eac7aa25ee0547be0d9e2c7fa03a9ee Reviewed-on: https://chromium-review.googlesource.com/576074Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487455}
-
Xiaocheng Hu authored
This patch changes the DCHECK of clean layout in TextIterator to CHECK, so that we can catch remaining lifecycle issues. Bug: 739060 Change-Id: I0ee0a152b438d3d8e1f97de0acd2844b190ef703 Reviewed-on: https://chromium-review.googlesource.com/575597Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487454}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7509b51..b56b94be Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If6c03cee3f7b37ffd47cedd93542aed163868261 Reviewed-on: https://chromium-review.googlesource.com/575833Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487453}
-
Jérôme Lebel authored
Removing 3 properties for metrics, all related to the access point value. Bug: 661794 Change-Id: I4f97831e1bf775d9c660d6658e6dfa3bf857260d Reviewed-on: https://chromium-review.googlesource.com/575137Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487452}
-
Mikhail Pozdnyakov authored
This patch brings following improvements: - Same call chain is used for actual Sensor state updating and for firing the events (i.e. no implicit Sensor state change on JS side) - All the pending notification is suppressed after Sensor has stopped (or an error has occurred) - Notification for initial reading Bug: Change-Id: Ia0505a4f51e17fbfaa8faa07602fff5618b8dc3d Reviewed-on: https://chromium-review.googlesource.com/559344Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#487451}
-
Xida Chen authored
These functions are called within the same class, no reason to be public. This is a pure clean up CL, no behavior change at all. TBR=junov@chromium.org Bug: None Change-Id: I26f87e53d6bab6c3cf71df2228db852087542c39 Reviewed-on: https://chromium-review.googlesource.com/575828Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487450}
-