- 19 Jul, 2018 40 commits
-
-
Tatsuhisa Yamaguchi authored
Test: ash_unittests --gtest_filter=TrayInfoLabelTest* Bug: 862116 Change-Id: Ifbedc4d656b1e5421f8a2b546d528378e56c6fc6 Reviewed-on: https://chromium-review.googlesource.com/1140019Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576377}
-
Jochen Eisinger authored
BUG=831073 R=qinmin@chromium.org,clamy@chromium.org Change-Id: I1c07cd89e06a8b15272ff862d237da5527288b7a Reviewed-on: https://chromium-review.googlesource.com/1138081Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576376}
-
Ramin Halavati authored
Clear browsing data preferences (browsing_data::prefs::*) are removed from incognito whitelist for persistent storage. The browsing_data preferences are used by Clear Browsing Data, which is only available in regular mode. Bug: 861722 Change-Id: I7835f8b1ad2a8b4a8b7bb72b99401b281823f313 Reviewed-on: https://chromium-review.googlesource.com/1141565 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576375}
-
Livvie Lin authored
This deletes code that references kRevertCertificateErrorDecisionsFieldTrialName, the experiment for clearing certificate exception decisions at the end of a session. This includes deleting all code for FORGET_SSL_EXCEPTION_DECISIONS_AT_SESSION_END since we decided to launch REMEMBER_SSL_EXCEPTION_DECISIONS_FOR_DELTA. Bug: 840045 Change-Id: I6ea2606a64c907e52215e20dc820b481ef28c114 Reviewed-on: https://chromium-review.googlesource.com/1142567 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#576374}
-
Tetsui Ohkubo authored
This CL stops showing slider bubble when main bubble is shown on any display. TEST=manual BUG=852866 Change-Id: I18e80b9ba480e88dd08bb10fe1b92adbeace7582 Reviewed-on: https://chromium-review.googlesource.com/1141556 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#576373}
-
John Z Wu authored
//ios/web_view does not need to mirror accounts. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I100f3005dd3d02dd03c5f8e730e4ce3daa492d62 Reviewed-on: https://chromium-review.googlesource.com/1142543Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576372}
-
Kunihiko Sakamoto authored
Spec side change: https://github.com/WICG/webpackage/pull/261 Bug: 803774 Change-Id: I0d0aa289b6f991b3cb09b2f53f6b1fbf752d2bbd Reviewed-on: https://chromium-review.googlesource.com/1142846Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#576371}
-
CJ DiMeglio authored
These calls were accidently misordered. |compositor_frame_sink_| needs to stick around for the completion of resource_provider_->OnContextLost(), as it uses the |compositor_frame_sink_| for DidDeleteSharedBitmap. TBR=junov@chromium.org Bug: 864657 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I24ace6f8766a2c4d9c77b359d61c4c4531b9b14e Reviewed-on: https://chromium-review.googlesource.com/1142827Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#576370}
-
sawtelle authored
This change addresses crbug 856251 and allows for strings to be passed through the call stack when a custom control is clicked. Currently this is not being used, but in the future this plumbing will be connected to developer-defined custom controls that have unique ids. Bug: 856251 Change-Id: Ie8305104d677afcccf3223a1fabb94a9f376710e Reviewed-on: https://chromium-review.googlesource.com/1119082 Commit-Queue: Steven Sawtelle <sawtelle@google.com> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#576369}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL removes all remaining traces of GYP Closure Compilation. This includes: - all compiled_resources2.gyp files from ui/webui - all PRESUBMITs that add the closure_compilation bot - the closure_compilation bot in all build systems - some GYP tooling that is only used for closure compilation builders TBR=sashab@chromium.org Bug: 632206 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ief58c91d43ed859d5b4022dd30e7d5507dd7909b Reviewed-on: https://chromium-review.googlesource.com/1051144 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576368}
-
Jialiu Lin authored
When Chrome gets password protection verdicts from Safe Browsing, we'd like to log the referrer chain size by verdict type. Bug: 864608 Change-Id: If11cd732c6c45865a64bfbbccf71af4615b148f9 Reviewed-on: https://chromium-review.googlesource.com/1141179 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576367}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8364706c02c6..b423247bc239 git log 8364706c02c6..b423247bc239 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-18 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-18 bungeman@google.com Revert "Reland "Add some optimizations to PolyUtils"" 2018-07-18 bungeman@google.com Revert "Add kAAHairline to GpuPathRenderers" 2018-07-18 herb@google.com Redo drawTextRSXForm for glyph runs Created with: gclient setdep -r src/third_party/skia@b423247bc239 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Icb0154d88fbbf49e2a373da2a1328276c4b344dc Reviewed-on: https://chromium-review.googlesource.com/1142904Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576366}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/664261cb3f4d..bb5cc39baf68 Created with: gclient setdep -r src-internal@bb5cc39baf68 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:859120 TBR=mmoss@chromium.org Change-Id: Ie91bd8caf414aa42df3c8e99c72e3926da3af62f Reviewed-on: https://chromium-review.googlesource.com/1142017Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576365}
-
Timothy Loh authored
This CL adds basic support for installing .deb files from within the file manager. An "Install with Linux (Beta)" task is added for .deb files, which will open a confirmation dialog when selected. A future CL will expand this dialog to retrieve and display detailed information about the package, such as name, version, and a description. For successfully started installations, progress will be displayed in a notification (similar to e.g. file downloads). This patch only adds the file handler to .deb files that are selected individually and already in the container. In a subsequent patch, we should expand this so we can show an appropriate error message when selecting multiple .deb files, or files outside the container. TBR=benwells Bug: 822464 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1cfb84491134e0911ad53a488a02a7479d78d299 Reviewed-on: https://chromium-review.googlesource.com/1126812 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#576364}
-
Takayoshi Kochi authored
Remove myself from script WATCHLISTS. TBR=kouhei@chromium.org NOTRY=true Change-Id: I64ce436981cbf3c3882dc4207d286b27d00534f1 Reviewed-on: https://chromium-review.googlesource.com/1142859Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576363}
-
Sasha Morrissey authored
Hide the modified date for Team Drives, since it's always set to 1st Jan 1970. In a later patch, we will update it to the correct date. Bug: 861622 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7be57d16fedf62c07cb0eb7bf3e2e32cf01ccaf6 Reviewed-on: https://chromium-review.googlesource.com/1141459 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#576362}
-
Yutaka Hirano authored
Tbr: mlamouri@chromium.org No-Try: true Bug: 865262 Change-Id: I8b4e49744783c45c84a80fe1560e4e21133f4d0e Reviewed-on: https://chromium-review.googlesource.com/1142858Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576361}
-
Sergey Ulanov authored
Previously headless ozone platform was used on Fuchsia. Switched it to scenic. content_unittests fail with scenic, so this change also adds --ozone-platforms=headless flag in the unittests, until this issue is resolved. Bug: 829980, 865172 Change-Id: I8a0b282953cf90554dc78ed1575d927b53374c58 Reviewed-on: https://chromium-review.googlesource.com/1142492Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576360}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf7e4982. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21542 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=foolip No-Export: true Change-Id: I1ca56fbb3904ee198c0b969f1187ddbcc145cb8b Reviewed-on: https://chromium-review.googlesource.com/1142744 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576359}
-
Peter Boström authored
Instantly hides or shows the IconLabelBubbleView separator when focus rings are available to prevent showing the separator when a focus ring overlaps it. Bug: chromium:865029 Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99 Reviewed-on: https://chromium-review.googlesource.com/1142442 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#576358}
-
Ned Nguyen authored
Bug: 865247 Change-Id: I9913d1610ae0c8733e9839da3d885ac754fe5984 Reviewed-on: https://chromium-review.googlesource.com/1142598Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#576357}
-
Esmael El-Moslimany authored
Bug: 863145 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia8b82930d525b9ba3eee1e3332da1d5e35809131 Reviewed-on: https://chromium-review.googlesource.com/1141220 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576356}
-
Peter Boström authored
Under Refresh there's no top border drawn by the tabstrip. As such the three other strokes that form the content border look cut off and out of place. This change removes them when Refresh is turned on. Bug: chromium:848549 Change-Id: If77903b5b275f6d0deee6d22d88a3725885137f2 Reviewed-on: https://chromium-review.googlesource.com/1132543 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#576355}
-
Makoto Shimazu authored
When starting a new shared worker, RendererPreferences is passed from the browser to the renderer. This preference is used to reflect DNT header and referrer for requests from shared workers. Bug: 853085 Change-Id: Ie369a3ec513ffd16ba8a3f4b6a28061e6e1e83c0 Reviewed-on: https://chromium-review.googlesource.com/1135107 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576354}
-
Fady Samuel authored
Add some methods to allow printing out SurfaceRanges. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I363a64ae45961897f031c7dc0379d21462af29a5 Reviewed-on: https://chromium-review.googlesource.com/1142512Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576353}
-
Esmael El-Moslimany authored
After removing a site, the next site is focused with a single tab press. Bug: 740046 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifcd05b623e1f98361b9dc14e0ed2c41c4889f876 Reviewed-on: https://chromium-review.googlesource.com/1141360Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#576352}
-
Sky Malice authored
Feed component adds a significant amount of code that's not used yet for users. See Feed DEPS rolls for current size impact. This change also fixes some areas outside of components/feed/ that were assuming Feed was always compiled in on Android. TBR=gab@chromium.org Change-Id: I72944b4518388ee650f9fd0c444d52b9ddcc23b7 Reviewed-on: https://chromium-review.googlesource.com/1142296 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#576351}
-
Clark DuVall authored
This will be used in URLLoaderFactoryGetter::FlushNetworkInterfaceForTesting to prevent nested IO message loops. Hit this in https://chromium-review.googlesource.com/c/chromium/src/+/1139048. Bug: 857577 Change-Id: I1b6a53f39737ff0a6d4681b4256991569b91a2d5 Reviewed-on: https://chromium-review.googlesource.com/1142198 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576350}
-
Kenneth Russell authored
conformance/textures/misc/tex-video-using-tex-unit-non-zero.html is failing intermittently on all platforms. Going to rewrite the test for better correctness and improve its diagnostics. Bug: 830901 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ice9efc8cdcff75753bfd64c231dafc7c7a154790 Tbr: cwallez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1142698Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576349}
-
kristipark authored
In order to prevent private information from being leaked to third- party NTPs, information related to editing/adding links will be contained in an iframe. Once the user finishes editing, the information will be sent to the EmbeddedSearchAPI and ultimately be received by the Most Visited iframe by querying EmbeddedSearchAPI with the specified rid. Screenshot: https://screenshot.googleplex.com/FcYM4VCiu3c.png Design Doc: go/chrome-ntp-custom-links Bug: 851293, 865071 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I06f4449f9c3764c5d797b83acbc7c97e6903b787 Reviewed-on: https://chromium-review.googlesource.com/1139108Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#576348}
-
Jesse Selover authored
Work towards consolidating privacy load flags into the single allow_credentials field. In the first stage of this migration, we'll migrate all existing usages of the load flags to the new API, which will force them to all have the same value. This CL just creates the new API and one usage of it (in report_sender.cc). Bug: 799935 Change-Id: Iaec1fa8455d93f234a2d3be11c3b9c5b4d71228f Reviewed-on: https://chromium-review.googlesource.com/1134026 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#576347}
-
Wenzhao Zang authored
This CL is a combination of small changes based on the meeting with PM and UX, It includes: 1) Disable daily refresh when another wallpaper is selected. 2) Make the entire area of daily refresh thumbnail clickable. 3) Add shadow to preview top bar and selected thumbnails. 4) Adjust spacing for buttons in current wallpaper info bar. 5) Switch the colors for enabled/disabled states for the buttons. 6) Change the color of the button text. 7) Prevent restoring the previous active windows in tablet mode after the picker closes (i.e. continue to show the new wallpaper or home launcher). 8) Hide scroll bar if there's no scroll event after a timeout. Bug: 863491 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id0aa1913f2bb0820909d7c714805cb723426a316 Reviewed-on: https://chromium-review.googlesource.com/1137486Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#576346}
-
Matt Falkenhagen authored
Also expand on documentation. Rationale: * This interface is the counterpart of ServiceWorkerHost. * It's the initial/master interface for the message pipe for talking to a service worker from the browser, that other interfaces are associated with. So it deserves a more important-sounding name. * It does more than dispatch events already. * This was apparently the original plan in https://docs.google.com/document/d/1FxFISiZKBH2MALypxt-aoGAbmyco-7kEMi1zMe5KrzE/edit Bug: 629701 Change-Id: Iab5969fa60d308300b3fcd8dada4fcca1ddc18b2 Reviewed-on: https://chromium-review.googlesource.com/1142704Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576345}
-
Ted Meyer authored
fuchsia should no longer be racing and taking a page fault on IP. Bug: 864018 Change-Id: I07a21cbc80944822ceb3dcc12cfc39f8978d677c Reviewed-on: https://chromium-review.googlesource.com/1141353 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576344}
-
Chris Harrelson authored
Partial re-land: [IO] Only compute intersection observations if any property tree state has changed, and only for full-frame updates. This CL includes only the refactoring aspect of the original CL, not the part about avoiding intersection observations when possible. Bug: 831762 Change-Id: I6dd2786e61faedd4b3b6fdedc0f6d3080b4a9bf1 Reviewed-on: https://chromium-review.googlesource.com/1141065Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576343}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iaf213e06847c17b38a8742207815062a7c20e5b3 Reviewed-on: https://chromium-review.googlesource.com/1142603Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576342}
-
Kyle Milka authored
Bug: 850701 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iff3f58b719a71e089bd821f030a8345af2620b98 Reviewed-on: https://chromium-review.googlesource.com/1125266 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576341}
-
Dominick Ng authored
This ensures that users holding down the Enter or Space key cannot accidentally trigger an external protocol launch. BUG=865202 Change-Id: I2cec7b3c216b80641200c97dec2517a66b4e0b24 Reviewed-on: https://chromium-review.googlesource.com/1142705 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576340}
-
Travis Skare authored
Bug: 864302 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibe9a8fdf1ae1c9eb1ef401d3f667f261a76ef65d Reviewed-on: https://chromium-review.googlesource.com/1069735 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#576339}
-
Dominick Ng authored
This CL removes the chromeos::AppType enum in favour of the newly introduced apps::mojom::AppType. This new enum is defined in the App Service and will be used for all app types going forward. This CL also makes a number of changes with the eventual aim of cleanly separating ARC dependencies out of AppsNavigationThrottle. These changes include: * moving page_transition_util.{_unittest.cc,cc,h} from components/arc to chrome/browser/chromeos/apps, and removing redundant includes * moving the IntentPickerResponseCallback to apps_navigation_types.h The next CL will refactor and rename ArcNavigationThrottle and AppsNavigationThrottle to encapsulate Chrome OS-only functionality more cleanly. This will allow AppsNavigationThrottle to be moved to chrome/browser/apps and reused on non-Chrome OS platforms where only desktop PWAs will be supported. BUG=853604 Change-Id: Icd8f6607dc7d1e7419564b06481031136e270553 Reviewed-on: https://chromium-review.googlesource.com/1139939 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576338}
-