GitLab

Reason for revert:

Causes a slew of devtools failures: 
17:18] <mpearson> http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(1) 
[17:18] <mpearson> http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(1) 
[17:19] <mpearson> http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%20ChromiumOS%20Ozone%20Tests%20(2) 
[17:19] == tapted_ [~tapted@121.211.79.93] has quit [Quit: tapted_] 
[17:19] <mpearson> http://build.chromium.org/p/chromium.win/waterfall?builder=Vista%20Tests%20(1) 



failed 4 
stdio 
TestConsoleOnNavigateBack 
TestDeviceEmulation 
TestNetworkSyncSize 
TestScriptsTabIsPopulatedOnInspectedPageRefresh 

browser_tests 
browser_tests 

> Blink roll 178929:178950
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178950&mode=html
> TBR=haraken@chromium.org,jchaffraix@chromium.org
> BUG=
> 
> Review URL: https://codereview.chromium.org/417293002

TBR=blink-deps-roller@chromium.org

Review URL: https://codereview.chromium.org/424483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285739 0039d316-1c4b-4281-b951-d872f2087c98

Previously the host and client were running on the main thread, so they
both would compete for it and that skews the perf numbers, particularly
with NSS SSL sockets because they use a separate thread.

BUG=394067
R=rmsousa@chromium.org

Review URL: https://codereview.chromium.org/414443009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/420553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285737 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/382633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285735 0039d316-1c4b-4281-b951-d872f2087c98

scottmg told me to do this.

> Block on LaunchProcess failing on specific bot
> 
> Block in a loop if we get a specific failure on a particular bot.
> See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference.
> 
> Timeout raise attempted at https://codereview.chromium.org/410353004/ so
> that there will be time to attach a debugger.
> 
> R=brettw@chromium.org
> BUG=340422
> 
> Review URL: https://codereview.chromium.org/411223002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/414363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285734 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/415773009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285730 0039d316-1c4b-4281-b951-d872f2087c98

time. In particular, do not call XConvertSelection() till SelectionNotify is
received for the current request (or the current request has timed out).

This is part #1 of implementing support for receiving selection data in multiple
chunks via the INCR property. In particular, when data is transmitted via the
INCR property, the transmission is not complete when the SelectionNotify event
is received.

BUG=367549
TEST=None

Review URL: https://codereview.chromium.org/391593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285729 0039d316-1c4b-4281-b951-d872f2087c98

- Fix menu bg asset to properly allow the menu to overlap the anchor
- Turn on dismiss button in menu
- Fix some animation code related to the dismiss button in the menu
- Make overlapping an RTL item work properly

BUG=394898
NOTRY=true

Review URL: https://codereview.chromium.org/419673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/411143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285727 0039d316-1c4b-4281-b951-d872f2087c98

There may be more than one favicon if loading an extension favicon,
which loads for all supported scale factors immediately rather than
in an as-needed fashion.

BUG=397341

Review URL: https://codereview.chromium.org/421633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285725 0039d316-1c4b-4281-b951-d872f2087c98

Since ozone builds removed X11, they get identified as "unknown" in the user agent string and as a result calendar and potentially other things don't work.

This CL brings identification back in line with other linux builds.

BUG=394335

Review URL: https://codereview.chromium.org/394233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380313

Review URL: https://codereview.chromium.org/417043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=asvitkine@chromium.org, isherman@chromium.org, thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/365253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285722 0039d316-1c4b-4281-b951-d872f2087c98

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285446

Review URL: https://codereview.chromium.org/418723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=279351
TBR=armansito@chromium.org

Review URL: https://codereview.chromium.org/419683010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285720 0039d316-1c4b-4281-b951-d872f2087c98

Apparently, OS X allows commas as separators between hostnames in the hosts
file. Treat commas the same as whitespace to support this. (Hostnames and IP
addresses will never contain commas, so this shouldn't break anything.)

BUG=396309

Review URL: https://codereview.chromium.org/415153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285718 0039d316-1c4b-4281-b951-d872f2087c98

Current host warning "Read and modify your data .." should say "Read and change your data .." to maintain consistency with other strings.

As part of the overall effort to cleap up extensions/app warnings we need to ensure the consistency of the wording. All write access should say "change", thus this CL fixes this for hosts permission.

BUG=386224
R=jww

Review URL: https://codereview.chromium.org/415293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285717 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke a ton of tests:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14823

Original issue's description:
> Run android tests through runtest.py.
> 
> BUG=329102
> R=qyearsley@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285667

TBR=qyearsley@chromium.org,jbudorick@chromium.org,klundberg@chromium.org,navabi@chromium.org,yfriedman@chromium.org,eseidel@chromium.org,zty@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329102

Review URL: https://codereview.chromium.org/423593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285716 0039d316-1c4b-4281-b951-d872f2087c98

app_host.exe was removed in r220555. This change removes some dead code
that was left behind. Specifically:
- chrome_launcher_support no longer exposes any methods related to the
  AppHost.
- Chrome's uninstall prompt no longer has a special case to handle
  suppressing the "delete your profile" checkbox.
- Chrome and its installer no longer have a dependency on
  launcher_support.
- The installer no longer supports installing items from the webstore.
- GetUntrustedDataValue no longer has consumers and is gone.

BUG=297647
R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org
TBR=grt@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/419913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396785
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/417813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285714 0039d316-1c4b-4281-b951-d872f2087c98

The original revert can not be done in isolation. There are dependent
changes in Blink. This revert broke all of the tests on the GPU bots
and likely tests on other bots. Undoing the revert.

> Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (https://codereview.chromium.org/403273003/)
> 
> Reason for revert:
> It broke the component builds.
> 
> Original issue's description:
> > Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2
> > 
> > Blink should make use of blink_resources.grd for the inline resources of inspector.
> > This removes the dependency upon using xxd.py which embeds these resources as strings.
> > 
> > Part 1: https://crrev.com/401233003
> > Part 3: https://crrev.com/402033002
> > 
> > BUG=312586
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436
> 
> TBR=jochen@chromium.org,abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=312586
> 
> Review URL: https://codereview.chromium.org/421623004

TBR=aurimas@chromium.org

Review URL: https://codereview.chromium.org/420923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285713 0039d316-1c4b-4281-b951-d872f2087c98

We need to support this new hidden api to avoid onDraw getting ahead of
DrawGL. Without this, onDraw can finish producing frame n+1 before DrawGL
consumes frame n, in which case DrawGL skips a frame.

Also make AwDrawGLInfo future proof.

BUG=397358

Review URL: https://codereview.chromium.org/414163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285712 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA to report the type of net error that occurred
when the data reduction proxy probe failed due to a
network error. Note the probe can also fail due to
the response being modified, which this UMA does not
track.

BUG=397256

Review URL: https://codereview.chromium.org/417253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397693
TBR=gab@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/422433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285710 0039d316-1c4b-4281-b951-d872f2087c98

Also add a |GetArray()| method to |UserPointer<>|.

And fix a bug in my previous change to convert ReadMessage...() (which
I'm too lazy to update) in |PutArray()|. (And also "restore"/convert one
of the ReadMessage...() tests ... which lead me to finding that bug.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/419973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285709 0039d316-1c4b-4281-b951-d872f2087c98

In record_wpr, we did the following:

  temp_target_wpr_file_path = tempfile.mkstemp()[1]

In python, tempfile.mkstemp() will return a tuple containing the file handle and the file path. Since the script never closes this file handle, it looks like we throw a WindowsError when we try to move the file with the open file handle.

BUG=

Review URL: https://codereview.chromium.org/420893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395154

Review URL: https://codereview.chromium.org/410713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285707 0039d316-1c4b-4281-b951-d872f2087c98

Causes compile failures on official builders:

e.g.,
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/

FAILED: ninja -t msvc -e environment.x64 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj.rsp /c ..\..\chrome\installer\util\chrome_app_host_distribution.cc /Foobj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj /Fdobj\chrome\installer_util_nacl_win64.cc.pdb 
c:\b\build\slave\google-chrome-rel-win\build\src\chrome\installer\util\chrome_app_host_distribution.cc(126) :error C2065: 'kChromeAppHostGuid' : undeclared identifier
ninja: build stopped: subcommand failed.


> Remove some dead app host code.
> 
> app_host.exe was removed in r220555. This change removes some dead code
> that was left behind. Specifically:
> - chrome_launcher_support no longer exposes any methods related to the
>   AppHost.
> - Chrome's uninstall prompt no longer has a special case to handle
>   suppressing the "delete your profile" checkbox.
> - Chrome and its installer no longer have a dependency on
>   launcher_support.
> - The installer no longer supports installing items from the webstore.
> - GetUntrustedDataValue no longer has consumers and is gone.
> 
> BUG=297647
> R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org
> 
> Review URL: https://codereview.chromium.org/422453004

TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/422593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285706 0039d316-1c4b-4281-b951-d872f2087c98

The state is now taken from the label with the instructions within the bookmark bar.
Now an empty bookmark bar's label is accessible.

BUG=395895

Review URL: https://codereview.chromium.org/408103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/420663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285703 0039d316-1c4b-4281-b951-d872f2087c98

Also add a |PutArray()| method to |UserPointer<>|.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/417303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285702 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (https://codereview.chromium.org/403273003/)

Reason for revert:
It broke the component builds.

Original issue's description:
> Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2
> 
> Blink should make use of blink_resources.grd for the inline resources of inspector.
> This removes the dependency upon using xxd.py which embeds these resources as strings.
> 
> Part 1: https://crrev.com/401233003
> Part 3: https://crrev.com/402033002
> 
> BUG=312586
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436

TBR=jochen@chromium.org,abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=312586

Review URL: https://codereview.chromium.org/421623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285701 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285700 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178950&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/417933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285696 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the sync_unit_tests target so it no longer uses strange
export_dependent_settings hacks.  Rather than creating three separate
targets with type 'none' and having the sync_unit_tests target depend on
them, the new setup just puts those dependencies and sources in the
sync_unit_tests target directly.

BUG=397574

Review URL: https://codereview.chromium.org/418163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285695 0039d316-1c4b-4281-b951-d872f2087c98

This has no functional change, but prepares the field for allowing the Mac
to use a different TaskRunner which will allow pumping during resize.

BUG=392031

Review URL: https://codereview.chromium.org/421483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285694 0039d316-1c4b-4281-b951-d872f2087c98

Now when double tapping with no last touch exploration location, the tap timer is no longer fired, which was previously entering no fingers down state when a finger was actually down.

TEST=TouchExplorationTest.DoubleTapNoTouchExplore
BUG=397296

Review URL: https://codereview.chromium.org/419923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285693 0039d316-1c4b-4281-b951-d872f2087c98

This CL turns const by value return values into const by ref.

Replacing const value by a const ref when a member variable is returned
is safe, because the member variable will live at least as long as the
temporary object returned now. It can also be more efficient, because
returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/423483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285691 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285690 0039d316-1c4b-4281-b951-d872f2087c98