- 04 Dec, 2019 40 commits
-
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mohsen@chromium.org Bug: 1023677 Change-Id: Ibc5d9625d2e2c08177b4fed8e03fe06370910ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925463 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721737}
-
Lei Zhang authored
In base::File, |file_| is a ScopedPlatformFile. So add constructors that can take a ScopedPlatformFile directly, instead of having the caller release the PlatformFile, and then rewrapping it. Change-Id: Ie70cacc0a47263ff9ec5ce38f84032f1e469faa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948195Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721736}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=loonybear@chromium.org Bug: 1023677 Change-Id: I61b6638bcefb958cab0079adfc40c1378321e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927058 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#721735}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 457ad5ab. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" a93be69b "Update reversing-an-animation test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I78951794b58a7cb400743e107a6f78b08a828a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950889Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721734}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 1023677 Change-Id: I754c80d5f281438539432343841ff3a251b90283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926922 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/f54082a0145f..d58736db7b79 $ git log f54082a01..e62e63cbd --date=short --no-merges --format='%ad %ae %s' 2019-11-27 fayang gfe-relnote: Use HandshakerDelegateInterface in QUIC handshakers. Abstract keys installation, keys discarding, default encryption level change and mark handshake complete to HandshakerDelegateInterface. Protected by gfe2_reloadable_flag_quic_use_handshaker_delegate. 2019-11-27 bnc Enforce header list size limit in QpackDecodedHeadersAccumulator. 2019-11-27 bnc Rename qpack_constants.* to qpack_instructions.*. 2019-11-27 renjietang Switch the order of QPACK streams sending stream type. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I9b46c079f94def86e82d0abc19b556ab63771b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949151 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721732}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75a7e95c6f5c..460dca5483db Created with: gclient setdep -r src-internal@460dca5483db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029105,chromium:915409,chromium:966792 Tbr: jbudorick@google.com Change-Id: I38909a96b0895d77694bdf49e0f7956809a42aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951766Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721731}
-
Toni Barzic authored
Adds 16 dip margin between page switcher and the app list view right edge - this effectively changes the minimal apps grid margin from the app list view edge to 56 dip (8 dip margin between apps grid and page switcher, 32 dip page switcher width, 16 dip between page switcher and app list view edge). Updates the the threshold at which the app list contents margin changes between 1/16 of the screen width and 1/12 of the screen width from 600 dip to 896 dip (which is the width at which the minimal apps grid horizontal margin would not fit into 1/16 of the screen width). Moves the margin calculation code to app list config, so it can be reused between apps container view (to calculate the apps container layout) and contents view (to calculate search box width). Along the way fix search box width calculation to respect the minimal search box width of 440 dip. BUG=1028332 Change-Id: I5ebb105775fc24a1e94c10011e7dc9f968e0ddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941197 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721730}
-
Ken Rockot authored
This sticks a Content Service instance directly in each BrowserContext rather than having them owned indirectly by BrowserContext via Service Manager APIs. The two existing uses are refactored to get NavigableContentsFactory receivers bound directly through the BrowserContext rather than using a Service Manager Connector. Bug: 977637 Change-Id: I4a3e41235e15a8b93973f152e8313d8612bfc290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931444 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Brandon Wylie authored
This is a reland of a59a4ff3 Original change's description: > Visually scale down the size of the Google G logo in the omnibox > > Bug: 1020774 > Change-Id: I48b32fdfbcf4dc2a20ba047ee3f93783f4fa2a38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918047 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718931} Bug: 1020774 Change-Id: I27aa92db055e39570f8ba0099d5c54bf22236194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946849Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721728}
-
Caroline Rising authored
Fix bug where the wrong color is shown for tab hover cards after switching between system light/dark modes. The fade label child views are set to be ignored by tab hover card layout. This means the background color is not updated for these labels after creation. This change update the color before an animation would take place. Bug: 1030328 Change-Id: I8204978fc8983f4ff4b3cc02922a0401cf039244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951090 Commit-Queue: Caroline Rising <corising@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#721727}
-
Ken Rockot authored
Child processes send a message to BrowserChildProcessHostImpl to have the host register Resource Coordinator client pipes on their behalf. The implementation of this message accesses the corresponding ChildProcessLauncher's PID indiscriminately. Meanwhile the process may have died by the time the message is actually dispatched, and it's invalid to access that PID after process termination. While this race doesn't seem to affect security or stability of production code in practice, it does cause browser tests to hit a DCHECK on PID access, causing fairly common flake. This fixes the race by ensuring the Process is still valid before attempting to grab its PID. Fixed: 1029627 Change-Id: I3f8eb6e9f6cd5c94c4011b76446e7fce63c0d12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944618Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#721726}
-
John Z Wu authored
This will be used in CWVAutofillController to handle forms found in the page. Bug: 1030451 Change-Id: I2224e8ed65074bf0c4658db5a3e5016c3d13d36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949299 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721725}
-
Sean Kau authored
BrowserNonClientFrameViewTabbedTest.HitTestsTabStrip was disabled due to flakiness caused by a class that was not properly cleaned up between tests. This issue has now been resolved and this test is being re-enabled. Still flaky for TSAN. Updated TODO to reflect the TSAN bug. Bug: 1015949 Change-Id: I3ecbc316369742ab40cf5abba7ea8f247dff8d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951650 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721724}
-
Sammie Quon authored
See bug for screencast. The bug was caused because even if a finger is idle, we still get miniscule event location and scroll updates. For example, a log I got had something like: scroll: 0.1875, -0.1875, 0.325, -0.325 etc while my finger was stationary. To prevent this, add up the scrolls and update the grid once they reach a threshold, which i choose 1. Test: manual Change-Id: I206ca709b11c82dd108a6655792279cdf8404163 Fixed: 1030724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951964Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721723}
-
Peter Kotwicz authored
This CL: - merges the WebAPK/CCT browser control visibility logic - merges the WebAPK/CCT close button visibility logic BUG=991079 Change-Id: I6f955a584a6cc33709d00aecb028ea52552b28d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902483 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#721722}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/db3c93975a8f..dadf12a4bd9c git log db3c93975a8f..dadf12a4bd9c --date=short --first-parent --format='%ad %ae %s' 2019-12-04 rharrison@google.com Remove unused variable from C++ API (#926) Created with: gclient setdep -r src/third_party/shaderc/src@dadf12a4bd9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I3fca8800f8c28c00779aa29e269772c334952d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721721}
-
Garrett Beaty authored
This is a reland of b46672aa Added branched versions of triggered builders that aren't present in the mirror configuration for the waterfall try builders. Original change's description: > Add branched versions of Phase B CI builders. > > All branch CI builders have been moved to be scheduled once per day. As > we get capacity and get the builds into a good state, we will move them > to be continuously triggered. > > Bug: 1024641, 922150 > Change-Id: Ie066240907dd581175c94cbca431e5a6bf37deb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948050 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721218} Bug: 1024641, 922150 Change-Id: I93f158401e8a741439c16f069f6936cdb198f03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951331Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#721720}
-
Kevin McNee authored
BrowserPlugin is being removed, so this event resending code is dead. Bug: 533069 Change-Id: Ieb5d2e14671621dcb1d85646f3d12887f8c3d68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951332Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721719}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=maybelle@chromium.org Bug: 891670 Change-Id: I53fe47639f2f146806d52791fc7d34b8fd5d8221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944670 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/024cbe1befe1..391d4f3130da git log 024cbe1befe1..391d4f3130da --date=short --first-parent --format='%ad %ae %s' 2019-12-04 tsepez@chromium.org Remove #ifdef around right-button methods in fpdf_view_c_api_test.c 2019-12-04 tsepez@chromium.org Expose FORM_OnRButton{Down,Up} to non-XFA builds Created with: gclient setdep -r src/third_party/pdfium@391d4f3130da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia43b81e53d114f53b60cd6bff59b29a24c99fbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951656Reviewed-by:
-
David Dorwin authored
Bug: 973095 Change-Id: Ic0f0dffdaf16a4a024e08a08ea3daa811d8e192c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935156Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721716}
-
Anushruth authored
Some builds take more than 3 hours leading to timeout of almost complete builds. Extend timeout until the builds are faster. R=bpastene@google.com Bug: 1030593 Change-Id: I4c85e14abfe1613e1f6908f175cbfaf1b8e91214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951091Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#721715}
-
Christopher Cameron authored
It's unlikely that CoreAnimation remains a power win when we get to many layers, because of how we reconstruct the CALayer tree. Further, when we get to ~20k layers, we start seeing corruption. Bug: 1022116, 1024110, 835395 Change-Id: If74cd2b0d80c11dabf050be160d7eee3fb81e274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951659Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721714}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/53782d60dc73..42b3b9c4131a git log 53782d60dc73..42b3b9c4131a --date=short --first-parent --format='%ad %ae %s' 2019-12-04 rharrison@chromium.org Plumb UseSpvc toggle for tests Created with: gclient setdep -r src/third_party/dawn@42b3b9c4131a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I35a4c44e8f6a5896e08b84d6f59d755f39b1e42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951341Reviewed-by:
-
Joe DeBlasio authored
This CL removes the 'ignore' button on Safety Tips. UX folks felt that this would be clearer and more consistent with existing patterns. Both the infobar (mobile) and bubble (desktop) variants have dedicated close (X) buttons that do the same thing. This leaves them looking like this: Desktop: https://drive.google.com/open?id=1e3UlzRa0g4kzr5p1-8dCO7Hfec3rWho7 Android: https://drive.google.com/open?id=19OGdgjZsQ4khNErmG_W160vlhQrvDiz6 Bug: 1030171 Change-Id: I906751b7ceb7b5023ae9ebaf5eea957ce220f51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948248Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#721712}
-
Mounir Lamouri authored
It avoids triggering callbacks that end up being no-ops and limit it to situations where the observer would actually do something about it. Bug: 1028822 Change-Id: I7982f74d5791277e181e63e91c0f9f076586717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949561Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#721711}
-
Lei Zhang authored
Most of them are not necessary at all. One spot has parameters shadowing member variables. Fix this by renaming the parameters. Change-Id: I16c13588d40269d5c18bfe8877af31abc3ac5516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947828Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721710}
-
Chris Lu authored
This change hooks up the selection of languages in this ViewController to trigger InfobarTranslateLanguageSelectionDelegate calls in the TranslateMediator. This will result in the Translate InfobarModal to be updated with the new language selected. The new language will be temporarily stored in the mediator. Only when the user taps on the Translate button will the InfobarDelegate be updated with the new language. To show the current source/target language in the ViewController, TableViewTextItem is given a new checked property for the mediator to set before sending up the items to the ViewController. A isMovingFromParentViewController check is also made in viewDidDisappear in InfobarTranslateTableViewController so that it doesn't call modalInfobarWasDismissed: when the user is trying to change languages. Bug: 1014959 Change-Id: If4374caac153673ac04618663994811a00dc76b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942672 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721709}
-
Evan Stade authored
WebLayer uses the same implementation as WebView. What it lacks compared to Clank is just metrics. That is, the parts of //chrome/browser/spellchecker that Clank actually uses are purely metrics as the spelling service is not enabled for Clank. Implementing spellcheck for desktop would require refactoring a lot of //chrome/browser/spellchecker. Bug: 1025621 Change-Id: I186f78c08d97267cb8d55e55adff952018293840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929494 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#721708}
-
tby authored
After more investigation of which devices logged URLs will be coming from, it's unlikely we'll be getting useful signal from the chromebook itself. So let's disable URL logging altogether. This CL: 1. Disables URL navigation logging. 2. Redacts any existing URLs in saved protos. Bug: 1012936 Change-Id: Ie96191ea6b0be47f7a2adbb29b80cc3b693f7844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947614Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#721707}
-
Matthew Denton authored
Change-Id: Iec9b00fb28f5d94900da086cefdb556bd1c31a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949848 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721706}
-
Connie Wan authored
See attached bug for screencast. Confirmed with UX that the highlight should only appear on drag, not hover. Bug: 1017822 Change-Id: I0921f5cf425d82c25344adb4801de6de8746f771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929490Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#721705}
-
Tim Song authored
This regression was caused by refactoring the delegate in https://chromium-review.googlesource.com/c/chromium/src/+/1938253 Change-Id: I2fe052bbe240b9fb19ef0c6c5bd633f8d67f2336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940870Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721704}
-
Tommy Li authored
Currently, when the device scale changes, we accept the Window Manager's instructions on how to re-position the omnibox popup. That doesn't work anymore in the WebUI tab-strip world, and actually if it ever worked in the past, it seems like it must have by chance only. This CL makes it so that on widget resize (which should only happen during device scale change or rotation), we explicitly update the popup appearance, which should re-align it to wherever the omnibox currently is. I tested this by changing the device scale (Ctrl+Shift+Plus) on ChromeOS on Linux with the omnibox popup open. Bug: 1027387 Change-Id: If80e20ef276704363c01ec98a685eb791f29ae56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951335 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Andrew Comminos authored
Tests basic functionality of the JS Self-Profiling API via a helper JS module. Bug: 956688 Change-Id: Ib16e7f86c05fb35df930639f41dc1a25b9dd9242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790586 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721702}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/80d21bbafd2d..a727d8080716 git log 80d21bbafd2d..a727d8080716 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 sugoi@google.com Enable the fullDrawIndexUint32 feature Created with: gclient setdep -r src/third_party/swiftshader@a727d8080716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I01c09606e6f6d9a8e334219b425cc4cc0ccbe7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951647Reviewed-by:
-
Kyle Milka authored
Update some of the share sheet styling to match the spec. Also add in the icons for STTS and QRCodes. screenshot: http://screen/4okyHGgCLAn.png Bug: 1009124 Change-Id: If1aa78812644602643ff5d76d068ad1151bd159e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949077Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721700}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=reveman@chromium.org Bug: 1023677 Change-Id: Ia795dd9eeb5400b51249bb3cc48120e262f22f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927014 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721699}
-
siyua authored
Bug: 1020740 Change-Id: I15dbc8d06a72e54c4c7c0a16b2afa8331113185b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951337Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#721698}
-
