GitLab

Fuchsia emulation now uses KVM so the long tests do not time out.

Bug: 780317
Change-Id: I15d85e7e843781c0ae445bddba0900b6e38192f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427565Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#810280}

Speculative disable these tests since the failure seems similar
to crbug.com/1069608 on ChromeOS.

Bug: 1129807, 1128470
Change-Id: I33eb4db810b57ddb46f1c6982ced26b45f59fcb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429263Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810279}

This reverts commit 99517448.

Reason for revert: As this CL itself is incomplete and M87 branch is
near, let's land this together with other CLs after M87 branch.

Original change's description:
> Prepare for segmented paint artifact
>
> This is the first of a series of CLs to improve performance and
> flexibility of subsequence caching. The basic idea is to split a
> previous monolithic PaintArtifact into segments which are the basic unit
> of subsequence caching. A segment will be created when we start or end a
> subsequence. It's either a leaf subsequence or the gap between two leaf
> subsequences. When a subsequence can be cached, its segments will be
> copied from the previous PaintArtifact with trivial cost.
>
> The mechanism will work for both CAP and pre-CAP. In pre-CAP we'll also
> use one PaintController for each local frame tree, and we'll also create
> segments at GraphicsLayer boundaries. In this way, the difference in
> painting of CAP and pre-CAP will be greatly reduced.
>
> This CL prepares PaintArtifact and PaintChunkSubset for segmenting.
> PaintChunkSubset supports iterating paint chunks in a PaintArtifact:
> - for all paint chunks;
> - for a subset of paint chunks, with a segment range, which will be for
>   pre-CAP GraphicsLayers;
> - for a subset of paint chunks, with an array of paint chunk indices
>   which will be for CAP layerization algorithm, including CompositeSVG
>   for SVGs.
>
> Now we can also iterate the display items in a chunk with
> PaintChunkIterator::DisplayItems(), so that a PaintChunkSubset (which
> references the containing PaintArtifact) can represent all painted
> result of a composited layer.
>
> Bug: 917911
> Change-Id: I5c894e105463e866ac38a17cdc9c5e43eca6a6e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407298
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810007}

TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: I8384a99bbaba2c0a3b532d7e0f56287ed27ac9e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 917911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429864Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810278}

The ID prefix is shared between the Wayland client code in Lacros and
the Wayland server code in ash, so share the constant.

Bug: none
Change-Id: If62550c447670e553a854ce1092cfd3d7d9aacff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427546Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810277}

Bug: 1131921
Change-Id: I847df334df884624b2df8fa02b9dff2d80ca70fa
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427310Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#810276}

This also fixes the blur on this new wallpaper.

Plus, change AddRemoveDisplay to use the same display id
for added display.

Fixed: 1126186
Test: covered by unittest

Change-Id: I2698d8f073f58edb18e29e84e7e16c4296ea48a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425431
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810275}

This CL modifies the behavior of the DecoupleSyncFromAndroidMasterSync
feature. When the feature is enabled, Sync will only decouple from
master sync and be re-enabled once the master toggle is first re-enabled.
The fact that the decoupling happened is persisted using the APIs from
crrev.com/c/2398524.

We also do some non-related code brush up:
- Shorten the implementation of some methods in AndroidSyncSettingsUtils.
- Deprecate one test constructor of AndroidSyncSettings.
- Add missing assertOnUiThread() to the methods to add/remove an
observer in AndroidSyncSettings.
- Restrict AndroidSyncSettingsTest#testAccountInitialization to the
case where the feature is disabled, which should have been done in
crrev.com/c/2366895.

Bug: 1125622
Change-Id: Ia37a1075b159754337c3c7308d9b789b8008ec21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398504
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810274}

There is active work going on that may affect the reliability of the
crashpad process so the histograms need to be extended beyond M85.

Bug: 1119519
Change-Id: I6bab6600ce3a927fc2b9577216c172e086e00e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417295
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810273}

These files are included in Android builds, but they shouldn't
be. This adds checks and fixes the include errors.

These checks are a step toward enabling gn check in chrome/browser.

Bug: 949535
Change-Id: I9fb2a1bbbe04c5ba0fc68b53b795f5f3e43f3232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426805
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810272}

The feature seems to no longer appear in the code.

Bug: 1126640
Change-Id: Ifcdc7966cf366470c18028a8d078d2f7716789f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427132Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#810271}

Bug: None
Change-Id: I2c8af87d523350c5c397cf77ac25a253fe45e5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426292Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810270}

Component manager driver was invalid at password generation. This CL
fixes the issue by passing web_contents_ to |WebsiteLoginFetcher|
instead of thedriver. Driver is later fetched just before password
generation.

Bug: 1131519
Change-Id: Ic903dfc33fd867efc185260817364fecc5d6ec8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426427Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#810269}

Added visibility for androidx.arch.core:core-common

Bug: 1121300
Change-Id: I3cc80e17e2380b406548ee461a4c658453ca54f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428828
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810268}

We want to use IdentifiabilityStudySettings::Get()->IsActive() instead
of IsUserInIdentifiabilityStudy().

We also want to gate getParameter() instrumentation on

IdentifiabilityStudySettings::Get()->IsTypeAllowed(
    blink::IdentifiableSurface::Type::kWebGLParameter)

Bug: 973801
Change-Id: Ib40cf7f890b9ece31d13fe3d35717e6e1b358f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425462
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810267}

As well as in normalized_apk_size.

We should ignore it in the central directory for the same reason as we
ignore it in the local file headers (it causes noise).

We use zipalign when is_official_build=true, so this change is more
just for completeness.

Bug: 1130754
Change-Id: Ic564321f2a477592010352d1afde4552fc7cb6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426550
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810266}

PackageManagerUtils##resolveDefaultWebBrowserActivity can return null.
Add one more check to prevent NPE.

Bug: 1131772
Change-Id: I93cd791b00c675d2d797fdcde76ca5fedd0a50a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427138Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#810265}

Fuchsia-specific code does not need to be compatible with Windows.

Change-Id: I6dc72f36a261f4d3f50936ddde712640675b2ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427845
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810264}

Before this patch, several places in Web Payment, e.g.,
ServiceWorkerPaymentApp, held on to a PaymentRequestSpec* pointer that
could become invalidated and used after free.

This patch replaces PaymentRequestSpec* member variables with
WeakPtr<PaymentRequestSpec> and checks it for null before use.

After this patch, Web Payment holds WeakPtr<PaymentRequestSpec> member
variable that is checked for null before use, thus avoiding use after
free.

Bug: 1127322
Change-Id: Icfe356c7321dfabc63f9fa68d6fcca7d3a4a761b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422432Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810263}

This CL allows READER_MODE to:

a) Remove top row action icon menu:
   Forward, Refresh, pageinfo, Bookmark.

b) Menu item to contain only "Find in page" and a custom menu item
   "Appearance".

Screenshot: crbug.com/1128856#c1
Bug: 1128856
Change-Id: I9624da87b9a95a22a2fe0b4eb67c6676214b8ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426484
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810262}

Bug: 1109316
Change-Id: I7b43d2fcfcce720ac8a812034aade2cecbc2c715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428392Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810261}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I0a5d55ddbf4dd345572d8c5011f91fe15bcb342c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810260}

With overlay forwarding using wl_subsurface, a wl_buffer can be cropped
and scaled to fit a display_rect. This CL adds the extension
wp_viewporter to enable crop&scale, as well as buffer_transform.
When calculating surface-local damage, take into account
buffer_transform, crop and scale.

This is 5/? CL for overlay forwarding using wl_subsurface.

Bug: 1063865
Change-Id: I5cd0a28b7043557aeca0664f59152fd05eadf885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327636Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810259}

This change replaces usages of autofill::PasswordForm with
password_manager::PasswordForm in the file range [fake...http] in the
//components/password_manager/core/browser directory.

Bug: 1067347
Change-Id: If62b9017a4bf2deb82eab75b7968c6c395f6b732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426709Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810258}

This is the first of several CLs to replace DecodeStatus with
media::Status.  This one adjusts DecodeCB to return a Status, and
alters the consumers to expect it.  It also adds the DecodeStatus
enum values to StatusCode, so that old code continues to work
without modification.  DecodeStatus is aliased to StatusCode.

DecodeCB implementations have been modified to check for "not
ok, not aborted" where they used to check for
`DecodeStatus::DECODE_ERROR`.  While `DECODE_ERROR` is still defined
in the enum, and decoders continue to return it, the consumers
should now work even if individual decoders start sending more
detailed status codes.  `DECODE_ERROR` will be removed once all the
decoders have been updated.

For tests, there is now a `IsDecodeErrorStatus()` matcher that does
the same thing.

Future CLs will update other uses of DecodeStatus to do it more
properly, and not rely on this somewhat hacky enum-merging.  It can
be done incrementally with these changes, which is the real goal.

Change-Id: I77dd3ee9e3be5b17ca070e602f2b173ba98d4694
Bug: 1129662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392950Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810257}

This method also records counts for sync entities, so its name and
documentation should be updated. The name is chosen to match the
corresponding method in DataTypeControlller.

Bug: None
Change-Id: I6333884975c60ac78f7e3de5b54ed43ed51077ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424227
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#810256}

Previously, CreateMetadata() returns None if the resulting metadata is
empty. Recently updates to _ParseApkOtherSymbols() requires |metadata|
to be available (to add 'zipalign_padding') field. This leads to
breakage when SuperSize is run on Trichrome.

This CL changes CreateMetadata() to return {} instead of None to fix
the issue. This does not affect existing metadata use in SuperSize;
already it's not explicitly compared against None.

Bug: 1040645
Change-Id: I8664148f647910cbb5f9dea216684262174e0e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427324Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810255}

This reverts commit 6d81ed25.

Reason for revert: the project dependency, platform-side proxy, is
currently only enabled with device policy and not universally available
until M88.


Original change's description:
> deploy AttestationFlowIntegrated
>
> This CL deploys the usage of platform side of attestation flow because
> attestation service at platform side knows better about the stat
> machines of the enrollment.
>
> BUG=b:158955123
>
> Change-Id: I902f8bfc43da9cb2cae0e65a0d244c31ce986dfa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297061
> Commit-Queue: Leo Lai <cylai@google.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#789858}

TBR=emaxx@chromium.org,cylai@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:158955123
Change-Id: I429984e8ef2f7c0e3b52d829fa9c4abc8cbc47fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423700
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Andreea-Elena Costinas <acostinas@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810254}

This will make them easier to work with when used in collections

Change-Id: I8225afc3076929c9d8c162ca2a4af30c390e7fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425400
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810253}

Background (from the CSS2 spec):
 "Although margins, borders, and padding of non-replaced
  elements do not enter into the line box calculation, they are
  still rendered around inline boxes. This means that if the
  height specified by line-height is less than the content
  height of contained boxes, backgrounds and colors of padding
  and borders may "bleed" into adjoining line boxes". [1]

Background about SpatNav:
a. SpatNav's distance formula's input is only the origin's
   (current focus') rect and a candidate's rect.
b. If two rectangles intersect, they are considered to be at
   zero (or negative) distance.

Problem:
When a link's inline box "bleeds" onto links below, then links
on the same line (to the left or right) could get unreachable
when SpatNav's distance formula favors the intersecting rects
below, see snav-line-height_less_font-size.html.

Solution:
Shrink these bleeding inline boxes to their line box's [2]
height. If a link is line broken over 2 lines, use 2x the line
box height, and so on.

[1] https://drafts.csswg.org/css2/#leading
[2] https://drafts.csswg.org/css2/#line-box

Bug: None
Change-Id: I002da7af30721de45105f5ba1330f4679a5457af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410039
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#810252}

This reverts commit 1208732e.

Reason for revert: likely making
ExecuteScriptApiTest.ExecuteScriptInFrame flaky.

Bug: 1131966

Original change's description:
> Remove unneeded CursorLoaderWin::SetPlatformWindow calls
>
> SetCursorNative is only called from WindowTreeHost::SetCursor, which
> guarantees that the platform cursor has been set.
>
> Bug: 1097556
> Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#810120}

TBR=sky@chromium.org,hferreiro@igalia.com

Change-Id: I60d2de90149af77a5d6ebdce2f02a859f9262f9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1097556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429229Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810251}

Bug: 1110685
Change-Id: If30b18f3d1b0dd1643442cfd4a6fd5bd730bae22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424666Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810250}

Similar to CL:2404109, ComputedStyle::DecorationColorIncludingFallback()
was not handling system colors correctly with
CSSSystemColorComputeToSelf enabled.

Bug: 1081945,1129485
Change-Id: I3b01f5060c0758a9167a771058d365dbb4629008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424674Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810249}

Just a helper to check if both suffix and prefix autocompletion are
empty. This is in preparation for the potential introduction of a 3rd
autocompletion field.

Bug: 1062446
Change-Id: I58aecb9cffb690618bb835ed97e1cb69cfdae635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426964
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810248}

This allows the state from freezing the tree to match the updates we're
about to send up to the browser process. On amazon.com homepage,
activating the hamburger menu results in a focus to the hamburger menu,
then a synthesized click. The click handler bounces focus to the popup
menu's close button and also modifies its styles so that it is visible.

The first focus event queues up a deferred notification for
HandleNodeGainedFocusWithCleanLayout. This is then added as an AXEvent
(and queues a SendPendingAccessibilityEvents) as part of the lifecycle
update triggered by RenderAccessibilityImpl::PerformAction for the click.
The click happens and script bounces focus to the other element.

The SendPendingAccessibilityEvents task then runs, which snapshots the
pending_events_ (and clears it) before freezing the tree and updating
layout. Due to this there is an AXTreeUpdate where focus points to the
close-menu. However the close-menu element has not yet recomputed to be
unignored as the relevant events are queued up in pending_events_.

This change runs the document lifecycle before snapshotting the
pending_events_ and dirty_objects_ so that we send up a self-consistent
set of accessibility updates.

Also added some tracing to help narrow down Accessibility focus issues
in the future.

AX-Relnotes: N/A

Bug: 1131827

Change-Id: Ia8133c9bff45c243018185041bd13762bac25295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427749Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810247}

Temporary remove non factory-default permissions from the summary string
until we are able to populate the permissions subpage directly using
this controller's returned permissions:
https://chromium-review.googlesource.com/c/chromium/src/+/2410859

Bug: 1077766
Change-Id: If57829db3c656c0631dda7fc755b9a46b2abb714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429044Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810246}

Bug: 1099917
Change-Id: I51249a533b84439513708d62e5f56ac83120cce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427184Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810245}

The logic for determining whether a network is metered for the purpose
of auto updates is implemented separately in session_manager. We need
to resolve this before enabling the toggle. See issue for details.

Bug: 1129994
Change-Id: I976e191b8b27017339876d747c01967bab6081dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426982
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810244}

This reverts the changes to GoogleAccountsCallback and introduces a new
API for retrieving the user email, name and avatar.

- getEmail is synchronous because the information is UI-blocking. We
  could show the UI, then later update, but that would be more jarring
  and more likely to cause misclicks, since the UI would move under the
  user's fingers.
- getAvatar is async because the above problems don't apply.

Bug: 1129893
Change-Id: I2cde39cc18f1da9edf6c3004f4c909492cd424c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421444
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810243}

Instead of exposing MainController's conformance to BrowsingDataCommands
use the app state's dispatcher to access it.

Bug: 1045659
Change-Id: I71bd5d4693d5d2eefdc67def9abb345a84d24ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418336
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810242}

Bug: 1088801
Change-Id: Ib266b90c1dabf72cc1b5e31ee2dfebc937e393f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421823
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810241}