- 01 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4efbe326b48b..4977f960c950 2020-09-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-01 petermarshall@chromium.org [typescript] TypeScript-ify accessibility/AccessibilityModel.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9e08e3cb7c7ff3bdcf3d47796f1e5452f3b792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387940Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803485}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2645e44ad6b..64e4b1e8e2e8 2020-09-01 lalitm@google.com ui: ensure resolution of at least 1ns If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:166684163 Tbr: perfetto-bugs@google.com Change-Id: Ie42af652adc4f5d14810d3e24ee4186b72355421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387941Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit 0a7f5359. Reason for revert: This confirmed the android bot was not overriding the origin trial key. Once confirmed, this patch isn't useful anymore. Hence reverting it. Original change's description: > Check the android bot do not override default origin trial key. > > The origin trial "CrossOriginOpenerPolicyReporting" is not properly > recognized on the Android bot. > > I suspect the default origin trial test key is overriden. This patch > adds a check to ensure this isn't the case. > > Bug: 1119555 > Change-Id: I86e8f1fe6b5e2cc7b8ffd301bc96c0d4d810a844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374788 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802147} TBR=clamy@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1119555 Change-Id: Ie091eeec36c38e72d992d124246022aa8cd2a5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386742Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803483}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0b89b27263b1..1c4a7f780f10 2020-09-01 jiawei.shao@intel.com Fix the initialization of the buffers with MapRead and MapAtCreation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib469a1854e8743242b0a9308fd4aaeed49d3aaa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387661Reviewed-by:
-
Nela Kaczmarek authored
[Passwords] Redirect to change password url fetched from AffiliationService in WellKnownChangePasswordNavigationThrottle. This change modifies the navigation in WellKnownChangePasswordNavigationThrottle. It prefetches change password URL from AffiliationService if /.well-known/change-password is not supported and feature flag kChangePasswordAffiliationInfo is enabled. The change covers browser integration tests. Bug: 1108279 Change-Id: I3cac54891e62b718ddec0aa46c1fd727cee24dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382810 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803481}
-
Ewann authored
This CL adds the following user actions: - MobileTabGridCloseAllTabsConfirmationConfirmed - MobileTabGridCloseAllRegularTabsConfirmationPresented - MobileTabGridCloseAllIncognitoTabsConfirmationPresented - MobileTabGridCloseAllTabsConfirmationCanceled Bug: 1119319 Change-Id: Ifebaca830bcf52e0c526a32acb90b82d376db33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367094Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#803480}
-
Jesse Schettler authored
Hook up the Mojo interface provider to the scanning UI and generate js-lite bindings from scanning.mojom. A subsequent CL (http://crrev/c/2378138) uses the ScanService Mojo interface to get the connected scanners and add them to a dropdown in the UI. Bug: 1059779 Change-Id: I4270721ac585d668ee1ad5405695590ba78e7711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368238Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#803479}
-
Marc Treib authored
Every type of UserEvent must specify whether it should or should not come with navigation IDs (or that either is okay). kFlocIdComputedEvent did not specify any of these options (instead falling through to a default case with a NOTREACHED()). This CL fixes this by specifying that Floc events should not have navigation IDs. It also adds a comment to the relevant "switch" to make this clearer, and hopefully prevent the same thing from occurring again. Bug: 1116628 Change-Id: I7f8fd9a4ec008ee65dc606619bd2a8247123ca6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387573Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#803478}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19157ee4a2fd..e2645e44ad6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5bf2a80e244acadc2d556541da3be1d397c47cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387623Reviewed-by:
-
James Cook authored
This allows us to avoid creating a test mojo service and simplifies the code. Follow up from review comments in: https://chromium-review.googlesource.com/c/chromium/src/+/2368484 Bug: 1116652 Change-Id: I02206df8f1213beb264068e2a8b818d93ef2cee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386378 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#803476}
-
Fredrik Söderqvist authored
Regular/non-fast-path parsing limits <quirky-color> to a limited number of properties (based on the list in the quirks spec [1]). The fast-path however did not limit based on property but only considered the parser mode. This meant that some parsing code-paths would allow <quirky-color> even when they shouldn't have. [1] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk Bug: 1024491, 998400 Change-Id: I88acb102c434c1a73c79eeb1eb94ad06c0677b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385357Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#803475}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. Tbr: hkamila@chromium.org Bug: 1104836 Change-Id: Ic598ca409d1a0634abb9b99c8186a8d92c28b260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367075 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#803474}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e464bb1096d27bda8da2a9637b0906dbb2422da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387450Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib5ea3151f87a385b27b37cb5944c981a124b9dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383017Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803472}
-
Nektarios Paisios authored
AXPosition now uses the deprecated text iterator class for translating DOM offsets to text offsets, and for calculating text lengths with all uncompressed white space removed. A text offset in the accessibility tree might not have the same value as the DOM offset for an equivalent position in the DOM tree, because the DOM may have extra white space that should be collapsed. This patch switches to using the NGOffsetMapping class in Layout NG for all such calculations. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1008031 Change-Id: I6953355e83b0953ffa341207bbdde0249cd1b74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384471 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803471}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic193475f84e8f43193ad141477a5265ea81e458f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382077Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803470}
-
Andrew Grieve authored
Bug: 1123778 Change-Id: I5c0b7b4e91c7b01907ae5b59523f7d3db1b0ca22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387341 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#803469}
-
Javier Ernesto Flores Robles authored
I found 2 users crashing in this util. Instead of crashing this will return an empty string and log an error. This will fill an empty string, but will also help diagnose the cause of the issue. Bug: 1122639 Change-Id: I648398811388225382bb0a039736b9eff5f538b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379843Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#803468}
-
Claude van der Merwe authored
Add Phone Hub, Phone Hub Notifications, Phone Hub Notifications Badge and Phone Hub Task continuation feature item summaries to Multi Device sub page. Bug: 1106937 Change-Id: Ib1b99e6d1187220eceb365e97b1177c15f1cad24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386420Reviewed-by:
-
Erik Språng authored
These are used to monitor WebRTC performance over time, and is not part of any particular experiment setup. As such, it does not make sense to have expiry dates for them, that needs to be maintained. Bug: 1109878, 1109877, 1105014, 1091162, 1089987, 1089667, 1087422, 1075638, 1072675, 1068041, 1066086, 1053185, 1041092, 1037408, 1018112, 1008000, 1000023, 988738, 988737, 988727, 988718, 988701, 988698, 988685, 988680, 988637, 988632, 974250, 1121219 Change-Id: I5433c5187e0f51b418dca446570b14b34f563bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362701 Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
-
Michele Mancina authored
When error state is set, the active step is colored red and icon's pulse animation is disabled. When active step is past the last step (meaning all steps had been completed), and the error_state is set, the whole bar is colored red. Bug: b/163114648 Change-Id: Id37ff9469e69bb9926b083523b9eaed52fafab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380283 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803465}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af609dca0136..4efbe326b48b 2020-09-01 sigurds@chromium.org [ts] Type-check console/ConsoleContextSelector.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4a3e7c767b5ac3ff12179ac136bc68c1dfdd337f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387448Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c0dda02196e8..c21fdb07d60c 2020-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1ca2f943 to 86334243 (403 revisions) 2020-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f428aa39ca2b to 8a0ebd40f86d (1 revision) 2020-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0e98e894a84c to f1315472247d (2 revisions) 2020-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 1b0bbd1550ed to 25d277579d1e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Iad395065e7488770da0e43cbfb62fbed08597c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387446Reviewed-by:
-
Dominik Röttsches authored
Move firmware matching to separate method and rename service_ member in order to distinguish it from matching against downloadable fonts (updateable via GMSCore) on the Java browser process side later. No functional change. Bug: 1121589 Change-Id: I3f7c25ed86cc7542cfbeeac587e473eec7ff809d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387566Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a42d4b38183..d397f7662abb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mamir@google.com Change-Id: I16f59f7b4700ee6a11a0cc140a0eb53d1c900748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803461}
-
Mohamed Amir Yosef authored
This reverts commit 16fa21a7. Reason for revert: This test is consistently failing on Mac10.13 Tests (dbg) Original change's description: > Reland "Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest" > > This is a reland of b89144a4 > > AX-Relnotes: n/a > > Original change's description: > > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > > > AX-Relnotes: n/a > > > > Bug: 1114959 > > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Joey Arhar <jarhar@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803007} > > TBR=ellyjones@chromium.org,masonfreed@chromium.org,jarhar@chromium.org > > Bug: 1114959 > Change-Id: I747aee7e8c533c564ec279b05e5511f25c38f603 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386935 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803385} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,aboxhall@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: Ibd4264a4bf99ed562cf1ebaace46d53b20cf1246 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387802Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#803460}
-
Mohamed Amir Yosef authored
It has been failing consistently on CrOS bots. This disables it. Bug: 1123872 Change-Id: I79152a991118af02a215e3f809c50f42c12d24cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387101 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803459}
-
Eleonora Rocchi authored
This CL adds a copy button in the dialog used by the user to view a compromised password. It also adds a test to verify the button is working correctly. Screenshot in the linked bug. Bug: 1119825, 1092444 Change-Id: I36cd31f1172be23e035360f89d75320ca62a0397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380286Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#803458}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19157ee4a2fd..e2645e44ad6b 2020-09-01 lalitm@google.com Merge "ui: fix io related thread state bugs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9661ff293e10eba49a891f8cb61c072ed253bcfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387447Reviewed-by:
-
arthursonzogni authored
This CL removes all studies in fieldtrial_testing_config.json where neither the study name nor any of enabled or disabled feature names appear as a string literal elsewhere in the codebase. This CL has been generated semi-automatically: 1. Download cleanup.py attached to https://crbug.com/1053702#c3 2. Generate cleaned-up list of studies: $ python3 ~/Downloads/cleanup.py \ testing/variations/fieldtrial_testing_config.json \ ~/scratch/out.txt 3. Copy the output: $ cp ~/scratch/out.txt \ testing/variations/fieldtrial_testing_config.json 4. Format the output: $ python testing/variations/PRESUBMIT.py \ testing/variations/fieldtrial_testing_config.json Bug: 1053702 Change-Id: I100d97a68aabeba2f7c182cc9ddc478314d71dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379730 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#803456}
-
Julie Jeongeun Kim authored
This CL handles the case that a widget is destroyed and its content view is alive when GetIndexInParent is called with the view. For instance, OmniboxPopupContentsView is not destroyed even though |popup_| widget is destroyed and Orca calls atk_object_get_index_in_parent on the view. Since it doesn't on the children list, it meets DCHECK from AXPlatformNodeBase::GetIndexInParent(). Since GetParent() returns the application node for views if it doesn't have the parent, checking the parent doesn't work for this case. This change overrides GetIndexInParent at AXPlatformNodeAuraLinux and before calling AXPlatformNodeBase::GetIndexInParent() it checks if the node is valid. AX-Relnotes: n/a. Bug: 1122523 Change-Id: Iba6c8cb852a8e91c775bf5f8c14bc54e83e15643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379395 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#803455}
-
Michele Mancina authored
This is done by saving the expanded/collapsed state when the tab is switched and restoring it when the tab is reselected. Bug: b/159308598 Change-Id: Ib2f9c511c96557291251ef4b723bd88e4aa1721c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362824 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 77ffd97a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mek@chromium.org, stevebe@microsoft.com: external/wpt/native-file-system NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ia4b2e0f08bb0ac9d2a0688b56ff8ab5ac796760d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386762Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803453}
-
Henrique Ferreiro authored
Both IDBKey and PolicyValue Mojo unions where being wrapped with a struct with the union as its only member. This CL simplifies that representation by removing the outer struct. Change-Id: I0fdfbdca7ae6553e48248e2a6a39a062120c6797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374449 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#803452}
-
Mohamed Amir Yosef authored
TBR=mlamouri@chromium.org Bug: 1123879 Change-Id: I12fd316791e1597bf506ea3547bcd36f9c9659ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387019Reviewed-by:
-
dizg authored
Dice to the chrome://signin-internals. Bug: 1115247 Change-Id: I91bce3fe2280d011fdae74969838119eedfda30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377930 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#803450}
-
Andreea Costinas authored
This CL updates the wording on the System-proxy notification to add more clarity for non-technical users. Bug: none Test: none, not a functional change Change-Id: I3c50e34d00484f7179344e0a4de564fe1b7be5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366727Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#803449}
-
Maksim Sisov authored
This is a reland of 8ce938a2 Fixes vulkan tests on Linux FYI SkiaRenderer Vulkan and angle tests on Linux Ozone FYI bot. Original change's description: > Reland "Reland "X11 and Ozone: enable use_x11 and use_ozone"" > > This is a reland of 75363679 > > Original change's description: > > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > > > This is a reland of f985905e. > > > > This change broke our headless build: > > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > > assert(ozone_platform_x11) > > ^----- > > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > > "//ui/events/platform/x11",. > > > > Fix: > > Don't include x11 build for headless case. > > > > Original change's description: > > > X11 and Ozone: enable use_x11 and use_ozone > > > > > > This is the final change that enables use_x11 > > > and use_ozone for Linux builds and (as it was > > > before) excludes X11 for chromeos, chromecast, > > > lacros. > > > > > > in order to run ozone/X11/wayland, one must pass > > > —enable-features=UseOzonePlatform > > > —ozone-platform=x11 or wayland. otherwise, > > > non-ozone/X11 is used. > > > > > > it’s also possible to completely disable X11 > > > so that clients, who need that kind of build can > > > continue to have that. > > > > > > Bug: 1085700 > > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > > Cr-Commit-Position: refs/heads/master@{#801523} > > > > Bug: 1085700 > > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801692} > > Bug: 1085700 > Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802773} Bug: 1085700 Change-Id: I26fb00938adc6a9e49576257ca316f23830e9cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382834 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803448}
-
Bartek Nowierski authored
There is a handful of pointers that cause crashes when converted to CheckedPtr. With exception of one, they experience a tag mismatch when dereferencing/extracting the pointer. And one pointer appears to be assigned an unallocated address. These require further invesitagion, but for now blocklisting them, so that we can get perf numbers. Bug: 1069567 Change-Id: I8fb0f371161d08b25a1ffec9ac55596b86994185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358933Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Jimmy Gong authored
- Diagnostic app can be accessed through the launcher and app drawer. - Feature flag must be enabled. Bug: 1120206 Test: SWA integration test Change-Id: I9add3d5e2f9fe1a79a0d9109426714464e2bf0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377516 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#803446}
-
