GitLab

crrev.com/c/1808144 replaced the ancient --no-referrers
command-line switch with a base::Feature. The change
contained a bug and didn't add sufficient test coverage beyond
what was already present---and there was no test coverage already
present!

This patch remedies both the bug and the lack of coverage:
1. The bug was a failure to sync the base::Feature to a profile-scoped
pref; the previous patch only propagated the base::Feature to a
system-scoped (local state) pref. This is fixed by having the pref's
default value, set in prefs_tab_helper.cc, depend on the value of the
Feature.
2. This patch adds additional referrer policy browsertest coverage
to make sure that, when the NoReferrers feature is on, the browser
sends no referrers.

R=jochen

Bug: 1004486
Change-Id: Idc98b6d912dd59b23eab6eeef128e7a6992758ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842040
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703492}

The purpose of this CL is to provide ICU support for 30 extra languages
(see crrev/c/1648623 for more details). crrev/c/1811973 adds a feature
module that delivers an extra ICU data file containing support for the
aforementioned extra languages. To make use of this extra data file, we
check at browser process startup whether the extra ICU feature module is
installed and if so init ICU with the extra data file inside the module.
We retrieve the module install state from the ContentBrowserClient as
feature modules are a chrome layer concept and the ICU initialization
happens in the content layer. The extra ICU data file is applied
_before_ the main ICU data file. Otherwise, the main ICU data file would
override the extra languages.

Requires crrev/c/1834464.

Bug: 1006794
Change-Id: Ic7c14bf3437309b90cf2ce205ade14da937203c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818876
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703491}

This change hooks up the CookieMonster's CookieAccessDelegate to
CanonicalCookie::IncludeForRequestURL and IsSetPermittedInContext, by
passing them the CookieAccessSemantics for that particular cookie that
is returned by the delegate. The access semantics is fed into
CanonicalCookie::GetEffectiveSameSite, where it is taken into account
when computing the effective SameSite mode of a cookie.

For now, the default value of the parameter is CookieAccessSemantics::
UNKNOWN, so other callers do not yet pass the right access semantics
to IncludeForRequestURL and IsSetPermittedInContext. They will be
updated in subsequent changes.

Bug: 978172
Change-Id: Icf0dc68738c3651c8e0fc648e597658485dc799c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845233
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703490}

Bug: 982762
Change-Id: I6bcd8ea8be2fef88e907248b4b56a6ac96ee5ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837203
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703489}

Bug: 980533
Change-Id: I6c351d4ca8ee49b369ac9e187994aa69d470424e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836451
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703488}

Currently Omnibox would clear the temporary text if the first results is
attempted to be selected using the arrow key. This prevents the first
zero-prefix result from being selected as there is no default matches in
that case. This CL fixes that by adding an extra condition to prevent
selection when there's no editing.

Bug: 996516
Change-Id: Idb3338fcc86233ce14f0de22dc4253691f5daf13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845913Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703487}

controls on the page do.

Bug: 842891
Change-Id: I1dbb8e2228fcc393bc70479d1467b343b46ec7ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838393Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#703486}

Bug: 1005568
Change-Id: Ia232b595a862525d89a6be135a839f3f30dffbad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841758
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703485}

base::Bind/base::Callback are deprecated in favor of either
base::BindOnce/base::OnceCallback or base::BindRepeating/
base::RepeatingCallback (depending on whether the callback
is invoked once or multiple time).

Convert some uses of base::Bind/base::Callback (this is a
multipart change) in components/prefs and services/prefs
to the recommended methods/types.

Bug: 1007719, 1007831
Change-Id: I7d18d35c3148ccacf4228cc5d44349b96cefb56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844813
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703484}

Convert the implementation and all users of the
snippets_internals::mojom::PageHandlerFactory, PageHandler and Page
interfaces.

Bug: 955171
Change-Id: Ifaefd53184ce0f547b5048df1ffe2e144cf5fa4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807223Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#703483}

This is just a minor build rule simplification. Should not affect
anything.

Change-Id: If778e8c2ece6e223b492ed4f172ce138f3c4e357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845932
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703482}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d16fbbb2686c..9ccec3700953


Created with:
  gclient setdep -r src-internal@9ccec3700953

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:140584925,chromium:None,chromium:None,chromium:1011526
Change-Id: I7f8ed074a01bb4872e37fca816ca300cea46d8ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845942Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703481}

Enable fetching of hints from the URLs extracted from the
search result page.
The hints are fetched only on slow connections.

Change-Id: I0c8d0324ff913297c9f2b2a5fdc300771c0c3798
Bug: 1004527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839240
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703480}

Configures the NetworkContext to permit CORS requests with headers
"Purpose" or "X-Requested-With" headers. These headers are safe and
used for resource preloading and CSRF blocking, respectively.

Previously, the Chromium netstack would block resources from loading if
either of these headers were set.

Bug: 1011905
Change-Id: I994ad2adddca5d00226e603b37c87d57cca69e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846013Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703479}

Remove line-height, which was causing the area outside the actual size
of the menu option to be selectable.

Before: https://drive.google.com/open?id=16vEe60P6VDgFI1SKzexUS3mrZroQll-I
After: https://drive.google.com/open?id=1QE7I6ig2lnomxVNxDG3bS_KvabJSw6s1

Bug: 1011802
Change-Id: I1c762703bb6b59a099477d4706618bf307179d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845697Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703478}

Before this CL, strings are not escaped, which caused
test failures when strings in import maps contains e.g. backslashes.

This CL fixes the test failures by escaping the strings
using EncodeForDebugging().

This CL doesn't affect non-test behaviors because ToString()
is only used from test code.

Bug: 990561
Change-Id: I0b1b8dd428026c2c9c8a837022e1d2c71604113f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843314
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703477}

ForcedColors is added to about:flags and is disabled by default.
Enabling this flag will turn forced colors mode on for web content.

Bug: 970285
Change-Id: Iab5320903e8e22ec3374b2d2ffc8a659bdaed4bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841975Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703476}

Both testRestoreHistory tests were emulating a background/kill/restore
by simply disabling/enabling web usage.  Doing a tabgrid close all /
undo is more similar.

Upon EG2 migration, this method can be removed, and the test can do
a proper background/kill/restore.

Bug: 1011791
Change-Id: I1f3074917747551833ef090e2da598674476de77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846072
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703475}

LLD partition generation has been patched to work properly in Debug
builds, so that configuration can be re-enabled.

Ride-along tweaks:

- Rename variable use_native_modules to use_native_partitions

- Remove redundant allow_partitions template argument, which can be inferred
  from whether module descriptors are supplied.

Bug: None
Change-Id: Ib885f75bb00358b3e61b450187db2020b1f32a9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844076Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703474}

BUG=762641
TBR=xiyuan@chromium.org

Change-Id: I57b206813f77ce3ea8130c5847030ece73efb023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845954Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703473}

Without this change when user navigates back by pressing SHIFT TAB from inputs in throttling settings pane.
Tab stops at whole throttling settings pane. Again, pressing SHIFT TAB it takes to 'Throttling' in Settings then, pressing TAB it lands in Throttling Pane content section instead of landing on first control 'Add custom profile button'.
This change removes that extra TAB so that, when user presses TAB it lands only in interactive controls and satisfies below given rule:
- Don't allow users to tab to text elements (such as labels) or other static content.
More info: https://accessibilityinsights.io/docs/en/windows/reference/tabstops

Bug: 963183
Change-Id: I100ccc0b541f2eb8a077a7fdb63c6f594dbc6c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817412Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703472}

Bug: 1011483
Change-Id: I45db77c672ee662a368491f8c3ff1895ece10701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845871Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703471}

This CL removes a redundant "CookieStoreManagerTest/" prefix from all
unit test names. For example,
CookieStoreManagerTest/CookieStoreManagerTest.OneCookieChange/0 becomes
CookieStoreManagerTest.OneCookieChange/0.

Change-Id: I9f07ad0c322c55a7d26e5d02a16fb52aa1350844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844152
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Staphany Park <staphany@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703470}

This is a follow up to crrev.com/c/1840171.

MakeAccountAvailableWithCookies is used for setting
the unconsented primary account, because it waits for
the account to be propagated.

TBR=treib@chromium.org

Bug: 995720
Change-Id: I6b063eb427e5719aa2fec8d2534c67de63ee82ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846271Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703469}

The native resources are loaded centrally when calling Module.getImpl()
so that all modules can reuse the same infrastructure. Currently, the
modules with native resources are whitelisted until we have a solution
that automatically determines whether a module has native resources.

+ Make test dummy use the new infrastructure.

Bug: 1011943
Change-Id: Ia47de6eafdae1700e948208427d3c68e3086308a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838915Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703468}

Change-Id: I4c092837916c9b93c9c6a1f85ad83d218ea01d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846238
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703467}

This was causing issues when testing the client. We can remove these
since we currently don't need them.

Change-Id: I780b4e95bd751c39e8521b56c7647ae0a6fd1b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845791Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703466}

This persists session_id, an integer which counts the current user
session with the app. This value is reported in UMA metrics.

Bug: 1004614
Test: startup webview shell multiple times, log session_id inside
Test: AwMetricsLogUploader::UploadLog, verify session_id increases
Change-Id: I3bb33e1b9443729d3d59c60bdd11af2e790c8512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842627Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703465}

This reverts commit 142130e8.

Reason for revert: Caused invalid routing-id allocation per https://bugs.chromium.org/p/chromium/issues/detail?id=1011283

Original change's description:
> Split the WebContentsDelegate::ShouldCreateWebContents API.
>
> Currently ShouldCreateWebContents() does 3 separate things
>   (1) Tells WebContentsImpl::CreateNewWindow() to suppress default
>       popup creation logic.
>   (2) Signals to the embedder that a window creation has been attempted
>   (3) Allows the embedder to signal back, via use of the global routing_id
>       maps, that a new WebContents has been created and needs partial
>       initialization inside the content layer.
>
> This is super complex, especially since only one delegate uses (3).
>
> The new API creates 2 functions:
>   bool IsWebContentsCreationOverridden()
>   WebContents* CreateCustomWebContents()
>
> Breaking up the API makes it cleaner. If the WebContents initialization
> logic can get changed to absorb the single odd use case in (3) then
> CreateCustomWebContents() could be changed to have a void return type
> making the API even simpler.
>
> Bug: 545684
> Change-Id: Ib22d097f7e92a5c7d8132c183a814314c38d7ea2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824321
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Auto-Submit: Albert J. Wong <ajwong@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702347}

TBR=ajwong@chromium.org,jam@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 545684, 1011283
Change-Id: I4cd2db8880729aa17809128a3b1d0f8f0afe5dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845997Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703464}

Following the guidance at https://crbug.com/634507#c45, this swaps out
spots which use ToInternalValue/FromInternalValue for persisting a
base::Time in prefs, in favor of PrefService::SetTime()/GetTime().

I verified these internally use From/ToDeltaSinceWindowsEpoch(), which
is consistent with the internal implementation of base::Time.

Bug: 1010369
Test: None
Change-Id: I6a7ba2e93610702e33482eb830bb34ef61a50f89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839634Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703463}

The ownership model for SandboxedVfs and SandboxedVfsFile is explained
in class comments. It is not straightforward (smart pointers) because
SandboxedVfs is tied to sqlite3_vfs and SandboxedVfsFile is tied to
sqlite3_file, which are under SQLite's control.

The class comment state that SandboxedVfsFile is deleted when Close() is
called, but the implementation did not do that. This CL fixes the
inconsistency, plugging a small memory leak.

Bug: 1010577, 1009234
Change-Id: I21c819b16e15868bebf6a1a06f1b8de776d100f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843150
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703462}

Low latency 2d canvas should use swap chains on Windows when supported,
but this broke a few weeks ago during the canvas shared image
refactoring.

This CL fixes that, and adds a trace integration test to verify that
swap chains are indeed being presented in the GPU service.

Bug: 1009860
Change-Id: Ifeb8a9cc68bbca8d6b379c71a7707adb62921bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836791Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703461}

Bug: 1010764
Change-Id: I060b66acacc11353eccd7696cc229e10dafe35f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842751Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703460}

This crash is caused by the following DOM structure (achieved via)
DOM manipupation:

blink::HTMLBRElement
    blink::HTMLMapElement
        blink::Text
        blink::Text
        blink::HTMLAreaElement

Note that the <br> tag has children, which is not possible via markup,
but can be generated easily with JavaScript.

In AXPosition::CreatePositionBeforeObject, the crash occurs here:

  const AXObject* parent = child.ParentObjectIncludedInTree();
  DCHECK(parent); // parent is nullptr

While there is technically a parent node in the DOM, there is no layout
node, since the tree is corrupted. The AXObject implementation for
this depends on either a valid parent node or a layout node (see
AXImageMapLink::ComputeParent). Creating an AXPosition in this state
results in the nullptr deference listed above.

An alternative would be to generate a parent specifically for
AXImageMapLink in this scenario, however I dropped that approach when
it became clear that the layout and accessibility engines hit lots of
DCHECKS when the DOM tree is invalid (as they should).

Instead, the approach taken here is to add additional resilience in
AXPosition to handle invalid parent/child relationships.

Bug: 996525
Change-Id: I598e4ac930d4caeb10ce74f6328d3a75eb9580fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830012
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703459}

See bug for full description.

Now if a tab wants to open another tab in the same group, but the other
tab would open in a different window, the group is not assigned. Calling
TabStripModel::InsertWebContentsAt() with params specifying a group that
does not exist at all in the tabstrip is (and should be) an invalid
operation.

Bug: 1011140
Change-Id: I34d9cf15ec74b96f9c5c53878f76f124fcca4d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839015
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703458}

By default, API transitions are disallowed.

Bug: 1011467
Change-Id: I88c537b26964443bb825c68092a9d7087d03c06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846034Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703457}

https://skia.googlesource.com/skia.git/+log/25f416465e8d..38f0a4972a24

git log 25f416465e8d..38f0a4972a24 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 csmartdalton@google.com Add GL_QCOM_TILED_RENDERING as an optional interface
2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-07 borenet@google.com [infra] Remove broken commit from go.sum
2019-10-07 brianosman@google.com Particle gallery: Add two more examples

Created with:
  gclient setdep -r src/third_party/skia@38f0a4972a24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@google.com

Bug: None
Change-Id: Ib587276ab78e06232fd43b991acc2497bd95f6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845941Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703456}

Fix all related tests.

Bug: 1008444
Change-Id: Idff548f6f9547960cb81c931e72015578bd8cf29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826991
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703455}

Hairlines were deprecated as part of our style long ago, but not
removed. Doing an A/B test with a "webby UI" separator first requires
this change, as we cannot guarantee pixel sizing for separators.

Still to do:
 - Replace drawn separators with a separator view in most cases
 - Simplify BrowserView and BrowserViewLayout
 - Add Webby UI separator
 - [Re]start A/B test (but safe for Beta/Stable)

Bug: 993502
Change-Id: I00c9182cb884a284060c3f9742758d694348e165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842617Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703454}

During a payment process the merchant can change details of the
paymentRequest in response to changes in shipping address, etc. The
browser redacts the unnecessary fields from Updated payment details
before sending it to the Payment Handler.

This cl changes the redacting logic so that shipping information is
included in redacted details only when shipping is requested and the
payment handler is responsible for handling shipping address.

Bug: 984694
Change-Id: I0f5e93cb27e91565425167bfc796908c67dcd747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842292Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703453}