GitLab

BUG=422621

Review URL: https://codereview.chromium.org/698633002

Cr-Commit-Position: refs/heads/master@{#302495}

BUG=

Review URL: https://codereview.chromium.org/696923002

Cr-Commit-Position: refs/heads/master@{#302494}

BUG=429322

Review URL: https://codereview.chromium.org/693893005

Cr-Commit-Position: refs/heads/master@{#302493}

The log showed that the sum across all C-states didn't change, but C0 went down and WFI went up. AFAIK it shouldn't be possible for any of them to go down, so we'll just drop the data in this case.

BUG=426430
TEST=None.
TBR=tonyg

Review URL: https://codereview.chromium.org/679813002

Cr-Commit-Position: refs/heads/master@{#302492}

This reverts commit 07a90a91.

Revert "Fixes bug in Media.AudioInputCbErrorMac histogram."

This reverts commit beaa161b.

Rationale: appears to make AppRTC hang on Mac. This looks like the
only related CL in the blamelist, speculatively reverting.

BUG=428706
TBR=xians@chromium.org

Review URL: https://codereview.chromium.org/695393002

Cr-Commit-Position: refs/heads/master@{#302491}

The name attribute is repeated in AX tree formatter on Windows
because WriteAttrubute() is called twice for the name attribute.
This patch makes formatter write it only once.

BUG=N/A

Review URL: https://codereview.chromium.org/688653002

Cr-Commit-Position: refs/heads/master@{#302490}

GetCmdStatusAndOutputWithTimeout in cmd_helper should log the commands
run, like GetCmdStatusAndOutput does.

BUG=429766

Review URL: https://codereview.chromium.org/695403002

Cr-Commit-Position: refs/heads/master@{#302489}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=plundblad@chromium.org

Review URL: https://codereview.chromium.org/683583003

Cr-Commit-Position: refs/heads/master@{#302488}

Device info is always enabled, regardless of sync everything state.

BUG=429217

Review URL: https://codereview.chromium.org/694903002

Cr-Commit-Position: refs/heads/master@{#302487}

Similar UI has already been added to mobile platforms. Functionality is hidden behind a flag until the passwords website launches.

BUG=426508
R=estade@chromium.org, isherman@chromium.org, mkwst@chromium.org, nyquist@chromium.org

Review URL: https://codereview.chromium.org/682133003

Cr-Commit-Position: refs/heads/master@{#302486}

BUG=426252
TEST=compiles, verified version number shows up on Windows

Review URL: https://codereview.chromium.org/681983004

Cr-Commit-Position: refs/heads/master@{#302485}

R=dmazzoni@chromium.org
BUG=428156

Review URL: https://codereview.chromium.org/701583002

Cr-Commit-Position: refs/heads/master@{#302484}

BUG=105388

Review URL: https://codereview.chromium.org/678263003

Cr-Commit-Position: refs/heads/master@{#302483}

CodeGen doesn't do anything fancy like fork() or ptrace(), so it's
safe to test using just plain gtest. That also allows us to convert
the tests to use parameterized tests, so we can easily run each test
independently.

While here, also invert the structure a bit because I expect once I
rewrite and simplify CodeGen, a lot of the ProgramTestFuncs to go
away.

Lastly, for simplicity I'm leaving a lot of statements as ASSERT_TRUE
even if they could use ASSERT_EQ, etc.  Again, I'm expecting some of
those to go away, so I'll worry about cleaning them up once the
unneeded asserts are gone.

BUG=414363

Review URL: https://codereview.chromium.org/687813003

Cr-Commit-Position: refs/heads/master@{#302482}

If the user navigates away from a distilled web page or the
renderer crashes while the DomDistillerViewerSource is still
active, a request can still come in. However, using the
render_process_id and render_frame_id to find the live renderer
(RenderFrameHost) might fail.

That case used to be a DCHECK, but since this happens in the
wild and is reproducible, this CL removes the DCHECK and instead
just bails out early if that happens, since there is no renderer
to send the data to.

It also fixes another place in the same method where the
RenderFrameHost used to be looked up again, but now the one that
has been already found is just reused.

BUG=421949

Review URL: https://codereview.chromium.org/693053002

Cr-Commit-Position: refs/heads/master@{#302481}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/690403002

Cr-Commit-Position: refs/heads/master@{#302480}

In OnSwapBuffersComplete we call PageFlipComplete in BufferQueue, which ensures
the buffers are recycled properly.
However, GpuSurfacelessBrowserCompositorOutputSurface::OnSwapBuffersComplete is
never called as GpuBrowserCompositorOutputSurface directly calls the base class
implementation. This CL fixes it.

BUG=380861

Review URL: https://codereview.chromium.org/697823002

Cr-Commit-Position: refs/heads/master@{#302479}

Currently, the client side arrays feature is controlled by a compile flag.
And the flag is only defined in nacl build. This change uses a variable to
control it. So we could enable it in runtime.

BUG=429179

Review URL: https://codereview.chromium.org/702493002

Cr-Commit-Position: refs/heads/master@{#302478}

GrContext::wrapBackendTexture will return null in case of failure
but the compositor assumes that this will never happen. This will
make GetSkSurface early out if the return value of
GrContext::wrapBackendTexture is null.

BUG=419136

Review URL: https://codereview.chromium.org/696353003

Cr-Commit-Position: refs/heads/master@{#302477}

Update the keyboard before notifying observers that it has changed. Observers notified of this change that query the keyboard currently receive inconsistent information.

BUG=429699

Review URL: https://codereview.chromium.org/700573002

Cr-Commit-Position: refs/heads/master@{#302476}

Code changes will be submitted separately.

BUG=398053

Review URL: https://codereview.chromium.org/694873002

Cr-Commit-Position: refs/heads/master@{#302475}

Also removes white cruft on top and bottom of #list while scrolling.

R=arv@chromium.org
BUG=429591

Review URL: https://codereview.chromium.org/696383002

Cr-Commit-Position: refs/heads/master@{#302474}

This isn't overridden by any tests, so make it a private method.

BUG=304341

Review URL: https://codereview.chromium.org/697163002

Cr-Commit-Position: refs/heads/master@{#302473}

This is to clear the observer pointer prior to invalidating the weak factory.

BUG=369796
TBR=perkj

Review URL: https://codereview.chromium.org/685993006

Cr-Commit-Position: refs/heads/master@{#302472}

Suppresses 4 warnings that look like

In file included from ..\..\cloud_print\service\win\cloud_print_service.cc:32:
..\..\cloud_print/service/win/service_controller.h(28,3) :  warning(clang): ISO C++11 does not allow conversion from string literal to 'TCHAR *' (aka 'wchar_t *') [-Wwritable-strings]
  DECLARE_REGISTRY_APPID_RESOURCEID(IDR_CLOUDPRINTSERVICE,
  ^
C:\b\depot_tools\win_toolchain\vs2013_files/VC/atlmfc/include\atlbase.h(3086,10) :  note(clang): expanded from macro 'DECLARE_REGISTRY_APPID_RESOURCEID'
                return _T(appid); \
                       ^
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\tchar.h(2498,21) :  note(clang): expanded from macro '_T'
                    ^
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\tchar.h(206,21) :  note(clang): expanded from macro '__T'
                    ^
<scratch space>(20,1) :  note(clang): expanded from here
L"{8013FB7C-2E3E-4992-B8BD-05C0C4AB0627}"
^
1 warning generated.

BUG=82385

Review URL: https://codereview.chromium.org/686683004

Cr-Commit-Position: refs/heads/master@{#302471}

This code is not being shipped and there are no plans that will
change that. Remove it for now as it means less code to maintain
and will allow some cleanup. It can be added back later if needed.

BUG=
R=piman@chromium.org

Review URL: https://codereview.chromium.org/699643002

Cr-Commit-Position: refs/heads/master@{#302470}

Currently, this metric on cocoa tracks opening the user menu from the
icon or bubble, but on Views only from the icon. We want to also track
opening the new User Menu in Views with this stat.

BUG=NONE

Review URL: https://codereview.chromium.org/702483002

Cr-Commit-Position: refs/heads/master@{#302469}

Also, renaming valid_params and valid_parameters when validating bisect options
to required_params and required_parameters respectively to better reflect what
they actually are.

Fixing some runtime errors introduced by the refactoring to use ArgsParser
instead of OptionsParser.

BUG=424688

Review URL: https://codereview.chromium.org/697713003

Cr-Commit-Position: refs/heads/master@{#302468}

Recognize input type="password" for CVC field

BUG=429343

Review URL: https://codereview.chromium.org/694073002

Cr-Commit-Position: refs/heads/master@{#302467}

Restricts Plugin Power Saver to small content that's cross-origin.

Also handles the temporary whitelist for cross-origin as described by
thestig@ in the design doc.

Design doc: http://goo.gl/iDix3p

BUG=403800

Review URL: https://codereview.chromium.org/680193002

Cr-Commit-Position: refs/heads/master@{#302466}

Updates to address formats and sub-region names.

BUG=NONE

Review URL: https://codereview.chromium.org/687213004

Cr-Commit-Position: refs/heads/master@{#302465}

BUG=

Review URL: https://codereview.chromium.org/691163002

Cr-Commit-Position: refs/heads/master@{#302464}

Syntax of Privacy preferences within Advanced section follows the format at:
https://support.google.com/chrome/answer/2392969
https://support.google.com/chrome/answer/2392971
https://support.google.com/chrome/answer/2392709

Note that this UI text is used by src/chrome/common/localized_error.cc.
However, native code does not have access to internal Android strings like
IDS_PREFERENCES, IDS_PREFS_SECTION_ADVANCED, IDS_PREFS_PRIVACY,
IDS_NETWORK_PREDICTIONS_TITLE.  Therefore unfortunately these strings must be
hardcoded.

TBR=cpu
BUG=422314

Review URL: https://codereview.chromium.org/650903004

Cr-Commit-Position: refs/heads/master@{#302463}

Create a platform-independent ToolbarActionViewController
and platform-independent ExtensionActionViewController, and
wire the controller into the cocoa implementation. Add
platform specific implementations as needed.

BUG=422976

Review URL: https://codereview.chromium.org/670463004

Cr-Commit-Position: refs/heads/master@{#302462}

Fix two potential crashes in ExtensionToolbarModel.

Review URL: https://codereview.chromium.org/684373004

Cr-Commit-Position: refs/heads/master@{#302461}

Revert of Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/686683005/)

Reason for revert:
Undo the revert, it wasn't the cause of the test failures.

Original issue's description:
> Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/696283002/)
>
> Reason for revert:
> Common CL assumed to be causing Android Tests to fail:
>
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16593
> and
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23875
>
> Original issue's description:
> > Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5).
> >
> > TBR=machenbach@chromium.org
> >
> > Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4
> > Cr-Commit-Position: refs/heads/master@{#302437}
>
> TBR=machenbach@chromium.org,v8-autoroll@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/56957b6e401489d556fe87e5ca77b1e36170314f
> Cr-Commit-Position: refs/heads/master@{#302458}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/680393004

Cr-Commit-Position: refs/heads/master@{#302460}

The UserManager will now set the ProfileInfoCache's "signin required" bit to false after the browser's opened rather than before, so that it can be read during startup.

BUG=420762

Review URL: https://codereview.chromium.org/694593002

Cr-Commit-Position: refs/heads/master@{#302459}

Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/696283002/)

Reason for revert:
Common CL assumed to be causing Android Tests to fail:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16593
and
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23875

Original issue's description:
> Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5).
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4
> Cr-Commit-Position: refs/heads/master@{#302437}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/686683005

Cr-Commit-Position: refs/heads/master@{#302458}

dpks-query is spamming stderr when the packages we query are not found.
Silencing stderr for dpkg-query.

BUG=429719
NOTRY=true

Review URL: https://codereview.chromium.org/695373002

Cr-Commit-Position: refs/heads/master@{#302457}

This patch adds support for copying the Chromium library from the APK file
to a separate file.

This patch is largly based on https://codereview.chromium.org/673093005/.

BUG=390618

Review URL: https://codereview.chromium.org/684163002

Cr-Commit-Position: refs/heads/master@{#302456}