- 18 Dec, 2020 40 commits
-
-
Frédéric Wang authored
This CL removes host name "localhost.localdomain" from the list of known localhost addresses. This means it will be resolved using the native DNS resolver rather than Chrome's internal one and that it won't be treated as "potentially trustworthy" origins [1] [2]. This aligns with the behavior of WebKit and Firefox, is expected to have low backward compatibility risk and one can configure things to preserve existing support [3] [4]. [1] https://tools.ietf.org/html/draft-west-let-localhost-be-localhost-06 [2] https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy [3] https://chromestatus.com/feature/5668106045227008 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/hq4iR3UTyNw Bug: 1153337 Change-Id: Ie141a973783a142cd65117fe4904cc3c1f608b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577688Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#838446}
-
Eric Lawrence authored
Launching of URL protocol schemes handled by external applications is gated on a user-gesture check that allows only one attempt to launch such applications per gesture. This is a security measure to prevent malicious web content from trying to flood the user with prompts. Unfortunately, user-gestures are only recorded for interactions in the web content area, and thus the protection can block attempts to launch protocol handlers from bookmarks or the omnibox. Fix this by exempting such invocations from the user-gesture check. Bug: 1156651 Change-Id: I4860d9e75b9ed8426364a5006e4bc119776118c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581446Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838445}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7d265e7818a..13ce523300da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If1ac7c5f51c69fce7d1e56b2f8815f554a2e6e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598046Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838444}
-
Morten Stenshorne authored
These have been failing on linux_layout_tests_layout_ng_disabled ever since they got added in September: https://chromium-review.googlesource.com/c/chromium/src/+/2410039 TBR=fs@opera.com Bug: 1160211 Change-Id: Ia77ca4e42c9576ebc4a8bb2bb9b0041700aa4780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597580Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838443}
-
Morten Stenshorne authored
Needed after https://chromium-review.googlesource.com/c/chromium/src/+/2587607 TBR=jarhar@chromium.org Bug: 561071 Change-Id: I8f09b6d59265ebfdbbab867794ed4c0f31e82c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595284Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8592111e458d..2157c5d256c2 2020-12-18 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2020-12-18T04:04:58). 2020-12-17 handellm@webrtc.org RtpTransceiverInterface: introduce HeaderExtensionsNegotiated. 2020-12-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1a8a708c..31e5ea78 (838088:838188) 2020-12-17 hta@webrtc.org Declare the Clone operator of SessionDescriptionInterface as const. 2020-12-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c8be2f62..1a8a708c (837967:838088) 2020-12-17 mbonadei@webrtc.org Make RTC_OBJC_EXPORT respect is_component_build. 2020-12-17 ivoc@webrtc.org Fix for overflow in iLBC code. 2020-12-17 ivoc@webrtc.org Use low latency mode on Android O and later. 2020-12-17 philipp.hancke@googlemail.com sdp: remove extra check for attribute type when parsing fingerprint 2020-12-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6370178a..c8be2f62 (837763:837967) 2020-12-17 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2020-12-17T07:06:37). 2020-12-17 jianj@google.com Decide Av1 num of threads on frame size and available cores. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051821,chromium:1158070,chromium:1159620 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If073586bcef31634763c4ce841302fa0f1980b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838441}
-
Fredrik Söderqvist authored
We can't clip with a proper visual rect that includes effects from filters during pre-paint, because filters may not have been updated yet. Since the visual rect no longer include bounds from filters, clipping to them is too restrictive. Drop said clipping from LayoutSVGResourceMasker::ResourceBoundingBox(). This in turn means that the |mask_content_boundaries_| member field as well as the code to compute it is dead, so remove them as well. Bug: 1153600 Change-Id: I633deccba1a841750b4ef920725b59526b9846e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566822Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#838440}
-
Rainhard Findling authored
Bug: 1152336 Change-Id: I3eefeca6ca9809d1275d970c5e22acb61a9a1740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596343Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#838439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36bcb86f66a4..a7d265e7818a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ib07a7c5679496a184aadf17fa4015347a073b2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597395Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iadb3f2a862fd2e03257b099a048e73f33acad08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596886Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/415642b766fa..b9a172aaef22 2020-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1ca6504eb7bb to 1cc5b3357d2f (2 revisions) 2020-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 909ea88b5e6d to de703db564d6 (5 revisions) 2020-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 09282fd5 to a51698b2 (491 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Test: Test: Test: BufferStorageTestES3.BufferStorageFlagsPersistentCoherentWrite Change-Id: I1d770cc26ec1e1b052eab578ded446d5f9d709ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597833Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ee977a0df8e3..64c5d601f89b 2020-12-17 enga@chromium.org Update ComputeStorageBufferBarrierTests to use WGSL 2020-12-17 enga@chromium.org Update DynamicBufferOffsetTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I318647264712f4b8659c30cb6965ba8ff207f6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598157Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608249589-e11ce53a2384150a68c372a42aa0334667012fbb.profdata to chrome-mac-master-1608270660-18803338ac16174284c6f853c8c8e431f99a687d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifd7a10a8e5f7a19ee87adc81223ffbb09548cf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598317Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608249589-9c170b057d7f5d331838398008b8ec38a41e02e3.profdata to chrome-linux-master-1608270660-61058158d4c2c4d0ef6b26849a7fbe6b1e868c2c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic23732a9ac383da3dca83a5280a8201c6a30d635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598102Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination in //android_webview since blink::mojom::ResourceType is deprecated[1]. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I9bb4817971029420ac30abfd52075f7df2f52edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596909Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#838432}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_ShouldOverrideUrlLoading to FrameHost interface. This CL moves the handler of the existing IPC message from AwContentsMessageFilter to AwRenderViewHostExt. Bug: 1157131 Change-Id: I29ab375d5502ab3af465ffcca769dfb3980d5843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592534Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Ian Barkley-Yeung authored
WebUI JavaScript error reporting is only launching on Linux and Chrome OS for now. Maybe Windows or other platforms some day, but not in the near future. Correct #ifdefs and flag description text. BUG=chromium:1121816 Change-Id: I13d25210a1b4bd93079edcb2987ae25ba76bf85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596831Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43abbad0ebd2..36bcb86f66a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144488 Tbr: Change-Id: I2dd6e02a067f61660cd632451228732d571f3e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597072Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72f25b4b486d..50f3473f0f8a 2020-12-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8ac322226ffd6335c581326e858805a3fd8f59da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598100Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/af6738a7..68e7e8e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7fea2ae78479139c554b60d84cb6f9bb8c789011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596037Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838427}
-
Lachlan Ford authored
Implementation of webxr anchors in the OpenXR vr device. GetInputSourceSpace is introduced but left unimplemented as anchors will never be created using input spaces. The method is there for completion but is expected to be implemented when OpenXR hit-testing is implemented. Change-Id: I4ff9d4b1f5e7f039242427efd79a0d6bcb3d91c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493061 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#838426}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ed863a30a95..415642b766fa 2020-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b31cd871ad10 to 64c5d601f89b (7 revisions) 2020-12-18 bsalomon@google.com Fix alignment when getting slice in GrVkGpu for upload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Id0f0505c32aa57ee3827277b0f793131befc7bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598162Reviewed-by:
-
David Maunder authored
Two bugs were discovered 1) If a Tab navigates to a new URL, the ShoppingPersistedTabData should be invalidated. Otherwise we will return ShoppingPersistedTabData for the previous URL. To achieve this an observer on onUrlUpdated is added to delete the saved ShoppingPersistedTabData and disassociate the object with the Tab via UserDataHost. We should also do this on a tab close. 2) An observable supplier was not registered for ShoppingPersistedTabData. This pattern is used to control turning saving of the PersistedTabData object (in this case ShoppingPersistedTabData) on and off. Bug: 1159657 Change-Id: I5ac0d914cb1f03e0bdc9efc7914458dc16877d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596435 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#838424}
-
Maggie Chen authored
With the command line switch "show_dc_layer_debug_borders", green debug borders will be displayed for the root damage rect. This damage rect does not include the damage from overlays except for some beginning overlay frames. Bug: 1117235 Change-Id: Ic7c13e7cdf5b0fd1f6c3ca958331f2a4b0ec47a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595975 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#838423}
-
Wanming Lin authored
Currently SetTimeout(..., 0) is clamped up to 1ms while which is not supposed to be in the spec. This CL is intended to fix the tests that become flaky with https://chromium-review.googlesource.com/c/chromium/src/+/2578703 Not all setTimeout 0 -> 1 in the web tests are strictly necessary, I only change the affected tests. Bug: 402694 Change-Id: Ie6e0ef0352146dec11f412fbea3999f37e895005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593716 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#838422}
-
Jeremy Roman authored
This appears to leak all mapped shared memory forever at present. Bug: None Change-Id: I67b44a7e1db5daa4885a1d6b1988fbaba30c3ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596999Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#838421}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 971e0b95. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I92f9c520205794c845057578e051e1bd2428f85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597545Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838420}
-
Liquan (Max) Gu authored
Context: Opening a PDF in Payment Handler UI is a use case that's too rare to support. This CL disallows this behaviours to avoid any PDF-related risks. Before this CL, the WebContents in desktop PaymentHandler UI could navigate to a pdf file. After the CL, the WebContents could not navigate to PDF file. Bug: 1159267 Change-Id: Ic682bbf8a9c75e40658f1e17e423cf77b0847386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595453Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#838419}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b778fd86daf8..43abbad0ebd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kmilka@google.com Change-Id: Id39724fa88a9df4d60edd661c97e2eb24a0abcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595226Reviewed-by:
-
Aleks Totic authored
My very large table test used to be 50% slower in TablesNG compared to Legacy. 3576733 36.7g 950.3m 0.0 0.5 1:37.01 tables_ng 3577099 36.6g 847.5m 0.0 0.4 0:57.16 legacy The slowdownwas triggered by PrePaintTreeWalk taking much longer in TNG. This happened because in TNG rows were never skipped in PrePaintWalk. This was because ObjectRequiresPrePaint returned true in NG, false in Legacy. The object.bitfields_should_check_for_paint_invalidation_ flag was set in NG, not Legacy. The root cause was that LayotutBox::CachedLayoutResult was indiscriminatey calling ClearNeedsLayout. ClearNeedsLayout always calls SetShouldCheckForPaintInvalidation. If we only call ClearNeedsLayout if NeedsLayout is true, TablesNG performance is only 6% slower. 3853570 950.9m 0.0 0.5 1:03.50 content_shell NG 3853829 847.0m 2.6 0.4 0:57.33 content_shell Legacy Bug: 958381 Change-Id: Ic4cfb77f6a65a6e77824fe8e035860c8ed6d9218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594077Reviewed-by:
-
Toni Barzic authored
Adds a toast that's shown when the hardware camera privacy switch (which turns off the camera) gets toggled. A notification shown to the user if they try to use camera while the camera privacy switch is on. BUG=1159919 Change-Id: Ia1b3292dd064d05542cf41554346f3909d74a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597697 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838416}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.55. R=machenbach@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: Iab5bdde1ae888309424dcd5c0c0fb17df7767abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598217 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#838415}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ic38b9c87c73119accea204c075b1095a8c244ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596566 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#838414}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/74ebd7e6ceaa..6ed863a30a95 2020-12-18 johnstiles@google.com Rewrite faceforward/refract to work around Adreno driver bug. 2020-12-18 fmalita@chromium.org Reland "[svg] Absolute positioning support for text" 2020-12-18 adlai@google.com Yank out old reduceOpsTaskSplitting code 2020-12-18 ethannicholas@google.com Reland "Reland "Reland "Reland "Revert "Initial land of SkSL DSL.""""" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I6201ccd10da353c46dd39674df339165a1561d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597901Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49872c09220e..72f25b4b486d 2020-12-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8239d0a6d5c9cfe06674955ed06c183551315186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598158Reviewed-by:
-
David Bienvenu authored
Also fixes some cpplint errors. No functional changes. Bug: 1010217 Change-Id: I4127bf0b033c28658a3f19632e034618ad984e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597222Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8481473d..af6738a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0af899620de995f1298d179e892b8101e4148d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598177Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608216969-d8963b2867fbdeca37528114dc3700d4528ac121.profdata to chrome-win64-master-1608228003-e74739fcdefa7518b67623025a08d95b63f00b00.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0f091a4cdfe583c11c75fe3c7eac4a52161cdf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595223Reviewed-by:
-
Ian Barkley-Yeung authored
Improve the WebUI JS Error Reporting browsertest by confirming we are also getting good stacks with actual function names. Bug: chromium:1121816 Change-Id: I0106b71709a9a266cca5e2a02097ebbaf5e66318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598007 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#838408}
-
rajendrant authored
This CL records login to password entered site, and login to preloaded list of sites commonly user enter password. This information is maintained in SiteIsolation, and plumbed to LoginDetection code. Bug: 1159981 Change-Id: Ifabbd34383971e434e9af356b93017fc4b4f251a TBR: robertogden@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597184Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#838407}
-
