- 04 Dec, 2018 40 commits
-
-
Matt Menke authored
They've been commented out since they landed in https://codereview.chromium.org/2641413003, almost two years ago. The files don't currently exist, and it's not clear why they were commented out in the first place (Did they exist at the time?). Regardless, they seem to add no value, and mess up auto-sorting of the gn file. Bug: none Change-Id: I663f7665f522e6bf5c6c3930517d398d26c70427 Reviewed-on: https://chromium-review.googlesource.com/c/1358646 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#613424}
-
Takuto Ikuta authored
This is a reland of 181b0c85 Change: Set is_chromeos_chrome in !is_chromeos case too. Original change's description: > [build] symbol_level=1 in simple chrome by default > > In simple chrome build, link time of chrome is around 1 minute. > This is due to default symbol_level=2 in simple chrome build. > > For faster link time, I will remove symbol_level=2 from simple chrome. > https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1356679 > > But we want to see stacktrace both on x86 and arm device, so setting symbol_level = 1 in this CL. > symbol_level=1 improves link time of chrome from 61.1s to 34.6s in simple chrome build. > > Change-Id: Ie484bc4305d908a0b38fa60c2c57d2a4f7cb3c70 > Reviewed-on: https://chromium-review.googlesource.com/c/1358616 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613389} Change-Id: I1a5d36a7b74e28282921cc14563e5b407fcbaf5f Reviewed-on: https://chromium-review.googlesource.com/c/1360194Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#613423}
-
Hiroki Nakagawa authored
For off-the-main-thread shared worker top-level script loading, this CL cleans up startup sequence in WebSharedWorkerImpl. Specifically, this CL... - factors out WorkerClients creation and WorkerThread creation from ContinueOnScriptLoaderFinished() into CreateWorkerClients() and StartWorkerThread(), - uses FetchClientSettingsObjectSnapshot as much as possible instead of directly asscessing Document in order to remove WorkerShadowPage later. Change-Id: I9a9c864f6234c6bd5042fabcdbc3fd4f1cbacd7c Bug: 835717 Reviewed-on: https://chromium-review.googlesource.com/c/1358110 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#613422}
-
Stuart Langley authored
Bug: 884020 Change-Id: I056a5a830c8ca5821d6ca3338372ee27702c0ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1355308 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#613421}
-
Yutaka Hirano authored
Getting a user-agent string in a sandboxed process results in a wrong value, so move GetUserAgent and GetProduct functions from ContentClient to ContentBrowserClient. Bug: 818450 Change-Id: I611228e8966c13b6429726fbf77302a32108f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/1352086 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613420}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64a001ef13c8..ffb5052e431c git log 64a001ef13c8..ffb5052e431c --date=short --no-merges --format='%ad %ae %s' 2018-12-04 tandrii@chromium.org delete unused api.gerrit.get_change_destination_branch. Created with: gclient setdep -r src/third_party/depot_tools@ffb5052e431c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id5dc4fb4e623cceefef420cf704fc5e0726f7352 Reviewed-on: https://chromium-review.googlesource.com/c/1359723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613419}
-
Evan Stade authored
Bug: 905430 Change-Id: Ie6a7886a351c0ea75c92947bc5a7829762e8bd8c Reviewed-on: https://chromium-review.googlesource.com/c/1355759 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#613418}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ff03e51ea25e..e3e680ca47dc git log ff03e51ea25e..e3e680ca47dc --date=short --no-merges --format='%ad %ae %s' 2018-12-04 jmadill@chromium.org Remove State::syncProgramTextures. Created with: gclient setdep -r src/third_party/angle@e3e680ca47dc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ic33d7791a5506fd5703b44fbde7b204449c7fa3d Reviewed-on: https://chromium-review.googlesource.com/c/1360161Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a201204215f0..d0b69a8c50f4 git log a201204215f0..d0b69a8c50f4 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 kron@webrtc.org Send and receive color space information if available Created with: gclient setdep -r src/third_party/webrtc@d0b69a8c50f4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6c7e7016e5eb96466d71a296716a2c653230394d Reviewed-on: https://chromium-review.googlesource.com/c/1360159Reviewed-by:
-
Noel Gordon authored
- add background BUILD rule for mock_crostini - make mock_crostini visible to foreground code - include mock code in foreground unittests.html - change background / foreground tests to use it No change in test behavior. Bug: 911024 Change-Id: I15e3b243cea5937111da66ac504e143116bcbf0d Reviewed-on: https://chromium-review.googlesource.com/c/1358321 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c294315e5a9..e1d45d5c88fb git log 8c294315e5a9..e1d45d5c88fb --date=short --no-merges --format='%ad %ae %s' 2018-12-04 wonderfly@google.com chromeos_config: Add all lakitu release builders to master-lakitu-release Created with: gclient setdep -r src/third_party/chromite@e1d45d5c88fb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0074fcc4ced67272faeeccccc3fce9c961cf1d8f Reviewed-on: https://chromium-review.googlesource.com/c/1360155Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I2b8882439da8fcc5c09d4f5e91d93361212adffe Reviewed-on: https://chromium-review.googlesource.com/c/1359978Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#613413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0b201b07e499..99cc65bc5d90 git log 0b201b07e499..99cc65bc5d90 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 35cd7332ab62..66f0d2c1e7b5 (4 commits) 2018-12-03 benjaminwagner@google.com Upgrade Win10 Intel Skylake GPU driver. Created with: gclient setdep -r src/third_party/skia@99cc65bc5d90 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I901df990ba99b0f40506d62c9d0980d7068962c6 Reviewed-on: https://chromium-review.googlesource.com/c/1360152Reviewed-by:
-
Sunny Sachanandani authored
Remove extraneous parameters and remove the unnecessary shared state split. Add documentation for each parameter. Followup cleanup planned: 1) Move direct composition surface from gpu/ipc/service to ui/gl 2) Move ProtectedVideoType to ui/gfx so that viz/common doesn't need to depend on ui/gl 3) Split direct composition surface and its helpers Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I507209d66229183dc00c3039b9e2db7629f39d14 Bug: 909827 Reviewed-on: https://chromium-review.googlesource.com/c/1292515 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#613411}
-
Fabio Tirelo authored
When the new dropdown is shown in landscape mode, most vertical space is occupied with the on-screen keyboard and the sticky footer options, leaving not enough space to actually show the suggestions. This CL adds a quick fix that prevents the most common cases by allowing the dropdown to only be shown in landscape mode when we are sure that we have enough vertical space (e.g. tablets). This will allow us to at least to experiment on the new dropdown in M72 and collect metrics to understand the size of the affected population and make an informed decision on how we should address this issue. Moving forward, the plan to properly fix this is: - [short term] Make the footer non-sticky; - [long term] Move away from the dropdown and show suggestions in the keyboard accessory. A follow-up CL will add a new bucket to Autofill.FormEvents to track how often that happens. Bug: 905081 Change-Id: Ia8f8b14f987e13e8d9f0afc021d156fbf4238af6 Reviewed-on: https://chromium-review.googlesource.com/c/1346734 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#613410}
-
Zakhar Voit authored
* ONC normalizer now removes StaticIPConfig fields that are overriden by IPAddressConfigType and NameServersConfigType. * ONC validator validates StaticIPConfig properly (e.g. requires fields based on IPAddressConfigType and NameServersConfigType) Bug: 847429 Change-Id: I47fceaaf10f41346afba552a35206fcdb130a887 Reviewed-on: https://chromium-review.googlesource.com/c/1288576Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d87b09662ee8..64a001ef13c8 git log d87b09662ee8..64a001ef13c8 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 sergiyb@chromium.org Add support for retry command to buildbucket.py Created with: gclient setdep -r src/third_party/depot_tools@64a001ef13c8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:911143 TBR=agable@chromium.org Change-Id: I8cf02c8854e28ccf1a360495e5a7eb10ce6e0a5e Reviewed-on: https://chromium-review.googlesource.com/c/1359374Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/f701a90597fc..277022e0e51a git log f701a90597fc..277022e0e51a --date=short --no-merges --format='%ad %ae %s' 2018-12-04 dschuff@chromium.org Yet another whitespace change Created with: gclient setdep -r src/native_client@277022e0e51a The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: Ibacc7550a92bf2d7a87314bf610d6fcd48eaad9c Reviewed-on: https://chromium-review.googlesource.com/c/1360154Reviewed-by:
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/1343472 tried to do this, but it only updated one of two conditionals. clang-based NaCl compilers used to encode the absolute path to each .o file twice in each .o file. After this, it's still encoded one time, so this doesn't really help with making nacl compiles deterministic, but it helps a bit. Bug: 906741 Change-Id: Idfe83764a1691719f7aa93dcf97f6c7be4e4772e Reviewed-on: https://chromium-review.googlesource.com/c/1359972Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613406}
-
John Lee authored
Bug: 902387 Change-Id: I6ce83c4434122e038f372b6f9a19229b6dca5552 Reviewed-on: https://chromium-review.googlesource.com/c/1354501Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613405}
-
Kunihiko Sakamoto authored
The test was flaky because internals.settings.setViewportMetaEnabled() for the child window was called too early, before the initial settings are applied to the new window. Bug: 613887 Change-Id: I8222e616ce1489671dc9ea43724ad3a1ad70f91d Reviewed-on: https://chromium-review.googlesource.com/c/1356175Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613404}
-
Zhiqiang Zhang authored
This reverts commit 74e258c6. Reason for revert: The previous revert was wrong. This is still a necessary change Original change's description: > Revert "[Android MR] Postpone route selection until session launch" > > This reverts commit 7c453583. > > Reason for revert: This introduces some regression in some cases. The old logic works just fine so it is safe to revert. > > Original change's description: > > [Android MR] Postpone route selection until session launch > > > > Previously, we unselect and re-select the route due to CAF limitation. > > The reason is that we need to set the receiver app ID after the user > > choose a device. However CAF won't be able to know a device was selected > > after the receiver app ID gets changed. > > > > In this CL, to solve the issue, we intercept the click event in > > MediaRouteChooserDialog (which would select the route automatically). > > The route selection is postponed right before session launch. Therefore > > we are able to set the receiver app ID and select the route to get rid > > of CAF limitation. > > > > Bug: 711860 > > Change-Id: I5b1534d36d540b62199a6fb739c56ad5131c2711 > > Reviewed-on: https://chromium-review.googlesource.com/c/1351893 > > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > > Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611437} > > TBR=zqzhang@chromium.org,tguilbert@chromium.org > > Change-Id: I30322daecf8c866fdda9e846d0cb37d9a319f033 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 711860 > Reviewed-on: https://chromium-review.googlesource.com/c/1352973 > Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org> > Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611572} TBR=zqzhang@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 711860 Change-Id: I8bbeeb9e6917e07163bb0fbfacd1fa1c3f762a49 Reviewed-on: https://chromium-review.googlesource.com/c/1359822Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613403}
-
Kenichi Ishibashi authored
Bug: N/A TBR=yhirano@chromium.org Change-Id: I65b6ca092f4da2e73571fc1efed72294742c2832 Reviewed-on: https://chromium-review.googlesource.com/c/1359832Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613402}
-
Alexander Alekseev authored
Bug: 891277 Change-Id: I8d8733fd4ad1003a9f801d7b529d70572a3c248d Reviewed-on: https://chromium-review.googlesource.com/c/1338882Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#613401}
-
Gabriel Marin authored
CollectionParams will need to be visible to multiple classes in metrics/perf, but not outside the CWP code, so it is stored as a top level class in an internal namespace. This CL is part of a larger restructuring of the PerfProvider class to enable additional collectors. BUG=b:116527691 TEST=Unit tests pass Change-Id: I625d71685fba2042599c57f27fea0462eabc1f8c Reviewed-on: https://chromium-review.googlesource.com/c/1343353 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613400}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec086d842ce7..a201204215f0 git log ec086d842ce7..a201204215f0 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 amithi@webrtc.org Adding SDP parsing for Simulcast. Created with: gclient setdep -r src/third_party/webrtc@a201204215f0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3b948979fcc7ddc7cc57c2f78fc6bf97f6b43548 Reviewed-on: https://chromium-review.googlesource.com/c/1359573Reviewed-by:
-
bsheedy authored
Updates the VR goldens from the microphone permission prompt test that recently changed slightly due to a controller rendering change. Also re-enables the affected test which was disabled due to the failures. TBR=bajones@chromium.org Bug: 911144 Change-Id: Ia621c84a37ec45e35126145374f1dd72f28bf0ea Reviewed-on: https://chromium-review.googlesource.com/c/1359315Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613398}
-
Takuto Ikuta authored
This reverts commit 181b0c85. Reason for revert: broke build Original change's description: > [build] symbol_level=1 in simple chrome by default > > In simple chrome build, link time of chrome is around 1 minute. > This is due to default symbol_level=2 in simple chrome build. > > For faster link time, I will remove symbol_level=2 from simple chrome. > https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1356679 > > But we want to see stacktrace both on x86 and arm device, so setting symbol_level = 1 in this CL. > symbol_level=1 improves link time of chrome from 61.1s to 34.6s in simple chrome build. > > Change-Id: Ie484bc4305d908a0b38fa60c2c57d2a4f7cb3c70 > Reviewed-on: https://chromium-review.googlesource.com/c/1358616 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613389} TBR=derat@chromium.org,jamescook@chromium.org,stevenjb@chromium.org,tikuta@chromium.org Change-Id: I95e41dfd343eb9be265c9dd61ea70dd26c06ca4a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1360252Reviewed-by:
-
Varun Khaneja authored
Previously: Use the address of the URLCheckCallbackMeta object as a callback_id. This id was is to track the pending requests in Java. When a response is received, reinterpret the callback ID as an address to the URLCheckCallbackMeta object and then call Run on the callback object. This caused a race condition if the request timed out in Java and the object address got re-used. See: crbug/889972#c44 Now: Maintain a map of pending requests sent to Java in a map <callback_id (int), URLCheckCallbackMeta>. When a response is received, look up the map on IO thread to get the callback object to respond to. The callback_id is based off an incrementing counter, not derived from the address of the callback object. Bug: 893110,889972 Change-Id: I503379ecb1e3f52fc31c272386b1d2f1b065586c Reviewed-on: https://chromium-review.googlesource.com/c/1359308 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613396}
-
Joel Einbinder authored
Files not from the filesystem, or not with green dots, are way more likely to be relevant to the user. Bug: 806225 Change-Id: I59e9727cf336299a459323a8357c3c242d965034 Reviewed-on: https://chromium-review.googlesource.com/c/1359468Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#613395}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b8b9a06ee3d..c49ee63d5e98 Created with: gclient setdep -r src-internal@c49ee63d5e98 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I173b031be2bd7782081d1bd76348ed1136ef170c Reviewed-on: https://chromium-review.googlesource.com/c/1359113Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613394}
-
Wez authored
Always log kernel serial output to a temporary file on the host, so that if we're unable to establish connectivity to the QEMU guest then we can dump the contents of that file for diagnostic use. Bug: 909936, 869753 Change-Id: Ie44ea6f6d0ccaedbae6994651ec13568ad241a40 Reviewed-on: https://chromium-review.googlesource.com/c/1359483Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#613393}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4f870714be35..4feee5840de2 git log 4f870714be35..4feee5840de2 --date=short --no-merges --format='%ad %ae %s' 2018-12-04 crouleau@chromium.org [Telemetry] Deprecate --smoke-test-mode flag. Created with: gclient setdep -r src/third_party/catapult@4feee5840de2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894254 TBR=sullivan@chromium.org Change-Id: I60b05d06fbd591a7c80bae9787e415abeea4de97 Reviewed-on: https://chromium-review.googlesource.com/c/1359114Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0cfefd1a1e98..890eac2b7fd1 git log 0cfefd1a1e98..890eac2b7fd1 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tsepez@chromium.org Prefer WideString() over L"". 2018-12-03 tsepez@chromium.org Kill off most remaining wide string literal comparisons 2018-12-03 thestig@chromium.org Restructure EAN barcode classes to merge common code. 2018-12-03 tsepez@chromium.org Avoid malloc/copy in CFX_WideTextBuf::operator<<(const ByteStringView&) Created with: gclient setdep -r src/third_party/pdfium@890eac2b7fd1 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I627e3b9e425d7cde579165acbc821be60d476c5b Reviewed-on: https://chromium-review.googlesource.com/c/1358810Reviewed-by:
-
Brandon Wylie authored
Reports metrics occurring in Java to the native CachedImageFetcher reporting infra. Bug: 905732 Change-Id: I9f25527fa9459bf1e433f6169de0640b6600248a Reviewed-on: https://chromium-review.googlesource.com/c/1347510 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#613390}
-
Takuto Ikuta authored
In simple chrome build, link time of chrome is around 1 minute. This is due to default symbol_level=2 in simple chrome build. For faster link time, I will remove symbol_level=2 from simple chrome. https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1356679 But we want to see stacktrace both on x86 and arm device, so setting symbol_level = 1 in this CL. symbol_level=1 improves link time of chrome from 61.1s to 34.6s in simple chrome build. Change-Id: Ie484bc4305d908a0b38fa60c2c57d2a4f7cb3c70 Reviewed-on: https://chromium-review.googlesource.com/c/1358616 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Write and pass a test case for an invalid AXTree. Test exposed error handling not previously considered. This change list depends on https://chromium-review.googlesource.com/c/chromium/src/+/1351782. Change-Id: Ie5e65f6583a9baf6861a95e7db4969bd3ec0e979 Reviewed-on: https://chromium-review.googlesource.com/c/1357530 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#613388}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/66f0d2c1e7b5..ff03e51ea25e git log 66f0d2c1e7b5..ff03e51ea25e --date=short --no-merges --format='%ad %ae %s' 2018-12-03 jmadill@chromium.org Copy PDBs in update_canary_angle. Created with: gclient setdep -r src/third_party/angle@ff03e51ea25e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: If6a41b9f074d40826ef34d7f7c00270222f3468d Reviewed-on: https://chromium-review.googlesource.com/c/1358770Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 910488 Change-Id: I566c42a2a6141d963b538208a400b38fcdc64e4e Reviewed-on: https://chromium-review.googlesource.com/c/1359292 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#613386}
-
Hui(Andy) Wu authored
The status message of bottom sheet gets cut if it's more than 1 line, change the config for height to 'wrap_content' fixes the issue. Also change a casting in BottomBarAnimations.java, because we don't need the casting to concrete type here. Change-Id: Ia01cc5f0ebee89a01c882d5a1159507f27cf4458 Reviewed-on: https://chromium-review.googlesource.com/c/1359317Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
