- 20 Jul, 2017 40 commits
-
-
Sam McNally authored
Remove the deprecated ChildProcessHost::CreateChannelMojo overload and migrate its final user (service utility process) to the other overload. This requires the service process to directly connect to the service_manager.mojom.Service interface to bind interfaces and claim to be the browser service when binding interfaces so ChildThreadImpl allows the IPC bootstrap request. Change replay process to support the non-deprecated approach of using the initial mojo handle as a service_manager::mojom::ServiceRequest. Change chrome/utility/importer/firefox_importer_unittest_utils_mac.cc to define its own constant for the channel token and remove the shared content::switches::kMojoChannelToken. Bug: 666605 Change-Id: Ib0721eecae5f53373262d320ebeb23745b62c7c1 Reviewed-on: https://chromium-review.googlesource.com/564914Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488159}
-
Yoichi Osato authored
Since we can split marking SelectionState and invalidate painted LayoutObject. SelectionPaintRange has both info but we should split it. This patch introduces SelectionMarkingRange which is just copy from SelectionPaintRange class. I will drop unused functionality from each class in later patches. Bug: 739062 Change-Id: I6ffececbf96228f1b7593ac82e49632b1a348760 Reviewed-on: https://chromium-review.googlesource.com/578701Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488158}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e867917..0850262f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I5f911c135d6900cd0be45a25aca76b93226b3e11 Reviewed-on: https://chromium-review.googlesource.com/578399Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#488157}
-
Brett Wilson authored
We previously removed the optimization that this option turned off but forgot to remove the option. It currently does nothing, so removing it is a no-op. Change-Id: Iefe122b9351dbe06f88fec098d4267b789b8e786 Reviewed-on: https://chromium-review.googlesource.com/578245 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#488156}
-
Yutaka Hirano authored
Bug: None Change-Id: I939a06f5d554101cea344f092f8de63bfb15e758 Reviewed-on: https://chromium-review.googlesource.com/575113 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488155}
-
Kent Tamura authored
This reverts commit 0627c931. Reason for revert: Link failure on some Windows bots. e.g. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_Builder%2F42057%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Remove unnecessary #includes from Assertions.h > > Change-Id: I9d9a0ff0c56a10923e393d4eef7ccde7b33c4a2b > Reviewed-on: https://chromium-review.googlesource.com/578532 > Commit-Queue: Yuta Kitamura <yutak@chromium.org> > Reviewed-by: Yuta Kitamura <yutak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488149} TBR=yutak@chromium.org,tkent@chromium.org Change-Id: If9b9b1ada6a3b45bd3a670b9aaab908401530e9d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/578829Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488154}
-
Andreas Haas authored
The issue which made this test flaky has been fixed in https://chromium-review.googlesource.com/c/559769/, so we can turn this test on again. R=bsep@chromium.org Bug: chromium:736676 Change-Id: I423782d2cd1f299f40a70a1f1595b573fa7646c2 Reviewed-on: https://chromium-review.googlesource.com/576033Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#488153}
-
Peter Kasting authored
Calling one of these APIs results in creating a WebDataRequest object to allow calling back with the result. This object assumed the caller had a ThreadTaskRunnerHandle, but there's no reason callers need to have such a handle. Instead, allow calling any task back, using the thread or sequenced task runner if available, or simply PostTask() if not. Bug: 689520 Change-Id: Icf901e6de5a5b629bcf9d17617baf46a45502844 Reviewed-on: https://chromium-review.googlesource.com/578572 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#488152}
-
ricea authored
Only WebSocket connections from the main page were tested. WebSocket connections from Workers should also lead to display of an interstitial. Modify malware_websocket.html to accept a "type" query parameter indicating which environment to create the WebSocket in. Make the MalwareWebSocketBlocked tests be parameterised on the environment type. Due to a recent change (https://codereview.chromium.org/2960703003), these changes need to be tested by passing --enable-features=NetworkService to browser_tests, as opposed to the --enable-network-service argument that was needed before. BUG=644744 Review-Url: https://codereview.chromium.org/2971333002 Cr-Commit-Position: refs/heads/master@{#488151}
-
apacible authored
This change adds a general window that overlays other windows, initially for the use case of picture in picture. This includes a partially stubbed views implementation. Cocoa work will be done in a separate CL. BUG=726621 Review-Url: https://codereview.chromium.org/2905833004 Cr-Commit-Position: refs/heads/master@{#488150}
-
Kent Tamura authored
Change-Id: I9d9a0ff0c56a10923e393d4eef7ccde7b33c4a2b Reviewed-on: https://chromium-review.googlesource.com/578532 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#488149}
-
Ramin Halavati authored
Network traffic annotation is added to network request of: content/browser/frame_host/render_frame_message_filter.cc BUG: 656607 Change-Id: Ie68e036d5e00aaf4cad0966e6a5e0ce2a1d624b0 Reviewed-on: https://chromium-review.googlesource.com/570029 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#488148}
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Change-Id: I9d8fe29dc0a840e98d070164bb1171334cc32464 Reviewed-on: https://chromium-review.googlesource.com/578660 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#488147}
-
Koji Ishii authored
The word-break:keep-all code was forked in [1]. This patch merges it back to single template function, in preparation of supporting after-white-space in LayoutNG. Includes some cleanup to make IsBreakable() inline function smaller without increasing non-inline function calls. [1] https://codereview.chromium.org/1094863007 BUG=636993 Change-Id: I6471b83437e29f5ee2fcb30473c8eb8d526abf35 Reviewed-on: https://chromium-review.googlesource.com/575799 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#488146}
-
Naina Raisinghani authored
We then change the style of all elements in the tree and benchmark the time spent. This allows us to set up a benchmark for style manipulation done using selectors. This adds test to apply pseudo selectors on: 1. Children of elements 2. Grand children of elements 3. All elements (universal selector) 4. Checking for partrial match for an attribute Bug: 741970 Change-Id: Idb1cb91fbbcc20044cf902bb5e193cb7a73343e0 Reviewed-on: https://chromium-review.googlesource.com/577330Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#488145}
-
Darren Shen authored
This patch adds an OWNERS file to the code generators found in core/css. Currently there's only one file in that folder but this will grow as we move css related code generators into that folder. Bug: 732657 Change-Id: I5987cba699416d40194c029fd7621b1c269b6ef3 Reviewed-on: https://chromium-review.googlesource.com/574898 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#488144}
-
Kent Tamura authored
https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#clamped-to-the-range We had a bug that an attribute value greater than 2^32-1 was handled as a parse error, instead of range overflow. We need to clamp such values to a maximum value defined for a attribute. Implementation: The main change is to introduce blink::ParseHTMLClampedNonNegativeInteger(), and use it in HTMLTableCellElement and HTMLTableColElement. This CL introduces WTF::NumberParsingState in order to pass "fail by overflow" information from platform/wtf/StringToNumber code. Bug: 745376 Change-Id: Ie57a0538816f0f508324573cdcda6d96ad51afb2 Reviewed-on: https://chromium-review.googlesource.com/577428Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488143}
-
proberge authored
Moves the details text in with the title and the remove button. Files to remove list now is a toggle instead of a expand-once section. Bug: 690020 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0301598d48ce2734f9bda0b7a96993cdc2040978 Reviewed-on: https://chromium-review.googlesource.com/576382 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488142}
-
Piotr Swigon authored
This reverts commit 5192ab32. Reason for revert: crbug.com/746616 TL;DR: we're listening for compositor frame swap on browser-process compositor instead of on the renderer-process compositor (which composites the page, instead of the browser UI). Original change's description: > [Installed PWA] Waits for a frame swap before hiding a splash screen. > > This patch fixes the flash of white between the splash screen and the > web content in installed web apps. This is achieved with waiting for > a compositor frame swap before starting splash screen hiding animation. > > Adding callbacks for next frame swap in CompositorViewHolder might not > be at the right level of abstraction - feedback welcome. I introduced > a generic mechanism as we might need it different places as well. > E.g. In CustomTabActivity the same issue is solved with a time delay, > which I plan to change to this mechanism in a follow up patch. > > Existing tests for a webapp splash screen cover showing/hiding it in > various circumstances. Writing a specific test to assert flash of white > is fixed would be more work than it's worth it. > > FYI: On Google Pixel this causes the splash screen to be shown about > 50-100 later, which seems like the time time when flash of white was > visible. > > Bug: 734500 > Change-Id: I70f8bde54f251c283e260d17a291685738f9e080 > Reviewed-on: https://chromium-review.googlesource.com/569552 > Commit-Queue: Piotr Swigon <piotrs@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487336} TBR=mdjones@chromium.org,khushalsagar@chromium.org,dominickn@chromium.org,piotrs@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 734500 Change-Id: Ib8afce105fa818b76492b8fce7da7d17c8e07e6a Reviewed-on: https://chromium-review.googlesource.com/578631Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#488141}
-
Dale Curtis authored
BUG=738595 TEST=existing tests pass TBR=wolenetz Change-Id: I1076fc1a74b7064bff021c5c124f20216fc0867e Reviewed-on: https://chromium-review.googlesource.com/578656Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488140}
-
Mark Pearson authored
Bug: 706046 Change-Id: I9bd0ff5d297f93ff3dbdc92f668c307630d46dc5 Reviewed-on: https://chromium-review.googlesource.com/578659 Commit-Queue: Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#488139}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d7e07ff..2e867917 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I3e0211807103e7f6ce58386936e75d5570825d22 Reviewed-on: https://chromium-review.googlesource.com/578396Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#488138}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/67ccef73bf66..40870db0aade $ git log 67ccef73b..40870db0a --date=short --no-merges --format='%ad %ae %s' 2017-07-19 drgage Add FPDFAnnot_GetFormFieldAtPoint() and embedder tests. 2017-07-19 drgage Add FPDFAnnot_GetFormFieldFlags() and associated embedder tests. 2017-07-19 tsepez Rename StringCs c_str() to unterminated_c_str(). 2017-07-19 caryclark fix continue skia cache flush 2017-07-19 dsinclair Remove unused GetThisAppearanceStream 2017-07-19 dsinclair Create CPWL_AppStream. Created with: roll-dep src/third_party/pdfium BUG=59266,59266 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: If4c2a89080c44d782e6ae44431cfd20c33b2ffff Reviewed-on: https://chromium-review.googlesource.com/578678 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488137}
-
Paul Irish authored
Bug: 745958 Change-Id: I87c0de5d5c7e9d5fc8b6fd38d95dec8013934db8 Reviewed-on: https://chromium-review.googlesource.com/576359 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488136}
-
Miguel Casas-Sanchez authored
This CL lands the client-side implementation of the mojom::VEA and unit tests for it. It doesn't connect it yet, but the final result can be found in https://crrev.com/c/558846. Bug: 736517 Change-Id: I24f29c8893c59e1f16560026e0ed94b611b0651a TBR=tsepez@ for adding [Sync] to the mojom interfaces (that anyway reflects the current IPC). Change-Id: I24f29c8893c59e1f16560026e0ed94b611b0651a Reviewed-on: https://chromium-review.googlesource.com/566145 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#488135}
-
Hajime Hoshi authored
On OnMemoryDump, base::SharedMemory's IDs are used to create ownership edges. However, there is no guarantee that the ID is still valid when OnMemoryDump is called. Actually, some crashes [1] are found when MemoryAllocatorDumpGuid::UseSharedMemoryBasedGUIDs() is true [2]. This CL fixes this bug to avoid dumping when shared memory id is invalid (empty). Also, this CL changes OnMemoryDump use SharedMemory:: mapped_id(), that returns an valid ID only when the shared memory is actually mapped, so that we can avoid unnecessary dumps. [1] https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/501311 [2] This is now always false, but we plan to make this return true to use new ownership edges. Bug: 604726 Change-Id: I2400ba334860e57b9b83a785cd69f4a32b8ef151 Reviewed-on: https://chromium-review.googlesource.com/571386Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488134}
-
Patricia Lor authored
Certain permissions are always denied for insecure (HTTP) origins, and notifications is one of them. Fix SiteDetails.DefaultSettingSource by using a secure (HTTPS) test origin instead. This is to fix a test that broke after r488086 landed. Change-Id: Ieac59f3ff7b19dd64d0d299fb678ce7f6e9ec89e TBR: dschuyler@chromium.org Reviewed-on: https://chromium-review.googlesource.com/578534 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488133}
-
Yutaka Hirano authored
Now it is equivalent to domain == "net" && reason == ERROR_ABORTED. Bug: None Change-Id: Ia39d123a8a15d79a3efbcc86fd1c70f225c51439 Reviewed-on: https://chromium-review.googlesource.com/575112Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#488132}
-
Mark Pearson authored
Bug: 706071 Change-Id: Idcf5feefa594463a1b7295dd30025c1cbc489345 Reviewed-on: https://chromium-review.googlesource.com/578227Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488131}
-
Michael Martis authored
These will help us understand user translate behaviour and how it is affected by various UI decisions. We don't log the cross (source language, target language) as there are too many combinations to use as histogram buckets. Bug: 742684 Change-Id: Idf6a72a6418db820431e75ba1982f260d92bad21 Reviewed-on: https://chromium-review.googlesource.com/572486 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488130}
-
Lei Zhang authored
The attempt to restore this feature in r469749 did not quite do the job and has several issues. BUG=731600,740830,746768 Change-Id: I417611e32e6d3e1bb29c96f6e5de6eee39abc846 Reviewed-on: https://chromium-review.googlesource.com/577374Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488129}
-
Hidehiko Abe authored
This CL replaces last use of MockCryptohomeClient by fake, and then remove it. BUG=739622 TEST=Ran trybot. Change-Id: I9477b540b40789c663657147b8172f5ae189dfc3 Reviewed-on: https://chromium-review.googlesource.com/571244 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488128}
-
Ian Clelland authored
Two changes have landed recently which need to be reflected in documentation for origin trials: - Trials are disabled automatically in the virtual test suite, and do not have to be named explicitly in VirtualTestSuites. - V8 bindings code is now generated automatically This documentation change brings the developer docs up to date with reality. BUG=685788, 615060 Change-Id: Icec69074b654bc749d790136de4e3a72855e3660 Reviewed-on: https://chromium-review.googlesource.com/578171Reviewed-by:Jason Chase <chasej@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#488127}
-
Mark Pearson authored
In the process, removes an unnecessary chrome::FocusLocationBar() in chrome/browser/policy/policy_browsertest.cc because it's not necessary. Two lines later, the test calls ui_test_utils::SendToOmniboxAndSubmit() which immediately sets focus. The current behavior causes a failure (DCHECK) because the omnibox doesn't expect two consecutive SetFocus calls. (Everything else in the omnibox edit system makes sure not bother sending a SetFocus call if focus is already in the omnibox.) TBR=pastarmovj for the trivial change to the policy_browsertest (I would like this to be submitted by branch point, so not waiting for a review.) Bug: 715274 Change-Id: I3c195c4dbd87c5e9c4eec20271d6142c252e3315 Reviewed-on: https://chromium-review.googlesource.com/576615 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#488126}
-
Minh-Duc Nguyen authored
This is an extension for CL https://chromium-review.googlesource.com/c/564903/. In this patch, we also replace the switchcase conversion code from CSS enum to KeywordValue enum. Gen diff: https://gist.github.com/nguyen-minh-duc/97f5a4942b006690bdc0f442f11dff12/revisions https: //chromium-review.googlesource.com/c/564903/ Bug: 744203 Change-Id: I11cc3467aaa4911ff948a570d3d076e59114750e Reviewed-on: https://chromium-review.googlesource.com/572884 Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#488125}
-
Tim Song authored
BUG=741214 Change-Id: I2184b489044fc07de51ca3abbe4d5a5836138411 Reviewed-on: https://chromium-review.googlesource.com/567244 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488124}
-
tzik authored
after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2. As a follow-up of the refactoring, this CL inlines the alias to its users in //base and //cc. base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber Change-Id: I343885b85cce413148ccd6aa9e5fa94913d7fecc Reviewed-on: https://chromium-review.googlesource.com/568063Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#488123}
-
Hayato Ito authored
This is one of the efforts to organize core/dom files. See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing for details. See the similar CL, https://chromium-review.googlesource.com/c/569532/, as I did for intersection_observer. Bug: 738794 Change-Id: I1eb0b47341df4880faddc2df6c7ae9f1dd6ccdb7 Reviewed-on: https://chromium-review.googlesource.com/576597Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#488122}
-
Xing Liu authored
The network change observer notifies the offline signal later than the actual failure in download request. The controller will immediately retry since the state is still online. This CL adds a delay to the retry logic, so it potentially can wait for an actual online timing to retry. Bug: 746082 Change-Id: I42e519618538f6db857b1c173a5bada828c6512d Reviewed-on: https://chromium-review.googlesource.com/575572Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#488121}
-
Timothy Loh authored
- Remove unused requesting_origin_ - Make destructor private - Remove unused GetAcceptState() declaration Change-Id: Ie8a8984d2a6975568cd8b26e57c0844c88acb594 Reviewed-on: https://chromium-review.googlesource.com/575737Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488120}
-