- 07 May, 2018 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/376d927a..e3f3bcb2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I895c1f5f0aaffe25a9d2234b8e373a1ed8f71233 Reviewed-on: https://chromium-review.googlesource.com/1047405Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556476}
-
Gaofeng Huang authored
Caused by: https://chromium-review.googlesource.com/1022186 Bug: internal b/79235281 Test: local build Change-Id: I681c8aa74aa8d374fadf31f136d7c2367a978d3c Reviewed-on: https://chromium-review.googlesource.com/1044486Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556475}
-
Florent Castelli authored
In case the related bug gets fixed in WebRTC, we don't want any build failure when it is rolled out to Chrome. Bug: 803494 Change-Id: I3001c566049067182b1123d2f452f8a8297d5525 Reviewed-on: https://chromium-review.googlesource.com/1047665Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#556474}
-
edchin authored
Previously, an alert was presented as a stub to the undo close all action. This CL updates the egtest to check that the undo operation actually worked, now that the undo close all operation is fully implemented. There already exists more extensive unittesting on the undo close all operation. Bug: 804569 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If30ec4fb457ccfad259f8b79a5a45e9db43a9a1e Reviewed-on: https://chromium-review.googlesource.com/1045227Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556473}
-
Tom Anderson authored
Due to the way workspace data is stored for the session [1], it is necessary not to optimize the case where "workspace_ == workspace_str" because the SessionCommand to set the workspace would not get created on browser start (only when windows are created or moved between workspaces). [1] https://cs.chromium.org/chromium/src/components/sessions/core/session_service_commands.cc?rcl=34077ec24a99e50f6211585b0ae652fe97ced33c&l=756 R=sky Change-Id: I6021c8ce0a5ff38529b88bff067188378e5739b0 Reviewed-on: https://chromium-review.googlesource.com/1044946Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#556472}
-
Rohit Rao authored
An upcoming refactoring will move methods out of BookmarkTableView and into BookmarkHomeViewController or BookmarkHomeMediator. To ease this transition, we introduce a data structure that holds various ivars that used to be in BookmarkTableView. BUG=839427,840381 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaeb854e3a5cc243e90dd6b5a6e15e70f679728f6 Reviewed-on: https://chromium-review.googlesource.com/1047365 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#556471}
-
Qiang Xu authored
Bug: 840052, 733662 Test: manual test Change-Id: I37bc5f60f1b7b16112237a32f713ae49c452f539 Reviewed-on: https://chromium-review.googlesource.com/1045903Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#556470}
-
Javier Fernandez authored
The definition of intrinsic size excludes explicitly performing layouts to compute the final value. However, it may be necessary to laid out some children to retrieve accurate information about the geometry of the box, specially when some of these children are orthogonal to the box its intrinsic size is being computed. However, the writing-mode specification suggest [1] that auto-sized orthogonal boxes may require to run their sizing phase before any content contribution could be established. The Blink engine discourages performing layouts during intrinsic size computation. In order to address the orthogonal flow issues and get a more accurate sizing, both during intrinsic size and layout phases, the engine performs a pre-layout of all the orthogonal boxes in the layout tree (LocalFrameView::LayoutOrthogonalWritingModeRoot). However, this pre-layout operations doesn't make sense for grid items because the grid areas, the grid items' actual containing blocks, are not computed yet. Hence, we decided to exclude grid items from this pre-layout operation (PrepareOrthogonalWritingModeRootForLayout). With this CL, we follow the same plan Blink has for orthogonal flow boxes, but doing it once the grid items are placed in their corresponding grid areas. Since the grid tracks sizing algorithm has not been run at this stage, the size of the grid areas is estimated based on the track's max-sizing function, in a similar way [2] the algorithm does to deal with orthogonal items during the layout phase. This change is covered by current tests, however, added an additional test to verify we use the max-track sizing as a way to estimate the orthogonal item's block-axis size. [1] https://www.w3.org/TR/css-writing-modes-3/#orthogonal-flows [2] https://drafts.csswg.org/css-grid/#algo-overview Change-Id: I836b92120825916324f94befec6d35263ec84f2b Reviewed-on: https://chromium-review.googlesource.com/1027882 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#556469}
-
Marc Treib authored
All it did was change the label for the Sync dashboard link. This was for a feature called "Chrome Away" which has long been abandoned. Bug: 402615 Change-Id: I6e4ab8973eed17aaeed631831b4145566ec3f86a Reviewed-on: https://chromium-review.googlesource.com/1047225Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556468}
-
Doug Arnett authored
Adds log message instead so situation will be available for user feedback report based on this screen. Tested log message locally by hacking threshold constants to simulate blocked proxy condition. Bug: 839478 Change-Id: I92935bb164255187127096ac86820bb32b689b2e Reviewed-on: https://chromium-review.googlesource.com/1042794Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#556467}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05cfcff70ced..8a95244f626c $ git log 05cfcff70..8a95244f6 --date=short --no-merges --format='%ad %ae %s' 2018-05-07 egdaniel Revert "Avoid drawing BW clipped color glyphs many times." 2018-05-07 egdaniel Revert "Remove android specific code" 2018-05-06 egdaniel Revert "Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice" 2018-05-06 egdaniel Revert "Restore old SkBitmapDeviceFilteredSurfaceProps" 2018-05-04 liyuqian Restore old SkBitmapDeviceFilteredSurfaceProps 2018-05-04 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ e76163e3c..336cdd903 (1 commit) 2018-05-04 senorblanco Remove GR_TESSELLATOR_LEGACY_INVERSION_HANDLING (unused). 2018-05-04 halcanary SkSinglyLinkedList: use unique_ptr to manage ownership 2018-05-04 fmalita [skottie] Switch to RapidJSON 2018-05-04 fmalita Fuzz should observe the optional Skottie flag. 2018-05-04 herb Add missing header from core.gni 2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice 2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs. 2018-05-04 bungeman Allow finer rotation in Viewer app. 2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)" 2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag 2018-05-04 bsalomon Remove could not invert matrix SkDebugfs 2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops. 2018-05-02 herb Remove android specific code 2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times. 2018-05-04 fmalita [skottie] Disable on Android Framework builds 2018-05-04 borenet [recipes] Remove core.setup() 2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1 2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2) 2018-05-04 caryclark Revert "Reland "remove obsolete color defines"" 2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer Created with: roll-dep src/third_party/skia BUG=chromium:836113 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ic6c1790f7f06de8205301449379701a24266cbff Reviewed-on: https://chromium-review.googlesource.com/1047185 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556466}
-
Mathieu Perreault authored
Payment Handler instrument icon was only shown in the Payment Sheet. Now it is shown as a 32x32 "favicon" in the Payment Handler window. Bug: 840056 Change-Id: Id4df874e0443fd5479b301a6dacd8bdece52382e Reviewed-on: https://chromium-review.googlesource.com/1045865Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556465}
-
Alex Loiko authored
Beacuse compilation on WIN fails otherwise. Bug: webrtc:9076 Change-Id: I230a861e6f4c50fce986ed49b5d33458091c2f00 Reviewed-on: https://chromium-review.googlesource.com/1047271 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#556464}
-
John Chen authored
This reverts commit 60ef2364. Reason for revert: Issue chromedriver:2407 resolved, extra debugging output no longer needed. Original change's description: > [ChromeDriver] Debug for page load timeout tests > > Some page load timeout tests are currently flaky on Mac. Adding some > debugging output to help diagnose this issue. > > Bug: chromedriver:2407 > Change-Id: Ic16074e77e2b100ea3f9d104bf9eef4599f78b6b > Reviewed-on: https://chromium-review.googlesource.com/1036592 > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555419} TBR=johnchen@chromium.org,kereliuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:2407 Change-Id: Ifa8c86e3a10b11b95eef4144584e1508de0d4a37 Reviewed-on: https://chromium-review.googlesource.com/1047545Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556463}
-
Moe Ahmadi authored
TranslateInfoBarDelegate shouldn't have reduced visibility of methods inheritted from infobars::InfoBarDelegate. This change is required as part of refactoring infobars in iOS Change-Id: Ied7c67388503129349bf19fd0a8e9f65668877c1 Reviewed-on: https://chromium-review.googlesource.com/1047188Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556462}
-
Matthew Jones authored
This patch removes the use of OverviewModeBehaviorWatcher which is completely unnecessary for testing the close button. Instead, we now just force the tab switcher open without animation. This is the most persistent (if not the only) source of failure for this test. Bug: 838719 Change-Id: I327347973890f8c10a332a82825a89504bc8c31e Reviewed-on: https://chromium-review.googlesource.com/1045092 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556461}
-
Calder Kitagawa authored
Zucchini has a use case for libfuzzer where the seed corpus can be generated at compile time. The reason for this is that as the Zucchini patch format changes the seeds need to change to reflect the new format. To do this at compile time a gn action that executes a python script needs to be executed before the seed_corpus action occurs in the fuzzer_test template. Adding the seed generation action to fuzzer_test deps is insufficient since the seed_corpus action can executed before seed exists. The solution to this is to add deps to the seed_corpus action that perform the dependent action prior to the seed_corpus archive generation. Change-Id: Icd90e308102d9c5b5923aa93a466bd3f39387702 Reviewed-on: https://chromium-review.googlesource.com/1044116Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Cr-Commit-Position: refs/heads/master@{#556460}
-
David 'Digit' Turner authored
This method of ELFSymbolizer can be used to wait for the completion of all async tasks, then allow additional ones to be performed after that. This is unlike the Join(), which waits for completion then terminates all addr2line processes immediately, making any future call to SymbolizeAsync() crash at runtime. BUG=755225 R=pasko@chromium.org, lizeb@chromium.org, agrieve@chromium.org,jbudorick@chromium.org Change-Id: Iea50c5e06bf495390dc1bc50a81151e069841175 Reviewed-on: https://chromium-review.googlesource.com/1046846Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#556459}
-
Mike Wasserman authored
The original crrev.com/c/1038819 broke volume keys: crbug.com/839683 PS2 fixes that by reposting events to other rewriters and adds a test. ORIGINAL CHANGE DESCRIPTION FOLLOWS: Move the rewriter files to ash, keep the delegate impl in chrome. Add a mojo interface for the delegate to receive and return events. Ash's controller creates the rewriter, Chrome sets the delegate. Move, expand, and refine the existing unit tests. Add TODOs to refine the rewriter/delegate/ChromeVox pattern. (the rewriter shouldn't pass events that will need to be reposted) This should allow Mash to support this rewriter in the future. (for now, Ash doesn't get Window Service events sent to Chrome) TBR=jamescook@chromium.org Bug: 647781 Test: No regressions with ChromeVox spoken feedback on Chrome OS. Change-Id: Id2e778fa3a82aee7f568244a5c2596ab86919a1d Reviewed-on: https://chromium-review.googlesource.com/1044780 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556458}
-
W. James MacLean authored
While the incidents of this bug are decreasing, we are still seeing it somewhat on Windows. In each case, it seems the current gesture target is no longer in the owners_map_. Adding more keys to confirm whether the target is the root view or not (seems most likely it isn't), and whether there are other views in the map beyond the root view. Bug: 824774 Change-Id: I99e777fb0d244ee80784a23332744089419f1d96 Reviewed-on: https://chromium-review.googlesource.com/1047192 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556457}
-
John Abd-El-Malek authored
Bug: 598073 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I370ee1b06eb256072f502ee946e02b5032ec22fa Reviewed-on: https://chromium-review.googlesource.com/1035202Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#556456}
-
Jochen Eisinger authored
The codepath is no longer used, instead, we just navigate to cross origin URLs. BUG=831073,823639,660288 Change-Id: I6a347a11e84539ad73d2b0b6aaaa1cc97d0b6118 Reviewed-on: https://chromium-review.googlesource.com/1016906 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#556455}
-
Harald Alvestrand authored
This tests that the browser conforms to RFC 7742, "WebRTC Video Processing and Codec Requrements". It establishes a new subdirectory for protocol-related WebRTC tests. Bug: chromium:839753 Change-Id: Ia4795c4532fb74ae76e6a47329a41807479113c5 Reviewed-on: https://chromium-review.googlesource.com/1043886 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#556454}
-
Paul Jensen authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id44e47c24716bbf790070f4176ce26b4da12fd92 Reviewed-on: https://chromium-review.googlesource.com/1044349Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556453}
-
David Benjamin authored
Trim a bit of memory use where we can. Bug: none Change-Id: I632d712e869f59f27ac0522d0bf33dc32b9a91f2 Reviewed-on: https://chromium-review.googlesource.com/1045225 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556452}
-
Nicolas Pena authored
Change-Id: I8a7183bbd848f22a17888b60ed4475a87a64ec3d Reviewed-on: https://chromium-review.googlesource.com/1040776 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556451}
-
Michael Lippautz authored
This reverts commit bd9ac13a. Reason for revert: Unfortunately there's another V8 CL close which massively affects speedometer. We need to reland to get a clear picture. Original change's description: > [oilpan] Enable incremental marking buildflag > > Includes incremental garbage collection infrastructure in regular > builds. Does not enable incremental marking at runtime! > > This CL may cause throughput regressions and is an attempt > to collect a broad range of potential performance issues. > > Bug: chromium:757440 > Change-Id: If4d91be2eb325417736a38e27c481ab23ce7a0e9 > Reviewed-on: https://chromium-review.googlesource.com/1041986 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555698} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:757440 Change-Id: I87dd96d9b9cd142503ff22534b8207da27b8c352 Reviewed-on: https://chromium-review.googlesource.com/1047265Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556450}
-
Marc Treib authored
Instead, use GetAuthenticatedAccountInfo throughout ProfileSyncService. One more step on the way to eventually getting rid of SigninManagerWrapper. Bug: 825190 Change-Id: Icca7037b2f47f1bba3c549080f97ba3824ad9f77 Reviewed-on: https://chromium-review.googlesource.com/1046950 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556449}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: Ib6b33bb7ea7c8978a9ee43383b22e5ee2546ba4c Reviewed-on: https://chromium-review.googlesource.com/1044348Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#556448}
-
Mark Pilgrim authored
The previous attempt was reverted because it crashed. This attempt features a crash test which reproduces the crash when run against the previous CL, and confirms that this CL does not crash. The cause of the crash was a reference to simple_url_loader after it had been std:move'd. This CL instead gets a reference to the newly moved pointer. previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1025068 revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/1030590 Bug: 773295 Test: ResetReportUploaderTest.NoCrash Change-Id: I7092ec501872dfa0019d37e8f9e10454458499db Reviewed-on: https://chromium-review.googlesource.com/1042359 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#556447}
-
Amirhossein Simjour authored
When in VR, CVC popup does not show properly, so there is no support for server side credit cards. GetCreditCardSuggestions in autofill_manager is updated to support a flag to decide whether the server side cards should be included or not. When in VR, we set the flag (include_server_cards) to false and don't show suggestions for server side cards. Bug: 831751 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I86b6a87ba88109d01ef84a6622096118f9970486 Reviewed-on: https://chromium-review.googlesource.com/1031200Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#556446}
-
https://chromium.googlesource.com/angle/angle.git/+log/e88e454803a7..54aafe58f5bd $ git log e88e45480..54aafe58f --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jiawei.shao Use ShaderMap in Caps - Part I Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: If2ee0b23c59a0aa6ae82098022ad0e054168f230 Reviewed-on: https://chromium-review.googlesource.com/1046928 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556445}
-
Elly Fong-Jones authored
TBR=jbudorick@chromium.org Bug: 828031 Change-Id: I496e425a7a3a955b2bee4448d642466235ad3195 Reviewed-on: https://chromium-review.googlesource.com/1047326Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556444}
-
Ella Ge authored
We were skipping Mac PointerEvent tests with pointerType = 'touch' because mac doesn't have touch event support. This CL adds InjectTouchEvent function in mac RWHV, which supports injecting WebTouchEvent to mac platform. This adds gesture_provider to mac RWHV for testing purpose and will be used on touch emulator in the future. Tests with multiple touch point is still failing because of an issue with SyntheticTouchDriver. Still skip these tests(crbug.com/613672) This Cl also correct that screen coordinate wasn't set when creating synthetic WebMouseEvent. Because of that PointerLock movementX_Y test is failing. On mac, movement_delta was set from NS event. The injected event doesn't set the movement. Skip these two tests until crbug.com/802067 is resolved. Bug: 613672 Change-Id: I78d442032ff36da2bc1ad3b84cc8ba9181ae8f0a Reviewed-on: https://chromium-review.googlesource.com/1039773 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556443}
-
Guido Urdaneta authored
This reverts commit 1b89887a. Reason for revert: Apparently causes compilation failure on iOS bots. See https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59633 Original change's description: > Roll src/third_party/webrtc/ 823f9135f..a5b903833 (1 commit) > > https://webrtc.googlesource.com/src.git/+log/823f9135f858..a5b903833f88 > > $ git log 823f9135f..a5b903833 --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: I93fc64657ce737b93f6ded1f7bf95a1ab27dc518 > Reviewed-on: https://chromium-review.googlesource.com/1046927 > Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#556431} TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I60a4ac7b083df5c4c617e3324773b43d43de59b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1047166Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556442}
-
Luke Zielinski authored
The previous approach of having a shared feature/param containing a csv of quota for all triggers makes it impossible to run more than one trigger trial at the same time (since the populations would be setting the same feature, even though the triggers run independently). More details at https://groups.google.com/a/google.com/forum/#!topic/chrome-safebrowsing-team/vx1yxXugwCY Bug: 817377 Change-Id: I02903e2bb722a8d5557a684b2d6c3788338c81c5 Reviewed-on: https://chromium-review.googlesource.com/1042377Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556441}
-
Emily Hanley authored
From what I can see, bot_id is a gauranteed field in the query response vs assuming it comes back as a tag. Bug: 831252 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6cb0c48a1dce8ffcea35ce3ab65404366c450c9a Reviewed-on: https://chromium-review.googlesource.com/1047065 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556440}
-
Michael Lippautz authored
Address cache is only actively used during roots marking. For incremental marking we pass over roots multiple times, each time potentially requires clearing the cache. Drive-by: - Add unit tests - Rename to AddressCache - Encapsulate handling fully in AddressCache - Remove outdated caller Bug: chromium:757440, chromium:830196 Change-Id: I51780e0bbbb8566ad0c83df98229e15133b42825 Reviewed-on: https://chromium-review.googlesource.com/1044214 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556439}
-
François Beaufort authored
This is a temporary fix that sets document.pictureInPictureEnabled to false in the case of disabling the GPU. Bug: 806249, 807840 Change-Id: I84445a0231b46cfbd0bb2f25eaca53f96604ce55 Reviewed-on: https://chromium-review.googlesource.com/1042290 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#556438}
-
stkhapugin@chromium.org authored
Disables keyboard shortcuts for FIP (cmd+F, cmd+G, cmd+shift+G) on NTP and other pages where FIP is not available. Bug: 694971 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f32c55760a2ed976bac085994223afa50c3b976 Reviewed-on: https://chromium-review.googlesource.com/1046829 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556437}
-