GitLab

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2883313004
Cr-Commit-Position: refs/heads/master@{#472218}

Relocated from https://chromium-review.googlesource.com/c/506720/
due to gerrit CQ issues.

BUG=722781
TBR=boliu@chromium.org,torne@chromium.org

Review-Url: https://codereview.chromium.org/2885093002
Cr-Commit-Position: refs/heads/master@{#472217}

Complement RendererScheduler.NumberOfTasksPerQueueType metric by
reporting total duration of tasks split per queue type.

R=skyostil@chromium.org,isherman@chromium.org
CC=haraken@chromium.org
BUG=702314

Review-Url: https://codereview.chromium.org/2755953003
Cr-Commit-Position: refs/heads/master@{#472216}

We're evaluating a different approach to hiding the `nonce` content
attribute, moving the behavior change up to `HTMLElement` and `SVGElement`
rather than placing it on `{HTML,SVG}{Script,Style}Element`. This
patch adds `nonce` to `ElementRareData` in order to support that
approach, and wires up a new `NoncedElement` interface to the new
properties.

Still behind a flag while we're working out details.

Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/wu_fMIYkyaQ/85j16Cg6BAAJ

BUG=680419

Review-Url: https://codereview.chromium.org/2801243002
Cr-Commit-Position: refs/heads/master@{#472215}

Also updates some constants to match spec.

BUG=715554

Review-Url: https://codereview.chromium.org/2885433003
Cr-Commit-Position: refs/heads/master@{#472214}

https://skia.googlesource.com/skia.git/+log/738aa4dc7047..eb99bfd85882

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

$ git log 738aa4dc7..eb99bfd85 --date=short --no-merges --format='%ad %ae %s'
2017-05-16 herb Move lambdas to statics.
2017-05-15 halcanary SkCanvas: Helpers for draw{Point,Line,Circle}
2017-05-16 fmalita Add SK_LEGACY_SWEEP_GRADIENT on Android

Review-Url: https://codereview.chromium.org/2887813002
Cr-Commit-Position: refs/heads/master@{#472213}

Remove GpuChannelMessageQueue and GpuChannelMessageFilter from header.
Also remove the dependency between MediaGpuChannel and the filter.

R=piman
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2870333003
Cr-Commit-Position: refs/heads/master@{#472212}

Before I landed crrev.com/2859193004 GridLayout didn't take into account
the view's border. The main profile button was adding its own padding to
account for that problem. After that patch landed it meant it was
doubly-padded. This patch removes the extra padding.

BUG=721660

Review-Url: https://codereview.chromium.org/2876343002
Cr-Commit-Position: refs/heads/master@{#472211}

This updates the designated requirement used in Chrome's
binary integrity incident checks to be the same designated
requirement that Chrome is signed with. Specifically, it uses
the certificate hash instead of the team identifier.

BUG=703793
DONOTSUBMIT=true

Review-Url: https://codereview.chromium.org/2813273003
Cr-Commit-Position: refs/heads/master@{#472210}

BUG=
NOTRY=true

Review-Url: https://codereview.chromium.org/2886873003
Cr-Commit-Position: refs/heads/master@{#472209}

BUG=718960

Review-Url: https://codereview.chromium.org/2880123002
Cr-Commit-Position: refs/heads/master@{#472208}

Map file generation is disabled on Linux Builders (see
http://crbug.com/716209), so the script fails if Linux is used with
--cloud.

BUG=717550

Review-Url: https://codereview.chromium.org/2880793002
Cr-Commit-Position: refs/heads/master@{#472207}

We need a method on DocumentMarkerList that returns the marker type the list
supports so we know when we can safely cast a DocumentMarkerList* to an impl
type.

This CL adds two subclasses of SpellCheckMarkerListImpl, SpellingMarkerListImpl,
and GrammarMarkerListImpl, so we can implement this method.

Note that adding this method also requires modifying
GenericDocumentMarkerListImpl to take a MarkerType param (we're going to
eliminate GenericDocumentMarkerListImpl once we add TextMatchMarkerListImpl but
we need this for now).

BUG=707867

Review-Url: https://codereview.chromium.org/2868413002
Cr-Commit-Position: refs/heads/master@{#472206}

The ReadingListMediator will now handle the ReadingListModel instead of
passing it directly in the ReadingListCollectionViewController.

BUG=721758, 688392

Review-Url: https://codereview.chromium.org/2879183002
Cr-Commit-Position: refs/heads/master@{#472205}

Cr-Commit-Position: refs/heads/master@{#472204}

BUG=none
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2863623004
Cr-Commit-Position: refs/heads/master@{#472203}

This CL refactors audioparam-testing.js so we can hide global variables
and functions from the window scope.

BUG=722884
TEST=(All layout tests passes after this change.)

Review-Url: https://codereview.chromium.org/2886883002
Cr-Commit-Position: refs/heads/master@{#472202}

Make DnsSdRegistry a leaky singleton so that it can be used by both CastMediaSinkService and MDnsAPI.

BUG=687377

Review-Url: https://codereview.chromium.org/2874243003
Cr-Commit-Position: refs/heads/master@{#472201}

In ChromeOS the graphics cards are opened in the browser process and
IPC-ed to the GPU.

BUG=482610
TEST=Ran on link, and daisy and verified Chrome starts up

Review-Url: https://codereview.chromium.org/2870213003
Cr-Commit-Position: refs/heads/master@{#472200}

With our recent change to merge paint timings across all frames in
a page, some of the timing ordering assumptions we make, such as
parse and layout always starting before paint, can be violated.

More specifically, we can observe sequences like the following:
* parse starts in main frame
* child frame created
* child frame paints
* child frame reports paint event
* parent frame reports parse start event

Even though the events happened in the expected order, due to cross
frame buffering, we are notified of the child paint before the
main frame parse start.

This change addresses this issue, by buffering observer callbacks until
we've received events with the expected ordering.

zhenw's recent change https://codereview.chromium.org/2872793002 encountered
this issue and had to be rolled back as a result.

I confirmed that, with zhen's patch applied, the flaky test failed on 8 of
10 runs. With zhen's patch and this patch applied, that same test passed 10
of 10 times.

BUG=722860

Review-Url: https://codereview.chromium.org/2885053002
Cr-Commit-Position: refs/heads/master@{#472199}

BUG=591099
TBR=eae@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2880993003
Cr-Commit-Position: refs/heads/master@{#472198}

https://chromium.googlesource.com/angle/angle.git/+log/82830ed..995c2ed

BUG=,chromium:721783, angleproject:1593

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884343002
Cr-Commit-Position: refs/heads/master@{#472197}

The investigation revealed:
- BreakpointManager does not know how to set breakpoints in the UISourceCodes
  with exact URLs. For this reason, breakpoints are removed inside workers
  in case of multilpe workers launched with the same URL.
- node.js reports file URLs which clash with the file URLs from persistence.
  This provokes the same illicit behavior in BreakpointManager.
- the same would happen with file-url web sites with persistence folder

This behavior is a conceptual issue of BreakpointManager, which is relied
upon in different parts of BreakpointManager.

Given the poor state of the things in the BreakpointManager, this patch
suggests a trade-off solution for the issue:
- it is localized to persistence only
- it is localized to the case of URL collisition between FileSystem and
  network URLs

Unfortunately, the attempts to write a test with workers failed due to the
BreakpointManager's poor handling of breakpoints in workers.

BUG=722636
R=dgozman

Review-Url: https://codereview.chromium.org/2886643002
Cr-Commit-Position: refs/heads/master@{#472196}

BUG=722827
TBR=sdefresne@chromium.org for ios/

Review-Url: https://codereview.chromium.org/2886803002
Cr-Commit-Position: refs/heads/master@{#472195}

There are no more callers of this method.

BUG=667892

Review-Url: https://codereview.chromium.org/2882523002
Cr-Commit-Position: refs/heads/master@{#472194}

This disables automatic timeline recording on page reload.
To record a reload users now should either use reload button on Timelin
panel or use a dedicated shortcut (Ctrl+Shift+E).

BUG=708099

Review-Url: https://codereview.chromium.org/2883143003
Cr-Commit-Position: refs/heads/master@{#472193}

Before this CL, we asserted that ModuleMap::GetFetchedModuleScript always queried load completed module scripts, but it was not always the case.
This CL changes the member function to return nullptr if the entry doesn't exist or the entry is being fetched.

This CL fixes a crash that happens when we early-exit module script graph fetch by a sub-graph instantiation failed, but there are still partial subgraph in flight.

BUG=718442,594639

Review-Url: https://codereview.chromium.org/2860993002
Cr-Commit-Position: refs/heads/master@{#472192}

Add one UMA for CrossFadeAnimation smoothness, used in maximize windows,
so that we can evaluate how much improvement we can achieve by forcing
use of render surface.

BUG=708513
TEST=has histogram at local device.

Review-Url: https://codereview.chromium.org/2869263002
Cr-Commit-Position: refs/heads/master@{#472191}

This patch prunes a call site of the deprecated function to improve code
health. The change is safe because it is equivalent to hoisting the layout
update from the deprecated function.

BUG=698633
TEST=n/a; no behavioral changes

Review-Url: https://codereview.chromium.org/2883083003
Cr-Commit-Position: refs/heads/master@{#472190}

BUG=722943
TBR=gab
NOTRY=true

Review-Url: https://codereview.chromium.org/2887893002
Cr-Commit-Position: refs/heads/master@{#472189}

BUG=b:38123645
TEST=First run tutorial is started after voice interaction
  OOBE completed broadcast.

Review-Url: https://codereview.chromium.org/2881283002
Cr-Commit-Position: refs/heads/master@{#472188}

BUG=717085
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2884133002
Cr-Commit-Position: refs/heads/master@{#472187}

Avoids allocating the CSSGlobalRuleSet on html import StyleEngines.

Review-Url: https://codereview.chromium.org/2883003002
Cr-Commit-Position: refs/heads/master@{#472186}

Review-Url: https://codereview.chromium.org/2861373004
Cr-Commit-Position: refs/heads/master@{#472185}

BUG=716658,716656
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888493002
Cr-Commit-Position: refs/heads/master@{#472184}

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2878163002
Cr-Commit-Position: refs/heads/master@{#472183}

This patch adds a stable id into PaintImage. This is stable in the sense
that if the blink::Image that generated the paint image hasn't changed,
then the id would be the same. It's used in a case where either we have
a partially loaded image that finishes loading or an animated image
ticks to a new frame. In those cases, the SkImage unique id is different
since the contents of the image are different. However, the stable id
should remain the same to indicate that it's a part of logically the
same image.

The primary use for the stable id would be to determine whether the
compositor is allowed to checker the image. Specifically, if we have
ever displayed an image stable id X, then all other images with the
same stable id X are not allowed to be checker imaged.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2873003002
Cr-Original-Commit-Position: refs/heads/master@{#471351}
Committed: https://chromium.googlesource.com/chromium/src/+/ae192fde12e7fba4ac2d8f027037d10c3d0f22a4
Review-Url: https://codereview.chromium.org/2873003002
Cr-Commit-Position: refs/heads/master@{#472182}

Since this benchmark is not scheduled on perf waterfall, we move it to the contrib/
directory & set memory-infra as OWNERS.

BUG=720257

Review-Url: https://codereview.chromium.org/2874033005
Cr-Commit-Position: refs/heads/master@{#472181}

Previously, entering/exiting fullscreen whilst the media controls are
hidden due to inactivity would cause the media controls to briefly show
then almost immediately hide again, resulting in an ugly flicker.

They were shown by HTMLMediaElement::UpdateControlsVisibility (called
from HTMLMediaElement::Did{Enter,Exit}Fullscreen) and then hidden again
by MediaControlsImpl::OnTimeUpdate since ShouldHideMediaControls()
returns true.

(This was often masked by the fact that clicking the fullscreen button
with a mouse results in the mouse hovering over the media controls at
the start of the fullscreen transition, in which case it's ok to show
the media controls. It became particularly noticeable with the recent
video-rotate-to-fullscreen feature, which enters/exits fullscreen
without interacting with the media controls, but it can be reproduced
without that feature as well).

This patch renames MediaControls::Show to MaybeShow and makes it only
show the controls if they won't soon be hidden again.

BUG=717520
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2873493004
Cr-Commit-Position: refs/heads/master@{#472180}

This patch is to improve performance of network panel when a domain url
is very long we crop it in order to make scrolling not lag as much.

R=pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2876623003
Cr-Commit-Position: refs/heads/master@{#472179}