- 24 Oct, 2018 40 commits
-
-
Xi Cheng authored
Previously, a pointer to the NotificationImageRetainer object is stored in NotificationTemplateBuilder. This is unnecessary as this object is only used by two private methods called within Build() and never used again. This CL changed to pass the pointer into those functions directly. Separately, a GetCleanupTask() method is added for NotificationImageRetainer so that it doesn't need to expose AsWeakPtr() to the public. Bug: 888276 Change-Id: I4a7fa2a39e30c739f9adb7021b4809a4b56062fa Reviewed-on: https://chromium-review.googlesource.com/c/1292712 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#602496}
-
Scott Graham authored
Bug: 808287 Change-Id: Id50a9e5e45428fe155d0de4059486b14ee71f11b Reviewed-on: https://chromium-review.googlesource.com/c/1298414 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602495}
-
rbpotter authored
In Polymer 2, shouldExpandSettings_ is called when the computed property shouldShowMoreSettings_ is undefined, and returns true in this case, resulting in a flash of the expanded settings. Return false unless shouldShowMoreSettings_ is set to the boolean value of false. Bug: 898100 Change-Id: I7154772921c59ba24ba1c80901da4b962305eeac Reviewed-on: https://chromium-review.googlesource.com/c/1297605Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602494}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b6c3804254e9..7100fff13dd0 git log b6c3804254e9..7100fff13dd0 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 dgarrett@google.com cros_mark_as_stable: Force list type. Created with: gclient setdep -r src/third_party/chromite@7100fff13dd0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I88bafc5322a1faa8602f2ab5e48158bb879a366d Reviewed-on: https://chromium-review.googlesource.com/c/1298165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602493}
-
Tim Volodine authored
Recent patch by boliu@ [1] introduced delayed onPageStarted callback and now requires |is_renderer_initiated| member to be set in AwContentsClientBridge.onReceivedError [2]. The following tests are impacted and are currently crashing because of that: - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testNotCalledOnStopLoading - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnPageStartedTest.testOnPageStartedCalledOnceOnError This patch fixes the issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1270096 [2] https://cs.chromium.org/chromium/src/android_webview/browser/aw_contents_client_bridge.cc?l=440 BUG=897750,841556 Change-Id: I3e20e5317a86a0cfe479cef270cc7f9ae933b066 Reviewed-on: https://chromium-review.googlesource.com/c/1293581Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#602492}
-
Robert Liao authored
AnimatedImageViews that never receive an animated image and are never started should not DCHECK(animated_image_) at AnimatedImageView::Stop. BUG=890221 Change-Id: I519e826861870a3c7cee623667dc7e1b92369dbd Reviewed-on: https://chromium-review.googlesource.com/c/1298228Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#602491}
-
Collin Baker authored
Bug: 887991 Change-Id: I30849f971071d73b42970927abc12a4259fc73c2 Reviewed-on: https://chromium-review.googlesource.com/c/1295187Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#602490}
-
Oystein Eftevaag authored
R=chiniforooshan@chromium.org Change-Id: I4ddf86ca1ac051593689806a2282ad24b2e694c8 Reviewed-on: https://chromium-review.googlesource.com/c/1298229 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602489}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d123ad73f85..4f598e8c829a git log 2d123ad73f85..4f598e8c829a --date=short --no-merges --format='%ad %ae %s' 2018-10-24 brianosman@google.com GrColor4s, a fixed-point signed short type for wide color vertices 2018-10-24 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-24 reed@google.com more setters for SkFont 2018-10-24 brianosman@google.com Align trace event allocations to avoid alignment issues on 32-bit ARM Created with: gclient setdep -r src/third_party/skia@4f598e8c829a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I695951301f2fd847800928a224b1552998259176 Reviewed-on: https://chromium-review.googlesource.com/c/1298164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602488}
-
Eugene But authored
This is the only file where ForceViewRendering is used. Bug: None Change-Id: I0091cb7182bde45ebb2d3b22c63a366bab0afc56 Reviewed-on: https://chromium-review.googlesource.com/c/1294399 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602487}
-
Matt Menke authored
It was only being used in one test (Which no longer needs it) and internally in net, so it's no longer needed. Net internally now uses a bool taken from the HTTP session, which it can also assume to be constant for the lifetime of the network stack. Also switches the |load_flags| parameter for SSLSocketParams to an |ignore_certificate_errors| bool, since the only flag that mattered at that layer was the now removed LOAD_IGNORE_ALL_CERT_ERRORS. Bug: 533571 Change-Id: Ie2562ba2e82086b6478a343680f9094e95fe365d Reviewed-on: https://chromium-review.googlesource.com/c/1297470 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#602486}
-
rbpotter authored
In Polymer 2, setting background-color for paper-fab directly overrides the value applied when the paper-fab has keyboard focus, as well as the normal value. paper-fab provides a mixin for setting the background color. Using this mixin sets the default background color correctly, and allows the background-color styling that overrode the styling for :host(.keyboard-focus) to be removed. Bug: 897595 Change-Id: I7332d57b822286c884ef6ca7a32d6b890130a5e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297629Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602485}
-
Sam Maier authored
Bug: 898251 Change-Id: Iad2680ad461007baa99aff5da0b0b6cabcaf88e6 Reviewed-on: https://chromium-review.googlesource.com/c/1298357Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#602484}
-
mrefaat authored
This was replaced by the view inside PagePlaceHolderTabHelper. Bug: 898544 Change-Id: I077b13abcf0220100d1bb0fec4d39672b8a4fdc6 Reviewed-on: https://chromium-review.googlesource.com/c/1297459Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#602483}
-
Tom Tan authored
Chromium task manager static_asserts on Windows structure SYSTEM_THREAD_INFORMATION and SYSTEM_PROCESS_INFORMATION, but it assumes non-x64 is x86. Fix this for Windows ARM64. Bug: 893460 Change-Id: I1face62bdb617c1d62fcdc3d1e2540eecaa45878 Reviewed-on: https://chromium-review.googlesource.com/c/1297394Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#602482}
-
Jeremy Roman authored
Narrow the scope of blocking observation in ThreadConditionTest to the single Wait call of interest. Bug: 897550 Change-Id: Id34dc044bb6c5bd5e177d405015fdd909827ce18 Reviewed-on: https://chromium-review.googlesource.com/c/1298346 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#602481}
-
Wenzhao Zang authored
Bug: 812085 Change-Id: Ia2bf565c0ff5e5cd43e94079ae41b7a0be614430 Reviewed-on: https://chromium-review.googlesource.com/c/1297356Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602480}
-
Kenneth Russell authored
conformance/rendering/canvas-alpha-bug.html is failing on this configuration on 10.13 and later. Rather than specialize the suppression for multiple OS versions, suppress it on this GPU type. Tbr: jdarpinian@chromium.org No-Try: True Bug: 886970 Change-Id: Ifeeaa59aca1c232b3d3eda6b2a82b35451c8a2bc Reviewed-on: https://chromium-review.googlesource.com/c/1298199 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602479}
-
edchin authored
Enable the experiment to return to regular tabs when closing last tab. Bug: 891396 Change-Id: I0a0784c901fc0f19508fdf5db612c350ed8d38ef Reviewed-on: https://chromium-review.googlesource.com/c/1297177Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602478}
-
Malay Keshav authored
When initializing a RecordPaintCanvas, the size set should be in pixels. Right now we are setting the DIP size which is resulting in PaintOps that are outside the clip bounds to be rejected all together. This patch also adds a DCHECK to ensure that the clip bounds set on the canvas matches the expected pixel size of the rasterized image. Bug: 896203 Change-Id: I10cf95bc656950c217d3ae464f277a0cb7140063 Component: CanvasImageSource Reviewed-on: https://chromium-review.googlesource.com/c/1296687 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602477}
-
Ken Buchanan authored
Dragging the frame dividers of a frameset should cause that RenderWidget to receive all mouse input until a MouseUp is received, otherwise the mouse moving over cross-process content, such as a PDF or an OOPIF, will cause the resize to stop. This CL triggers mouse capture in that case. Bug: 878007 Change-Id: I96c4855954799c5f03d7dfc697ad399a31a561dd Reviewed-on: https://chromium-review.googlesource.com/c/1298222 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#602476}
-
Scott Graham authored
I'm not sure if this will be correct until these tests can run, but this will at least compile, as opposed to using the Windows version. Bug: 808287 Change-Id: I2f112f9ab2575abc88d1495ba324cdcc15cde4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1298299Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602475}
-
Xiaocheng Hu authored
There are some crashes in the function due to legacy implemetation of StartOfWord() creating invalid/legacy positions, which lead to reversed word ranges. This patch adds handling of reversed word ranges so that we don't crash, before switching StartOfWord() to proper implementation. Bug: 886589 Change-Id: I8ad988247c6e4ab4a4a7cf90675d7df5f326f56f Reviewed-on: https://chromium-review.googlesource.com/c/1298018Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#602474}
-
Christopher Cameron authored
Process death should be treated as window exit. Tested using a process kill. Bug: 898627 Change-Id: I4e659dfeb71541ac2e111979842eda40110d7a66 Reviewed-on: https://chromium-review.googlesource.com/c/1298297Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#602473}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/879d5e3796bd..2b71832f6d8d git log 879d5e3796bd..2b71832f6d8d --date=short --no-merges --format='%ad %ae %s' 2018-10-24 sergiyb@chromium.org Hide standard output from the browser when running git-cl-web Created with: gclient setdep -r src/third_party/depot_tools@2b71832f6d8d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iddaf6ca2f2dc2983712a05ec77d7a4cccbda8238 Reviewed-on: https://chromium-review.googlesource.com/c/1298158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602472}
-
Reza.Zakerinasab authored
Bug: 898500 Change-Id: Iabfe264766e4c33b930df61b9269ed3f068b2ccb Reviewed-on: https://chromium-review.googlesource.com/c/1298252Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#602471}
-
Fredrik Hubinette authored
Change-Id: I5381ace23e4cf2729555d952f23d25f5901a259d Reviewed-on: https://chromium-review.googlesource.com/c/1292401Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#602470}
-
Theresa authored
BUG=898529 Change-Id: Iff27d791065c04700d379cf3d60b1210ac24d477 Reviewed-on: https://chromium-review.googlesource.com/c/1298351Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602469}
-
Theresa authored
Not all users have suggested articles, so for technical accuracy we're dropping "and view suggested articles" from the clear tab in-product help string. BUG=898598 Change-Id: I75861c97cae32dd5a18007a0017815b4f0ab6e18 Reviewed-on: https://chromium-review.googlesource.com/c/1298226 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602468}
-
Sylvain Defresne authored
PrimaryAccountMutator is a new API that wraps the method related to the mutation of the signed-in state of the primary account. It will become the recommended API to set and clear the primary account when migrating to the Identity Service API. The PrimaryAccountMutatorImpl methods are not implemented yet. They will be implemented in follow up CLs (and corresponding tests added). This is done to limit the size of the CLs. Design document is available at: https://docs.google.com/document/d/1YVx-SW0VbrAnek69PVxQ1ie71VewcuKvf8JvIzFfuRQ/view Bug: 889902 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2acd1ebdccadfebb855e55f4e9b78c148557ed85 Reviewed-on: https://chromium-review.googlesource.com/c/1286852Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602467}
-
Daniel Cheng authored
It's more memory efficient than std::set. Also changes the sets to hold StringPiece instead of std::string, since the sets only hold string constants. Change-Id: Ia5e8823e7285863724bb4a1956afaff2bc6186ea Reviewed-on: https://chromium-review.googlesource.com/c/1298359Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602466}
-
Katie D authored
Adds user action logging for dwell action types. Changes dwell delay logging so that it is logged each time the user changes the delay pref. It will still be logged when the AutoclickController starts, so we should still get events at startup as well. Bug: 894907 Change-Id: Iedcf7c40385e58e1e29e354870f5c839c5c715c7 Reviewed-on: https://chromium-review.googlesource.com/c/1287265 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602465}
-
Scott Graham authored
Bug: 808287 Change-Id: I6a8e1af6e4073a3a064a94976b17271f9d7330ca Reviewed-on: https://chromium-review.googlesource.com/c/1298348Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602464}
-
Joe DeBlasio authored
This CL allows the interstitials browser tests to verify that displayed interstitials are the ones expected. Previously, tests only compared the page titles, which were often shared between different interstitials. Bug: 891096 Change-Id: Ieb5e9f9a90739cf35f2357655d5e0c31a2a68c91 Reviewed-on: https://chromium-review.googlesource.com/c/1297578Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#602463}
-
Xianzhu Wang authored
Scrolling background is the background painted on the scrolling contents layer. Previously we used the scrolling contents graphics layer as the display item client to give the background proper visual rect, but that didn't work for SPv2 which doesn't have the graphics layer. Now use a special display item client for scrolling background. This is a prerequisite of fixing SPv2 scrolling background. Bug: 732611 Change-Id: I3518e69b5985b7c6124ec3e8f9ec9a66005d5eb6 Reviewed-on: https://chromium-review.googlesource.com/c/1297131 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602462}
-
Theresa authored
The EoC toolbar button used to be wrapped in a FrameLayout. Removing the FrameLayout broke the tab switcher overlay in RTL. This CL mirrors the tab switcher button drawing logic for the experimental button. This also updates when we capture a new texture with or without the experimental button to wait until animations are finished. BUG=898441 Change-Id: I42759ffb3a836ec4a74ec996c070607902517324 Reviewed-on: https://chromium-review.googlesource.com/c/1297978Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602461}
-
Peter Kasting authored
This is part of an effort to move away from direct reliance on the switches, so they can be renamed or removed. Bug: none Change-Id: I64c5a521f7d6e6e148d0d4329a1710d8efa3b69b Reviewed-on: https://chromium-review.googlesource.com/c/1297582Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602460}
-
Erik Chen authored
The keyboard shortcut was behaving incorrectly and triggering the shortcut for ctr+tab. This was fallout from the change of the menu item to use "ctr+shift+->" as the key equivalent, and AppKit's funky handling of ctr+shift+tab to create "end of medium" instead of "horizontal tab". Bug: 896389 Change-Id: Iea85c69077874201b6e3608771aa9fcbfa368aef Reviewed-on: https://chromium-review.googlesource.com/c/1298187Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602459}
-
David Bokan authored
SyntheticGestureTargetAura::GetTouchSlopInDips was subtracting 1 from the slop configuration value. However, GestureDetector::IsWithinTouchSlop would incorrectly return true if we scrolled one pixel past the slop in this case. Additionally, there's no need to ceil the touch slop adjustment in SyntheticSmoothMoveGesture since we're sending float deltas. Bug: 897520 Change-Id: I35725c603910b3c694d9eddf5fde31f1f6b9cf2e Reviewed-on: https://chromium-review.googlesource.com/c/1293171Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602458}
-
Zhenyao Mo authored
This reverts commit be9cde47. Reason for revert: broke media lab bots Original change's description: > Allow loading SwiftShader after sandbox init on Mac > > We could blacklist WebGL based on GL version, which is after creating a context. > > Right now this will trigger a failure and GPU process will exit and then > relaunch with SwiftShader mode, which pre-load SwiftShader before sandbox init. > > So users will not notice, but this GPU process exit and relaunch is less optimal > and unnecessary. > > BUG=897914 > TEST=manual > R=kerrnel@chromium.org,kbr@chromium.org,sugoi@chromium.org > > Change-Id: Idcd018ca1f2e5161002cdae4563462c76316c606 > Reviewed-on: https://chromium-review.googlesource.com/c/1297481 > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602391} TBR=sugoi@chromium.org,zmo@chromium.org,kbr@chromium.org,kerrnel@chromium.org,rsesek@chromium.org Change-Id: Ib9ab22645f1727249db8f3f9a007cc76402e6067 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897914 Reviewed-on: https://chromium-review.googlesource.com/c/1298419Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602457}
-