- 06 Jan, 2017 40 commits
-
-
sky authored
Mash should really use ChromeNativeAppWindowViewsAuraAsh, but that depends upon a bunch of types in ash. So, make mash use ChromeNativeAppWindowViewsAura, which isn't perfect, but at least it doesn't crash. BUG=679028 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2617923004 Cr-Commit-Position: refs/heads/master@{#442067}
-
chfremer authored
In interface media::VideoCaptureDevice::Client, change interface Buffer to a move-only struct. The new struct separates the concerns of providing access handles (for in-process as well as for inter-process transit) from access permissions. This allows clients to explicitly obtain in-process memory-mapped handles when they need it. Clients who only want to pass along the buffer or move it across process boundaries do not need memory-mapped handles. In interface media::VideoCaptureBufferPool, renamed GetBufferHandle() -> GetHandleForInProcessAccess() GetHandleForTransit() -> GetHandleForInterProcessTransit(). Removed outdated implementation in video_capture Mojo service. We leave the implementation empty, until refactoring the interfaces has been completed. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.9.10 For a peek at the follow-up CLs, please see https://codereview.chromium.org/2607203002/ https://codereview.chromium.org/2602983002/ BUG=584797 TEST= content_unittests --gtest_filter="*Video*", video_capture_unittests, Apprtc loopback on Debug, Desktop Capture Example extension on Release [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2573223002 Cr-Commit-Position: refs/heads/master@{#442066}
-
asvitkine authored
With this change, this code will set both the Java and native side prefs if any of the three indicators of TOS being seen are true, i.e. either of the two prefs or "any user has seen ToS". This is especially needed to fix variations seed fetching from native code in the case of Backup & Restore, which does not appear to restore the Chrome native pref. BUG=669543 Review-Url: https://codereview.chromium.org/2614183002 Cr-Commit-Position: refs/heads/master@{#442065}
-
Jinsuk Kim authored
The new testfiles added in the CL had a problem. Fixed it now. This reverts commit 9c484365. BUG=676762 R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2613093003 . Cr-Commit-Position: refs/heads/master@{#442064}
-
chrishtr authored
BUG=674795 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2617903002 Cr-Commit-Position: refs/heads/master@{#442063}
-
rohitrao authored
Reland of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2615283002/ ) Reason for revert: Reverting broke tests on the main waterfall, so unreverting =) Original issue's description: > Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2613163002/ ) > > Reason for revert: > This is crashing on 32-bit devices. > > Thread 0 Crashed:: Dispatch queue: com.apple.main-thread > 0 com.apple.CoreFoundation 0x05b57301 _CFRelease + 1505 > 1 org.chromium.gtest.generic-unit-test 0x00a3afb7 > base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 39 > 2 org.chromium.gtest.generic-unit-test 0x00071d47 > base::internal::ScopedNSProtocolTraits<NSString*>::Release(NSString*) + 23 > 3 org.chromium.gtest.generic-unit-test 0x00071d28 > base::ScopedTypeRef<NSString*, base::internal::ScopedNSProtocolTraits<NSString*> > >::~ScopedTypeRef() + 40 > 4 org.chromium.gtest.generic-unit-test 0x00071cf7 > base::scoped_nsprotocol<NSString*>::~scoped_nsprotocol() + 23 > 5 org.chromium.gtest.generic-unit-test 0x00071cd7 > base::scoped_nsobject<NSString>::~scoped_nsobject() + 23 > 6 org.chromium.gtest.generic-unit-test 0x00071567 > base::scoped_nsobject<NSString>::~scoped_nsobject() + 23 > 7 org.chromium.gtest.generic-unit-test 0x000716dd > web::TestJavaScriptDialog::~TestJavaScriptDialog() + 45 > 8 org.chromium.gtest.generic-unit-test 0x00071707 > web::TestJavaScriptDialog::~TestJavaScriptDialog() + 23 > 9 org.chromium.gtest.generic-unit-test 0x00383724 (anonymous > namespace)::CRWWebControllerPageDialogOpenPolicyTest_AllowConfirmWithTrue_Test::TestBody() > + 4212 > 10 org.chromium.gtest.generic-unit-test 0x00adafe7 void > testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, > void>(testing::Test*, void (testing::Test::*)(), char const*) + 103 > 11 org.chromium.gtest.generic-unit-test 0x00aae98a void > testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, > void>(testing::Test*, void (testing::Test::*)(), char const*) + 106 > 12 org.chromium.gtest.generic-unit-test 0x00aae8b6 testing::Test::Run() + 246 > 13 org.chromium.gtest.generic-unit-test 0x00ab062f testing::TestInfo::Run() + > 255 > 14 org.chromium.gtest.generic-unit-test 0x00ab1d44 testing::TestCase::Run() + > 260 > 15 org.chromium.gtest.generic-unit-test 0x00ac59ce > testing::internal::UnitTestImpl::RunAllTests() + 974 > 16 org.chromium.gtest.generic-unit-test 0x00add3c7 bool > testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, > bool>(testing::internal::UnitTestImpl*, bool > (testing::internal::UnitTestImpl::*)(), char const*) + 103 > 17 org.chromium.gtest.generic-unit-test 0x00ac559a bool > testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, > bool>(testing::internal::UnitTestImpl*, bool > (testing::internal::UnitTestImpl::*)(), char const*) + 106 > 18 org.chromium.gtest.generic-unit-test 0x00ac549f testing::UnitTest::Run() + > 335 > 19 org.chromium.gtest.generic-unit-test 0x00a4bc93 RUN_ALL_TESTS() + 19 > > Original issue's description: > > [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. > > > > Use TestJavaScriptDialogPresenter instead of deprecated > > CRWWebUserInterfaceDelegate. > > > > BUG=661445 > > TBR=kkhorimoto@chromium.org > > > > Review-Url: https://codereview.chromium.org/2613163002 > > Cr-Commit-Position: refs/heads/master@{#441998} > > Committed: https://chromium.googlesource.com/chromium/src/+/e3cb6842bb7d440a8f8259bea661e5b97159fdca > > TBR=michaeldo@chromium.org,eugenebut@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=661445 > > Review-Url: https://codereview.chromium.org/2615283002 > Cr-Commit-Position: refs/heads/master@{#442036} > Committed: https://chromium.googlesource.com/chromium/src/+/8c9857238e62da4de34c8b02458418916c8a77d0 TBR=michaeldo@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661445 Review-Url: https://codereview.chromium.org/2615293002 Cr-Commit-Position: refs/heads/master@{#442062}
-
sujiths.s authored
Adding Mali Workaround patch for the latest Mali-G71 https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=678508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2611933002 Cr-Commit-Position: refs/heads/master@{#442061}
-
sadrul authored
The native window parenting should happen in the window server, since a sandboxed gpu process won't be able to do it. BUG=643746 Review-Url: https://codereview.chromium.org/2610783003 Cr-Commit-Position: refs/heads/master@{#442060}
-
xlai authored
BUG=657102 Review-Url: https://codereview.chromium.org/2613733002 Cr-Commit-Position: refs/heads/master@{#442059}
-
csharrison authored
Downstream code expects nonzero resources to be discovered during FrameSerializer::serializeFrame. However, this can happen in some cases when processing image documents. BUG=678893 Review-Url: https://codereview.chromium.org/2613253002 Cr-Commit-Position: refs/heads/master@{#442058}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/24315c519ee9..f84aaa04d4d0 $ git log 24315c519..f84aaa04d --date=short --no-merges --format='%ad %ae %s' 2017-01-06 rnephew [BattOr] Update Win, Mac and Linux battor agent binaries in deps manager. 2017-01-06 simonhatch Dashboard - Fix some internal bisects not starting automatically. 2017-01-06 eakuefner [StyleGuide] Add specific delineation for JavaScript 2017-01-06 sullivan Do not create data stoppage alerts for ref builds. BUG=677303,678659 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2617223002 Cr-Commit-Position: refs/heads/master@{#442057}
-
jdufault authored
Original patch got reverted due to compile error. BUG=678034 Review-Url: https://codereview.chromium.org/2615263002 Cr-Commit-Position: refs/heads/master@{#442056}
-
estade authored
(the page info bubble for chrome:// pages) BUG=585076 Review-Url: https://codereview.chromium.org/2616573002 Cr-Commit-Position: refs/heads/master@{#442055}
-
Justin DeWitt authored
"Import wpt@eeecf3e14368d4ab5221cde688003dedeca30dba" This reverts commit cfd8c14d. "Update MANIFEST.json to newest version." This reverts commit dc2a9e04. Reason for revert: Begins running layout tests without proper expectations. Original issue's description: > Update MANIFEST.json to newest version. > > Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed http://crbug.com/678077 for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt. > > This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly. > > TBR=dpranke > > BUG=678077 > > Review-Url: https://codereview.chromium.org/2615903004 . > Cr-Commit-Position: refs/heads/master@{#441999} > Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d TBR=dpranke@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678077 Review-Url: https://codereview.chromium.org/2619613002 . Cr-Commit-Position: refs/heads/master@{#442054}
-
jam authored
Fix NavigationControllerBrowserTest.SubframeForwardRedirect with PlzNavigate and site isolation enabled. The problem is that NavigationRequest::dest_site_instance_ is set in the constructor of that class. If RenderFrameHostManager::CanSubframeSwapProcess determines that a cross process redirect should happen for the subframe (because of site isolation) then we might need to use a new site instance. BUG=674734 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2594263004 Cr-Commit-Position: refs/heads/master@{#442053}
-
danakj authored
The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which has methods that look like blink::WebMediaPlayer methods, but it is a chromium-style class. The WebMediaPlayerAndroid is-a blink::WebMediaPlayer and also a RendererMediaPlayerInterface so its overrides end up overriding both at once. This is problematic because, while also being difficult to follow where control flow goes, when the blink names are renamed in the Great Blink Rename to be chromium style, incorrectly-blink-styled names outside of blink will not be renamed and the inheritance here will break. The two methods here are hasVideo() and paused(). It turns out that neither method is ever used as part of the RendererMediaPlayerInterface. And only paused() is used as part of the concrete WebMediaPlayerCast class. So I have removed them both from the RendererMediaPlayerInterface and added IsPaused() as a non-virtual method on WebMediaPlayerCast instead. R=hubbe@chromium.org BUG=578344 Review-Url: https://codereview.chromium.org/2619593002 Cr-Commit-Position: refs/heads/master@{#442052}
-
jmadill authored
https://chromium.googlesource.com/angle/angle.git/+log/a818c32..a66779f BUG=chromium:677841,chromium:644610 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2614063006 Cr-Commit-Position: refs/heads/master@{#442051}
-
jamescook authored
Ash only builds on Chrome OS these days, so it doesn't need platform ifdefs. The only thing remaining in ash/common is accelerators, which is a bigger reshuffle. BUG=666773 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2616023005 Cr-Commit-Position: refs/heads/master@{#442050}
-
paulirish authored
BUG=678722 Review-Url: https://codereview.chromium.org/2615083002 Cr-Commit-Position: refs/heads/master@{#442049}
-
bokan authored
This crash is caused because of a divide-by-zero when calculating viewport units. The zero width visual viewport occurs because the WebView is responsible for resizing the VisualViewport but the autoresize code resizes the FrameView. This does eventually lead to resizing the WebView when a layout occurs and calls though to WebView::layoutUpdated, however, until that happens the layout will use the 0 value. This isn't ever a problem since the calculation that's dividing by 0 is used to adjust the browser controls to the minimum page scale but autoresize isn't ever used on Android, which is the only platform that uses browser controls and a non-1 minimum page scale. BUG=667712 Review-Url: https://codereview.chromium.org/2616893004 Cr-Commit-Position: refs/heads/master@{#442048}
-
eugenebut authored
Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation Manager. It's unclear how app can get into this state and one assumption is that didStartProvisionalNavigation: does not add a pending navigation item. This UMA histogram is logged when didStartProvisionalNavigation: fails to add a pending item. This histogram is added only to verify the assumption and should be removed after M46 is released. BUG=676458 Review-Url: https://codereview.chromium.org/2602133002 Cr-Commit-Position: refs/heads/master@{#442047}
-
wangxianzhu authored
Floating object belongs to its containing block, no matter if it's under an inline and no matter if the inline is layered, stacked, or paint invalidation container. This requires us to specially handle floating objects for LayoutObject::paintingLayer(), LayoutObject:: container(), paint invalidator, etc. BUG=666553 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2575423003 Cr-Commit-Position: refs/heads/master@{#442046}
-
msw authored
Used the attached profile; not the active profile. Regressed in: https://codereview.chromium.org/2391253004 BUG=675599 TEST=Multi-login cros users get correct shelf prefs. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2613303003 Cr-Commit-Position: refs/heads/master@{#442045}
-
tmartino authored
Review-Url: https://codereview.chromium.org/2614123004 Cr-Commit-Position: refs/heads/master@{#442044}
-
einbinder authored
Empty placeholder text could cause TextPrompt to lose its editing caret BUG=none Review-Url: https://codereview.chromium.org/2615933002 Cr-Commit-Position: refs/heads/master@{#442043}
-
reillyg authored
In r441491 I neglected to notice that the lifetime of the PermissionManager is longer than that of PermissionServiceContext. On frame changes existing subscriptions should be cleared as they were before that patch. PermissionServiceImpl::AddPermissionObserver removes redundant early return logic checking that browser_context->GetPermissionManager() is non null. CreateSubscription already does that. BUG=677774,678664 TBR=mlamouri@chromium.org Review-Url: https://codereview.chromium.org/2617863003 Cr-Commit-Position: refs/heads/master@{#442042}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/8c8cb5bfc547..f55ea6a1deb2 $ git log 8c8cb5bfc..f55ea6a1d --date=short --no-merges --format='%ad %ae %s' 2017-01-06 mtklein Retry "SkRasterPipelineBlitter: support A8"... 2017-01-06 mtklein Revert "Get latest ANGLE as of January 6, 2017" 2017-01-06 djsollen Add a script and documentation for building the Viewer APK. 2017-01-06 brianosman Get latest ANGLE as of January 6, 2017 2017-01-06 robertphillips Get Debugger app compiling again Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2618973002 Cr-Commit-Position: refs/heads/master@{#442041}
-
blink-w3c-test-autoroller authored
Using update-w3c-deps in Chromium 00f04a8e. Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7859 TBR=qyearsley@chromium.org NOEXPORT=true Review-Url: https://codereview.chromium.org/2613313002 Cr-Commit-Position: refs/heads/master@{#442040}
-
fmalita authored
DragImageBuilder is currently instantiating a picture-backed SkImage. But there is no advantage to that, because DragImage::create() is immediately rasterizing it (via SkImage::asLegacyBitmap). Since we're trying to reduce the use of picture-backed images in Blink, refactor to rasterize upfront. R=reed@google.com BUG=skia:6100 Review-Url: https://codereview.chromium.org/2619573002 Cr-Commit-Position: refs/heads/master@{#442039}
-
ios-autoroller authored
Roll Material Font Disk Loader to 93acc021e3034898716028822cb802a3a816be7e Roll Material Sprited Animation View to c6e16d06bdafd95540c62b3402d9414692fbca81 Roll Material Text Accessibility to 318d5100f2976e59c94643e5dcab69e7a830ee43 TBR=smut Review-Url: https://codereview.chromium.org/2615613008 Cr-Commit-Position: refs/heads/master@{#442038}
-
rdevlin.cronin authored
Custom hooks need the ability to return results synchronously and throw exceptions in the case of bad invocations. Update native bindings to allow for hooks to do this, and add a number of tests. BUG=653596 Review-Url: https://codereview.chromium.org/2609553003 Cr-Commit-Position: refs/heads/master@{#442037}
-
rohitrao authored
Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2613163002/ ) Reason for revert: This is crashing on 32-bit devices. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.CoreFoundation 0x05b57301 _CFRelease + 1505 1 org.chromium.gtest.generic-unit-test 0x00a3afb7 base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 39 2 org.chromium.gtest.generic-unit-test 0x00071d47 base::internal::ScopedNSProtocolTraits<NSString*>::Release(NSString*) + 23 3 org.chromium.gtest.generic-unit-test 0x00071d28 base::ScopedTypeRef<NSString*, base::internal::ScopedNSProtocolTraits<NSString*> >::~ScopedTypeRef() + 40 4 org.chromium.gtest.generic-unit-test 0x00071cf7 base::scoped_nsprotocol<NSString*>::~scoped_nsprotocol() + 23 5 org.chromium.gtest.generic-unit-test 0x00071cd7 base::scoped_nsobject<NSString>::~scoped_nsobject() + 23 6 org.chromium.gtest.generic-unit-test 0x00071567 base::scoped_nsobject<NSString>::~scoped_nsobject() + 23 7 org.chromium.gtest.generic-unit-test 0x000716dd web::TestJavaScriptDialog::~TestJavaScriptDialog() + 45 8 org.chromium.gtest.generic-unit-test 0x00071707 web::TestJavaScriptDialog::~TestJavaScriptDialog() + 23 9 org.chromium.gtest.generic-unit-test 0x00383724 (anonymous namespace)::CRWWebControllerPageDialogOpenPolicyTest_AllowConfirmWithTrue_Test::TestBody() + 4212 10 org.chromium.gtest.generic-unit-test 0x00adafe7 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 103 11 org.chromium.gtest.generic-unit-test 0x00aae98a void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 106 12 org.chromium.gtest.generic-unit-test 0x00aae8b6 testing::Test::Run() + 246 13 org.chromium.gtest.generic-unit-test 0x00ab062f testing::TestInfo::Run() + 255 14 org.chromium.gtest.generic-unit-test 0x00ab1d44 testing::TestCase::Run() + 260 15 org.chromium.gtest.generic-unit-test 0x00ac59ce testing::internal::UnitTestImpl::RunAllTests() + 974 16 org.chromium.gtest.generic-unit-test 0x00add3c7 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 103 17 org.chromium.gtest.generic-unit-test 0x00ac559a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 106 18 org.chromium.gtest.generic-unit-test 0x00ac549f testing::UnitTest::Run() + 335 19 org.chromium.gtest.generic-unit-test 0x00a4bc93 RUN_ALL_TESTS() + 19 Original issue's description: > [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. > > Use TestJavaScriptDialogPresenter instead of deprecated > CRWWebUserInterfaceDelegate. > > BUG=661445 > TBR=kkhorimoto@chromium.org > > Review-Url: https://codereview.chromium.org/2613163002 > Cr-Commit-Position: refs/heads/master@{#441998} > Committed: https://chromium.googlesource.com/chromium/src/+/e3cb6842bb7d440a8f8259bea661e5b97159fdca TBR=michaeldo@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661445 Review-Url: https://codereview.chromium.org/2615283002 Cr-Commit-Position: refs/heads/master@{#442036}
-
mef authored
BUG=629299 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2569863002 Cr-Commit-Position: refs/heads/master@{#442035}
-
reed authored
Using PlatformCanvas (previously) always paid for the cost of the native graphics context (e.g. HDC or CGContext), but there are no callers of gfx::Canvas that use those facilities. BUG=675977 Review-Url: https://codereview.chromium.org/2615493003 Cr-Commit-Position: refs/heads/master@{#442034}
-
rouslan authored
In this patch: 1) Query locally installed native Android payment apps. 2) Show the name and icon of these apps in UI. 3) Invoke the apps with matching payment method data. 4) Return the results back to the merchant website. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/fsslHD1Gf88/K2KpikS6BwAJ The feature is disabled by default. It can be enabled via a flag: chrome://flags/#android-payment-apps To test the new functionality: 1) Install BobPay: https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg 2) Enable chrome://flags/#android-payment-apps. 3) Open https://rsolomakhin.github.io/pr/bob/. 4) Click [Buy] button. BUG=620173 Review-Url: https://codereview.chromium.org/2604193002 Cr-Commit-Position: refs/heads/master@{#442033}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/8d94b6687f27..591ed144f8df $ git log 8d94b6687..591ed144f --date=short --no-merges --format='%ad %ae %s' 2017-01-06 tsepez Remove CFX_MapPtrToPtr and templates. 2017-01-06 tsepez Remove CFX_MapPtrToPtr in xfa/fgas, part 2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2617953003 Cr-Commit-Position: refs/heads/master@{#442032}
-
bruthig authored
This CL ensures the correct layout of the launcher button and the overflow button in the Ash MD shelf when the shelf is being resized. This can occur in two situations: when the shelf is being 'stretched' toward the center of the screen by touch, or during a shelf hide/show animation. BUG=668230 TEST=manual Review-Url: https://codereview.chromium.org/2598223002 Cr-Commit-Position: refs/heads/master@{#442031}
-
fmalita authored
It has only one client. Inline the implementation (and simplify, as the optional src_rect param is always present). BUG=675977 R=reed@google.com,robertphillips@chromium.org TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2610323004 Cr-Commit-Position: refs/heads/master@{#442030}
-
sky authored
And improve comment. Additionally removes some dead includes in RootWindowController. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2610853012 Cr-Commit-Position: refs/heads/master@{#442029}
-
rune authored
setNeedsActiveStyleUpdate checks if the document is active before calling markTreeScopeDirty. This avoids marking shadow root tree scopes dirty for non-active documents which caused a DCHECK fail in markTreeScopeDirty. R=esprehn@chromium.org BUG=676441 Review-Url: https://codereview.chromium.org/2611053004 Cr-Commit-Position: refs/heads/master@{#442028}
-