- 19 Nov, 2018 40 commits
-
-
Maxim Kolosovskiy authored
This reverts commit aee1ee31. Reason for revert: Suspect this CL caused https://bugs.chromium.org/p/monorail/issues/detail?id=4576 Original change's description: > Make EndOfSentence stop at block boundaries > > This patch stops EndOfSentence from crossing block boundaries, since > block boundaries are also sentence boundaries. > > Bug: 778507 > Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993 > Reviewed-on: https://chromium-review.googlesource.com/c/1337432 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608850} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 778507 Change-Id: I7d48146bd7fb27c34427f543ad3b54443ae63715 Reviewed-on: https://chromium-review.googlesource.com/c/1340815Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609224}
-
Ioana Pandele authored
This change separates the current text of the infobar into title and body. The latter contains a link pointing to where the user can find the saved generated password. Screenshot on the bug. Bug: 903257 Change-Id: Iadbfb68298b338d990c4be0b0ab3d11007b4b125 Reviewed-on: https://chromium-review.googlesource.com/c/1156586Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#609223}
-
Justin Cohen authored
Change-Id: Idd933d2bfcff3e136c4b2787a80d70b562068ceb Reviewed-on: https://chromium-review.googlesource.com/c/1341206 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609222}
-
Vaclav Brozek authored
The PasswordForm.FillOnLoad UKM aims at measuring the change in behaviour of Chrome with the new password form parser, if an explicit condition for filling on load is changed from A to B. It turned out that even if A is the explicit condition, B still can break fill on load. So the change is not so much A -> B as A && B -> B. This means that the metric's bucket recording the state when A is true and B false needs to be merged into the bucket when A == B, because in both cases the behaviour does not change. Bug: 895781 Change-Id: Ic3ab14d9a1e43c0312580d2dfe5bff34f2cdd20a Reviewed-on: https://chromium-review.googlesource.com/c/1340274Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609221}
-
Hans Wennborg authored
This is part of cleaning up for a new Clang warning that's currently disabled: In file included from ../../ash/app_list/home_launcher_gesture_handler.cc:19: ../../ash/wm/window_transient_descendant_iterator.h:69:43: error: explicitly defaulted copy assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted] WindowTransientDescendantIteratorRange& operator=( ^ ../../ash/wm/window_transient_descendant_iterator.h:72:37: note: copy assignment operator of 'WindowTransientDescendantIteratorRange' is implicitly deleted because field 'begin_' has an inaccessible copy assignment operator WindowTransientDescendantIterator begin_; ^ Bug: 890307 Change-Id: Ic47bc989f9fe26e1387f9a6a8c00f19fcf6b91ce Reviewed-on: https://chromium-review.googlesource.com/c/1340331 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609220}
-
Yuki Shiino authored
The return type of OnBeforeUnloadEventHandler is DOMString?, so we should use V8StringResource<kTreatNullAsNullString> instead of V8String<kDefaultMode>. Change-Id: I6df9581cf5dd01ae8215d773c95a3e9dc6a78e08 Reviewed-on: https://chromium-review.googlesource.com/c/1341779Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609219}
-
Daniel Bratell authored
Change-Id: I88b641bf356044ca94552273081af22c0fde1795 Reviewed-on: https://chromium-review.googlesource.com/c/1341530Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609218}
-
Yuki Shiino authored
This patch fixes a regression at https://crrev.com/c/1215512 , which doesn't run 'beforeunload' event listeners when one of the related execution contexts is paused. This patch adds an exceptional handling for 'beforeunload' event so that 'beforeunload' event listeners run regardless of pause. Bug: 903297 Change-Id: I92bb24a8fd16ee9f81a5082f5c561c97c1dd5348 Reviewed-on: https://chromium-review.googlesource.com/c/1333548 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This will remove the need to know about specific instances of SigninManager, AccountTrackerService, ProfileOAuth2TokenService and GaiaCookieManagerService from the calling places for those methods. Also move the SigninManagerForTest definition in identity_test_environment.h one level up, to allow sharing it among |IdentityManagerDependenciesOwner| and |IdentityTestEnvironment| without relying on such definition being also available from identity_test_utils.h (from where it's now being removed due to no longer being required by those test utilities). Bug: 904404 Change-Id: If96b0c7dea763030dc7372d58922f82a31eb5733 Reviewed-on: https://chromium-review.googlesource.com/c/1336127 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecb09be23157..7e385fd60000 Created with: gclient setdep -r src-internal@7e385fd60000 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifdfe2ed136d3a4440cc92cee9b8706b50e8c77ab Reviewed-on: https://chromium-review.googlesource.com/c/1341566Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609215}
-
Julian Pastarmov authored
Some ph tags were incorrectly using the $1 placeholder and were replaced with the string Google Chrome instead of their content. BUG=none Change-Id: Idd9540861a44c124ad8ac5e9ccca6e588e98b74f Reviewed-on: https://chromium-review.googlesource.com/c/1337624Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609214}
-
Yutaka Hirano authored
It was introduced for out-of-blink CORS, but the check doesn't work with extensions. Until it's fixes let's rely on the renderer side check and disable the check. Bug: 895999 Change-Id: I59aaafcb9185e1937372cf8967ef45d3728dff64 Reviewed-on: https://chromium-review.googlesource.com/c/1335078 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609213}
-
Hayato Ito authored
Current implementation of flat tree traversal is not cheap when traversing host's children. See http://crbug.com/906494 for details. There was an attempt to make it faster in v1, https://crrev.com/c/1328622, however, this idea was already implemented in v0, and this attempt actually caused a perf regression in some cases (https://crbug.com/905197). This CL makes flat tree traversal for host's children much faster in a different approach. The basic idea is: 1. Let NodeRareData has additional pointers, as FlatTreeNodeData, and set pointers at the timing of slot assignment recalc. 2. At flat tree traversal, use these pointers to skip hashmap lookup. In this CL, |next| and |previous| pointers for assigned nodes are used in flat tree traversal. Thanks to that, flat tree traversal no longer lookup node-to-index hashmap, nor do a liner search there. These additional pointers are only set for host's children. There shouldn't be additional cost for other cases. In a follow-up CL, I'll use FlatTreeNodeData's |assigned_slot| to make flat tree traversal and other operations much faster again. Since this task might be complicated, that can be done in another CL. BUG: 906494 Change-Id: I617da70371d6733050b7dc754d3b40c88c090c79 Reviewed-on: https://chromium-review.googlesource.com/c/1337225 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609212}
-
Dean Liao authored
Use VideoFrameLayout to store negotiated input/output format, coded_size and buffer layout obtained from S_FMT command. BUG=b:110815424,b:73752373 TEST=Run VEA VDA unittest on devices (peach_pit and elm) VEA: video_encode_accelerator_unittest \ --test_stream_data=bear-320x180.yuv:320:180:1:bear.mp4:100000:30 \ --disable_flush --single-process-tests -v=0 VDA: video_decode_accelerator_unittest \ --test_stream_data=/usr/local/video/test-25fps.h264:320:240:250:258:\ 35:150:1 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm Change-Id: If708cb66c5f33cb16ad8599339999a3aac9fcd47 Reviewed-on: https://chromium-review.googlesource.com/c/1340440 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609211}
-
Kent Tamura authored
Implement the second paragraph of [1]. - Rename HTMLFormElement::ConstructFormDataSet() to ConstructEntryList() The algorithm name in the specification was renamed. - Add HTMLFormElement::is_constructing_entry_list_. It is set to 'true' in ConstructFormEntryList(). - FormData::Create() takes additional ExceptionState& argument The behavior change by this CL is behind a runtime flag. [1] https://docs.google.com/document/d/1JO8puctCSpW-ZYGU8lF-h4FWRIDQNDVexzHoOQ2iQmY/edit?pli=1#heading=h.veshh4ug726u Bug: 825684 Change-Id: I28fc29c2b8e969a5fbe1b6f955e9d8b65df0d8ec Reviewed-on: https://chromium-review.googlesource.com/c/1340079Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609210}
-
Vlad Tsyrklevich authored
fdc1883a13ac fuchsia: Disable ProcessReaderFuchsia.ChildThreads, flaking 656fa55c74a8 Refactor ProcessReaderWin to use ProcessMemoryWin 1c4c1277e870 Add a ProcessSnapshot::Memory method ad788280e4df fuchsia: Disable HTTPS tests to avoid (unavailable) dependency on BoringSSL f42a579b8c84 Add ProcessSnapshotMinidump::CustomMinidumpStreams() 083fd52cc3c1 linux: Fix build failure on ARM/MIPS Change-Id: If912a1d3a287ebbf9f34d77f84dc8ff517456383 Reviewed-on: https://chromium-review.googlesource.com/c/1341242Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#609209}
-
Yutaka Hirano authored
They are no longer leaky. Bug: 672740 Change-Id: I327d3f5c073008ec092dc3f94bb00701d05cd183 Reviewed-on: https://chromium-review.googlesource.com/c/1341735Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609208}
-
David 'Digit' Turner authored
This patch fixed the base::trace_event::TraceEvent::Reset() method to ensure that it never creates dangling pointers. This can happen in the following case: - TraceEvent::Initialize() is called on an instance, with TRACE_EVENT_FLAG_COPY set in the |flags| argument. This will copy argument names, copyable string values, as well as the name and scope into a single heap allocated buffer backed by |parameter_copy_storage_|, and will also adjust all internal pointer fields to point to it. - TraceEvent::Reset() is called on the same instance, this frees the storage area, but before this CL did not update the internal pointers, who were now dangling into heap-free memory! - Later, some code will iterate over the arguments with a loop like: for (int i = 0; i < kTraceMaxNumArgs && arg_names_[i] != nullptr; ++i) { ... } The assumption being that an arg_names_[i] value of nullptr indicates the end of list. Unfortunately, in the case above, this will read completely invalid values from memory. + Fix TraceEvent::MoveFrom() to call other->Reset() to ensure that the source instance is left in consistent state. I believe this is the source of flakiness on many tests related to TraceEvent, and hope this fixes it. BUG=905624,899813 R=oystene@chromium.org,primiano@chromium.org,alexilin@chromium.org,pkl@chromium.org Change-Id: I63cbadc728130cddc68b8c92b28e1e3f584793f4 Reviewed-on: https://chromium-review.googlesource.com/c/1340308 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Peter Lee <pkl@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#609207}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6340200508f8..ecb09be23157 Created with: gclient setdep -r src-internal@ecb09be23157 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib075e2ef3d8f0d384cc1d1c4c2d1265cf9bb0124 Reviewed-on: https://chromium-review.googlesource.com/c/1341564Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 11841 11844 11850 11855 11857 11861 11868 11873 11876 11877 11879 11885 11886 11890 11903 11913 11919 11921 11923 11925 11935 0 lines were removed and 3 lines were deflaked by consecutive results since 11877. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I42b2db12e91066fb87b5d8c81b4a8b18d6bb3a7f Reviewed-on: https://chromium-review.googlesource.com/c/1337213 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609205}
-
Christopher Lam authored
This CL adds a WebUI for App Management that replaces chrome://apps when the feature NewAppManagement is enabled. This involves: - adding the feature - adding a new MojoWebUIController - adding a mojom, and its C++ handler - adding a skeleton HTML and Polymer 'app' element - adding a BrowserProxy which connects the Renderer JS to the backend C++. Bug: 906508 Change-Id: Iac5be9ce82dc2cb0b1c77301ca43ccf7a99f318f Reviewed-on: https://chromium-review.googlesource.com/c/1309380 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#609204}
-
Tetsui Ohkubo authored
This CL implements animation for clearing all Notifications. This CL does not accurately implements the animation as the spec. For the UX spec, see the bug. TEST=UnifiedMessageListViewTest BUG=897915 Change-Id: I750b3a3e9d86706bef7c9cd13474dbff986486e9 Reviewed-on: https://chromium-review.googlesource.com/c/1312176Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#609203}
-
Giovanni Ortuño Urquidi authored
Un-capitalizes all instances of "radio" to make them consistent. TBR=dominickn@chromium.org Bug: 870192 Change-Id: Ibf38e8eae85d2ae05a2f82788193fec880f6a46a Reviewed-on: https://chromium-review.googlesource.com/c/1341773Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609202}
-
Dean Liao authored
We used to get V4L2ImageProcessor instance from constructor and perform initialization later. And Initialize() set several data members which are not changed after Initialize(). With factory method, Create(), we can perform Initialize() before constructing V4L2ImageProcessor instance. And those data members set by Initialize() can be const-qualified. This commit is a leading commit for using VideoFrameLayout to encapsulate input/output format and size. Because VideoFrameLayout is a const object, the input/output VideoFrameLayout variables for creating V4L2ImageProcessor should be determined before calling constructor. Thus factory method becomes a natural design choice. BUG=b:110815424,b:73752373 TEST=Run VEA VDA unittest on devices (peach_pit and elm) VEA: video_encode_accelerator_unittest \ --test_stream_data=bear-320x180.yuv:320:180:1:bear.mp4:100000:30 \ --disable_flush --single-process-tests -v=0 VDA: video_decode_accelerator_unittest \ --test_stream_data=/usr/local/video/test-25fps.h264:320:240:250:258:\ 35:150:1 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm Change-Id: I6909b2c1dbe5eda5845681a51af9e3d1c88d89ec Reviewed-on: https://chromium-review.googlesource.com/c/1339084 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bea23e4d..55d0017c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6785c04a89de242ce474ed134405fb167397f522 Reviewed-on: https://chromium-review.googlesource.com/c/1340507Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609200}
-
Owen Min authored
chrome/browser/policy/browser_dm_token_storage* chrome/browser/policy/machine_level_user_cloud_policy* chrome/browser/policy/cloud/machine_level_user_cloud_policy* components/policy/core/common/cloud/machine_level_user_cloud_policy* Including: Change-Id: If7c4e8c68591db7c227748ab156475dc280e7212 Reviewed-on: https://chromium-review.googlesource.com/c/1340365Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#609199}
-
Yuki Shiino authored
This patch introduces a new counter part of BindingSecurity (in core/ component) as BindingSecurityForPlatform (in platform/ component). BindingSecurityForPlatform is a simple collection of trampolines to BindingSecurity. Change-Id: I41195111ff2f288ee3e314048ac92848adf6be0b Reviewed-on: https://chromium-review.googlesource.com/c/1340439Reviewed-by:
-
Dean Liao authored
According to https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#object-ownership-and-calling-conventions scoped_refptr should be passed by value, not by reference. This CL focus on image_processor. More than 200+ lines need to be fixed in media/gpu: ~/chrome/src/media/gpu$ grep -r "const scoped_refptr<.*>&" | wc 226 1068 21515 BUG=chromium:906479 TEST=Run VEA VDA unittest on devices (peach_pit and elm) VEA: video_encode_accelerator_unittest \ --test_stream_data=bear-320x180.yuv:320:180:1:bear.mp4:100000:30 \ --disable_flush --single-process-tests -v=0 VDA: video_decode_accelerator_unittest \ --test_stream_data=/usr/local/video/test-25fps.h264:320:240:250:258:\ 35:150:1 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm Change-Id: I963501af745124e565eee4a3febf5a0957d53e10 Reviewed-on: https://chromium-review.googlesource.com/c/1341288Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42fbb1521607..6340200508f8 Created with: gclient setdep -r src-internal@6340200508f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I59ddb3b867746c03f5034fbc4d0495ac60c1be48 Reviewed-on: https://chromium-review.googlesource.com/c/1341563Reviewed-by:
-
Yuta Kitamura authored
This reverts commit 15fef9cc. Reason for revert: Likely introduced flaky assertion failure (bug 906353). Original change's description: > RC: Set Frame->Process association at RenderFrameHost creation. > > At present this is only done at navigation time, which can leave frames > disconnected from their hosting process. > > Bug: 901828 > Change-Id: I611eafebe5e7e54c046def38bbaf5b348dedfcb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1318405 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608994} TBR=fdoray@chromium.org,wfh@chromium.org,jochen@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901828,906353 Change-Id: Idd7f4f1caf9a6ab884fd6de17ebb84b09e2c201e Reviewed-on: https://chromium-review.googlesource.com/c/1341294Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609195}
-
Takashi Toyoshima authored
This patch makes Chrome Extensions to call BrowserContext functions to have right permission access lists in all relevant processes including NetworkService that also has CORS checks. Since NetworkService is accessed over mojo, all operations need to be asynchronous. This requires that PermissionsUpdater take a completion callback to let callers know its completion. PermissionsUpdater now relies on a private helper class that outlives it to handle the asynchronous completion. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c0642f162a0a71034c2529262150dbf4a1e4da8 Reviewed-on: https://chromium-review.googlesource.com/c/1186382 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#609194}
-
Yoshifumi Inoue authored
Because of offset mapping doesn't use |BoxInfo| and creating |BoxInfo| also causes side-effect to mark layout objects |InNGInlineFormattingContext| this patch changes |NGInlineItemsBuilderTempalte<T>| not to use |BoxInfo| for offset mapping. This patch is follow-up the patch[1] and preparation of the patch[2]. [1] http://crrev.com/c/1327582 Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow [2] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText Change-Id: Id5a9d9c4e998261cfa57ec24fc9e268b002a8617 Reviewed-on: https://chromium-review.googlesource.com/c/1341293 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Stuart Langley authored
- For cr-dialog-button (e.g. delete file dialog) use css to set the order so that the ok button is on the right of the cancel button. - For the dialog footer just modify the html so that the ok button comes after the cancel button. Tested visually as there are no automated tests for style. Bug: 844168 Change-Id: Ia6eb652928cba50dd30cb8324b9c33ac13d46df2 Reviewed-on: https://chromium-review.googlesource.com/c/1341283Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609192}
-
Sam McNally authored
Bug: 903637 Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f Reviewed-on: https://chromium-review.googlesource.com/c/1341287 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Quick view: Style audio and video to have cursor pointer on their buttons Bug: 848216 Change-Id: I181cd2d3da2721d8c5bce837f0721435d4850297 Reviewed-on: https://chromium-review.googlesource.com/c/1341730Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e22505b4f07f..01979132133e git log e22505b4f07f..01979132133e --date=short --no-merges --format='%ad %ae %s' 2018-11-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@01979132133e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@chromium.org Change-Id: I7da676ba699bf377d65441bcfe82f95ff167f31b Reviewed-on: https://chromium-review.googlesource.com/c/1341561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609189}
-
Joel Hockey authored
Setting |overflow: none| in .progress-frame fixes it to display long filenames and the open/close controls within the visible space and intended. Bug: 825289 Change-Id: Id5027bf73961063f8568083d744264e9021aeb1a Reviewed-on: https://chromium-review.googlesource.com/c/1341728Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609188}
-
Noel Gordon authored
Bug: 905930 Change-Id: Ice0fb6efbfdaa7f52463cb9876d50b85b9900989 Reviewed-on: https://chromium-review.googlesource.com/c/1341298Reviewed-by:
-
tby authored
Add UMA logging for the error status of the ALS, the brightness monitor, and the validity of the user's personal curve at initialisation. Bug: 881215 Change-Id: I63f5e9da17cf9ee5e67ce67a2b7646751bbd808e Reviewed-on: https://chromium-review.googlesource.com/c/1319310 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609186}
-
Joel Hockey authored
In FilesApp, we set |overflow: auto| on .cr-dialog-container to allow scrolling on dialogs such as the chrome web store dialog which requires scrolling to work on small screens. The pulse event when a user clicks on .cr-dialog-container causes the frame (dialog box) to increase in size by 2% for 180ms. This is causing scrollbars to flash on during that time which is not desirable. By setting the pulse to increase the entire .cr-dialog-container rather than just the frame, we get the same intended visual effect, but without scrollbar flicker. Bug: 883671 Change-Id: I3fb75bef14059bc92b8baa2367290a16b0b0e08f Reviewed-on: https://chromium-review.googlesource.com/c/1341432Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609185}
-
