GitLab

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I20d6e94f1e192b18814959be24fd8648cefb7fd9
Reviewed-on: https://chromium-review.googlesource.com/884883Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532091}

Modify GpuProcessHost to be able to inject the necessary mojo pipe
creation functionality so that ozone/drm can use mojo IPC when enabled
by a command line flag.

BUG=620927

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I585b1f66cbddb60beea886dda700a37357b89e5c
Reviewed-on: https://chromium-review.googlesource.com/861906
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532090}

(1) A ExamplePreprocessorConfig proto is added.

(2) A ExamplePreprocessor class that build on a config proto and does
    preprocessing including missing feature handling and bucketization.

(3) A ExampleFloatIterator is also added to iterate through all
    features of a RankerExample.

(4) Add a unittest.

Change-Id: I0de0f2fa6d6e9b7ae3b873d8b7b00009cd04ec80
Reviewed-on: https://chromium-review.googlesource.com/872831Reviewed-by: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532089}

Don't list the context snapshot in the mojo manifest's required_files
in builds with use_v8_context_snapshot=false. Tweak existing manifest
overlay functionality to allow merging of required_files lists from
multiple manifests.

This avoids an "Ignoring invalid file v8_context_snapshot.bin" warning
on each browser stratup in use_v8_context_snapshot=false builds.

Bug: 804293
Change-Id: I0f4731811044980b7466887bedcaf115ee1fb288
Reviewed-on: https://chromium-review.googlesource.com/878371Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com>
Cr-Commit-Position: refs/heads/master@{#532088}

This reverts commit 8c08d938:
> Revert LayoutView::StyleWillChange viewport invalidation
>
> This patch is a speculative revert of the following patch:
> "Let LayoutView::StyleWillChange handle viewport invalidation."
> https://chromium-review.googlesource.com/c/chromium/src/+/609984
> r495573
> 1fac40c9
>
> This patch could be responsible for regressions in the following:
> * Blink.Paint.UpdateTime
> * Blink.Compositing.UpdateTime
>
> Bug: 768612
> Change-Id: I8d12b80473afee2eecdb3ff1a8c3538f334eaf59
> Reviewed-on: https://chromium-review.googlesource.com/719336
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Rune Lillesveen <rune@opera.com>
> Commit-Queue: Rune Lillesveen <rune@opera.com>
> Cr-Commit-Position: refs/heads/master@{#509012}

Unfortunately we couldn't observe performance metric recovery from the
speculative revert, thus landing the CL again and we will be watching if
performance fluctuated.

BUG=768612

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I05c2a6bfe0f85cffdbf0b2ea1813a3ff7a83f05d
Reviewed-on: https://chromium-review.googlesource.com/848153
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532087}

Also restrict hang reporting to the Canary channel while uncovered
issues stabilize.

R=asviktine@chromium.org

Bug: 806174, 804345
Change-Id: Ie99b0e7b36d606102642ccab10ef3a30832f08ab
Reviewed-on: https://chromium-review.googlesource.com/888498Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532086}

When showing ElementsPanel, all the tree outlines are not wired
to DOMModels yet, and therefore did not updated root node with a document.
We used to manually do that from ElementsPanel, but removed it recently.

Bug: 805353
Change-Id: I2b15a2368de92bcda090b95f22e912e553badd9b
Reviewed-on: https://chromium-review.googlesource.com/887648Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532085}

BUG=633030

Change-Id: Iaa27af5e6d3b4b55d11e044dc57e23dcf0682b39
Reviewed-on: https://chromium-review.googlesource.com/846356Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532084}

. Use OnceCallback for the 'benchmark done' callback.
. Remove an unncessary callback-runner function.

BUG=none

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib990293e05960755844fd1e5156e459b187c2e1c
Reviewed-on: https://chromium-review.googlesource.com/887163
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532083}

This is to evaluate if the mask DstIn optimization[1] is still useful.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp?rcl=399e97834e0f1b08ee104789a87482fd79712da0&l=383

Change-Id: I85b07a05d156020fe8bf20f38c38b722f6efb7a0
Reviewed-on: https://chromium-review.googlesource.com/882496Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532082}

Partial interfaces do not have constructors, so we can't nominate
them as members of V8ContextSnapshotExternalReferences.


Bug: 806163
Change-Id: I28e20fac326d57851f6443cca7c0c53bc86680fb
Reviewed-on: https://chromium-review.googlesource.com/888181Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532081}

Before this CL,
  we used V8Foo::InstallRuntimeEnabledFeatures() if we don't have V8FooPartial, and
  we used V8Foo::install_runtime_enabled_features_function() if we have.
It was confusing and difficult to call the correct one.

This CL does
 - rename InstallRuntimeEnabledFeatures() as InstallRuntimeEnabledFeaturesImpl()
 - create a new API 'InstallRuntimeEnabledFeautres()', which has same name as before
then callsites do not need to care whether the target interface has partial interface or not.



Bug: 806167
Change-Id: I6f277f2bb254df7cbe0fb193dd2f91c7ac1b1778
Reviewed-on: https://chromium-review.googlesource.com/888380Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532080}

This only affects the client hints that are requested by
origins using "Accept-CH" header.

Before this change, origins can request client hints
using the main frame response. Chrome would then attach
the requested client hints on either HTTP or
HTTPS subresources. With this change, the client hints
would be attached on HTTPS subresources only.

This is guarded behind a WebRuntimeFeature which will
be enabled after external communication on blink-dev.

This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/852863.

Bug: 782381
Change-Id: I462178bd6ed3fe08faa2ee67dcba306468ae1ca8
Reviewed-on: https://chromium-review.googlesource.com/887348Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532079}

Bug: 711517
Change-Id: I78f6c274a62066039f69fcf2ac66f232379b959c
Reviewed-on: https://chromium-review.googlesource.com/887737Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532078}

Merge PaymentRequestTestCommon into PaymentRequestTestRule since there is
no long need for sharing the implementation with other classes

Bug: 711517
Change-Id: I5810b58ac3850a38137d5c7debd782b664862c4b
Reviewed-on: https://chromium-review.googlesource.com/886838Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532077}

use the login password if this substitution variable exists.

BUG=chromium:386606

Change-Id: I8b4a804dbee1ebf38afcbc7a381d5f4df515a8da
Reviewed-on: https://chromium-review.googlesource.com/868507
Commit-Queue: May Lippert <maybelle@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532076}

This CL updates the testing configuration for the in-product help
feature for data saver.

BUG=748574

Change-Id: I782c429d67f04eca00c4a56172e0632f59c056a4
Reviewed-on: https://chromium-review.googlesource.com/885089Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532075}

This CL updates the testing configuration for the in-product help
feature for downloading web pages on Android after taking a
screenshot to the planned launch configuration.

BUG=748574

Change-Id: Iee3f04274649c62d3476539bd04441e6730fbd18
Reviewed-on: https://chromium-review.googlesource.com/884985Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532074}

Got reported by automated linter at:
https://bugs.chromium.org/p/chromium/issues/detail?id=805881

Bug: 805881

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia11917484274dda0c2f3f3914da3dce37376e2fe
Reviewed-on: https://chromium-review.googlesource.com/887748
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532073}

This patch adds test cases about vertical text and overflowing or
underflowing text to LocalCaretRectTest, to help the implementation
of the NG version of LocalCaretRectOfPosition().

Bug: 771398
Change-Id: I21a6a07cf1246b9dd867e7b5a4fe44aa101a2aff
Reviewed-on: https://chromium-review.googlesource.com/887918Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532072}

This CL adds android:host="*" to the intent filter and removes the
AppLinkUrlError suppression.

Bug: 804441
Change-Id: I30dc3f0171fbfb6b4f195b90f7deba0fd43911ba
Reviewed-on: https://chromium-review.googlesource.com/879584Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532071}

Modify URLRequestExtensionJob to determine the mime type of a requested
file through net::GetWellKnownMimeTypeFromExtension(), rather than
URLRequestFileJob::GetMimeType(). The difference here is that the latter
will include platform-specific modifications. This means that if another
application on the users machine specified a different mime type for an
extension, that type would be used.

This causes problems with modules in extensions, in the cases where a
different application has set a different mime type for .js files, since
modules have strict mime type requirements.

Use GetWellKnownMimeTypeFromExtension(), and add .js to the list of
primary mappings in mime_util.cc.

Bug: 797712

Change-Id: I27fea0479268520abd08fb62a501d213a3a04f52
Reviewed-on: https://chromium-review.googlesource.com/885401Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532070}

After r531270, gn chokes while running exec_script():

[0124/122441.126364:FATAL:thread_restrictions.cc(105)] Check failed:
!g_base_sync_primitives_disallowed.Get().Get().

GN executes scripts synchronously while loading files, so blocking is necessary.
This CL adds a ScopedAllowBaseSyncPrimitives for gn to use while waiting for
exec_script() to complete.

BUG=805628
R=dpranke,thestig,fdoray

Change-Id: I7ad539a8dee0230c84d94f1c6b37755a890bfcd7
Reviewed-on: https://chromium-review.googlesource.com/884423
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532069}

Serialize prefixes for HTML fragments correctly as described in the spec:
https://html.spec.whatwg.org/#serialising-html-fragments

Bug: 651762
TEST=external/wpt/html/syntax/serializing-html-fragments/serializing.html

Change-Id: I577841f60eea118ce0039e53f95d970c20566261
Reviewed-on: https://chromium-review.googlesource.com/883862Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#532068}

This patch makes spatial navigation work correctly when the root layer
scrolls feature is turned on. This class was incorrectly using
"absolute" coordinates to mean "root frame" so I fixed the naming where
appropriate and used the correct RLS-aware coordinate conversion
methods.

These tests also uncovered a bug in one of these conversion methods:
AbsoluteToRootFrame(LayoutRect). This CL fixes that issue as well.

Bug: 417782
Change-Id: I700069f46ce60d834e4f2a25113034a2c5bb3eb0
Reviewed-on: https://chromium-review.googlesource.com/887334
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532067}

As part of the effort to move UtilityProcessHost to the ServiceManager,
removing a reference to UtilityProcessHost from
MashServiceRegistryTest.

Bug: 775677
Change-Id: I7da48a0f58d46205c3ec2e7143a22e96981cba37
Reviewed-on: https://chromium-review.googlesource.com/886839Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532066}

No-Try: true
Tbr: dtapuska@chromium.org
Bug: 806357
Change-Id: Id60c740f60a867f081810efc62654271b0495e02
Reviewed-on: https://chromium-review.googlesource.com/889706Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532065}

Moving the manifest parsing and extension validation from the
Unpacker class to SandboxedUnpacker. As a result, all the extension
unpacking is done from the browser process and the Unpacker class is
removed.

The 2 remaining methods in unpacker.cc still used for unzipping the
extension have been moved to utility_handler.cc and the associated
tests renamed from unpacker_unittest.cc to utility_handler_unittest.cc.
The unzipping will also eventually be moved to the browser process at
which point utility_handler files will be removed as well.

Tbr: rockot@chromium.org
Bug: 800540
Change-Id: Ib286fa88edc96e4c186aba6e2ee1d9c2317efe84
Reviewed-on: https://chromium-review.googlesource.com/883967Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532064}

This change migrates the server/getPrimaryService(s) tests to wpt/.

BUG=509038

Change-Id: I9f3adb19f0b6edec2ba45eec7e331b75b3aae57c
Reviewed-on: https://chromium-review.googlesource.com/834201Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532063}

Add +aluo to related third_party repo and WebView sub directory as OWNER

Change-Id: Ieae996d2725893adf593e40c3f4950bd3e3e2d24
Reviewed-on: https://chromium-review.googlesource.com/887824Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532062}

There aren't any lifetime issues as far as I can tell, but
the code will be a lot safer given move-only semantics.

Remove always-empty fds_to_close_post_fork array usage.

Change-Id: I20638a01c30193275212c72f056b8da613c7072e
Reviewed-on: https://chromium-review.googlesource.com/887356
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532061}

This change updates a couple of characteristic same object tests to use
the new test API. This will allow the tests to be migrated into the wpt/
directory.

BUG=509038

Change-Id: I483a623c8f58848fb0a7e3cea7cb65b27c79eccc
Reviewed-on: https://chromium-review.googlesource.com/823072
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532060}

M65 changed some of the clicking/playing behavior so update the test to
use a backward-compatible fix.

Bug: 799585
Change-Id: If13867d2a56d0de8b374505f8c780385143f9aa2
Reviewed-on: https://chromium-review.googlesource.com/887425
Commit-Queue: Robert Ogden <robertogden@google.com>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532059}

* Make text on host setup instruction view darker so that the contrast
  ratio is higher than 4.5:1.
* Use Google Blue palette for the settings menu. Make primary text bold.

Bug: 806091
Change-Id: I7c6b02d502a24261e022eca329eb6766007563ea
Reviewed-on: https://chromium-review.googlesource.com/887720Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532058}

For SPv175 (but not SPv2) a chunk may have paint properties escaping
its containing composited layer. A layer may have no painting changed
but needs raster invalidation for changed paint properties (caused by
ancestors) of such chunks.

An example is a fixed-positioned object under a composited layer other
than the LayoutView. When the viewport scrolls, nothing will change in
in paint artifacts, but the fixed-positioned object's paint chunk
will change its chunk_to_layer_transform thus needs raster invalidation.

Bug: 805049

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I72c672657215aa4543783eed9cb2362411939a01
Reviewed-on: https://chromium-review.googlesource.com/885092Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532057}

Bug: 806068
Change-Id: I013b1396f3c56edb5b7dd349d9ad31616b1a5803
Reviewed-on: https://chromium-review.googlesource.com/887780Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532056}

OfflinePageRequestJob does not derive from URLRequestFileJob any more.
Instead, the file reading logic in URLRequestFileJob is integrated into
OfflinePageRequestJob such that the file can be opened and held for both
validation and reading.

Bug: 758690
Change-Id: Id33533316b79a919a365991aa0173bc8c71b5e4f
Reviewed-on: https://chromium-review.googlesource.com/865757Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532055}

TBR=junov@chromium.org

Bug: None
Change-Id: Ib34c35f73778b71cea041b81dcf94ca413f0e13a
Reviewed-on: https://chromium-review.googlesource.com/887962Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532054}

Disabling as this test is failing on linux-chromeos-rel builder.
See:
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/4627

TBR=yamaguchi@chromium.org
TBR=yoshiki@chromium.org

Bug: 804413
Change-Id: I9591ee8652fc7965b1261a8cf2f1666b6ae7d3ea
Reviewed-on: https://chromium-review.googlesource.com/887618Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532053}

This commit fixes a regression of crrev.com/c/874526.

Bug: 804517
Change-Id: Ib1150d51a35251bb9fcaa9853b41db55a50633f1
Reviewed-on: https://chromium-review.googlesource.com/887825Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#532052}