GitLab

This CL fixes presubmit_scheme_histograms.py and
presubmit_bad_message_reasons.py which after r462591 would always report
presubmit errors (because it started returning a tuple from HistogramNeedsUpdate
which always coerces to True in the broken presubmit scripts).

After r462591 HistogramNeedsUpdate effectively checks all
histogram-enum-related presubmits (both for updating histograms.xml and
for detecting duplicate values).  Therefore the current CL renames this
function to CheckPresubmitErrors and makes it return a presubmit error
(rather than a tuple of (needs_updating, duplicates)).  This refactoring
has a nice side benefit - after this CL, all presubmits going through
CheckPresubmitErrors will check for duplicate values (r462591 only added
this check for UseCounter histograms).

This CL also tweaks content/browser/PRESUBMIT.py so that it applies
*both* to upload-time and commit-time checks (without this change
|git cl presubmit| would not hit the checks related to
content/browser/bad_message.h - they would only be hit when running
|git cl presubmit --upload|).

Manual testing done:
- Make changes in content/browser/bad_message.h,
  chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc,
  third_party/WebKit/Source/code/frame
- Run git cl presubmit and verify that the presubmit
  checks detect 1) duplicates and 2) the need to update histograms.xml

BUG=577772
TEST=See "Manual testing done" above.
TBR=sky@chromium.org, jochen@chromium.org, rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2841823007
Cr-Commit-Position: refs/heads/master@{#468003}

This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies.

A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003

Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit#

GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3

R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org
BUG=691886

Review-Url: https://codereview.chromium.org/2798713002
Cr-Commit-Position: refs/heads/master@{#468002}

When forcible termination is requested, WorkerThread::WillProcessTask() calls
PrepareForShutdownOnWorkerThread() that disposes of the global scope scheduler,
which in turn disposes of the task to be run. This results in crashes.

This CL moves PrepareForShutdownOnWorkerThread() call from WillProcessTask() to
DidProcessTask() to fix the crashes. This could still cause a crash if the
termination request is issued between DidProcessTask() and WillProcessTask()
because in the case a task runs and may access an empty handle returned by V8
API. However, such a case would be rare because generally forcible termination
is scheduled as a delayed task(*) and DidProcessTask() can have a chance to
check IsForciblyTerminated() before it's fired.

(*) Forcible termination could synchronously be called in some path, but it'll
be removed (see issue 641846).

BUG=713914

Review-Url: https://codereview.chromium.org/2849583004
Cr-Commit-Position: refs/heads/master@{#468001}

If it happens that user policy is retrieved before session is started,
then there's no policy to apply to the user which could be used as
policy enforcement escape. This is a case when some flow went wrong,
and we abandon the user sign in.

BUG=689206

Review-Url: https://codereview.chromium.org/2801993002
Cr-Commit-Position: refs/heads/master@{#468000}

Spec: https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945

Review-Url: https://codereview.chromium.org/2851693002
Cr-Commit-Position: refs/heads/master@{#467999}

This feature was reverted due to the new browsertest being flaky on
internal Cast infrastructure: crrev.com/2838813003

=== Original Commit Message ===
In Chromium, Finch-enabled features are controlled through base::FeatureList,
a class which abstracts the experiment framework and developer overrides
from client code. Though Chromecast's experiment framework is fundamentally
different (in that it is server-driven) Cast builds can still make use of
this class. Introduce some utilities to help.

At boot-up, the pref store will be queried for experiment configs, which
were cached to disk on the most recent config fetch from the last boot
cycle. If a developer overrides these features from the command line,
that value takes precedence. These features will be used to initialize
base::FeatureList, which can then be statically queried from any client
code that depends on //base.

This patch does not actually introduce or convert any existing features
to use this framework.

BUG=714291
BUG= internal b/35424335

Review-Url: https://codereview.chromium.org/2836263003
Cr-Commit-Position: refs/heads/master@{#467998}

When a pen enters and leaves a tablet's proximity and enters again, the
PointerEvents' isPrimary should always be true.

Testing page: https://patrickhlauke.github.io/touch/tracker/multi-touch-tracker-pointer-hud.html

Webplatform test pointerevent_pointerleave_pen-manual.html does not work
right now because of no support of PointerLeave events when pen leaves
the range of the tablet in PointerActionSequence API. I will add it soon.

BUG=713745

Review-Url: https://codereview.chromium.org/2831933002
Cr-Commit-Position: refs/heads/master@{#467997}

https://skia.googlesource.com/skia.git/+log/56de05fec3fa..0122af08f6af

$ git log 56de05fec..0122af08f --date=short --no-merges --format='%ad %ae %s'
2017-04-27 msarett Revert "Delete copyTo(Allocator), hide copyTo() behind flag"
2017-04-27 herb Add instrumentation into SkArenaAlloc.
2017-04-27 mtklein jumper, remove C(int)
2017-04-27 egdaniel Revert "Plumb the use of GrBackendRenderTarget throughout Skia"
2017-04-26 brianosman Fold SkImageCacherator into SkImage_Lazy
2017-04-27 mtklein jumper, replace _i with normal constants
2017-04-26 egdaniel Plumb the use of GrBackendRenderTarget throughout Skia
2017-04-27 egdaniel Add additional checks when creating vulkan context
2017-04-27 kjlubick Don't reboot Pixel C or Nexus Player before task
2017-04-27 msarett Delete copyTo(Allocator), hide copyTo() behind flag
2017-04-27 mtklein In ok thread mode, use wait_util instead of wait_for.
2017-04-27 mtklein clear out C(), _i, and _f constants from SkJumper_vectors.h
2017-04-24 reed remove legacy code
2017-04-26 egdaniel Change vulkan image memory allocation back to using sub allocation
2017-04-25 brianosman Finish removing GrContext param from onRefEncodedData
2017-04-26 brianosman Fix color space handling in SkImage_Gpu::getROPixels

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I29643b478fde4d32304518327ea933b4e9176491
Reviewed-on: https://chromium-review.googlesource.com/489483Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467996}

Every LayoutBox with a PaintLayer will do some layer updating at the end of its layout; this consists of:

- updating the layer's transform
- updating the layer's scrollable area, if necessary
- in the near future, updating the layer's size

This change consolidates all of those into LayoutBox::UpdateAfterLayout.

BUG=701575
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2839183002
Cr-Commit-Position: refs/heads/master@{#467995}

Changes the confusing ACTION_funnel_ names in scheduler state machine to
did_ACTION_. Replaces prepare_tiles_funnel_ (the only real "funnel")
with a bool that does the same job. Changes the state machine to use
default member initialization.

One SchedulerTest which explicitly tested that we reset the funnel after
visibility change had to be modified. Since we don't reset the prepare
tiles state on begin frame any more that old test doesn't work as is.
Following along the discussion in crbug.com/497473#c14 the test's exact
behavior isn't needed as we never end up in a situation with an ever
increasing prepare tiles funnel after this change.

R=danakj
BUG=NONE

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Change-Id: I1541b358d05ad1b824955ae63e3bcb173c3ffda3
Reviewed-on: https://chromium-review.googlesource.com/487322
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467994}

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG=713180, 703894

Review-Url: https://codereview.chromium.org/2849673002
Cr-Commit-Position: refs/heads/master@{#467993}

We were drawing the text area resizer using an image scaled
to either 100% or 200% depending on the device scale factor.
This leads to a resizer that is too small at 190% DPI, for example,
and seems to sometimes draw too small on standard 2x DPI devices.

This patch refactors the code to paint the resizer using lines,
rather than an image. This results in correct behavior for any scale.

R=fmalita@chromium.org, peter@chromium.org
BUG=599225
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2835203005
Cr-Commit-Position: refs/heads/master@{#467992}

This allows calling chrome.enterprise.platformKeys.challengeMachineKey() from a profile that does not have a user associated with it.

BUG=715121
TEST=unit tests

Review-Url: https://codereview.chromium.org/2841553002
Cr-Commit-Position: refs/heads/master@{#467991}

This method has been replaced by Create() and Start().

R=gab@chromium.org
TBR=gab@chromium.org
BUG=690706

Review-Url: https://codereview.chromium.org/2845913004
Cr-Commit-Position: refs/heads/master@{#467990}

This CL corrects the load time metrics for Logos on the NTP.

The old behavior:
-----------------
If the doodle cache is empty, the LogoShownTime will be recorded when
the next DoodleService#Refresh triggers the observer who requested a
Refresh.
If the requested refresh is skipped, the observer records the time when
the next notification happens due to a refresh triggered by a different
caller. This can be timely but is much more likely to be 15 min or more
in the future. This delay blurs the metric.

The wanted/new behavior:
------------------------
This CL introduces a way to know that the refresh was skipped.
The observer that records LogoShownTime uses it to prevent recording
any metrics for this case.

BUG=713166

Review-Url: https://codereview.chromium.org/2833473002
Cr-Commit-Position: refs/heads/master@{#467989}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2849603003
Cr-Commit-Position: refs/heads/master@{#467988}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2846723004
Cr-Commit-Position: refs/heads/master@{#467987}

The device_settings_cache_unittest.cc file was accidentally dropped
from the build a long time ago.

BUG=chromium:139126,chromium:661774
TEST=DeviceSettingsCacheTest* passes.

Review-Url: https://codereview.chromium.org/2849533005
Cr-Commit-Position: refs/heads/master@{#467986}

Updates the updateWith function to accept an instance of
window.PaymentDetails as well as a promise that fulfills with one:
https://w3c.github.io/browser-payment-api/#paymentrequestupdateevent-interface

BUG=602666

Review-Url: https://codereview.chromium.org/2850723003
Cr-Commit-Position: refs/heads/master@{#467985}

R=shess@chromium.org
BUG=675446

Review-Url: https://codereview.chromium.org/2609473004
Cr-Commit-Position: refs/heads/master@{#467984}

Because of the spanning of multiple heaps by the resources associated
with FilterEffects [GCd] (SkImageFilter [mallocd]), the garbage
collector only observes a relatively slow growth, while resources tied
by or via the other heap can be substantial.

Since we have fairly good control of the lifetimes here, we can try to
dispose of our references to the resources on the other heap up front,
and prevent growth due to (dead) GCd objects in limbo.

Also rename FilterEffect::ClearResult to DisposeImageFilters to better
match it does nowadays.

BUG=610158

Review-Url: https://codereview.chromium.org/2846593008
Cr-Commit-Position: refs/heads/master@{#467983}

When I broke out a function, I mixed up the request and the JSON for the
argument.

Review-Url: https://codereview.chromium.org/2849763003
Cr-Commit-Position: refs/heads/master@{#467982}

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2808873002/ )

Reason for revert:
Reverting since ios_chrome_smoke_egtests its failing and it broke the autoroller.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/chromium-autoroller/builds/373/steps/ios_chrome_smoke_egtests%20%28iPhone%205s%20iOS%2010.0%29/logs/stdio

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2808873002
> Cr-Commit-Position: refs/heads/master@{#467947}
> Committed: https://chromium.googlesource.com/chromium/src/+/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b

TBR=stkhapugin@chromium.org,sdefresne@chromium.org,gambard@chromium.org,olivierrobin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2852713002
Cr-Commit-Position: refs/heads/master@{#467981}

BUG=694750

Review-Url: https://codereview.chromium.org/2832573002
Cr-Commit-Position: refs/heads/master@{#467980}

BUG=712809

Review-Url: https://codereview.chromium.org/2847893003
Cr-Commit-Position: refs/heads/master@{#467979}

Revert of Follow up from ARC conversion (patchset #2 id:20001 of https://codereview.chromium.org/2851713002/ )

Reason for revert:
Revert since its needed to revert https://codereview.chromium.org/2808873002 which broke the roller.

Original issue's description:
> Follow up from ARC conversion
>
> Addressing the comments raised in https://codereview.chromium.org/2808873002/
>
> BUG=none
>
> Review-Url: https://codereview.chromium.org/2851713002
> Cr-Commit-Position: refs/heads/master@{#467951}
> Committed: https://chromium.googlesource.com/chromium/src/+/6273712b527b4e13ec0d854fcd11e0b5e034eb2a

TBR=stkhapugin@chromium.org,sdefresne@chromium.org,gambard@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2849853002
Cr-Commit-Position: refs/heads/master@{#467978}

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing
WTFString::Split interface.

Hence this CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967

Review-Url: https://codereview.chromium.org/2844353003
Cr-Commit-Position: refs/heads/master@{#467977}

This is part of a series of CLs to get rid of the notion of
"Instant support" entirely, see
https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41

BUG=627747

Review-Url: https://codereview.chromium.org/2847083002
Cr-Commit-Position: refs/heads/master@{#467976}

VR no longer uses an HTML UI, so no longer uses the incognito profile.

BUG=

Review-Url: https://codereview.chromium.org/2845023003
Cr-Commit-Position: refs/heads/master@{#467975}

This is the first of a series of CLs to get rid of the notion of
"Instant support" entirely, see
https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41

BUG=627747

Review-Url: https://codereview.chromium.org/2845303002
Cr-Commit-Position: refs/heads/master@{#467974}

The test has been converted upstream to use ASSERT_DEATH_IF_SUPPORTED
and can now be built on iOS.

BUG=595645

Review-Url: https://codereview.chromium.org/2849713004
Cr-Commit-Position: refs/heads/master@{#467973}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e80a730b1b1b..5fa840e82c50

$ git log e80a730b1..5fa840e82 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 hjd [tracing] Add tests for ui/base/event_presenter.html

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I151ce9756fac64c0b3cceed142351f30c7f77005
Reviewed-on: https://chromium-review.googlesource.com/489694
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467972}

This CL lands server change 152524616 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2844963005
Cr-Commit-Position: refs/heads/master@{#467971}

Comparison of hashes of all suffixes of input with the sync password hash is implemented.

BUG=657041

Review-Url: https://codereview.chromium.org/2847743002
Cr-Commit-Position: refs/heads/master@{#467970}

Add net/spdy/PRESUBMIT.py that checks files in net/spdy/core and
net/spdy/platform/api to make sure that classes, functions, and macros
that have been factored out into net/spdy/platform are only used in that
form in shared code.

Review-Url: https://codereview.chromium.org/2847613002
Cr-Commit-Position: refs/heads/master@{#467969}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=marq@chromium.org

Review-Url: https://codereview.chromium.org/2846073002
Cr-Commit-Position: refs/heads/master@{#467968}

Also s/ActiveDirectoryAccountData/ActiveDirectoryAccountInfo

BUG=662400
TBR=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2841103002
Cr-Commit-Position: refs/heads/master@{#467967}

Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4 id:100001 of https://codereview.chromium.org/2827233006/ )

Reason for revert:
broke official-* bots, see crbug.com/716330

Original issue's description:
> [WebAPKs] Make WebAPK update flow more sensible
>
> Previously, whenever the shell_apk in shell_apk_version.gni there was a period
> of time during which
> - Chrome tries to update the WebAPK because the "shell_apk" version with which
>   Chrome is compiled with was updated
> - The WebAPK server is unable to fulfill the update request because the new
>   ShellAPK has not yet been uploaded to the WebAPK server
>
> This CL splits shell_apk_version in shell_apk_version.gni into two variables:
> |template_shell_apk_version| and |expected_shell_apk_version|
>
> The new flow for updating android/webapk/shell_apk will be:
> 1) Write CL which:
>    - Makes changes to code in android/webapk/shell_apk
>    - Increments |template_shell_apk_version|
>    This will:
>    - Update the template ShellAPK which is built on the official build bot
>    - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to
>      be updated
>    - Does not affect the "WebAPK update logic".
> 2) Upload new ShellAPK template to the WebAPK Minting Server
>    At this point:
>    - new WebAPK installs will have the updated shell.
>    - Chrome will still not request updates to the new ShellAPK version
> 3) Write CL which:
>    - Increments |expected_shell_apk_version|
>    This will:
>    - cause Chrome to request updates to the new ShellAPK version
>
> BUG=708053
>
> Review-Url: https://codereview.chromium.org/2827233006
> Cr-Commit-Position: refs/heads/master@{#467708}
> Committed: https://chromium.googlesource.com/chromium/src/+/d71abed75b07b4b9fc50591cbeb2b6c8874bf448

TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708053

Review-Url: https://codereview.chromium.org/2845943006
Cr-Commit-Position: refs/heads/master@{#467966}

This is required to land https://chromium-review.googlesource.com/c/483199/ which changes the behavior. Currently those tests hardwire wrong behavior that exposes internal implementation details. The change in the referred CL makes it more uniform, and in line with at least Firefox.

BUG=chromium:713732

Review-Url: https://codereview.chromium.org/2831923003
Cr-Commit-Position: refs/heads/master@{#467965}

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=

Review-Url: https://codereview.chromium.org/2845033002
Cr-Commit-Position: refs/heads/master@{#467964}