GitLab

Cr-Commit-Position: refs/heads/master@{#297162}

No functional change in this bug, but it paves the way to doing real work
with the PasswordStore by separating the IPC-handling bits from the
PasswordManagerClient implementation so that we can easily subclass
PasswordStoreConsumer in a way that keeps all the credential functionality
well-contained in a single object for clarity.

BUG=400674

Review URL: https://codereview.chromium.org/615483002

Cr-Commit-Position: refs/heads/master@{#297161}

BUG=216422
TEST=manual.

Review URL: https://codereview.chromium.org/613653004

Cr-Commit-Position: refs/heads/master@{#297160}

BUG=371692

Review URL: https://codereview.chromium.org/614673002

Cr-Commit-Position: refs/heads/master@{#297159}

Blink WebString::fromUTF8 are marginally faster than UTF8ToUTF16 on
pure ASCII input because they have a fast path for this case. Implement
the same thing for base::UTF8ToUTF16

DoIsStringASCII is now a port of charactersAreAllASCII from Blink.

BUG=391492
R=brettw@chromium.org, torne@chromium.org

Review URL: https://codereview.chromium.org/543043002

Cr-Commit-Position: refs/heads/master@{#297158}

and having it rely entirely on Finch.
BUG=417851
R=rkaplow, cbentzel

Review URL: https://codereview.chromium.org/606003003

Cr-Commit-Position: refs/heads/master@{#297157}

Removed all other manual test files in the ../webrtc/manual folder. They
too have moved to GitHub but are not used that often hence no redirect
pages are necessary.

The ../webrtc/manual folder now resides here:
https://github.com/GoogleChrome/webrtc/tree/master/samples/web/content/manual-test

BUG=NONE
NOTRY=TRUE

Review URL: https://codereview.chromium.org/609733002

Cr-Commit-Position: refs/heads/master@{#297156}

This patch allows to fetch thumbnails via metadata cache for provided file
systems.

TEST=Tested manually.
BUG=407954

Review URL: https://codereview.chromium.org/609263002

Cr-Commit-Position: refs/heads/master@{#297155}

BUG=398049

Review URL: https://codereview.chromium.org/577923002

Cr-Commit-Position: refs/heads/master@{#297154}

Will fix this test once the chromium side changes for this
issue will be merged 169574.

BUG=169574

Review URL: https://codereview.chromium.org/612563004

Cr-Commit-Position: refs/heads/master@{#297153}

R=isherman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/611523002

Cr-Commit-Position: refs/heads/master@{#297152}

BUG=418275
TEST=manually tested

Review URL: https://codereview.chromium.org/611953002

Cr-Commit-Position: refs/heads/master@{#297151}

Revert of Revert of Add nullptr support to scoped_ptr. (patchset #1 id:1 of https://codereview.chromium.org/604423005/)

Reason for revert:
multiple compilation errors

Original issue's description:
> Revert of Add nullptr support to scoped_ptr. (patchset #8 id:200001 of https://codereview.chromium.org/599313003/)
>
> Reason for revert:
> This patch seems to break ScopedPtrWithArray ASAN test.
>
> https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)/builds/2348/steps/base_unittests
>
> Original issue's description:
> > Add nullptr support to scoped_ptr.
> >
> > This adds support to use nullptr to construct, assign, or return a
> > scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
> > of a move-only constructor.
> >
> > The changes are:
> >
> > - Add a constructor that takes decltype(nullptr) as a parameter. This
> > allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
> > function with return type scoped_ptr<T> to "return nullptr;" instead
> > of "return scoped_ptr<T>();".
> >
> > - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
> > empty and deletes anything it held.
> >
> > - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
> > constructing a scoped_ptr from another using move-only semantics. This
> > piece is critical for allowing the function returning nullptr to be
> > assigned to some other scoped_ptr at the callsite. In particular, take
> > the following code:
> >   scoped_ptr<T> Function() { return nullptr; }
> >   scoped_ptr<T> var = Function();
> > In this case the constructor which takes a nullptr allows Function() to
> > be written, but not to be used. The move-only constructor allows the
> > assignment from Function() to var. See "C++11 feature proposal:
> > Move-only constructors" on chromium-dev for more explanation why.
> >
> > The scoped_ptr<T> class already had a constructor which took
> > scoped_ptr<U,E> as an argument, so this was changed to be
> > scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
> > constructor, so a scoped_ptr&& constructor was added. These match
> > the constructors found on the unique_ptr class.
> >
> > - Remove the RValue type and the contructor that constructs a
> > scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
> > instead of a scoped_ptr::RValue, to avoid the type conversion and
> > remove some complexity. This is done with a new emulation macro that
> > still provides Pass() and makes the type go down the MoveOnlyType
> > path in base::Callback code.
> >
> > This adds base_unittests to demonstrate and use these changes.
> >
> > The use of Pass() remains unchanged until std::move() is written
> > or allowed. At that time std::move() could be used instead of Pass.
> >
> > R=brettw@chromium.org, jamesr@chromium.org
> >
> > Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
> > Cr-Commit-Position: refs/heads/master@{#297072}
> >
> > Committed: https://crrev.com/a9527ce329c38d945e46773f1592a4939cf62b99
> > Cr-Commit-Position: refs/heads/master@{#297116}
>
> TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,dcheng@chromium.org,danakj@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/300249a2f5d9f0b8b86553712ac7ccb55d6afc1c
> Cr-Commit-Position: refs/heads/master@{#297149}

TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,dcheng@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/611973002

Cr-Commit-Position: refs/heads/master@{#297150}

Revert of Add nullptr support to scoped_ptr. (patchset #8 id:200001 of https://codereview.chromium.org/599313003/)

Reason for revert:
This patch seems to break ScopedPtrWithArray ASAN test.

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)/builds/2348/steps/base_unittests

Original issue's description:
> Add nullptr support to scoped_ptr.
>
> This adds support to use nullptr to construct, assign, or return a
> scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
> of a move-only constructor.
>
> The changes are:
>
> - Add a constructor that takes decltype(nullptr) as a parameter. This
> allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
> function with return type scoped_ptr<T> to "return nullptr;" instead
> of "return scoped_ptr<T>();".
>
> - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
> empty and deletes anything it held.
>
> - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
> constructing a scoped_ptr from another using move-only semantics. This
> piece is critical for allowing the function returning nullptr to be
> assigned to some other scoped_ptr at the callsite. In particular, take
> the following code:
>   scoped_ptr<T> Function() { return nullptr; }
>   scoped_ptr<T> var = Function();
> In this case the constructor which takes a nullptr allows Function() to
> be written, but not to be used. The move-only constructor allows the
> assignment from Function() to var. See "C++11 feature proposal:
> Move-only constructors" on chromium-dev for more explanation why.
>
> The scoped_ptr<T> class already had a constructor which took
> scoped_ptr<U,E> as an argument, so this was changed to be
> scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
> constructor, so a scoped_ptr&& constructor was added. These match
> the constructors found on the unique_ptr class.
>
> - Remove the RValue type and the contructor that constructs a
> scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
> instead of a scoped_ptr::RValue, to avoid the type conversion and
> remove some complexity. This is done with a new emulation macro that
> still provides Pass() and makes the type go down the MoveOnlyType
> path in base::Callback code.
>
> This adds base_unittests to demonstrate and use these changes.
>
> The use of Pass() remains unchanged until std::move() is written
> or allowed. At that time std::move() could be used instead of Pass.
>
> R=brettw@chromium.org, jamesr@chromium.org
>
> Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
> Cr-Commit-Position: refs/heads/master@{#297072}
>
> Committed: https://crrev.com/a9527ce329c38d945e46773f1592a4939cf62b99
> Cr-Commit-Position: refs/heads/master@{#297116}

TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,dcheng@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/604423005

Cr-Commit-Position: refs/heads/master@{#297149}

Added a unittest for ChromePermissionMessageProvider that ensures
permission messages currently coalesce and form as expected. Some of the
tests are purposely for broken functionality, just to ensure this
functionality exists (and will later be fixed). The tests will be
modified once the new model changes this permission behaviour.

BUG=398257

Review URL: https://codereview.chromium.org/594003002

Cr-Commit-Position: refs/heads/master@{#297148}

For adding web animations with animation timing on compositor.

BUG=417909

Review URL: https://codereview.chromium.org/598853003

Cr-Commit-Position: refs/heads/master@{#297147}

Cr-Commit-Position: refs/heads/master@{#297146}

This CL is needed for landing https://codereview.chromium.org/552653005.
https://codereview.chromium.org/552653005 moves MediaStream-related objects
to Oilpan's heap, and the objects are not collected until a next GC is triggered.
Thus some of the Chromium-side tests need to clear those objects and explicitly
trigger a GC in order to make sure that all objects are collected by the end of
each test. Otherwise LSan complains the leakage.

I've already landed a similar fix before: https://codereview.chromium.org/566793002/

I think this CL is a final fix for the memory leakage.

BUG=416466

Review URL: https://codereview.chromium.org/596923003

Cr-Commit-Position: refs/heads/master@{#297145}

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/614573002

Cr-Commit-Position: refs/heads/master@{#297144}

There is already a white list in the manifest, so this extra manual check
became redundant. Moreover, we want to give access to this API to some apps
which are not components.

Since this API is very powerful, a test has been added to make sure that
random apps will never have access to this API.

TEST=browser_tests: *FileManagerPrivateApiTest*Permissions*
BUG=None

Review URL: https://codereview.chromium.org/612753003

Cr-Commit-Position: refs/heads/master@{#297143}

Move Linux debug tests from Linux Tests (dbg)(2) to Linux Tests (dbg)(1) for consistency with other testers after turning on swarming.

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/611913002

Cr-Commit-Position: refs/heads/master@{#297142}

Revert of Add gtest_tests dictionaries for a single Linux debug tester. (patchset #2 id:40001 of https://codereview.chromium.org/599993003/)

Reason for revert:
reverting per new approach I'm taking in https://codereview.chromium.org/602963002/

Original issue's description:
> Add gtest_tests dictionaries for a single Linux debug tester.
>
> This has to be landed first. After the recipe change, I'll remove the old ones.
>
> BUG=414808
> R=phajdan.jr@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4d2bfd854ee6282d8a9af0722c205689d989001a

TBR=phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414808

Review URL: https://codereview.chromium.org/610943002

Cr-Commit-Position: refs/heads/master@{#297141}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/610893004

Cr-Commit-Position: refs/heads/master@{#297140}

BUG=413679

Review URL: https://codereview.chromium.org/546213005

Cr-Commit-Position: refs/heads/master@{#297139}

loop should break after match as values are getting reset to empty
rect after match.Changes done so that loop breaks after match.

BUG=417621

Review URL: https://codereview.chromium.org/603903002

Cr-Commit-Position: refs/heads/master@{#297138}

* When PLAY request for casted video is skipped, this.playInProgress_ was not cleared and this inconsistent state prevented the video from being played. I cleared the flag in this case.
* When PAUSE reqeust is in progress, incoming PLAY request should not be skipped. So I added a condition to skip the PLAY request.

BUG=417520,417538
TEST=manually tested the steps described in both bugs.

Review URL: https://codereview.chromium.org/603413003

Cr-Commit-Position: refs/heads/master@{#297137}

Previously we were using the plugin context when converting objects during calls
into the plugin from JS. As decided previously in https://codereview.chromium.org/555583003/
we should always use the caller's context in these circumstances.

This CL also separates the checks in PepperPluginInstanceImpl::GetContext to
help diagnose crbug.com/416311.

BUG=416311

Review URL: https://codereview.chromium.org/588083002

Cr-Commit-Position: refs/heads/master@{#297136}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/598393002

Cr-Commit-Position: refs/heads/master@{#297135}

BUG=None

Review URL: https://codereview.chromium.org/609153002

Cr-Commit-Position: refs/heads/master@{#297134}

BUG=None

Review URL: https://codereview.chromium.org/612693002

Cr-Commit-Position: refs/heads/master@{#297133}

* s/NULL/nullptr/g
* Fix lint errors

BUG=None

Review URL: https://codereview.chromium.org/610223002

Cr-Commit-Position: refs/heads/master@{#297132}

register() resolves to a ServiceWorkerRegistration, so we no longer need
to pass a ServiceWorkerVersion around.

This also cleans up a couple TODOs in RegisterJob:
- In ContinueWithRegistrationForSameScriptUrl, the TODO made sense when
register resolved to a version not a registration.
Now, the current behavior seems OK.
- In UpdateAndContinue, the TODO was misleading. We don't have to handle
an existing installing worker within RegisterJob since each job either
succeeds with a waiting/active worker or fails and cleans up the
installing worker.

BUG=406240

Review URL: https://codereview.chromium.org/605163002

Cr-Commit-Position: refs/heads/master@{#297131}

This prepares for landing of
http://crrev.com/530663002

which now requires a three-sided change due to changes in how Blink accesses
private script resources.

Part 1: http://crrev.com/583753003

BUG=408887
TEST=n/a; no code changes

Review URL: https://codereview.chromium.org/588473003

Cr-Commit-Position: refs/heads/master@{#297130}

Implements several new checks in the plugin, gated behind a flag:
- Only one of {virtual,override,final} should be ever used.
- Destructors must also be annotated correctly.
- A virtual final method that doesn't override anything should be
  devirtualized.

The test harness for the Chrome plugin has also been updated to stop
it from littering the source tree with object files, and to make the
golden files easier to update.

BUG=417463

Review URL: https://codereview.chromium.org/597863002

Cr-Commit-Position: refs/heads/master@{#297129}

Brett prefers we go with foo_unittests, it makes Windows users life
easier. And others easier, so they don't need to know/remember the other
possibility: /path/to:unittests

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug aura_unittests
ui_unittests
R=brettw@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/601753003

Cr-Commit-Position: refs/heads/master@{#297128}

Revert of Fixed flakiness in PolicyTest.FileURLBlacklist. (patchset #5 id:80001 of https://codereview.chromium.org/551323003/)

Reason for revert:
It's causing lots of flakiness on trybots, now that you added logging look at the past flakiness for more info:

http://chromium-try-flakes.appspot.com/search?q=PolicyTest.FileURLBlacklist

Original issue's description:
> Re-enabled PolicyTest.FileURLBlacklist.
>
> This test flakes on the Mac. This CL adds additional logging to help diagnose the source of flakiness.
>
> BUG=339240
>
> Committed: https://crrev.com/82405166f151d0d0be73d040aa5b77d309034aa0
> Cr-Commit-Position: refs/heads/master@{#295956}

TBR=pneubeck@chromium.org,joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=339240

Review URL: https://codereview.chromium.org/608153002

Cr-Commit-Position: refs/heads/master@{#297127}

Cr-Commit-Position: refs/heads/master@{#297126}

Cr-Commit-Position: refs/heads/master@{#297125}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/607313002

Cr-Commit-Position: refs/heads/master@{#297124}

We converted this target to GN already, so app_list can depend on it as
is. This should address the TODO(GYP) in the BUILD.gn file.

BUG=None
TEST=None
R=brettw@chromium.org
TBR=xiyuan@chromium.org,mark@chromium.org

Review URL: https://codereview.chromium.org/590863002

Cr-Commit-Position: refs/heads/master@{#297123}