- 23 Dec, 2019 40 commits
-
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=spang@chromium.org Bug: 1035074 Change-Id: I87fc8f5e0c888e350c18b3a17da8cd00f705bea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980950Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727210}
-
Haiyang Pan authored
Requires crrev.com/c/1979399 to land first Bug: 986990 Change-Id: I2e83a442b85a9c9ca494804d074b9cc51f01d669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979590Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#727209}
-
Abhijeet Singh authored
Updating the InternalConfig::visibility field to a string instead of an integer to make it compatible with the libassistant side changes. Bug: b:143715504 Change-Id: I775a4b067ae0944733bd87ecc8869641006866cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970807Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#727208}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/e223d0ec67ad..b93b64e6bec7 $ git log e223d0ec6..b93b64e6b --date=short --no-merges --format='%ad %ae %s' 2019-12-19 nharper Refactor GfeQuicCryptoServerStream so parent class owns handshaker 2019-12-19 dschinazi Add presubmit to disallow absl in /third_party/quic/ 2019-12-19 quiche-dev Created and integrated QuicIntervalDeque class for index management. Improves code readability. 2019-12-19 bnc Remove QuicHeaderList::max_header_list_size(). 2019-12-18 wub gfe-relnote: For QUIC BBRv2 flows, cut inflight_hi gradually when there is high loss from PROBE_UP. Protected by --gfe2_reloadable_flag_quic_bbr2_cut_inflight_hi_gradually. 2019-12-18 quiche-dev gfe-relnote: Migrate //gfe/test_tools/request_tools/clients/... from char* and size_t signatures to absl::string_view, a better and more modern representation of a view into a string buffer; changes the minimum number of tests to get successful compilation and runs 2019-12-18 dschinazi Make QuicSession own its perspective Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia367ccae1f60b09686b9f2945b7b6e89d3abe793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978902 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#727207}
-
Jonathan Freed authored
Change-Id: Idd5ccd907c011112e1abe9255ad6a7e9ec6ad54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979141 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#727206}
-
Darwin Huang authored
Improves the asan.md doc formatting, mostly as per review comments in https://crrev.com/c/1883615/. Change-Id: Ib4e51353b306d71f231521bd2f07944f13207c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972418 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#727205}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=dpranke@chromium.org Bug: 1035074 Change-Id: I1ac9d292b68955a38757cf90f57631ff260b388a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980893Reviewed-by:
-
Tom Anderson authored
libinput is not available on Trusty. BUG=1034916 R=friedman Change-Id: Ic408cb7b2a1c28e6d4fec10e1c4b4a50c9c8b414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980904 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Elliott Friedman <friedman@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Elliott Friedman <friedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#727203}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=wnwen@chromium.org Bug: 1035074 Change-Id: I8a403ba2b72e76dd956072f4a5db80e4ea0f1e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980873Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727202}
-
Gaofeng Huang authored
This is the only target needed by l10n/ Bug: internal b/146428609 Test: on device Change-Id: I6b70f08fc30ecce71c342f27fca061e423e174ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979514Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727201}
-
Mike Dougherty authored
Breakpad limits the size of values attached to crash reports to 255 bytes so reduce the number of redundant data in the breadcrumb timestamps in order to upload more overall events. Bug: 1003922 Change-Id: I38a9099b90ed7364088f61da1442ecd1e44eb028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979450Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727200}
-
Gabriel Charette authored
Flakily crashes. Can't revert suspect. See bug for details. TBR=caseq@chromium.org Bug: 1036627 Change-Id: I8d0febf988d82e37d71b888b6d2c689b08a0271f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980872Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727199}
-
Samuel Huang authored
This CL fixes resource_ids entry sample_system_web_app_resources.grd, which was added in: https://chromium-review.googlesource.com/c/chromium/src/+/1956978 The new GRD (B) displaced an entry (C) that has META "join" for mutually exclusive entries (A1 and A2). This causes the following sub-graph change: A1 <-- C ===> A1 <-------- C A2 <---+ A2 <-- B <---+ This caused A1 to collide with B when GRIT update_resource_ids runs. The problem was mitigated in https://chromium-review.googlesource.com/c/chromium/src/+/1980336 by swapping A1 and A2. However, the proper fix (implemented by this CL) is to move META "join" from C to B, so the sub-graph becomes: A1 <-- B <--- C A2 <---+ This CL also reserves more ID space for media_app_bundle_resources.grd (A1) to accommodate potential growth. Change-Id: I891b643192ef49699397b8376e4fec03e66f2f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980802Reviewed-by:
-
Mia Glaese authored
Before: Bug resulted in tabswitcher toolbar sometimes hidden, when tapping <more tabs> Now: Toolbar is always visible in TABSWITCHER state. Added tests for SinglePane (other states already covered). Bug: 1036754 Change-Id: I1043efb703a1c6dbdc5e8c6a77bf935412f1f170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980809Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#727197}
-
Fabrice de Gans-Riberi authored
TBR=fdegans@chromium.org Bug: 1036626 Change-Id: If75d049da7c99f3994b9fef50a589fdd8ef48617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980890Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea94670809ad..09ff24ebc7be Created with: gclient setdep -r src-internal@09ff24ebc7be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: Ib1f64ece75d43c6ba4f3b46ecaca5e914edfae63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727195}
-
Min Qin authored
This reverts commit 6c4ec3c0. Reason for revert: The LOG has provided information of the crash Original change's description: > Split some download CHECK message into a LOG message > > CHECK messages are discarded for release build. > Using a separate LOG message should give us the error message > in logcat > > BUG=1029746 > > Change-Id: Ia333ee1261ca33c0d9538a5f132af92ae394e347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972233 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725688} TBR=qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029746 Change-Id: I158bc5b1ed2b337d8bd43d13379c2868702e5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980803Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727194}
-
minch authored
Remove the |clipping_window| that created as the parent of the back gesture affordance while dragging from splitview divider. Since it belongs to the container, which will not be deleted together with the back gesture affordance. This might make the clipping window above the splitview divider after SplitViewDivider::SetAlwaysOnTop be called to stack splitview divider at the bottom of the AlwaysOnTopContainer. Then the event will not be dispatched correctly to the splitview divider for resizing. - Use Layer::SetClipRect(*) to clip the affordance instead. - Remove useless parameter of CanStartGoingBack(*). - Reset |dragged_from_splitview_divider_| correctly. Bug: 1035126 Change-Id: I56af8fcb860f1aa842fe92883f0c122dcc7cedc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977967 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#727193}
-
Vlad Tsyrklevich authored
In https://crrev.com/c/1841187 I updated GWP-ASan such that support on Android is only compiled in when frame pointers are enabled (e.g. on AArch64); however, I forgot to update the stack trace collection method to use frame pointers in that case. Do so here. Bug: 973167 Change-Id: I75399d81fa1a695c3ef2c4e135316914a8c945db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979099 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#727192}
-
Fabrice de Gans-Riberi authored
The test is flaky on all platforms, not just Linux and Mac. TBR=fdegans@chromium.org Bug: 931657 Change-Id: Iffe8b086401cedbae7b39c8eb089c93a1e5a1da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980807Reviewed-by:
-
Fabrice de Gans-Riberi authored
These tests were re-enabled but still flakily time out. TBR=antrim@chromium.org,fdegans@chromium.org Bug: 997685 Change-Id: Ia9400275968449b689f96f3cdf28c4567df128fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980889Reviewed-by:
-
Fabrice de Gans-Riberi authored
The test is flaky on all platforms. TBR=rajendrant@chromium.org Bug: 1035057 Change-Id: I9c4735750b9724fbcdcbfebe0895ce8f58a62192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980804Reviewed-by:
-
Andrew Grieve authored
Bug: 917452 Change-Id: Idf6490f254381790daada249fdc99b47fd08f8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979248 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727188}
-
Fabrice de Gans-Riberi authored
This reverts commit 08e34ded. Reason for revert: linux-chromeos-chrome test failures, see https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/695 Original change's description: > ServiceWorker: Stop creating ServiceWorkerProviderHost for clients > > This CL stops creating ServiceWorkerProviderHost for service worker clients, and > tweaks ownership model of ServiceWorkerProviderHost and > ServiceWorkerContainerHost. > > Notable changes are as follows: > > - Before this change, ServiceWorkerProviderHost is created for both service > worker clients and service worker execution contexts. After this change, > it is created only for service worker execution contexts. > - Before this change, ServiceWorkerContainerHost is owned by > ServiceWorkerProviderHost. After this change, it is owned by > ServiceWorkerContextCore for service worker clients or > ServiceWorkerProviderHost for service worker execution contexts. > - For service worker clients, ServiceWorkerContainerHost is destroyed when > connection with blink::mojom::ServiceWorkerContainer is broken. > See ServiceWorkerContextCore::UnregisterContainerHostByClientID(). > - For service worker execution contexts, ServiceWorkerProviderHost and > ServiceWorkerContainerHost are created and owned by ServiceWorkerVersion. It > is reset when the corresponding service worker is stopped. See > ServiceWorkerVersion::StartWorkerInternal() and > ServiceWorkerVersion::OnStoppedInternal(). > - Before this change, ServiceWorkerContextCore manages 2 maps: > <provider_id, unique_ptr to ServiceWorkerProviderHost> and > <client_uuid, raw_ptr to ServiceWorkerContainerHost>. > After this change, the context core manages only 1 map: > <client_uuid, unique_ptr to ServiceWorkerContainerHost> > > Design doc: > https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing > > Bug: 931087 > Change-Id: Ia1f46421f0b0f524391a24b6e2c386c53eada0bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945953 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727145} TBR=falken@chromium.org,nhiroki@chromium.org Change-Id: Ie03422e819762f6370a010651b79de46e2f58876 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980870Reviewed-by:
-
Andrei Polushin authored
The placeholder's style and value gets manipulated by autofill when previewing suggestions. Due to the dynamic style changing of the placeholder, disabling scroll anchoring on a placeholder could prevent occasional scroll adjustment. Note that the scroll anchoring gets disabled on a placeholder within an input element, but not on the input element itself, which is still perfectly eligible to become a scroll anchor. Moreover, as the position of the input element is more stable, it could be a better choice for for a scroll anchor. BUG=1033423 TEST=run_web_tests.py fast/forms/text/input-appearance-scroll-position.html Change-Id: I981599b781f9c010e2a11d01f23f5db1a937cd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966153Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#727186}
-
Denis Kuznetsov authored
Initially reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1958136 Bug: 955194 Change-Id: I061c4d0fe4c54c9c1bfb58ca741ed1cce5bc475c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980177Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#727185}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5c3afec7f34..809437762d00 git log f5c3afec7f34..809437762d00 --date=short --first-parent --format='%ad %ae %s' 2019-12-23 syoussefi@chromium.org Refactor TType's constructors Created with: gclient setdep -r src/third_party/angle@809437762d00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I287672401cc63b8cd161594a91355080108a3a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727184}
-
Sylvain Defresne authored
The CL https://crrev.com/1977655 did not update some code that was only compiled on Official builder. This caused the following error as ios/chrome/test/app/chrome_test_util.h was no longer imported: ..../settings_egtest.mm:315:23: error: no member named 'SetWWANStateTo' in namespace 'chrome_test_util' chrome_test_util::SetWWANStateTo(YES); ~~~~~~~~~~~~~~~~~~^ Add a new method to SettingsAppInterface that wraps the call to chrome_test_util::SetWWANStateTo() thus allowing this code to be built for both EarlGrey and EarlGrey2. Bug: none Change-Id: Icf85d50a8a83603b68cb3eee99ef276a9f4dc042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980614 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727183}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/078af834..08c025c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id054c8e21463932b5d1971fb545967d7a211a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727182}
-
David Tseng authored
A locale as used by ICU and by ISO standards refers to the [language]-[region/country] specifier. This change makes it so the chrome.accessibilityPrivate binding formerly called getDisplayLanguage returns instead the full display name for locale. This means that we can disambiguate between languages from specific regions e.g. English from the United Kingdom (en-GB) vs English from The United States (en-US). Possible clients of the api are ChromeVox and tts. This is mostly a stopgap measure until a more standards based solution comes. Change-Id: I1d0eda2edb28dbb5ee23e035d58ee5e4e46b617a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955100 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727181}
-
Jordan Bayles authored
This patch adds additional dependencies on Open Screen to enable running unit tests inside of Chrome. This adds a new openscreen_unittests target and adds it to the builders. The following TODO is also added: TODO(crbug.com/1025244): Move Open Screen unit tests from fieldtrial to linux, mac bots once we have ensured the tests are stable. Change-Id: Ia36d5af5136cbf39d5c1582238a0e5a1f69b7ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880544 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727180}
-
Olivier Yiptong authored
This implements a WritableStream-based API. WritableStream methods are fully implemented. Operations are queued and the WritableFileStream can be piped to. tell() queuing tracked at https://crbug.com/1034210 Transferability tracked at https://crbug.com/1035673 More information in the design doc: https://bit.ly/36wfLFA BUG=955189 Change-Id: Ibd2e0a29c230a2fa25b6133fdbaac4f4ad4f1eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913586 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#727179}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6b46fff0feca080816deab9c59df7f7b84e6c01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980792Reviewed-by:
-
Javier Ernesto Flores Robles authored
On iOS 13.2 this test started to fail on EG1. EG evaluates the icon as not visible, even thought it is clearly in the view hierarchy. I wasn't able to fix it after spending some hours on it, removing the second part of the test, since the first part already test the purpose of it. Bug: 1019535 Change-Id: If7da63916e9fe9ea757a129358d101372e3fa032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975159Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#727177}
-
Andrew Grieve authored
* Changes all status messages from print() -> logging.info() * Adds a --quiet flag * Adds a few more lines to output that script was dropping: Tombstone written to:|Abort message:|Revision:|Build fingerprint: Bug: 917452 Change-Id: Id6f572aee3d6ebe9ceb5ce035b032862d24e2ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978904 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#727176}
-
Bret Sepulveda authored
This patch disables ExtensionsToolbarMenu when running the suite BrowserActionsBarBrowserTest, as it mostly relies on behavior specific to ToolbarActionsBar, and adds a new test to ensure coverage of equivalent behavior in ExtensionsToolbarContainer. Bug: 984654 Change-Id: Iac774cc9df2da163c9a066b01bed297fa21c197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980734 Auto-Submit: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 955194 Previously reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1953626 Change-Id: I4408d126089be1c32710d9f4e564a84ef2f3ec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980176Reviewed-by:
-
Michael Crouse authored
This change persists the FCP session statistics used by the prediction manager using a pref so that the first page load of the next session will have a non-zero value for the first page load of the session. This should improve the accuracy of the slow page prediction model in these cases. Bug: 1036026 Change-Id: I015c4ce5d654af614e947ae2352b4c75d6059067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977745Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#727173}
-
Denis Kuznetsov authored
Initially reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1955728 Bug: 955194, 893934 Change-Id: I453ffb21ce148912ad58fe8ceaa2c6e354872d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980210Reviewed-by:
-
Akihiro Ota authored
This change moves away from the [Search + n/p + l] key combination for list navigation, as I got some feedback from testers that the combinations were awkward to invoke. Instead, list navigation now uses [Search + j + l] for next list and [Search + Shift + j + l] for previous list. This is more consistent with how existing jump commands are structured. This change also removes commands to navigate by paragraph, as movement by paragraph is already covered by group navigation. Lastly, this change renames next_keymap.json to default_keymap.json. Change-Id: If42c94d44f319ef08318575982d8a297d4aa9da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925207Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727171}
-
