GitLab

Previous to this change, suffixing a "." to the URL from which a
dictionary was being suggested would allow servers to bypass the
check against a subdomain (e.g. evil.protected.good.com) setting a
dictionary to be used by a superdomain (.good.com).

BUG=389451
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/574283006

Cr-Commit-Position: refs/heads/master@{#296246}

Properly initialize |drop_remaining_touches_in_sequence_| after
its addition in https://codereview.chromium.org/586553002/.

TBR=rbyers@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/581313003

Cr-Commit-Position: refs/heads/master@{#296245}

Use the ChromeNetworkDelegate::OnProxyFallback() callback to keep track of number of times the data reduction proxies fall back because of network errors. Display a warning to users if there are network errors when connecting to the proxy and no successful requests through the proxy.

BUG=401244

Review URL: https://codereview.chromium.org/568893002

Cr-Commit-Position: refs/heads/master@{#296244}

mojo/aura doesn't use webkit/common/gpu any more.

third_party/wtl is only used on windows and is added in a conditional
if (is_win) section below.

Review URL: https://codereview.chromium.org/599603002

Cr-Commit-Position: refs/heads/master@{#296243}

BUG=none
TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/592423004

Cr-Commit-Position: refs/heads/master@{#296242}

This is a possible cause for a failure being seen in the field in the
associated bug; this change is a quick fix for that failure + UMA to
determine if the failure is real.

BUG=416639
R=mef@chromium.org
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/597633002

Cr-Commit-Position: refs/heads/master@{#296241}

We recently changed the chrome build so that nacl binaries of both 32 and 64
bit type are not built unless needed.
The sdk had assumed both arches are built as a side effect.

Building both arches in the sdk.

BUG=None
TEST=local
R=binji@chromium.org

Review URL: https://codereview.chromium.org/590523002

Cr-Commit-Position: refs/heads/master@{#296240}

Dismiss the bubble without updating changes to the node.

BUG=329459
R=asvitkine@chromium.org

TEST=
1. Launch chrome, press "Cmd+Shift+D" to "Show Bookmarks Bar"
2. Navigate to any webpage or new tab & press "Cmd+D" to open bookmark window and then press "Enter" key
3. On the same page, again press "Cmd+D" and change the page name in bookmark bubble window
4. Now press "Esc" key and observe
5. On pressing "Esc" key, bubble should get closed without making any changes to the bookmark

Review URL: https://codereview.chromium.org/592323002

Cr-Commit-Position: refs/heads/master@{#296239}

* Changed one to "permission denied" for screen capture.
* Changed one to "no hardware" for platform app.

BUG=416233

Review URL: https://codereview.chromium.org/585263002

Cr-Commit-Position: refs/heads/master@{#296238}

net: manual HSTS addition by request of the site.
Cr-Commit-Position: refs/heads/master@{#296237}

Current LTH Context Lost tests do not test for
impl-side painting, this updates the tests to use
ContentLayer or PictureLayer based on the settings.

Also, SetRequiresHighResToDraw when we recover from lost
context/ new output surface is used, to avoid checkerboards.

BUG=401492, 415155

Review URL: https://codereview.chromium.org/591473003

Cr-Commit-Position: refs/heads/master@{#296236}

Revert of DevTools: Made id unique across different remote browsers (patchset #2 id:20001 of https://codereview.chromium.org/560523004/)

Reason for revert:
Need to delete the contents of chrome_beta_pages; see memory leak at https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20(3)/builds/7887

Original issue's description:
> DevTools: Made id unique across different remote browsers
>
> BUG=338303
>
> Committed: https://crrev.com/7732fd3f76fc31a95f14199f898804e5d80e96e3
> Cr-Commit-Position: refs/heads/master@{#296188}

TBR=dgozman@chromium.org,pfeldman@chromium.org,vkuzkokov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338303

Review URL: https://codereview.chromium.org/598663002

Cr-Commit-Position: refs/heads/master@{#296235}

Crashes in net::AssertEventNotSignaled() are hard reproduce, but looks like this is the primary reason.
With crash on CHECK(..._callback_.is_null()) we could identify incorrect code.

BUG=415753

Review URL: https://codereview.chromium.org/580163003

Cr-Commit-Position: refs/heads/master@{#296234}

The gpu_unittests don't use any ANGLE or native graphics API
logic. Thus the isolate shouldn't include any dependency on things
it doesn't use or build. This should clear up runtime errors on the
bots involving gpu_unittests_run and libGLESv2.dll.

BUG=415981

Review URL: https://codereview.chromium.org/594203003

Cr-Commit-Position: refs/heads/master@{#296233}

Redirects field in TopSitesDatabase is encoded as a space-seprated list
of URLs. But data URLS like "data:text/plain,this text  has space" adds
extra space, so that when decoded, non-URLs like "text" and "has" would
trigger DCHECK in URL() downstream, and crash debug Chrome.

This CL validates redirects URLs when they are read. It is not foolproof
(e.g., "data:text/plan,hidden http://extra.url"), but now we can ponder
how to best fix the root cause, without keeping the crashing bug around.

BUG=358034

Review URL: https://codereview.chromium.org/562993002

Cr-Commit-Position: refs/heads/master@{#296232}

BUG=chromium:410129
TEST=remove linux-libc-dev:i386 then run ninja -> fails
TEST=install linux-libc-dev:i386 then run ninja -> works

Review URL: https://codereview.chromium.org/593573002

Cr-Commit-Position: refs/heads/master@{#296231}

The == operator is re-factored to:

  bool Equals(const AudioParameters& other) const;

This will also help avoid expressions like !(a == b), transforming them to !a.Equals(b) instead.

BUG=416506

Review URL: https://codereview.chromium.org/593653003

Cr-Commit-Position: refs/heads/master@{#296230}

BUG=416747

Review URL: https://codereview.chromium.org/592343002

Cr-Commit-Position: refs/heads/master@{#296229}

BUG=416831

Review URL: https://codereview.chromium.org/593963004

Cr-Commit-Position: refs/heads/master@{#296228}

GpuRasterWorkerPool holds an SkMultiPicture, the RasterBufferImpl is
created with a pointer to SkMultiPicture, and returns the
SkPictureRecorder's canvas when AquireSkCanvas is called.  When the
canvas is released, we get the surface canvas and pass it to the
multipicture along with the recorded picture.

When we're finished with all of the tiles, we draw the multipicture.

Updated Picture::Raster() to call canvas->drawPicture(), instead of
picture->draw().  This is required to prevent parsing the skia ops
twice when using the multipicturedraw, since picture->draw() always
parses the ops, whereas canvas->drawPicture() might parse the ops,
or it might simply place the whole picture on the canvas (as it will
for the recorder's canvas)

BUG=skia:2315

Review URL: https://codereview.chromium.org/595553002

Cr-Commit-Position: refs/heads/master@{#296227}

Make check for whether _NET_ACTIVE_WINDOW is supported take into account _NET_SUPPORTED and _NET_SUPPORTING_WM_CHECK

BUG=416490
TEST=Manual

Review URL: https://codereview.chromium.org/591213004

Cr-Commit-Position: refs/heads/master@{#296226}

It was added as a part of this patch
https://chromiumcodereview.appspot.com/24078024

Review URL: https://codereview.chromium.org/598643002

Cr-Commit-Position: refs/heads/master@{#296225}

DCHECK(!channels_[name]) adds NULL channel with |name| into the
map, which was breaking DCHECK in JingleSession destructor. Replaced
with another DCHECK that doesn't have side-effects. Added unittest
to catch this problem.
Also removed no-op line from ~JingleSession().

Review URL: https://codereview.chromium.org/594743002

Cr-Commit-Position: refs/heads/master@{#296224}

Add histogram "Network.Shill.DeviceRemovedEvent" for tracking device
removed events per device (technology) type.

Add histogram "Network.Shill.Cellular.DevicePresenceStatus",
"Network.Shill.Ethernet.DevicePresenceStatus",
"Network.Shill.Wifi.DevicePresenceStatus", and
"Network.Shill.Wimax.DevicePresenceStatus" for tracking the presence
of each network device in the system. The presence status is emitted once
every 3 minutes for each device type.

While here, update the value definitions for NetworkServiceError enum to
match the definitions used in Shill. Also correct the histogram name for
WiMax related histograms.

BUG=chromium:411512, chromium:411510, chromium:402202

Review URL: https://codereview.chromium.org/589233003

Cr-Commit-Position: refs/heads/master@{#296223}

This will hopefully clear up the failure on the Windows GPU bots.

BUG=416719

Review URL: https://codereview.chromium.org/595933002

Cr-Commit-Position: refs/heads/master@{#296222}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d39c191..cd523eb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/595983002

Cr-Commit-Position: refs/heads/master@{#296221}

BUG=none
TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/601483003

Cr-Commit-Position: refs/heads/master@{#296220}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f704a8d..562c87e

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/598613002

Cr-Commit-Position: refs/heads/master@{#296219}

Now that selection bounds are routed through the compositor, enable the feature
in Blink and hook the CompositorFrameMetadata-carried bounds into the existing
selection handle pipeline.  Also suppress the sending of
ViewHostMsg_SelectionBoundsChanged messages when the feature is enabled.

This patch depends directly on
https://codereview.chromium.org/454643002/.

BUG=135959

Review URL: https://codereview.chromium.org/359033002

Cr-Commit-Position: refs/heads/master@{#296218}

Based on keyboard layout for opened and closed streams, keep count of those containing keyboard mic. Activate mic for first such stream, inactivate when last one is closed.

BUG=345296

Review URL: https://codereview.chromium.org/599443003

Cr-Commit-Position: refs/heads/master@{#296217}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/557833006

Cr-Commit-Position: refs/heads/master@{#296216}

BUG=none
TBR=awong

Review URL: https://codereview.chromium.org/598453005

Cr-Commit-Position: refs/heads/master@{#296215}

For now, this allows only a very limited set.  Also describes the process we're
going to follow to allow more features.  The idea is that we're gradually going
to allow more features over time.

Also included is the source of a tiny appengine app running at
chromium-cpp.appspot.com that will show the contents of the document in this
CL once it's submitted.

BUG=360096
NOTRY=true
R=ben@chromium.org, inferno@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/589413003

Cr-Commit-Position: refs/heads/master@{#296214}

BUG=None
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/596493002

Cr-Commit-Position: refs/heads/master@{#296213}

BUG=414363
R=jln@chromium.org

Review URL: https://codereview.chromium.org/588143007

Cr-Commit-Position: refs/heads/master@{#296212}

net: another batch of HSTS updates.
Cr-Commit-Position: refs/heads/master@{#296211}

BUG=410946
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/594283002

Cr-Commit-Position: refs/heads/master@{#296210}

BUG=414233

Review URL: https://codereview.chromium.org/545973003

Cr-Commit-Position: refs/heads/master@{#296209}

Note: thie will also change the name of some of our
raster_worker_pool_* performance tests.

BUG=
R=vmpstr@chromium.org

Review URL: https://codereview.chromium.org/584393003

Cr-Commit-Position: refs/heads/master@{#296208}

Split the Perl script into 2 and shard the actual checking, so we can
run it in parallel. On bots, this reduces the time needed to complete
"check licenses" step from 3-4 mins to 40 seconds!

I'm planning to rewrite the scanner in Python soon, but I see that this
change can already help running trybots faster.

BUG=416496

Review URL: https://codereview.chromium.org/589143002

Cr-Commit-Position: refs/heads/master@{#296207}