GitLab

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I984e218d26ca92c1f531fbec9267a0de56ea0c57
Reviewed-on: https://chromium-review.googlesource.com/c/1352422Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612267}

Bug: chromedriver:1997
Change-Id: Ic231f01e68cc141877d501b5aee6926bc48ac1ee
Reviewed-on: https://chromium-review.googlesource.com/c/1355172Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612266}

Otherwise they're hitting an old Mac version and can't find xcode

Change-Id: Ie959d5fa958001822cace2160fb6c45516b8f602
Reviewed-on: https://chromium-review.googlesource.com/c/1355131Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612265}

This change replaces base::Unretained with a weak ptr everywhere where
there's possible a doubt that something could go wrong.

In particular, it uses weak ptrs for the try_done and all_done callbacks
of batch element checkers, since they can be called after the checker
has been deleted, even if it's unlikely.

This change also moves the script tracker in the Controller to make it
the last owned type to be deleted, as the script tracker will access
everything that exists in the controller, through actions. It's best to
delete it first.

Finally, this change adds null checks for ui_delegate_ in
android_ui_controller.cc, as the controller can delete itself separate
from any UI decisions. In this case, it sets ui_delegate_ to null.

Bug: 806868
Change-Id: Ie2e11ea54a1bdf80c4bc80d79a158a1658bc0d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1353942
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612264}

This CL adds a validity check for FaviconDriver::GetActiveURL().
GetActiveURL() depends on GetLastCommittedItem, and can be nil at various
times -- such as during session restore on startup.

Bug: 908240
Change-Id: I32bcf8e93b862fd87ae22bce6c59cbb9c4ba2f5d
Reviewed-on: https://chromium-review.googlesource.com/c/1350873Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612263}

I've made this mistake a couple of times :(
Without a check, it writes single-letter files to the depfile.

Change-Id: I0cf315573d2ed92b6b23fcf095e7396980d8d03d
Reviewed-on: https://chromium-review.googlesource.com/c/1355324Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612262}

Bug: 908139
Change-Id: I678dc64c18e78392493c2fc3acba974b3b6a28f8
Reviewed-on: https://chromium-review.googlesource.com/c/1349466Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612261}

Bug: 904877
Change-Id: I303d40cd19cc0dcfbdf3606bcaa357adb4793edd
Reviewed-on: https://chromium-review.googlesource.com/c/1347579
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612260}

This CL removes unused Context field from SigninTestUtil, fixes usages
and also replaces a couple of anonymous classes with lambdas.

Bug: 738533
Change-Id: Ia47262016a7aa7d5bc7a682a949518613760cf8a
Reviewed-on: https://chromium-review.googlesource.com/c/1352319Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612259}

BUG=angleproject:2909
BUG=angleproject:2901
BUG=angleproject:2913
BUG=angleproject:2918
BUG=angleproject:2708
BUG=angleproject:2987

TBR=kbr@chromium.org

Change-Id: I4ac05d075a420f5a011c5b7ea056477a25a4c95c
Reviewed-on: https://chromium-review.googlesource.com/c/1351602Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612258}

Bug: 806868
Change-Id: Iba3d0a38f1d215880b3479a5c1baa2d3d4d97b24
Reviewed-on: https://chromium-review.googlesource.com/c/1355164Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#612257}

This test was marked as flaky, but it has not failed
in a while so we should try and re-enable it.

BUG=874500

Change-Id: I7564d54a82af721a72fb4e1b2fb836415edd5c07
Reviewed-on: https://chromium-review.googlesource.com/c/1354620Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612256}

It's flaky.

Tbr: tkent@chromium.org
Bug: 910211
Change-Id: I66a8cf70781d906fd97fda1a22f9d5050b273613
Reviewed-on: https://chromium-review.googlesource.com/c/1355487Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612255}

Bug: 898109
Change-Id: If15a8ea69c7fd77e084b5766ea23afb6a4f1224e
Reviewed-on: https://chromium-review.googlesource.com/c/1354921
Commit-Queue: Uladzimir Miniailau <miniailau@google.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612254}

This is a reland of eacb6ed3

The flaky test has been disabled.

TBR=piman

Original change's description:
> Reland "Start gpu channel and compositor mojo pipe collection eagerly"
>
> This is a reland of 66794d00
>
> In this reland we revert changes to RenderThreadImpl and mus to make
> LayerTreeFrameSink creation asynchronous again.
>
> Then in RenderWidget we must remember that a warmup is underway, we do
> so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool
> and invalidate the WeakPtrFactory.
>
> If a request for a frame sink beats the warmup completing, we save
> the callback and run that instead of saving the frame sink on
> RenderWidget when the warmup completes.
>
> This ignores some weird weird corner cases like where warmup is
> aborted then we start another warmup or unfreeze the widget or something
> and will just make redundant requests. Since these are so rare they
> are not worth adding complexity for.
>
> Original change's description:
> > Start gpu channel and compositor mojo pipe collection eagerly
> >
> > When a RenderWidget is frozen, its compositor is stopped. However when
> > the main frame is being navigated, we want to start requesting mojo
> > pipes for the gpu and display compositor immediately so that it can
> > happen in parallel with the navigation loading.
> >
> > Previously, we just always did this when creating a RenderWidget, and
> > left them active when freezing the RenderWidget. After 678f025f
> > however, we don't, and this causes time-to-first-pixels regressions
> > on navigation.
> >
> > So we add a WarmupCompositor() method to RenderWidget, and call this
> > from RenderFrameImpl::CreateFrame() when it makes the provisional
> > frame, and the WebFrameWidget, since we expect to make use of the
> > main frame RenderWidget shortly.
> >
> > Then, if RenderFrameImpl::FrameDetached() occurs, due to the
> > navigation failing, we will AbortWarmupCompositor() to drop the
> > mojo pipes instead of holding onto them indefinitely.
> >
> > This recovers the loading regressions introduced, while also not
> > allocating mojo channels for frozen RenderWidgets indefinitely.
> >
> > In order to do this reasonably, we drop the "callback" from the
> > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
> > it always returns something immediately. This way RenderWidget
> > does not need to worry about having a task run to collect the
> > new frame sink, and ordering with tasks from the compositor to
> > collect it.
> >
> > R=piman@chromium.org
> >
> > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
> > Bug: 905191
> > Reviewed-on: https://chromium-review.googlesource.com/c/1341073
> > Commit-Queue: danakj <danakj@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610909}
>
> Bug: 905191
> Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60
> Reviewed-on: https://chromium-review.googlesource.com/c/1351938
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611838}

Bug: 905191
Change-Id: I0320c8604d50d5d83157c058c230b471c0898b26
Reviewed-on: https://chromium-review.googlesource.com/c/1355321Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612253}

This disables an "optimization" in Skia that appears to actually cause
a performance regression. After looking, that optimization is probably
unnecessary, and will probably be removed. To facilitate that, this CL
switches it off so we can rebaseline the affected layout tests.

Effectively reverts:
https://chromium-review.googlesource.com/c/chromium/src/+/1334230

Bug: chromium:908566
Change-Id: I634814dabaed09b7f93390f7f4d5fba499317185
Reviewed-on: https://chromium-review.googlesource.com/c/1351761Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612252}

This reverts commit eabc228b.

Reason for revert: May have caused a compile error that closed the tree: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/2197

Original change's description:
> Fix DownloadManagerTestCase flakiness.
> 
> On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be
> called when task is in NSURLSessionTaskStateCompleted state. This
> resulted in extra URLFetcherResponseWriter::Finish call (one from
> didReceiveData: and one from didCompleteWithError:).
> URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so
> the test was flaky.
> 
> This CL changes DownloadTaskImpl to only call
> URLFetcherResponseWriter::Finish from didCompleteWithError:.
> 
> Bug: 873204
> Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d
> Reviewed-on: https://chromium-review.googlesource.com/c/1354233
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612249}

TBR=sdefresne@chromium.org,eugenebut@chromium.org

Change-Id: I1f7e7620911c73ce1f497fb6ae7b09ed16a2547f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873204
Reviewed-on: https://chromium-review.googlesource.com/c/1355600Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612251}

v8::string::ExternalStringResourceBase -> StringResource{8,16} cast is undefined
behavior, as there is now ParkableStringResource{8,16} and
StringResource{8,16}.

Add a common ancestor to these two classes, and cast to it to avoid UB.

Bug: 909796
Change-Id: I94c65e03f283ca3c9fee344743e3f607686d2846
Reviewed-on: https://chromium-review.googlesource.com/c/1355046
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612250}

On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be
called when task is in NSURLSessionTaskStateCompleted state. This
resulted in extra URLFetcherResponseWriter::Finish call (one from
didReceiveData: and one from didCompleteWithError:).
URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so
the test was flaky.

This CL changes DownloadTaskImpl to only call
URLFetcherResponseWriter::Finish from didCompleteWithError:.

Bug: 873204
Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d
Reviewed-on: https://chromium-review.googlesource.com/c/1354233Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612249}

TBR=inferno@chromium.org

Change-Id: I2bc6f5c7e165bba9bb4a0e02ca6535128cb59766
Reviewed-on: https://chromium-review.googlesource.com/c/1355481Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612248}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73b3bde2659f..f38fffb7aa2f


Created with:
  gclient setdep -r src-internal@f38fffb7aa2f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:906654
TBR=mmoss@chromium.org

Change-Id: I781599f8fc3ee65a6151606e25b935421aaeb03f
Reviewed-on: https://chromium-review.googlesource.com/c/1355360Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612247}

Bug: None
Change-Id: I5c695df177545dcfa69e0cb00cbfcc5f117c7883
Reviewed-on: https://chromium-review.googlesource.com/c/1117618Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612246}

It is unused, except for two calls to is AlignedTo which can be inlined.

Change-Id: I4aa8b56548b2e217f3ed0eb03be5e7ae5a0d8c54
Reviewed-on: https://chromium-review.googlesource.com/c/1352987
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612245}

Bug: 909928
Change-Id: I0168a159049cd92db949d664f8e671f9ba0aee31
Reviewed-on: https://chromium-review.googlesource.com/c/1353956
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612244}

Seeing if that will address this sort of crash:

Not true that <null> is equal to <com.google.android.libraries.feed.host.storage.CommitResult@422779e0>
	at com.google.android.libraries.feed.testing.conformance.storage.ContentStorageConformanceTest.lambda$new$8$ContentStorageConformanceTest(ContentStorageConformanceTest.java:110)
	at com.google.android.libraries.feed.testing.conformance.storage.ContentStorageConformanceTest$$Lambda$8.accept(Unknown Source)
	at com.google.android.libraries.feed.common.testing.RequiredConsumer.accept(RequiredConsumer.java:32)
	at org.chromium.chrome.browser.feed.ConsumerSyncWrapper.blockAndWrappedAccept(ConsumerSyncWrapper.java:36)
	at org.chromium.chrome.browser.feed.ConsumerSyncWrapper.waitForConsumer(ConsumerSyncWrapper.java:56)
	at org.chromium.chrome.browser.feed.FeedContentStorageConformanceTest$ContentStorageWrapper.commit(FeedContentStorageConformanceTest.java:67)
	at com.google.android.libraries.feed.testing.conformance.storage.ContentStorageConformanceTest.storeAndDeleteAll(ContentStorageConformanceTest.java:258)

See:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Tablet%20Tester/20063

TBR=aluo@chromium.org,skym@chromium.org
BUG=

Change-Id: Ic4811ae94f2db270b7717ce04b7ff9a1fc18811e
Reviewed-on: https://chromium-review.googlesource.com/c/1355335Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612243}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/81cbcd45e1a2..97b903782cf5


git log 81cbcd45e1a2..97b903782cf5 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 dgarrett@google.com binhost_test: Ignore boards from branch builders.


Created with:
  gclient setdep -r src/third_party/chromite@97b903782cf5

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I10b01f0474a15ce38af67d499bc4380cfdaa4000
Reviewed-on: https://chromium-review.googlesource.com/c/1355359Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612242}

APIPermission::CreateAPIPermission() returns a newly-created
APIPermission object. Update it to return a unique_ptr rather than a
raw c-style pointer.

Bug: 907661
TBR=dominickn@chromium.org (mechanical change to chrome_apps_api_permissions.cc)

Change-Id: Ia27e4d7da11fce00e30f0fd1720f110e22d74346
Reviewed-on: https://chromium-review.googlesource.com/c/1347796
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612241}

As of refs/heads/master@{#608185}, it is no longer a DrawingDisplayItem.

Change-Id: If25c6d41fdc15dd3bf3b21360eb3306105a1c75e
Reviewed-on: https://chromium-review.googlesource.com/c/1355322
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612240}

Bug: 906654
Change-Id: I08817df22c5043ec92ae51b7deeae15ceb1877ee
Reviewed-on: https://chromium-review.googlesource.com/c/1354690Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#612239}

Currently upon collecting the inputs for the mutation on main thread, we
don't offset the current time by the start time which is incorrect.

Note:
The layout test animations/animationworklet/worklet-animation-currentTime.html
fails the release build because AnimationClock::currentTime is often
incorrectly ahead of rAF time so that when asking for the current time
in a rAF via getComputedStyle it returns obsolete result. This bug is
tracked by https://crbug.com/785940.

Bug: 905405
Change-Id: I0b7e293ae942e47b96eb8a7a2a8fefd94be66773
Reviewed-on: https://chromium-review.googlesource.com/c/1343558
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612238}

Using wpt-import in Chromium fc5105a0.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mstensho@chromium.org:
  external/wpt/css/css-multicol

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ife778af6d81007e56deb6b68e7b5d12b946551d0
Reviewed-on: https://chromium-review.googlesource.com/c/1351265
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612237}

Uses IdentityManager API instead of using the soon to be
private ProfileOAuth2TokenService and AccountTrackerService
APIs.

Bug: 908855
Change-Id: If533b43a698b2f2ea7c24ad43273b4ecba74091f
Reviewed-on: https://chromium-review.googlesource.com/c/1354447Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612236}

Migrated the SigninManager APIs to the identity APIs.

Bug: 890815
Change-Id: Id145953cdece6f58222bedaadbf3358ac3491665
Reviewed-on: https://chromium-review.googlesource.com/c/1354198
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612235}

Pass the account_id by const reference instead of requiring a
new std::string each time (since this is invoked in a loop, it
can cause lots of unnecessary allocations).

Bug: none
Change-Id: I5c2f2e53e12616ed5e518250fb965babbd9e68db
Reviewed-on: https://chromium-review.googlesource.com/c/1350910Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612234}

Removing the CTFont based construction when rolling to HarfBuzz' native
AAT lead us to falling back to attempting the mmap'ed access to the font
SkStreamAsset. However, the implementation for onOpenStream in
SkTypeface_Mac is highly inefficient and synthesizes a font from copying
all tables. Disable this type of instantiation on Mac and use the table
copy method instead.

This should address memory regression for the HarfBuzz AAT roll [1].

[1] https://chromium.googlesource.com/chromium/src/+/c67f53b0b70f33c47159d37f7e59bb44399b0d09

Bug: 908552
Change-Id: Ibf19ea6308f34fd4927e2b7fd59cdff20f3aad6d
Tbr: eae@chromium.org, behdad@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1355129Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612233}

Now that we're using Shadow DOM v1, we have the option to make the
shadow DOM unreachable by outside script by specifying a closed
encapsulation mode. Now GuestViews will behave more like other
elements defined by the browser which internally use shadow DOM.
This also prevents script from interfering with our internal elements
and producing unexpected behaviour.

Bug: 892886, 803274
Change-Id: I57b2513e3ff7290e286b3d8391e7d93bac2bc4e9
Reviewed-on: https://chromium-review.googlesource.com/c/1342768
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612232}

This change modifies the "Passwords" entry in the settings page to link
to the Google Password Manager if the necessary conditions are met.
Currently this includes users that are syncing their passwords without
a custom passphrase and for which the corresponding Google Password
Manager experiment is active.

Bug: 904821
Change-Id: If93ee671b1c1b9aee17467aa9382fe5e834ead55
Reviewed-on: https://chromium-review.googlesource.com/c/1350877
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612231}

TBR=dmazzoni@chromium.org
NOTRY=true

Change-Id: Ib20e44b272d84612d480bf3cccf4bbf8dec20fa1
Bug: 498881
Reviewed-on: https://chromium-review.googlesource.com/c/1355323
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612230}

This change allows the reprioritization of HttpProxyConnectJobs by
adding a SetPriority method to the underlying
HttpProxyClientSocketWrapper. Depending on the type of proxy client
socket being requested, the reprioritization is passed down to the
transport or SSL socket pool, or the SPDY or QUIC stream request.

Bug: 166689
Change-Id: I593632a48ee43141277e5c50f81fda57662f523c
Reviewed-on: https://chromium-review.googlesource.com/c/1343047
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612229}

The base perftests can take longer than the default 120 seconds to
execute -- especially on low end Android devices. Increase the timeout
on Android to 10 minutes.

Bug: 906686
Change-Id: Iacfe08e3cbd1d6e7ef756a1a8c1028655a5d3918

TBR=fdoray@chromium.org

Change-Id: Iacfe08e3cbd1d6e7ef756a1a8c1028655a5d3918
Reviewed-on: https://chromium-review.googlesource.com/c/1353922Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612228}