- 06 Jul, 2020 40 commits
-
-
Sylvain Defresne authored
Since gn now generates a project that wraps the invocation of ninja in a script converting relative paths to absolute paths, there is nothing blocking the use of the New Build System. Bug: 852522 Change-Id: I9b4ca343dc9434efb64a3866ca88d6b7c4065760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276281Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#785343}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593970160-b868b25d854d27d062f6932d7e877d2efc883cc1.profdata to chrome-win64-master-1594014961-b33fec47337d1f487e4dacf5d1b618dace5d3422.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id6594e1f30e6b02561ae7d27cad48ac6f2fd388d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785342}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/350be7ea7229..9c6d11136851 2020-07-06 ilkos@google.com Do not emit metadata if empty If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I22eb39294529fbcedec53e35b170eb3b7c08e623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785341}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2d79f1059a09f190ca8d3ebc4a7170fa2e6d5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785340}
-
Antonio Gomes authored
API clean up: the helper function isn't strictly needed anymore. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifbded32ccc9c06fd4bd1a5953acac236c89dd0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280223 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#785339}
-
arthursonzogni authored
On Oreo, disable the test: org.chromium.chrome.browser.signin.SigninFragmentTest#testClickingSettingsDoesNotSetFirstSetupComplete TBR=triploblastic@chromium.org Bug: 1102296 Change-Id: I8b4fb32d75488ab322e0108ad94b6e5c60be9452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282585Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785338}
-
Yuki Yamada authored
VectorBackedLinkedList::clear() is called during IntersectionObserver's custom weak processing. In current implementation, it clears everything and then add back the anchor node, but we can avoid the allocation using Vector::ShrinkCapacity(). Bug: 1100257 Change-Id: I2cb00b4a1ac32d1b61ac3d81c13323634fd31cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279296 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#785337}
-
Vikas Soni authored
1. Refactor SharedImageVideo backing to use SharedImageBackingAndroid and SharedImageRepresentationSkiaVkAndroid. 2. Move GetAhardwareBuffer and VkImage creation from Representation's BeginRead to ProduceSkia. Bug: 1091945 Change-Id: Ic08616f37754c864d0059c38b0a64f1f296b1ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281478 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785336}
-
arthursonzogni authored
The following tests were flaky on Marshmallow the last ~10 build: org.chromium.chrome.browser.payments ├──ExpandablePaymentHandlerChangePaymentMethodTest │ ├──testDetails │ ├──testDetailsBasicCard │ ├──testReject │ └──testThrow ├──ExpandablePaymentHandlerChangePaymentMethodTest │ └──testThrowBasicCard ├──ExpandablePaymentHandlerTest │ ├──testNavigateBackWithSystemBackButton │ ├──testSecureConnectionShowUi__CERT_AUTO │ ├──testSecureConnectionShowUi__CERT_COMMON_NAME_IS_DOMAIN │ └──testSecureConnectionShowUi__CERT_OK_BY_INTERMEDIATE ├──PaymentHandlerChangePaymentMethodTest │ ├──testDetails │ ├──testDetailsBasicCard │ ├──testNoEventHandlerBasicCard │ ├──testReject │ ├──testRejectBasicCard │ └──testThrow ├──PaymentHandlerEnableDelegationsTest │ ├──testPartialDelegationContactInfoNotSupported │ ├──testShippingAndContactInfoDelegation │ └──testShippingDelegation ├──PaymentRequestPaymentMethodIdentifierTest │ └──testAddMasterCard └──PaymentRequestRemoveBillingAddressTest └──testPayWithCard TBR=rouslan@chromium.org Bug: 1102320 Change-Id: I182afa734c763abb5d377c5fde8a2510e85b6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283162Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785335}
-
Vikas Soni authored
Add initial read fence to SharedImageRepresentationAndroidSkiaVk to wait on before reading vulkan image. Bug: 1091945 Change-Id: Ie35002f717e3719eeda5b3e0a50996077ad56151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281729Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785334}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/62032d45924e..d7d2f27b1bb5 2020-07-06 eshr@google.com [Adaptation] Adaptation holds restrictions 2020-07-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33c9ff52..a9cc4f47 (785166:785286) 2020-07-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a245a047..33c9ff52 (785063:785166) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I07a6f5e5b0a5bbb008310d746bac194f7b087a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785333}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4efe8f9cce59..6e0f4bee6932 2020-07-06 kimanh@chromium.org Fix stylelint-config-standard issues in 2020-07-06 petermarshall@chromium.org Disable eslint test name check 2020-07-06 tvanderlippe@chromium.org Temporarily fix TypeScript verification build 2020-07-06 petermarshall@chromium.org Disable flaky e2e tests that are blocking trybots 2020-07-06 yangguo@chromium.org Fix stylelint-config-standard issues in ui/treeoutline.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073406,chromium:108314,chromium:1083142,chromium:1102324 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b82fd63fc346a6565aa2a0a213823481b42672d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785332}
-
Yoshifumi Inoue authored
This patch changes |StartOfSentencePosition()| to return null-position for null-position to avoid to hit DcHECK for non-null position in |TextSegments::FindBoundaryBackward()|. Bug: 1100971 Change-Id: Iacaa706be454ef0334c1524703eaeddf56bfe1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280978 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785331}
-
Victor Hugo Vianna Silva authored
This CL updates TODOs pointing to closed b4p bugs to point to the newly filed follow-up bugs. Bug: None Change-Id: I86ba9fb58a83f7cba33c6d001e4cd00008d7f3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282582Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#785330}
-
arthursonzogni authored
Disabled tests: org.chromium.chrome.browser.keyboard_accessory... ...AutofillKeyboardAccessoryIntegrationTest #testSelectSuggestionHidesKeyboardAccessory__default ...ManualFillingIntegrationTest #testAccessoryHiddenAfterTappingAutoGenerationButton #testAccessorySheetHiddenWhenRefocusingField #testInfobarReopensOnPressingBack #testInfobarStaysHiddenWhenOpeningSheet #testKeyboardAccessoryDisappearsWithKeyboard #testKeyboardAccessoryHiddenUntilKeyboardShows #testMovesUpSnackbar #testPressingBackButtonHidesAccessorySheet #testSelectingNonPasswordInputDismissesAccessory ...ManualFillingUiCaptureTest #testCaptureKeyboardAccessoryV2WithPasswordsRTL #testCaptureKeyboardAccessoryWithPasswords #testCaptureKeyboardAccessoryWithPasswordsRTL ...sheet_tabs.PasswordAccessoryIntegrationTest #testPasswordSheetDisplaysProvidedItems TBR=fhorschig@chromium.org Bug: 1102302 Change-Id: I537c30a59dd01e9de9e0abb93e1e367cc58dfdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282802Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785329}
-
Maksim Ivanov authored
Move the ScopedAllowBlockingForTesting into the TestCertificateProviderExtension class where needed, so that its consumers in tests don't have to worry about it (and also so that the scoped IO allowance is used in the smallest possible scope). This is a pure refactoring CL. Bug: 1067683 Change-Id: I164bd520c3ea9191a58838412628336147029eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280000Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785328}
-
Maksim Ivanov authored
Create a test mixin ExtensionForceInstallMixin that helps in testing of force-installed extensions. In this initial version, only device policy faked via DevicePolicyCrosTestHelper is supported; the extension has to be already packed into a CRX file. The mixin hosts the CRX file in an embedded test server, generates and hosts an update manifest XML and configures the device policy. Also partially migrate signin_profile_extensions_policy_browsertest.cc to the new mixin. Bug: 1090941 Change-Id: Ic2b82dc15d0bfcf18e68d267d78312ce2311789f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277812Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785327}
-
Richard Knoll authored
This component will render a preview of the to-be-shared content. This might be an image or some text for example. For now it renders a placeholder image and a title text below it. This component will be used from the confirmation-page and discovery-page. Bug: 1099710 Change-Id: I6331fa196a54d02662cd621e3c28ef15cb65de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277734Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785326}
-
Javier Ernesto Flores Robles authored
Removes DCHECK as success = false is now expected sometimes. Logs the error to UMA to be analyzed in the future. Bug: 1091927, 1095620 Change-Id: I64e1a662d9f936d8891c3e31eb2e2c14573829c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275896 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#785325}
-
Eugene Zemtsov authored
Apparently macros don't support histograms with suffixes, and we need to use a function for roughness, otherwise it triggers a DCHECK when the name changes. Bug: 1101907 Change-Id: Ie64da90f3a1929653f5c1a6453b680aad4646990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280465Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#785324}
-
Philipp Hancke authored
BUG=chromium:894057 Change-Id: Ibeb60e70c08fccc45886476ed4f459cd09ae9b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282921Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#785323}
-
Stephan Hartmann authored
'-Wdelete-non-abstract-non-virtual-dtor' is a clang-only flag. Switch pragma diagnostic from GCC to clang. Bug: None Change-Id: Ic4488d9f95b351bcf74eeb4dba5bf568405948e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279981Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#785322}
-
Bartek Nowierski authored
The USE_PARTITION_ALLOC_AS_MALLOC check encompassed too code in AllocFromBucket, effectively disabling memset(kUninitializedByte). This CL makes it more precise so that it only disables cookies and nothing else. Rename Partition*FreePointerAdjust -> Partition*PointerAdjustSubtract while at it, for consistency with the rest of the functions. Bug: 998048 Change-Id: Id0615de9537caf5274ce38a344a07af68c98fd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279269 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785321}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7231d11baf46..4efe8f9cce59 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/watchExpressionsSidebarPane.css 2020-07-06 sawallner@chromium.org Fix stylelint-config-standard issues in ui/viewContainers.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9ce287f13db240fc2db515a3f231d06756094786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785320}
-
Stepan Khapugin authored
Cleans up a few more now-unused methods in guts protocols. Bug: 1045660 Change-Id: I244ef31eb8ea7ef413f64328c3515a0dac7de9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279884Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785319}
-
Carlos Caballero authored
Defer cache lookup to until sandbox checks have been performed. Bug: 1051491 Change-Id: I8f31e8301b7270050bf324c04bcd853f4638670e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277882 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785318}
-
Sigurd Schneider authored
The new unittest is here: https://crrev.com/c/2282504 Bug: chromium:1060613 Change-Id: I258aa87e3637322eb4aa7b7c2a5d4b2374142a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282923Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#785317}
-
Maggie Cai authored
This CL creates an app service file tasks to allow the files app to query sharing task from app service intent handling backend. This is for testing the backend and it is behind a flag. It might need to be modified after link up with unified sharesheet UI. BUG=1092784 Change-Id: I4ba54f7b2ee9e9ae3fd89184b808c1040a01c288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279411 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#785316}
-
Ella Ge authored
Bug: 1007635 Change-Id: I49ae4220e8b139025e14c63500faff75db75db5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276480Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#785315}
-
Andy Paicu authored
Bug: 1094356 Change-Id: Ie49d2e0d59e851b3b9792370cff2dfeeacf880fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282743Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785314}
-
Swapnil authored
UploadExtensionInstallReport and CancelExtensionInstallReport methods are used in event based reporting for policy based extensions in CloudPolicyClient. This CL adds unit tests for these methods. Bug: 1101714 Change-Id: Id0322508fc1e67456658a982172e4171d45c2fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279210Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#785313}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/59ccb1f6de17..80f927d76321 2020-07-06 jiawei.shao@intel.com Implement buffer lazy initialization before writeBuffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4185f072901443894d58cdd514c4ebacbed3c501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785312}
-
Swapnil authored
ExtensionInstallEventLogManager class ties together collection, storage and upload of extension logs. This is used for event based reporting for policy based extensions. Add unit tests for this class. This CL add unit tests for ExtensionInstallEventLogManager. Bug: 1101709 Change-Id: Iff4ef1a5af9f979336fba5073426cb6313912f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277817Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#785311}
-
arthursonzogni authored
This test fails on Android N. It has been added very recently by: https://chromium-review.googlesource.com/c/chromium/src/+/2265236 TBR=wychen@chromium.org,yuezhanggg@chromium.org Bug: 1102288,1099037 Change-Id: Ie98a7e1771f11934a132e8b7fd9ed7111bde8ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282561Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785310}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib6ad08130aa92c8b80c08b475cb94ac3d58fc881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785309}
-
Hiroki Nakagawa authored
Callback: Convert base::Callback to base::OnceCallback for chromeos::file_system_provider::AbortCallback Bug: 1007635 Change-Id: I04d535ff9ce08c122f9ee0643d0f57e3b49ae639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281799 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#785308}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61570250a193..7231d11baf46 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in timeline/timelineStatusDialog.css 2020-07-06 bmeurer@chromium.org [wasm-debugging] Drop experimental out-of-progress language plugin 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in ui/toolbar.css 2020-07-06 kimanh@chromium.org Fix stylelint-config-standard issues in network/networkTimingTable.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1083146 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf7a21d92732677989f8aeca980d88e5f85ce56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785307}
-
Rob Buis authored
Properly initialize StretchyOperatorShaper::Metrics in the struct, instead of having to initialize the struct at point of use. This comes out of a discussion of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2270448 Bug: 6606 Change-Id: I1f00753ea25ce8de18e853729cb90e72a7e04e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275954Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#785306}
-
Quang Minh Tuan Nguyen authored
I tried to convert it to OnceCallback, but had problem with circular_deque https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8875545102440823552/+/steps/compile__with_patch_/0/logs/raw_io.output_failure_summary_/0 I guess we should go with RepeatingCallback here Bug: 1007685 Change-Id: I16a77c2f9a19f982249220adad1a9fb2dbbf7507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282143Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#785305}
-
My Nguyen authored
Both emoji and personal info suggestions require +2 elevation Current View: http://screen/rnfGzOx97Nw Emoji Specs: http://screen/qgE7xnf2LhN Personal Info Specs: http://screen/nbDgNJ3gdRZ Bug: 1099454 Change-Id: I6e7e8ed4ef0f91ed0ec1413430f9f5059bc918ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281768 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#785304}
-