- 12 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/25abeb83954a..eede75962a10 git log 25abeb83954a..eede75962a10 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 oysteine@google.com Merge "Add ProfiledFrameSymbols to the chrome subset of TracePacket" Created with: gclient setdep -r src/third_party/perfetto@eede75962a10 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia1f1a669cfd44f083142be7c854ecb3fad03f717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677083}
-
Mohamed Heikal authored
Supersize the tool that is used by the binary size trybot is now able to deobfuscate the resource paths for APKs and AABs that enable resource path shortening. This should allow the binary size trybot to blame resource size diffs on the correct directories. Bug: 753402 Change-Id: I396fd36b284a184bb5b07abf67d6b342920f0bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693172 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#677082}
-
Yuwei Huang authored
The old HostChangeNotificationListener listens to host deletion events from XMPP, which will go away with the gTalk turn down. New hosts rely on FtlHostChangeNotificationListener for getting host deletion events through FTL. This CL deletes the old HostChangeNotificationListener. Bug: 983282 Change-Id: I0d9acb261d3702391f8345a228853d9c4e1af5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700472 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#677081}
-
Raymond Toy authored
If the number of distinct elements in the input array does not match the number of elements in the expected set, an error was thrown trying to read a property from undefined. Instead, check that the lengths match and if they don't fail the test with an appropriate message. Also remove the-convolvernode-interface/active-processing.https.html that should have been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1653924 but wasn't. Bug: 974022, 978372 Test: audit-failures.html Change-Id: Ifa2da978f3c0f67dc444c69ceddb862675908b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659492 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#677080}
-
Raymond Toy authored
Move enum AudioParamType to AudioParamHandler class and update uses appropriately. Remove the unused AudioParam::GetParamName Bug: 982908 Change-Id: I2a16dad7c958082260df7434c02d564d428d665c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700261Reviewed-by:
-
Raymond Toy authored
Replace the offline audio context with a realtime context and an AudioWorklet. Previously, when the source stopped, the channel count change would sometimes get delayed until rendering is done, which is too late for the test. I believe this is because the main thread was previously too busy to process the messages to disable outputs and change the channel count. Using a realtime context makes the main thread less busy because the messages aren't posted as fast as possible, allowing time for them to be handled. I think this is still flaky, but much less so than before. Bug: 974258 Test: the-channelmergernode-interface/active-processing.https.html Change-Id: Id584ebfa5f54ad6870819f5242aafed5f4fc80d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663186Reviewed-by:
-
Nick Harper authored
Bug: 903642, 975114 Change-Id: Id7112697acbb6eff9fe73b0801c2c1063e111267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686691Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#677077}
-
Sophie Chang authored
Bug: 969558 Change-Id: I283b2a04899baba36cf6270bdee12ccba5e7de7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695885Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#677076}
-
Jonah Ryan-Davis authored
The corner case where CopyTexture is called on the same source/target image on different levels is now fixed in ANGLE. Bug: angleproject:2994 Change-Id: I256f1c0978b7635bb58821eb45749b5886b081f8 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700264 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#677075}
-
Erik Chen authored
Previously, base::PostDelayedTask was being called without any explicit task traits. ProcessMemoryMetricsEmitter must be called on the Browser UI thread. Bug: 982646 Change-Id: I1ef67ff4dbbb952a7004622399410e5f9636f2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697433Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#677074}
-
arthursonzogni authored
This fixes the tests: * VrBrowserNativeUiTest#testSecurityTokenOnHttp * VrBrowserNativeUiTest#testSecurityTokenOnHttps * VrBrowserNativeUiTest#testSecurityTokenOnHttpsBadCertificate See https://00e9e64bac97828476a63763ecdce7ef9fbd108cf315c02025-apidata.googleusercontent.com/download/storage/v1/b/chromium-result-details/o/5d2e46349bcedf8908ac942137d3e95a16c0cc06?qk=AD5uMEsZKJaSX55rhfhtfQGjUqSxHo8psOGyv31xUqi96tpf0SWU3yJdbGmozt8kzQ0ECgRK387HluYWOwqUKmksg_fejIr_trH5PLrRjRdRzOAKr9T6iOOGCUsChTtnC-ShtebDtv7fK0ttP8533Tgdfz7NkKHQ0HQEdlECziJUxzA9cu_P7XBz5BjSBD4ISpKMDtct5z69sIe2OORB5jy5biSOH8b8ERvsuPt_7_YABJG5_W9MDEeQTLsXnyZqTptTClt-MZB3ejwuwlZYdplS6KNEsRgBecxFzxqcGzZ_gqtOdl_zLQv7zfhcengUldISPjFgdOzE73js0XS8XU2tX9svzFgz8q8bKIza_AxlzCMPVtl-Dvk_EfkYDt5dIKoyxEJpDjK6jx2e6jTkhkHii11Kka0P7L9-KjKk7AjjSRciXmd-s6IoAojUK1XuNwwCO7DkUWZCoO7rVlM3861Fp6OeXbq-LM7ubVn3zOjbuP3MlDjBz6KXxxFPb3dodIIOW77tHtFi72zlwDDVVMfNi8pkudEw5CG667ilrcx1IMqqKFKGzYsk3yws4hKjrTSoSX12nMieKt_g0M2adCvNyVLqPWNFpowQF0N6iodJ_o6348aVIl9j4qkJv02YCC4OLMeLTEgTai0OtGlzutkgnmbwp95K_3vmKG4CTMrK8iqmC7vCe_KNSBQY0zvQxTb6BcRYWiI_L_SqNqN7G7hmGQnTHWqH0nmIo0eu1RkIV6qMc0fAD35GHfRHR_ZH74jUmYDP16W0DwHrkLLTfmdEyRiH9rxKoDfPTKSjVbldFzfrdng_781f4NakYE_y06OhysZQlf5v Bug: 983569 Change-Id: I9dcc7938ab23e612767277b2ef3902e1246e08d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700047 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#677073}
-
Xida Chen authored
Our current include order should be: c system header, c++ system header, others If it is a .cc file, then its corresponding .h file goes the first. This CL corrects this under for the files under renderer/platform/animation TBR=smcgruer@chromium.org Bug: None Change-Id: Ie73c69ec5770b8d1eb62b39d548cd5498425ddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699511 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#677072}
-
Vlad Tsyrklevich authored
When GWP-ASan is used with 32-bit address spaces, false positives are much more common because a random bad dereference is much more likely to point into the GWP-ASan region. After several months, the Windows/x86 version of GWP-ASan has not found bugs we couldn't find with the 64-bit only version so disable it to reduce false positives. Bug: 969146 Change-Id: I9beaa01b428c2fa6495c10f634cf9e01c3d170d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696208 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#677071}
-
Mark Pearson authored
This reverts commit 063cdeef. Reason for revert: Likely causes of deterministic failures on linux-chromeos-dbg bot since it was submitted. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13333 Failing viz_browser_tests item CrSettingsPeoplePageKerberosAccountsTest.All Failure looks like: [ RUN ] CrSettingsPeoplePageKerberosAccountsTest.All [1:1:0711/125719.782650:INFO:hugepage_text.cc(96)] Mlocking text pages failed: Cannot allocate memory (12) [12029:12029:0711/125720.228069:INFO:content_main_runner_impl.cc(981)] Chrome is running in full browser mode. [12029:12029:0711/125721.406902:INFO:remote_commands_service.cc(38)] Fetching remote commands. [12029:12029:0711/125721.407222:WARNING:remote_commands_service.cc(40)] Client is not registered. [12029:12029:0711/125721.408386:INFO:remote_commands_invalidator.cc(34)] Initialize RemoteCommandsInvalidator. [12029:12029:0711/125721.408549:INFO:remote_commands_invalidator.cc(59)] Starting RemoteCommandsInvalidator. [12029:12029:0711/125721.408652:INFO:remote_commands_invalidator.cc(130)] RemoteCommandsInvalidator ReloadPolicyData. [12029:12029:0711/125721.408726:INFO:remote_commands_invalidator.cc(172)] Unregister RemoteCommandsInvalidator. [12029:12029:0711/125721.821717:WARNING:wallpaper_controller_client.cc(328)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [12029:12029:0711/125722.620525:ERROR:gcm_driver_desktop.cc(1094)] Unable to get the InstanceID data: cannot start the GCM Client [12140:12201:0711/125722.698217:WARNING:simple_synchronous_entry.cc(1389)] Could not open platform files for entry. [1:1:0711/125722.911602:ERROR:utility_service_factory.cc(200)] Ignoring request to start unknown service: cups_proxy [12029:12029:0711/125723.200521:ERROR:account_manager_migrator.cc(249)] Could not find a refresh token for the Device Account. [12029:12029:0711/125726.095357:WARNING:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [12029:12029:0711/125729.770017:INFO:CONSOLE(1195)] "Running TestCase CrSettingsPeoplePageKerberosAccountsTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1195) [12029:12029:0711/125731.368557:WARNING:CONSOLE(11)] "Could not find style data in module named action-link", source: chrome://resources/polymer/v1_0/polymer/polymer-extracted.js (11) [12029:12029:0711/125735.550983:ERROR:CONSOLE(155)] "Uncaught (in promise) TypeError: this.$$(...).show is not a function", source: chrome://settings/people_page/kerberos_accounts.js (155) [12029:12029:0711/125735.763001:ERROR:CONSOLE(49)] "Mocha test failed: KerberosAccountsTests RemoveAccountShowsToast AssertionError: expected undefined to be false at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31) at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:788:15) at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/people_page_kerberos_accounts_test.js:257:7) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) [12029:12029:0711/125749.460448:ERROR:web_ui_test_handler.cc(72)] Test Errors: 1/37 tests had failed assertions. [12029:12029:0711/125749.460716:ERROR:web_ui_browser_test.cc(542)] CONDITION FAILURE: encountered javascript console error(s): [12029:12029:0711/125749.460773:ERROR:web_ui_browser_test.cc(544)] JS ERROR: '[12029:12029:0711/125735.550983:ERROR:CONSOLE(155)] "Uncaught (in promise) TypeError: this.$$(...).show is not a function", source: chrome://settings/people_page/kerberos_accounts.js (155) '... For more details, see http://crbug.com/983568 Original change's description: > Restrict CertificateManagementAllowed policy > > This cl restricts CertificateManagementAllowed policy to client > certificates only and renames it to ClientCertificateManagementAllowed. > > This is the first step towards creating a separate > policy that manages user permissions over CA certificates in the Chrome > certificate manager UI. > > Bug:958455 > Test:- manually tested that importing and deleting CA certificates > works regardless of policy settings > - manually tested that importing and deleting client certificates > works according to policy > > Change-Id: Id0aaf44f3bc4e3a22e99904234be3fd5343dce78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690862 > Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676384} TBR=stevenjb@chromium.org,rsleevi@chromium.org,pmarko@chromium.org,acostinas@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958455 Change-Id: Iffc9c2a3b983d2032a45ccfa80efc6be88712cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699200Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#677070}
-
Ben Kelly authored
Bug: 957175 Change-Id: I2b4fee145edc74bd9bba6afd2b3e66a0bd55b77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698127Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#677069}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24192c267a40..a7e3bcebaedc git log 24192c267a40..a7e3bcebaedc --date=short --no-merges --format='%ad %ae %s' 2019-07-12 mbonadei@webrtc.org Reland "Make new pacer padding more like old one" 2019-07-12 mbonadei@webrtc.org Reland "Pass RtpRtcp::Configuration to RtcpReceiver ctor and initialize ssrcs" 2019-07-12 mbonadei@webrtc.org Reland "Optimize PacketRouter/RTPSender interactions." 2019-07-12 mbonadei@webrtc.org Reland "Add ability to set RTCP sender ssrc at construction time" Created with: gclient setdep -r src/third_party/webrtc@a7e3bcebaedc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2db40fd22705a9266b9099891e5c4d35b98a15ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700422Reviewed-by:
-
Brian Sheedy authored
Makes the Skia Gold version of the GPU pixel tests non-experimental, so any unsuppressed failures will show up as builder-level failures since the tests have been quite stable. Documentation on Gold and how to triage any new images the tests produce can be found at https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gpu/gpu_pixel_testing_with_gold.md Bug: 850107 Change-Id: Ic7187f049f98bad561d8591e04354359fe64e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698644Reviewed-by:
-
Kevin Bailey authored
Class OfflinePageModel:SavePageParams was using an unset bool. It's now initialized in the constructor. Change-Id: Ie810decf6eb27c5ca0be020b52d5df3f4c43a7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699090Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#677066}
-
Miguel Casas authored
This CL extends two LOG(ERROR)s I was hitting on crrev.com/c/1619832: - one because a YUV420_BIPLANAR had an odd dimension - the other because I wanted to track a Mailbox use-after-release. No new functionality intended, only moarrrr debugging info. Change-Id: Ibe12e3e4850bbfc7bad5841f3aa6eea02e412dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699394 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#677065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a985c42ae65..851f501318ec Created with: gclient setdep -r src-internal@851f501318ec The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I700336691e6423f19aaae4d0c68c7d52d2d3b4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700421Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677064}
-
Jun Mukai authored
The current test case examines the smoothness for the transition of half-visible search to fullscreen search. The new one does the test of fullscreen app-list to fullscreen search. I think this would verify the animation smoothness within the app-list itself very clearly. With r676512, the performance numbers (on nocturne) are: LauncherAnimations/LauncherAnimationsFullscreenSearchTest.SearchAfterFullscreen/0: Apps.AppListHide.InputLatency: 64, 64, 64, 64, 64 Apps.StateTransition.AnimationSmoothness.Close.ClamshellMode: 93, 86, 86, 86, 86 Apps.StateTransition.AnimationSmoothness.FullscreenSearch.ClamshellMode: 39, 33, 33, 33, 26 LauncherAnimations/LauncherAnimationsFullscreenSearchTest.SearchAfterFullscreen/1: Apps.AppListHide.InputLatency: 63, 55, 64, 63, 64 Apps.StateTransition.AnimationSmoothness.Close.ClamshellMode: 93, 93, 93, 100, 93 Apps.StateTransition.AnimationSmoothness.FullscreenSearch.ClamshellMode: 66, 59, 73, 73, 66 Bug: 961467 Test: runs on nocturne Change-Id: I0246c63db1a327b55a1ee8f0540609613a9c0a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699211Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#677063}
-
Yuwei Huang authored
GTURN and Jingle-based ICE config fetching is not available in FTL world, so this CL removes them and does a few other cleanups. Bug: 983282 Change-Id: I2dba40fabfacd8a214d42c67f3f260267a4bca51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699521 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
Alex Cooper authored
This change implements the input related portions of the webxr-test-api and updates internal tests to use those methods/constants/inits. Most of the logic is ported from xr-internal-device-mocking.js and just converted from attributes to a pair of set/clear properties. No tests were actually using the getters, so those were just deleted. Because the webxr-test-api does not yet support gamepads, all of that logic was left in the internal mock. It also forces/fixes a potential bug where a device with no inputs may opt to set the "InputStates" value of the mojom to null rather than an empty array. (The device code typically sets this to an empty array) Rather than risk losing/confusing the diff to the updated tests, future work will move these tests to the external WPTs Bug: 979318 Change-Id: I846831a561217abd66ab841326a5e5472f38afeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699505Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#677061}
-
Lei Zhang authored
Nobody is looking at these stats. Change-Id: Ib16fddbd333d7a93e66bc2560f5abffcbae6b46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699249Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#677060}
-
Gayane Petrosyan authored
Remove titles for both colors and default tiles. This change makes crbug.com/976415 obsolete. Bug: 960982 Change-Id: I5138085065566bfad04e84b22ea2337be2e211c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693167 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#677059}
-
Etienne Pierre-doray authored
This CL Creates a new derived JobTaskSource that tracks the number of concurrent worker. It's a precursor of https://chromium-review.googlesource.com/c/chromium/src/+/1582427 which integrates JobTaskSource in ThreadGroups. Bug: 839091 Change-Id: Ie407823bdd6d4c84fd8b3db7d6d6a58a33846045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693182 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Ian Wells authored
This flag will be used to control whether to show notifications for Feed articles. Also, increase interest-feed-content-suggestions expiry milestone to 78. Bug: 982483 Change-Id: I759721cd0e005612ecc40352f43e5608287591ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693816 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#677057}
-
Chris Blume authored
A series of new tests began failing. Some of these consistent failures have already been added to the test filter. This adds the remaining test to get the bot green again. Since these failures are consistent instead of flaky we'll want to investigate the cause. TBR=jonross@chromium.org Bug: 983204 Change-Id: Ib6f754a7f12dd92a8674b83463e9c9bd8b27d333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700257Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#677056}
-
Dave Tapuska authored
To add a check in the bindings code to check that the agent is the same we need to support WebPagePopups to get the same security origin/agent in test framework. BUG=970360 Change-Id: Ie55eb5cb1b91b72ab0ed2b63ae60be616b4d2b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669750 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#677055}
-
ssid authored
BUG=967008 Change-Id: Ida55fce147ad25f302ec75d783c934f1094df4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699409Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#677054}
-
dpapad authored
Bug: 839707 Change-Id: I14ab2004a6b46153d5299c090fbaf16b119e9c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700364 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#677053}
-
Geoff Lang authored
These extensions were being exposed as requestable but failing to initialize because they weren't requested. BUG=angleproject:3675 BUG=983142 Change-Id: I7b8be3c49860bac5c62cb5df6cfb77f1ecf120b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698643 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#677052}
-
Ted Meyer authored
A few of the helper classes for WebMediaPlayerImpl have had some new methods added to support this. Change-Id: I362a8142338ee79b0c142fa1c7c6bb3e7acabf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680834Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#677051}
-
Yann Dago authored
Bug: 980124 Change-Id: I7d290370e6cfb8f336dab7c39753a5c369c16eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690706 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#677050}
-
Vlad Tsyrklevich authored
Previously I had enabled GWP-ASan by default because it looked like it was ready to launch with the default parameters. I'm having to tweak the parameters to address some small perf regressions, so disable it by default for now until it's actually ready to launch to 100% with the given default parameters. Change-Id: Ie1a723a70293da2fa4fa05d21025a09ea80230d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699512 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
-
Geoff Lang authored
ANGLE handles these workarounds internally and some of them generate GL errors when running on top of an ES driver. BUG=angleproject:3672 BUG=angleproject:3671 Change-Id: Ic301f57f882247db1bbe8991647b12b9bb0b4f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697530Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#677048}
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit I have also changed BindAutofillDriver() in ContentPasswordManagerDriver to BindPasswordManagerDriver(), since it isn't binding auto fill driver but password manager driver. Bug: 955171 Change-Id: I0817d7d54eb1fc46be4d16a2a611f98604ddef58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693890 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#677047}
-
Lukasz Anforowicz authored
Changes in this CL ================== This CL: 1. Updates FrameNavigationEntry::UpdateEntry and FrameNavigationEntry's constructor so that they both take |const base::Optional<url::Origin>& initiator_origin| which gets stored in a new FrameNavigationEntry::initiator_origin_ field. 2. Updates callers of FNE::UpdateEntry and FNE's constructor to provide/propagate the initiator as needed. This includes adding an |initiator_origin| parameter to - NavigationEntryImpl's constructor - NavigationEntryImpl::AddOrUpdateFrameEntry - NavigationController::CreateNavigationEntry (the list above is not necessarily exhaustive/complete) 3. Uses the new |FrameNavigationEntry::initiator_origin()| from NavigationEntryImpl::ConstructCommonNavigationParams (which used to always provide |base::nullopt| initiator for history navigations - always treating them as browser-initiated, rather than replaying the original initiator). The changes above makes sure that the right Sec-Fetch-Site http request header is "replayed" during history navigations. The CL adds browser tests and WPT tests to cover the new, desired behavior. Follow-up changes ================= This CL does not: - Use |FrameNavigationEntry::initiator_origin()| in GetOriginForURLLoaderFactory in render_frame_host_impl.cc (this will be done in a follow-up CL at https://crrev.com/c/1672176) - Handle persisting |FrameNavigationEntry::initiator_origin()| for session restore (this is tracked in a separate https://crbug.com/976055). Bug: 946503 Change-Id: I4f92614873a5ec8d4b52d3ae22031c7089d87ed5 Tbr: skuhne@chromium.org for //components/sessions Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662738 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#677046}
-
Marijn Kruisselbrink authored
Getting more access via permission requests or file pickers is restricted to first party contexts. This adds browser side checks to make sure this is the case. Bug: 980960 Change-Id: I026a6047e0e5587841f275a14558908ab1cf33fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700284 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#677045}
-
Ahmed Mehfooz authored
We do not currently flip the canvas for focus rings when RTL is enabled. This can cause certain focus rings to be drawn incorrectly for their corresponding buttons. Bug: 960284 Change-Id: I1144cee667c626e4978aaff9bd3cd8901494dbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696443Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#677044}
-
