- 31 Aug, 2020 40 commits
-
-
Yuwei Huang authored
gaia::GaiaOAuthClient doesn't call request_->SetTimeoutDuration() when sending out the request, which might be the cause of b/166817002 -- if CallWithToken never calls the callback, then all pending authenticated requests will be blocked. This CL adds a OneShotTimer to OAuthTokenGetterImpl so that it rejects the callback if it times out. Bug: 1123199 Change-Id: Ic05de360983b2540489edbf33aa0eee2f0c5c87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382488 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#803239}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4191c5c973ed..b6522350f5c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC connily@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073476 Tbr: connily@google.com,gab@google.com Change-Id: Iace3c9118f20cc4e3e77a63ab6f78f0faa92d19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385692Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803238}
-
Ali Juma authored
This records whether Safe Browsing is enabled when the Safe Browsing service is initialized. This metric is already recorded on non-iOS. Bug: 1123640 Change-Id: I1ba0157524be7bb5206ae0a8eb6066dfe965b55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385796Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#803237}
-
dpapad authored
Fixed: 1123224 Change-Id: Ifa40c81d5514ad903e6065f95109a43caa0a2dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384911Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#803236}
-
Michael Crouse authored
Queries to the optimization guide are based only on the mainframe host so if a hint for a mainframe is provided, it is applied to all relevant subframes. To prevent LiteVideos on certain hosts that are 1) frequently embedded subframes and 2) do not provide any benefit from LiteVideos, a host blocklist is added. Any queries to the decider with a host on this list will explicitedly be prevented. The set of hosts are controlled via Finch. Bug: 1117064 Change-Id: I7debd153c2578efd5d4638cfcaed809d3283adef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385975 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#803235}
-
James Cook authored
We need a version-skew stable mojo transport for UI images. The skia bitmap serializers have been stable for some time, so tidy them up and mark them as [Stable]. * Transport color spaces explicitly as a 7-float transfer function and 9-float transform matrix to XYZ D50. SkColorSpace::serialize() depends on the layout of internal Skia structs that might change. * Rename ColorType INDEX_8 as DEPRECATED, since it doesn't exist any more in skia. * Don't try to deserialize images with unreasonably large height/width (addresses a TODO) * CHECK-fail before sending a bitmap with negative height/width, rather than sending an empty one * Mark skia mojoms as [Stable] * Mark mojo_base.mojom.BigBuffer as [Stable], since it's a dependency See go/lacros-image-transport for background. Bug: 1116652 Test: skia_unittests Change-Id: I229cc405901a607ae613c410d7df5b92f03caf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368484Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#803234}
-
Jonathan Freed authored
Bug: b/166795933, 1123165 Change-Id: Ia445eb6f4c54f643fb64bcb53f8868245ae3720b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382407Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#803233}
-
Kevin McNee authored
Bug: 1033009, 1119576 Change-Id: Ia0f1a0989955340b3e383f51ba268ccf69eeb025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385784 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#803232}
-
Alex Newcomer authored
This feature has been enabled on many boards for a while. This CL enables it on all boards. Bug: 1123549 Change-Id: I6bccd9f1d9c75358b3aadebc468b0670669db2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386008 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803231}
-
dpapad authored
This makes the behavior of the page input and zoom input consistent, per UX request. Bug: None Change-Id: I8a44057f22971b9a77f0e7cefa91dd82c7e3e8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385955 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803230}
-
Ryan Hansberry authored
This method was just introduced in a recent uprev. Change-Id: Ie5d708ea8aacceef650c2b9fcaf46f5326bec574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382951Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#803229}
-
Bailey Berro authored
Now that we are launching DisplayIdentification without Display Alignment, DisplayLayout needs access to the browser proxy if only Display Identification is enabled. Bug: b:166670384 Change-Id: I39a6e3f1d84cca570631316c2c40b2a59479216c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382192Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#803228}
-
Brian Sheedy authored
Locks the GPU Windows 10 NVIDIA machines to Windows 10 1909 and the newer driver version since the upgrade is complete. TBR=ynovikov@chromium.org Bug: 1085489 Change-Id: I22a9c06309ab33585de71c5d700f10d588957169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385983Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803227}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598853319-353b2ae72aeb030448b18cf22e3efb9470af52fc.profdata to chrome-win64-master-1598874892-73206483eae1decbe634d34fb148ae3f49e172dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5637b2143711cdadfb8b02fcc248be657555f440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803226}
-
Natalie Chouinard authored
Add a Mojo interface for communicating between Clank and the renderer to provide access to downloadable fonts via GMS Core, as described in go/renderer-gmscore-fonts. Implements the matchLocalFontByUniqueName to provide the opened file descriptor for a given full font name, if available from the font provider, as a Mojo File. Bug: 1111148 Binary-Size: Unavoidable method count increase for new mojom interface. Change-Id: I394b2cb14171bd54ffad4fa033c89cb5451f64ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347916Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#803225}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/59d25cd7ff01..676387126d72 2020-08-31 wolfi@chromium.org Increase contrast for dark theme toolbar buttons 2020-08-31 jespertheend@gmail.com fix breakpoints gutter click event not getting removed properly 2020-08-31 mathias@chromium.org Clarify how to request merge approval If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1087635,chromium:1122511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I94026857b17817217d35d307cb4e521a5086d899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385681Reviewed-by:
-
Koji Ishii authored
This patch changes |NGLogicalStaticPosition| and |NGPhysicalStaticPosition| to use |WritingDirectionMode| and |WritingModeConverter|. Bug: 1091797 Change-Id: Id5232652e76a393bc2efad33202801d9a3b04518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374930 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803223}
-
Jimmy Gong authored
- Boiler plate template for the diagnostics app. - Future CL will covert this to an SWA. Bug: 1120206 Test: browser_tests Change-Id: Iae3851ba82859b4a202ea4df1a416c13127b9cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377405Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#803222}
-
Koji Ishii authored
Bug: 982194 Change-Id: Ieb7d92ccad9e02dee3ef1beeafe2332ec89867ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269454Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803221}
-
Xianzhu Wang authored
Chromium UI sets layers_always_allowed_lcd_text to true [1], indicating that it can almost always align raster pixels to physical pixels and doesn't care about temporary misalignment, so don't bother raster translation to avoid performance regression during non-composited animations. In the future, the performance hint is better to be passed through TransformNode::will_change_transform when we convert UI compositor to layer list + paint properties mode. [1] https://source.chromium.org/chromium/chromium/src/+/master:ui/compositor/compositor.cc;l=108 Bug: 1121789 Change-Id: I2337de448146d3b2246bbbf19b443b9422dc7364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382736Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803220}
-
Daniel Rubery authored
This reverts commit a4418459. Reason for revert: Causing crashes (https://bugs.chromium.org/p/chromium/issues/detail?id=1122534 and https://bugs.chromium.org/p/chromium/issues/detail?id=1122732) Original change's description: > Move visual feature scoring to helper thread > > This CL calls the GetMatchingVisualTargets in a worker thread, since > the process of scoring visual features takes longer than expected > and was blocking interaction. > > Fixed: 1121375 > Change-Id: I8f3e33d20f812645a72adfc16fe33241b49a6ff4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372869 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801907} TBR=vakh@chromium.org,bdea@chromium.org,drubery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I02048f19ab8aee3a39a413b6f3cea1e1c4f696de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385782Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#803219}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c2928bb0d5f..241f08018af3 2020-08-31 johnstiles@google.com Add helper function for inlining argument lists. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ie221e170585e0272545d2c9ee89c5e910dfbf4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385690Reviewed-by:
-
Olesia Marukhno authored
The first time when match changes its height, pedal button is misplaced and overlaps with another match. This was caused by setting wrong bounds for button row. Bug: 1121934 Change-Id: I297a3551c370f8efd7c4079e14b9c6fcace70e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385378Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#803217}
-
ckitagawa authored
We are seeing some possibly statistically significant memory increases with the show on startup experiment. One avenue to optimize is to only capture when the tab is hidden with the activity (may avoid capturing renderer staying around too long). Pros: - Probable reduction in memory usage - Fewer captures/disk-usage Cons: - Possibly there are scenarios where the user was on the tab switcher or in another state where we won't have hidden the tab with the activity meaning fewer cases where we have a capture to show. - We need to re-add this behavior for the tab-switching experiment where we need to capture on all hides anyway. Bug: 1123523 Change-Id: Icbb5e71b6255d32670dea558e63e4aba00a77506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382224Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803216}
-
Noah Rose Ledesma authored
Crashes have been observed on OSX canary builds that are likely due to an absence of a default device. This change removes the assumption that a default audio device will always exist from the device provider and UI. Bug: 1123043 Change-Id: I6983d2086b704274990e3019277976b9ffffa494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381810Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#803215}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.14-r1 to 86-4183.59-1598262024-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7ec949bac5738863ff614067311b3eee53a1b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385693Reviewed-by:
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: I8391d3e66cd5395e8107f43d680b9057446f14ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385302Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803213}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Iad9f9a167eda67d20d9e99861804a1f2183fe3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385455Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803212}
-
Anupam Snigdha authored
It is really not necessary to DCHECK whether the TSFBridge instance is null or not as the caller does check for null. Bug: 1115355 Change-Id: I256ec204e35bb3a3b76cedb7adffee7b2e856ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385978Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803211}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.14-r1 to 86-4183.74-1598264968-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id38e8eb7b09dbb8c8f7205a9168211576f898c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386076Reviewed-by:
-
Wenbin Zhang authored
This is the CL to disable reference builds on all testers from perf waterfall. Bug: chrmoium:1108663 Change-Id: I26152451b80094fb301552fefe8f4270d7faa732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378786Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803209}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.14-r1 to 86-4183.74-1598267562-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie7d062da0a550e99b4e31cb9c4500bf9a2a58df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386075Reviewed-by:
-
Xing Liu authored
This CL extendsd the flag expiration date for a few download related features. Bug: NONE Change-Id: I4393f74e095a150ff204a7a1494946a2f434beb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385977Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803207}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I80662cfab027d52340d006c895cb2297de45b2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385415Reviewed-by:
-
evliu authored
This CL adds a command line switch that enables the kLiveCaptionEnabled preference which will make it easier to add Swarming tests. Bug: 1122784 Change-Id: I27f0f4ae4a0b19b97f454336f1ca5f372b1e50cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382961Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#803205}
-
Prashant Nevase authored
The virtual tests for dark mode were scattered in virtual test directory. This patch moves them in web_tests/dark-mode, a single real directory. The dark mode has two main categories of the tests viz. colors and images. The tests are now organized in these categories. The web_tests/dark-mode runs tests in normal mode. The virtual tests run the tests in dark mode with additional arguments. Bug: 1116914 Change-Id: I5c8dfc9b6085e5d70475a82d018c25482f53fb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377037 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#803204}
-
Yue Zhang authored
This CL prevents default undo closure snack bar from showing when a closure happens within TabGridDialog. We use the visibility of TabGridDialog as a proxy to decide whether a closure happens in dialog. This is the step2 in https://docs.google.com/document/d/1OOlOVYtcFXE--8TMdcFAqAMqcsRyEsvJr0vzsNCR_F4/edit?usp=sharing. Bug: 1119899 Change-Id: Ibdfe53847af25921f32436d80a5868b97340a524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369469Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803203}
-
Andrew Grieve authored
Java code can have per-target lower-than-default min_sdk_versions, but the same is not true for native code. In order to increase min_sdk_version for native code, it must be done globally. Bug: 1116198, 1119402 Change-Id: Id6e55027f57bae26fc13b4338c4b16c462dfacf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367649Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803202}
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: Iae5980e46b154f0ec170c92f37d602b91ff5a854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385358Reviewed-by:
-
Brian Sheedy authored
Adds a test for exercising Telemetry's hung renderer detection/crashing code. If Telemetry detects a hung renderer, it should crash the hung renderer process and the GPU process so that we can get minidumps to diagnose the root cause. Bug: 1119564 Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
