- 07 Nov, 2019 40 commits
-
-
Fredrik Söderquist authored
With some unlucky combinations of parameters (timing and current time), we could end up spinning in the resolve loop, (re)resolving the same interval over and over, not making forward progress. Guard against this by bumping the next "begin after" value by epsilon if the resolved end is the same as the current "begin after". Bug: 1021630 Change-Id: I71ba25cd423c24428f5d3f41f05fc83a2a1693cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901043Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#713370}
-
Michael Lippautz authored
The Visitor parameter was not needed for custom weak callbacks because such callbacks are anyways not allowed to revive an object. Replace the parameter with WeakCallbackInfo which can be used to query liveness information. This allows us to move ObjectAliveTraits and its callers into a heap-private section in future as WeakCallbackInfo is only exposed when such queries are allowed. Renamed RegisterWeakMembers to RegisterWeakCallbackMethod as it is just delegating to RegisterWeakCallback appropriately. The GC plugin bailed out on checking for whether all fields are traced as soon as RegisterWeakMembers was present. The rename now requires changing WeakMember<> to UntracedMember<> because the method name is different. This matches semantics though as WeakMember<> should be automatically cleared by the GC whereas UntracedMember<> is manually cleared by the callback. A followup removes the GC plugin logic. Bug: 982754 Change-Id: I8387c12c06a9c35a6732060dd212290f058a7199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899377 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713369}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f8045a095cc1..64cfaeac4c5d git log f8045a095cc1..64cfaeac4c5d --date=short --no-merges --format='%ad %ae %s' 2019-11-07 yunchao.he@intel.com Reland "Implement readonly storage buffer - validation at API side" Created with: gclient setdep -r src/third_party/dawn@64cfaeac4c5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I61963fb40a584f189e43394baa5b6c15c0981336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713368}
-
chrome://help-appRachel Carpenter authored
This is shown in the launcher with --enable-features=HelpAppV2, otherwise existing Get Help app is shown. Bug: 1012578, b/140960611 Change-Id: I18a56bce24733fa2efa847ad4d2b8db5a7eccc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902174 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#713367}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I259fa814159f5f85b11515fbfddf3aff0356ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903407Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b70bebf7..dfb12d9e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f933d9011be92e00d46ebe1f8dfe1ee547a73e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902429Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713365}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e09342dccb0d..81bef5295824 git log e09342dccb0d..81bef5295824 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 vapier@chromium.org pylintrc: list more 3rd party libs Created with: gclient setdep -r src/third_party/chromite@81bef5295824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2eb62ef34984c46fb7774d2c11656d953a3dd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903406Reviewed-by:
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: Ia29e269f2335ee91432f3c4eb308d7ae3b8ac72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890431Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713363}
-
Adam Rice authored
Coverage indicated that the case where there is an exception looking up a pipeTo or pipeThrough option was not actually tested. Add a web platform test to verify that exceptions are thrown and that options are accessed in the correct order. Change-Id: I88d889a42853ee0625cc51fe30cd119b118289b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903169Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#713362}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/ab8035da9c..e66080e9a1 TBR=aerotwist@chromium.org Change-Id: Icb5a5e75a17f490a436743f042126438b68947e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903346Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713361}
-
Varun Khaneja authored
R=xinghuilu Bug: 963165 Change-Id: I3d78316f61aade1f4f6803e7646c149c12e9661e Fixed: 1021302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897002 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713360}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 80-3940.0-1572255699-benchmark-80.0.3951.3-r1 to 80-3943.1-1572866479-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ifcd186c5349354dc68447e13f99303988d44c0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903410Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 911415 Change-Id: I6a04f632ba9f5eb5338cb86060cc93e8d20ef852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898163 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#713358}
-
Trent Apted authored
This is needed to allow JS tests themselves to be compiled to ease future maintenance. js2gtest.js also needs to be compiled for that, which will be done in a follow-up. Hand-crafted externs are added for mock4js since it is not able to be consumed by the compiler directly. axs_testing.js is precompiled and also not easily consumed by the compiler, so appropriate suppressions are added to the a11y methods of test_api.js that deal with it. Bug: 1000989 Change-Id: Ife6b7595674ffc79c2eadc5484d0804830a648ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787477 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713357}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. A browser end-to-end tests will be added later in a follow up CL. An MVP implementation of the bridge+sync needed first. Bug: 860583 Change-Id: Ibde266ad7cb74af380b6d5949f4636c2333457e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893488Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#713356}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62303e032c7c..e09342dccb0d git log 62303e032c7c..e09342dccb0d --date=short --no-merges --format='%ad %ae %s' 2019-11-07 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@e09342dccb0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I409fed5bfffaf9d8e929b6d1f4de0c82a59da91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902261Reviewed-by:
-
Kamila authored
If a media (camera/mic/camera+mic) permission was recently accepted on a site level, but it was blocked on a system level, auto open bubble that leads users to system permissions. Situation this will be triggered: 1) Site asks for media permission. 2) Permission prompt shows on the left side of the omnibox. 3) User accepts the permission prompt. 4) Blocked icon appears on the right side of the omnibox & the bubble which gives the user the option to "Open system preferences" auto-opens. Note that if mic and camera are requested individually, the bubble will auto-open for each of them once. Change-Id: I611b4f256ca4f0793d2e97bb8bc8bc4cd12babe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897659 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#713354}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67d43fe58187..345a2735e2c8 git log 67d43fe58187..345a2735e2c8 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 215bc7949b35..27a3d31d7a9d (2 commits) 2019-11-07 rosasco@google.com No GL support on Fuchsia. Created with: gclient setdep -r src/third_party/skia@345a2735e2c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: Ic8ee40a2ab9dd34e6e950306624808a4f6f55b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902262Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d65febb94a9..70ec48ca281c git log 0d65febb94a9..70ec48ca281c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 47e9a612..59fc3bb1 (713182:713284) Created with: gclient setdep -r src/third_party/webrtc@70ec48ca281c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I213d29f2a7f42023068817215633e724eaa7822d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902479Reviewed-by:
-
Ramin Halavati authored
Persistent filesystem is enabled by default in incognito mode. Storage is still done in memory and is deleted when browsing session ends. Tested: third_party/blink/tools/run_blink_wptserve.py out/Default/chrome --incognito \ http://localhost:8001/wpt_internal/file-system-api\ /temporary_vs_persistent.window.html Bug: 990592 Change-Id: I2294dc65c79553917c28541897d5018afaa7b678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901079 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713351}
-
Koji Ishii authored
Following bot results are included. 204 206 207 208 209 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ia03b3f364433c288ab2427b5c8f46e9f03b501eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901148 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713350}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80def79b..b70bebf7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d07e85bae01c408824a63df36e286232d6628b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902588Reviewed-by:
-
Adam Rice authored
Remove ReadableStreamNative::PipeToEngine::Promise() getter, which is unused. Change-Id: I2bab42adc6eebdf697f38ecb4fcb96885aefcf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900521Reviewed-by:
-
Meredith Lane authored
Adds in extra test cases relating to moving elements in and out of scope. This behaviour is still under discussion, so is likely to change in future as the API is finalized. Bug=981423 Change-Id: I5863b1f8d7ab1b6287af1d95e859945af38fea60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816496 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713347}
-
Christopher Lam authored
This CL adds a semantic color file which will be used across all ChromeOS WebUIs such as System Web Apps and System Dialogs. As a strawman, some top-level OS Settings styles have been replaced. Bug: 1018654 Change-Id: Id06fe0a1ae6366e6e990c10f4ee004b330829b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880358Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Will Cassella authored
This enables WebXR sessions to record which features they requested, which features were granted, as well as which features were used or attempted to be used. This also fixes a small bug where the stop time was not being recorded for inline sessions. Bug: 995849 Change-Id: If025e5485dd9a99cd4bf0da63860dcd4f96413f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867199 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713345}
-
Koji Ishii authored
This patch propagates out-of-flow objects when FragmentItem is enabled. Out-of-flow objects need a different propagation up to their containing block. This patch makes sure out-of-flow objects in inline formatting context are handled the same way. Because objects in inline formatting context are no longer full |NGPhysicalFragment|, this patch splits |AddChild| to the logic we need to do for all new child, and to actually add to the child list, so that objects in inline formatting context can call the former part. Regresses ~30 tests by revealing hidden failrues or turning crashes into failures, but fixes ~1300. It is very likely that we need more tweaks for how to handle them with FragmentItem, I will invesigate other failures in following patches. Bug: 982194 Change-Id: I89523efe68e0558916cb47f6c0216dca2d2327b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899229 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#713344}
-
Trent Apted authored
This allows us to take advantage of the corresponding contributed externs file rather than roll our own. This is not the latest release of chai.js (4.2.0 is), but it's the one that has an available externs file. Bug: 1000989 Change-Id: I7045efdcfbc12025b6857178c11fc5195d8dbaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888619 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
Vsock proxy depends on /run/vm which is created by pre-start script in vm_concierge.conf. BUG=b:143997789 TEST=Launch Play Store Change-Id: I46ccb49cd19df98001f4a3937e7ab1c7e40d06c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901009Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#713342}
-
Josh Horwich authored
Bug: b/143923749 Change-Id: I178257708c0eb2e0268368a03de11c9c6dfaacaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900431Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#713341}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/361d1c3e5ab4..0d65febb94a9 git log 361d1c3e5ab4..0d65febb94a9 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33f41173..47e9a612 (713078:713182) Created with: gclient setdep -r src/third_party/webrtc@0d65febb94a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I073ca11e0aa3fd8649ba1451873249c19ff0986f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903091Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/13adddb32ef0..76ee91e12642 git log 13adddb32ef0..76ee91e12642 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 9856269+sarahM0@users.noreply.github.com Fix spvc test machanism and adds unit tests for OpSource (#868) Created with: gclient setdep -r src/third_party/shaderc/src@76ee91e12642 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I062b82a03dff981e50050137169846b7fecc33d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903006Reviewed-by:
-
Yoshifumi Inoue authored
This patch moves implementation of |PreviousLineOf()| to |NGInlineCursor| from |NGPaintFragmentTraversal| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I92d17fcd7381d54f8616cef79f131d9cdfb0589d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900791 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/322220a0b205..cc0919dcb64b git log 322220a0b205..cc0919dcb64b --date=short --no-merges --format='%ad %ae %s' 2019-11-07 jmadill@chromium.org Capture/Replay: Fix VertexAttribType BYTE output. 2019-11-06 tobine@google.com Vulkan:ImageHelper read combined DS textures Created with: gclient setdep -r src/third_party/angle@cc0919dcb64b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I571b360322f7e7e7b2c4bc0a6096e4b725133e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902923Reviewed-by:
-
Nigel Tao authored
The gif-animated-partial-load.html web test examines the intermediate rendering of loading a GIF image over a simulated slow network connection - an incomplete image. The GIF spec (https://www.w3.org/Graphics/GIF/spec-gif89a.txt) describes how to decode a complete GIF file, but does not mention intermediate on-screen state. Different decoders have leeway to present different partial decodings. Specifically, Chromium's old decoder only output complete rows of pixels and consumed only complete blocks of data. Chromium's new decoder can output partial rows and consume partial blocks. (A GIF image's compressed pixel data is framed into a sequence of blocks. Each block has a length byte, then up to 255 bytes of payload.) For interlaced GIFs, the old and new decoders also take different approaches as to how to expand 'tall' rows: whether the explicit row is the center or the top of the strip of implied rows. To repeat, different (spec-compliant) GIF decoders can produce different partial decodings. The Blink web test does a pixel-exact comparison to a golden screenshot, so this commit also updates that screenshot. https://bugs.chromium.org/p/chromium/issues/detail?id=1014044#c3 shows the old and new screenshots. This commit isn't about performance per se, it is about tracking upstream Skia. Nonetheless, here are some before-vs-after total times for Chromium's "image_decode_bench -i 10" program for x86_64, on a selection of GIF images that noel@chromium.org collects: old_time new_time ratio file_name file_size 0.000143 0.000391 0.37 bar.gif 265 0.000282 0.000401 0.70 radient.gif 1034 0.001328 0.001290 1.03 mondrian.gif 3792 0.002619 0.001893 1.38 rain.gif 10272 0.009508 0.005642 1.69 flag.gif 41738 0.021562 0.013780 1.56 warp.gif 106420 0.390664 0.301473 1.30 hex.gif 1072114 A ratio higher is better: more than 1.00 means that the new GIF decoder is faster than the old one. The ratios are consistent with the hypothesis that the new decoder has a higher fixed cost but lower per-pixel cost (cost in terms of time taken). Overall, it is arguably a net improvement in absolute time taken. The same relative difference (ratio) means larger absolute differences for larger images. Bug: 1014044 Change-Id: I20e2d6281945b8219778d049c3d09a52f456aed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898151Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713336}
-
Toni Barzic authored
The reporter was used to record app list transition animation smoothness when transitioning to/from home screen from/to overview. (using histogram Apps.StateTransition.AnimationSmoothness.*Overview). It was passed to the animation optionally created by HomeScreenDelegate::UpdateYPositionAndOpacityForHomeLauncher and HomeScreenDelegate::UpdateScaleAndOpacityForHomeLauncher. The former is already setting up metrics recorder for the same animation - the one owned by AppListView, but using different histograms (Apps.HomeLauncherTransition.AnimationSmoothness.*Overview). Given that we don't need two equivalent histograms, remove the recorder owned by HomeScreenPresenter, for two reasons: * it wasn't getting reset when the animation was interrupted * the tracked animation might outlive the recorder during shutdown (AppListView widget is destroyed after HomeScreenPresenter), so it might cause use after free - see linked bug. Also, remove HomeScreenDelegate::NotifyHomeLauncherAnimationTransition, which was used to set up app list view's state animation recorder before starting animation. Instead move the recorder setup into the methods that actually initiate animations (to make the API less prone to misuse). BUG=1021936,1022124 Change-Id: I7324826afb081f9bea6246cbb938cf8d7baa6688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901356 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713335}
-
Lin Sun authored
Added more platform tags to some expected failures to restrict the scenario. Also added some new failures on Linux and Intel graphics card. Bug: 832238, 849572, 928530, 950552 Bug: 1014429, 1021428 Bug: angleproject:2672 Change-Id: I9eec7fe7e08a3b6fcc17166e9e14e02eae8115ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899406Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#713334}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLTableElement> and DynamicTo<HTMLTableElement> as new downcast helper 2. Use IsA<HTMLTableElement>(element) in place of IsHTMLTableElement(element) Bug: 891908 Change-Id: If226fd115ed87225caa5396d770a8ecbc2b9987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899639Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Ryan Sturm authored
Add an entry for NavigationPredictorMultiplePrerenders in field trial testing config. This maps to the 5 prerender arm in the experiment (the most aggressive). We are not sure which arm will launch if any, so we might as well test the most aggressive behavior against the bots. Bug: 1016213 Change-Id: Ie8e930790b9a4438a32df76496bd7a6a183156ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900469Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#713332}
-
Varun Khaneja authored
This flag has been enabled for all Stable M78+ users. R=bdea Bug: 963165 Change-Id: Ic5b3f5236f66bae4bd6a87ba2ff98c5ff5193144 Fixed: 966646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892293 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#713331}
-
