- 18 Jul, 2018 40 commits
-
-
Mark Pilgrim authored
Bug: 844947 Change-Id: Iab736aaeffc70816f803a30d09bf65d712802134 Reviewed-on: https://chromium-review.googlesource.com/1135591 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576132}
-
Robbie McElrath authored
One of the tests starts a request that will repeatedly retry itself on failures, with backoff. The test asserts that the delay has a certain value, which is effectively the same as asserting that the request is on a certain retry attempt, but sometimes the request has time to retry more than once before the test assertion occurs. This changes to assert to not expect a specific value, just one that's larger than the default. Bug: 864797 Change-Id: Ia8fced88b119f724bb2e2c93602ed6034b0b87d1 Reviewed-on: https://chromium-review.googlesource.com/1141299Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#576131}
-
Lei Zhang authored
Fix some nits as well. Change-Id: I8340ee189d751643a74841ef826fd2df2b8884b5 Reviewed-on: https://chromium-review.googlesource.com/1141107Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576130}
-
Koji Ishii authored
The 'text-justify' property was implemented under the runtime flag but currently there are no active plans to ship. This patch skips tests for the property. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iccbdf6087be326c934ab5dbdde965c9b2a12b4ac Reviewed-on: https://chromium-review.googlesource.com/1142051 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576129}
-
Yue Li authored
Show Assistant UI on flow completion if relaunch parameter is set. Bug: b/111406040, b/110847784 Test: Manual Test Change-Id: I86c02bc90de7a4e797c1c57c7fd9fdab8b1b0cf0 Reviewed-on: https://chromium-review.googlesource.com/1139183 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#576128}
-
Peter Boström authored
This reverts commit 8025aa7e. Reason for revert: Inadvertently affects the attached bookmarks bar. Original change's description: > Changed kBottomMargin of the detached bookmark bar from 4 to 2 pixels. > > This makes the detached bookmarks items vertically centered. > > Bug: 863697 > Change-Id: Icf6529ec0b33255dc8072d5bfacc2f32b0495f93 > Reviewed-on: https://chromium-review.googlesource.com/1139191 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575746} TBR=bsep@chromium.org,cyan@chromium.org Change-Id: I9381f0796b85cd658d2101981e3a1ef7071fb4ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863697 Reviewed-on: https://chromium-review.googlesource.com/1142168Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576127}
-
Becca Hughes authored
It looks like standalone apps will still show the system UI (and should) so they will be blocked by the Android OS from extending into the display cutout. Therefore, we should not give them default control of the cutout BUG=859241 Change-Id: Ie26d41fe983c1f45e4177676a3f936a03ca3a07c Reviewed-on: https://chromium-review.googlesource.com/1134080 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576126}
-
Justin Cohen authored
Conditionally set IDEBundleInjection and libXCTestBundleInject.dylib based on Xcode version. Bug: 843236 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2a13fd1e93cbe87e80b045c1d3010f518a6ed862 Reviewed-on: https://chromium-review.googlesource.com/1141276Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576125}
-
Becky Zhou authored
+ Change color for icons from google_grey_600 to v2 Grey 800 + Add custom attribute for tinting preference icons set from XML + Update icon color for Download spinner and location dialog Bug: 834884, 863519 Change-Id: I7c9b61ad8983ef0fa01ad69065bdfe0b3baafa23 Reviewed-on: https://chromium-review.googlesource.com/1141128Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576124}
-
tmartino authored
This CL fixes an undesired interaction between the rounded corners and the scroll view in the new dropdown. Specifically, we observed that the clipping path was not being respected on Mac when applied to the contents of the scroll view. This is fixed by applying the existing padding outside, rather than inside, the scroll view, so that the region being clipped is guaranteed to be non-scrollable padding. (n.b.: the padding calculation ensures this is at least as much as large as the corner radius.) This also introduces a minor visual change in the scrolling case only, as the padding above and below the suggestions no longer scrolls along with the suggestions. Besides fixing the clipping bug, on platforms other than Mac this also ensures the top of the scrollbar does not get partially clipped. Change-Id: I6ef7319db094ec66b64859df64031f6330dd567c Bug: 863930 Reviewed-on: https://chromium-review.googlesource.com/1140913 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576123}
-
Tommy Nyquist authored
The action happens whenever the DownloadActivity is resumed, which can happen multiple times when it is triggered. This leads to the dashboard being cluttered with many of these events, that are not really helpful notions of user actions. BUG=786102 Change-Id: I534d2fa8f147281b619f8f10085a0aab8e3815bf Reviewed-on: https://chromium-review.googlesource.com/1138723Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576122}
-
Matthew Cary authored
This adds mojo/edk initialization to media/gpu/video_decode_accelerator_unittest. This is necessary for future changes that use mojo machinary for shared memory manipulation. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6d04891a4d306f7c458eb2bb4ce3fd42a1b77759 Reviewed-on: https://chromium-review.googlesource.com/1122095 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576121}
-
Kevin Bailey authored
Bug: 780835, 853929 Change-Id: I9f5018fa6522d76ab7a8c57b635b084764f482db Reviewed-on: https://chromium-review.googlesource.com/1142129Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576120}
-
Jacob Dufault authored
Bug: 858858 Change-Id: Ie3dbc2e390e1f1432c58ed18d821c57ea6e1f908 Reviewed-on: https://chromium-review.googlesource.com/1140751Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#576119}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. Bug: 846456 Change-Id: Icfc48871f853797a15de7c50f247dc5400eab77f Reviewed-on: https://chromium-review.googlesource.com/1095985 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576118}
-
Sky Malice authored
Bug: 831648 Change-Id: Ibaca5b3501997d0c4538a9d8a79ae6050c10ec01 Reviewed-on: https://chromium-review.googlesource.com/1131692 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#576117}
-
Vasilii Sukhanov authored
When there are saved credentials on the page we should suggest them on any password field. If the field is eligible for generation we append it to the end of the suggestions. A screenshot is attached in the bug. Bug: 859495 Change-Id: I614faa89037074345794cd4107c8801f715142f4 Reviewed-on: https://chromium-review.googlesource.com/1140718Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576116}
-
Tommy C. Li authored
This CL has no behavioral changes and is a name clarification only. 1) kRichSuggestionMarginHeight => kRefreshTwoLineRowMarginHeight We are using this margin height for all two-line suggestions, which include tab-switch suggestions and old-style answers in addition to rich entity suggestions. This rename makes that explicit. 2) "Split" suggestions => "One-line" suggestions. We originally named these split suggestions because the title and URL were split by a hyphen. However, since we are calling two-line suggestions "two-line", I think calling these "one-line" suggestions would be most clear. Bug: 863982 Change-Id: Id56f6798c9a609276bbd0b0de5e565a3cf2cd475 Reviewed-on: https://chromium-review.googlesource.com/1141207 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576115}
-
Jacob Dufault authored
Bug: 864270 Change-Id: I8bdcbfa8f9d3a84776a08cb1e39d609a77ba08b0 Reviewed-on: https://chromium-review.googlesource.com/1141091 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576114}
-
Xiaoqian Dai authored
It was introduced when rebasing this refactoring CL https://chromium-review.googlesource.com/c/chromium/src/+/1134503. Previously it was rebased against a child branch (which was later discarded), then then rebased against master branch, but some changes from the child branch remained. The CL reverts the changes that's introduced by the child branch. The refactoring CL should not do any functionality changes. Bug: None Change-Id: I05af1fd5fc61be4f357106ae58404f9a2d2f5b0d Reviewed-on: https://chromium-review.googlesource.com/1141112 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#576113}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I12b0170b4dcd821a4b7026bbfb968b7347a48d5e Reviewed-on: https://chromium-review.googlesource.com/1142196Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#576112}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5dbb0c3db56a..dc97fdc23571 git log 5dbb0c3db56a..dc97fdc23571 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 robertphillips@google.com Fix Valgrind skinning bug 2018-07-18 caryclark@skia.org fix bookmaker 2018-07-18 senorblanco@chromium.org GrTessellator: fix overlap outer boundary winding. Created with: gclient setdep -r src/third_party/skia@dc97fdc23571 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863389 TBR=bungeman@chromium.org Change-Id: I26bc0a79b28a21c9f653586280e7cb42102ecfe8 Reviewed-on: https://chromium-review.googlesource.com/1142004Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576111}
-
Alexander Semashko authored
Now it will quit the message loop immediately after receiving the notification. Also it does not allow nested tasks anymore. Bug: 668707 Change-Id: I8d8a0ffb073236c3bbd00877bd48cc496b1c5036 Reviewed-on: https://chromium-review.googlesource.com/982612Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#576110}
-
Orin Jaworski authored
The "= " was getting removed from start of calculator answers but now it will be left in when new answer layout is enabled. Bug: 838733 Change-Id: Ice7bf2087cc51cd052744164018ff74f4aeb68a7 Reviewed-on: https://chromium-review.googlesource.com/1141126 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576109}
-
Charlie Ma authored
The limit of this implementation is unintentional launch, e.g user click some notification and go to external activity and then go back, it will also be counted. Solution is create a histogram of launch type, if majority if launches come from hitting Chrome icon, then the noise have less impact to the accuracy of daily launch count histogram. Bug: 806240 Change-Id: Iec367758267bba806b4ed2c34c9e030e0ec65909 Reviewed-on: https://chromium-review.googlesource.com/1103838Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Charlie Ma <charliema@chromium.org> Cr-Commit-Position: refs/heads/master@{#576108}
-
Aldo Culquicondor authored
Bug: 837334 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5724d2c97e663afb5b2dc0ee9ad994a81db2052 Reviewed-on: https://chromium-review.googlesource.com/1138645Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#576107}
-
Yafei Duan authored
Removing the isNewTabPageUsedAsHomepage from HomepageClient interface, since it can be combined with isHomepageEnabled and was only used in a check on native side along with isHomepageEnabled. So those two methods are combined on Java side to make interface simpler. Bug: 862786 Change-Id: I32f112590afe206da8d3d2264e36202d8cf2b9ed Reviewed-on: https://chromium-review.googlesource.com/1140691Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#576106}
-
Theresa authored
Only enable the toolbar button for devices with a minimum screen width of 320dp or greater. BUG=865035 Change-Id: I6738739990cf0d1081a703afaaa703d644925779 Reviewed-on: https://chromium-review.googlesource.com/1141992 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576105}
-
Wez authored
Without this dependency making an SDK update containing e.g. a FIDL generator change would not cause FIDL stubs to be regenerated. Bug: 865059 Change-Id: If760cccfd0a2357abdd3f4f32281fb2dd79cbd43 Reviewed-on: https://chromium-review.googlesource.com/1142127 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576104}
-
Alex Moshchuk authored
This reverts commit ac436aaa. Reason for revert: Sorry for the revert, but this might be breaking some layout tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/71090 (see also a few subsequent builds) Failing tests include: external/wpt/trusted-types/HTMLImageElement-src.tentative.html external/wpt/trusted-types/HTMLMediaElement-src.tentative.html external/wpt/trusted-types/HTMLSourceElement-src.tentative.html external/wpt/trusted-types/block-string-assignment-to-HTMLImageElement-src.tentative.html external/wpt/trusted-types/block-string-assignment-to-HTMLMediaElement-src.tentative.html external/wpt/trusted-types/block-string-assignment-to-HTMLSourceElement-src.tentative.html Sample failure output (from external/wpt/trusted-types/HTMLImageElement-src.tentative.html, others are similar): This is a testharness.js-based test. FAIL src = TrustedURL.create(). URLS is not defined FAIL src = TrustedURL.unsafelyCreate(). URLS is not defined Harness: the test ran to completion. Original change's description: > Adjusted references in tests to match new helper.sub.js file > > helper.js changed to helper.sub.js. > URLS.safe modified to work with wpt. > > Bug: 739170 > Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec > Reviewed-on: https://chromium-review.googlesource.com/1141725 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Maja Kabus <kabusm@google.com> > Cr-Commit-Position: refs/heads/master@{#576037} TBR=vogelheim@chromium.org,mkwst@chromium.org,kabusm@google.com Change-Id: Ieaa3bba36a970c7aa7547939c8f97a57a1b32544 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739170 Reviewed-on: https://chromium-review.googlesource.com/1142165Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576103}
-
nednguyen authored
Bug: 864611 Change-Id: I15fe4879139e6b4500cc9dc67633cc2ddc3eed0f Reviewed-on: https://chromium-review.googlesource.com/1141663 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#576102}
-
Matthew Jones authored
FeatureUtilities#isBottomToolbarEnabled is agnostic to whether Chrome is in an activity that supports Duet. This patch moves the logic for whether to remove the menu button from the top toolbar to ToolbarPhone, where Duet is always supported. Bug: 865061 Change-Id: Icfceddf92d04722bb9e8d20266e671642c50033d Reviewed-on: https://chromium-review.googlesource.com/1142137Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576101}
-
Georges Khalil authored
Change-Id: I4facf3700f274141640707b18c97a8db9fd7ef0c Bug: 865007 Reviewed-on: https://chromium-review.googlesource.com/1141280Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#576100}
-
Wang Hui authored
Replace bellow codes with std::move in chrome/browser/net const base::Closure callback = callback_; callback_.Reset(); callback.Run(); BUG=807724 Change-Id: I008cf9af9785272ddceb18fff4feba13e62fdac8 Reviewed-on: https://chromium-review.googlesource.com/1134715 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576099}
-
Nicolas Ouellet-payeur authored
To keep track of WebUSB state, use the same backend as the WebUSB tab-strip icon. Bug: 863922 Change-Id: I89e346c3a310cfb76618a7492e2d89821c758106 Reviewed-on: https://chromium-review.googlesource.com/1140281Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#576098}
-
Sammie Quon authored
This was failing on Nautilus. I am not sure why it worked fine with other devices, but I tested this manually. Test: manual Bug: b/111137179 Change-Id: I8d457f7180b5b486d86226960913b20836849f70 Reviewed-on: https://chromium-review.googlesource.com/1139227Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576097}
-
P H authored
Bug: 836246 Change-Id: I991c886d8eeec65277c38d24f6a48b7e2ba35c98 Reviewed-on: https://chromium-review.googlesource.com/1135876 Commit-Queue: Patricia Hongo <phongo@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#576096}
-
Oksana Zhuravlova authored
This change moves the frame check inside the reader check to address cases when GamepadSharedMemoryReader::Start() is called again after Stop(), but the frame is null. Since the frame parameter is only used when creating a new instance of GamepadSharedMemoryReader, the check was moved inside the corresponding condition. Bug: 864557 Change-Id: I7b32e82f5c79af2007b211cf80cff43ff33be2c9 Reviewed-on: https://chromium-review.googlesource.com/1141156Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#576095}
-
Friedrich Horschig authored
With this CL, the password accessory controller caches credentials by origin to deliver the correct suggestions in a Tab, esp. when the focus changes to another frame with a different origin. Bug: 854152 Change-Id: I43cd3aa6a86e310414dec1ae43169338d5b1a245 Reviewed-on: https://chromium-review.googlesource.com/1126765 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576094}
-
bsheedy authored
Large refactor of the XR test frameworks and utility classes. Main changes: 1. Restructure framework hierarchy so all functionality in XyzTestFramework makes sense for feature Xyz. 2. Merge all utility methods that make use of WebContents into the frameworks. 3. Split VR, XR, and AR build dependencies. 4. Add non-static versions of static framework methods that use WebContents since they were almost exclusively used with the result of getFirstTabWebContents. Bug: 863256 Change-Id: Ib984e1c3cb0b51dcd2424734cbcfafa6e51ac3d1 Reviewed-on: https://chromium-review.googlesource.com/1141150Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576093}
-