GitLab

Bug: 758733
Change-Id: I0b4cac2f3bc605383e835184ef7c27c51be1be4a
Reviewed-on: https://chromium-review.googlesource.com/994144
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548240}

This patch adds an UMA metric for the time spent in
ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded when a
compositing-related change does need an update.

Bug: 826883
Change-Id: I49949aa286bfc2c3c265b9ba99e2b7cd5a33b90b
Reviewed-on: https://chromium-review.googlesource.com/994541Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548239}

crrev.com/c/728325 disabled fetching/using an ICC file for display color
correction if enough information was available in the monitor EDID. This
was based on the wrong assumption that either one or the other would be
present, but not both.  This CL reenables the use of (download of) the ICC
file for monitor colorimetry, using the EDID provided info as a fallback.

On the implementation:
DisplayConfigurator::NotifyDisplayStateObservers() pings DisplayColorManager
when there's new Display info. The later calls ApplyDisplayColorCalibration()
directly or after fetching the ICC file. In either case, if all steps
succeed, SetColorCorrection() is called; at this step we are sure that the
found/downloaded ICC file is good, and we can remove the usage of the EDID
provided ColorSpace.

Bug: 828102
Change-Id: Id799f8412ea06d781712884b1d02694f124860c6
Reviewed-on: https://chromium-review.googlesource.com/990494Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548238}

Sometime Android system fails to extract library. Manually extract them to
cache directory and load as needed.

Bug: 806998
Change-Id: I7ccff04435cb5201e410c71bde741e52687329ab
Reviewed-on: https://chromium-review.googlesource.com/930332
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548237}

This is necessary in order to land CL [1].  I've been trying for a few weeks to
land it, but there's always new merge conflicts due to changed layout test
baselines.  This CL bans changes in third_party/WebKit/LayoutTests for a few
hours while I rebase and land CL [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/976083

BUG=787020
R=dpranke

Change-Id: I24bf199e20e5d5da1fc84e1ac8e64320213527d0
Reviewed-on: https://chromium-review.googlesource.com/996633Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548236}

Adds a test that validates that the third-party libraries used by the
chrome media gallery util service are using the right CPU info.
This is going to be usefull for an upcoming CL that changes how that
information is set (it'll be passed through IPC).

Bug: 823931
Change-Id: I9e9586af8615739db0baf36ed547ef017546adb5
Reviewed-on: https://chromium-review.googlesource.com/996392Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548235}

TBR=kbr@chromium.org

No-Try: True
Change-Id: I3b6e7a4bfe81a67b0d67b334b09217fd02b2c579
Reviewed-on: https://chromium-review.googlesource.com/996638
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548234}

Bug: 826231
Change-Id: I82f681337a754513a69d002042d42e1d5206efa5
TBR: dgozman
Reviewed-on: https://chromium-review.googlesource.com/993974Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548233}

d108fd04a5e6 linux: Add PtraceConnection::ReadFileContents
08ce02c35276 Fix crashpad build on non Android ARMEL with a recent GLIBC

Change-Id: I89fe9a22bf10b1a08a322cfd856ca9b56797c899
Reviewed-on: https://chromium-review.googlesource.com/995421Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#548232}

Change-Id: Ib2a034a4ee2b38ced8e1dc51247a49eee244aede
Reviewed-on: https://chromium-review.googlesource.com/991152
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548231}

This is disk caching part of Feed Image Loader, and other parts of Feed
Image Loader will come later.
leveldb_proto is used as database. This disk cache need to save images
when Image Loader fetched images from network, and next time when Image
Loader received a same URL request, disk cache can provided without
downloading. Also this disk chache will do timestamp-base garbage
collection when Image Loader requested.

Bug:807359, 807457

Change-Id: I66db2411304012cf6f04a7380fc34fb1f5306d2f
Reviewed-on: https://chromium-review.googlesource.com/981298
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548230}

This is in preparation for nested dedicated workers.

Bug: 829119

Change-Id: Ifedf3a9b3d57a2e88b294280f148d25b6071a170
Reviewed-on: https://chromium-review.googlesource.com/993773
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548229}

This is for reuse by RasterDecoder in a subsequent CL. The test added
for GLES2DecoderImpl is similar to what will be added for
RasterDecoderImpl.

Changes:
- made CopyTextureMethod an enum class for easy forward decl
- moved ValidateCopyTexFormatHelper and GetCopyTextureCHROMIUMMethod for
  future reuse
- added mock for texture copying
- added unittest to make sure that texture copying clears source and
  destination textures appropriately

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I44a1ca37ad48d065acfd9d94b737ac1d925d99e5
Reviewed-on: https://chromium-review.googlesource.com/993592
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548228}

https://skia.googlesource.com/skia.git/+log/42f8bc40fd37..bf74a460814a

$ git log 42f8bc40f..bf74a4608 --date=short --no-merges --format='%ad %ae %s'
2018-03-22 liyuqian Fix drawBitmapRect in the threaded backend
2018-04-03 mtklein add Mac ASAN bots
2018-04-04 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 7dd7eed65..d26d270c8 (1 commit)
2018-04-04 djsollen Tag the unique keys of lazy images.
2018-04-04 robertphillips Add SkSurfaceCharacterization operator== && !=
2018-04-04 bsalomon Revert "Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.""
2018-04-04 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5d232d53b..bc54342bf (6 commits)
2018-04-04 egdaniel Don't use the inner radius when not stroking in DIEllipse
2018-04-04 bsalomon Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used."
2018-04-03 benjaminwagner Add mips64el_toolchain_linux asset.
2018-04-03 bsalomon Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.
2018-04-04 egdaniel Handle perspective scales in GrPathUtil scaleToleranceToSrc
2018-04-03 robertphillips Hide GrPixelConfig in SkSurfaceCharacterization
2018-04-04 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 770177dc9..7dd7eed65 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Id7caf5d1cb7c734bf9e1874ef87e4897d045e822
Reviewed-on: https://chromium-review.googlesource.com/996179Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548227}

BUG=827826

Change-Id: I6b91c4a9691f19df11f39a0799df5d5a4703681f
Reviewed-on: https://chromium-review.googlesource.com/996251Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548226}

This CL will early-out on a bad URL or there are too many requests inflight. This
avoids allocating and freeing a BitmapFetcherRequest (which is unnecessary).
This is a minor optimization for an uncommon case, but I plan to increase
the use of the bitmap fetcher - so this may become more common.

Bug: None
Change-Id: I3d498008a78faf622fcee68d20c4e9234e581e80
Reviewed-on: https://chromium-review.googlesource.com/994116
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548225}

Bug: internal b/77586397

Change-Id: I1a40b631bc3666e38008a367458737a4564f93a7
Reviewed-on: https://chromium-review.googlesource.com/994135Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548224}

Removes the was_focused_by_mouse_ flag implemented by a number of form elements,
and replaces it with a check for Node::WasFocusedByMouse().

R=tkent@chromium.org

Bug: 817199
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibd8477732d5646f928c010a5c1cef853bafc38ee
Reviewed-on: https://chromium-review.googlesource.com/988352
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548223}

Bug: 822951
Change-Id: If213f5703c966868778cd00511f222eba6ff5191
Reviewed-on: https://chromium-review.googlesource.com/990575
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548222}

Before playing media using the MediaPlayerBridge, we try to parse the
metadata, using the MediaResourceGetter. This class uses the Android
MediaMetadataRetriever API, which can be be resource intensive. We
eventually get all of the metadata we need from the Android
MediaPlayer, and pre-parsing the metadata sometimes does nothing but
delay the start of playback.

This CL removes the java MediaResourceGetter, and removes metadata
extraction capabilities from the C++ portion of the
MediaResourceGetter interface.

NB: This is unlikely to have a performance effect on HLS playback,
since the MediaResourceGetter did not support parsing HLS.

Bug: 739914
Change-Id: I460d5aea02bf1a0bf099f66a781a40ca6374d4d0
Reviewed-on: https://chromium-review.googlesource.com/988681Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548221}

BUG=829047

Change-Id: I3ff5012311bac36cef7636030e988143f47c3339
Reviewed-on: https://chromium-review.googlesource.com/996471Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548220}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: Ibfe71ea6fdd860fc83234fa31b3223339d0b71dc
Reviewed-on: https://chromium-review.googlesource.com/988847Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548219}

These tests have become especially flaky lately on one platform.
Disabling until the underlying problem can be fixed.

BUG=828780

Change-Id: Id6b56d76217a469641f13bb9be7e49d5bdc2e47e
Reviewed-on: https://chromium-review.googlesource.com/996017Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548218}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: I50409e8e4198a0b0e281cd6889c90935ca872402
Reviewed-on: https://chromium-review.googlesource.com/988846Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548217}

Bug: 828951
No-Try: True
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I75de3b418241c9b97cda622cd9798f06e0e08f3d
Reviewed-on: https://chromium-review.googlesource.com/996240
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548216}

When running gn gen with filters for the IDE output from ninja,
the gn gen command used the working directory (//out/foo) as the
base for resolving the filters, rather than "//" as is done when
running gn gen directly.

This CL fixes that by always using "//" as the root_dir. It also
fixes filter labels that have had the leading "/" in "//" removed
by Git Bash.

R=dpranke@chromium.org

Change-Id: I6c6e6f5e720d50b325d8b368f94ee1b3b5931627
Reviewed-on: https://chromium-review.googlesource.com/941209Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#548215}

Impose a limit on the depth of the embedding, to avoid a stack overflow
during the generation of the hit-test data phase.

BUG=820835

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I07f3dbb5422458db703661b421b315e1ca4784dd
Reviewed-on: https://chromium-review.googlesource.com/993033Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548214}

- RemoteViewHost derived from NativeViewHost on embedder side to embed
  a window and host the embedding window in view hierarchy;
- RemoteViewProvider on the embedded side to prepare an aura::Window
  to be embedded;

Bug: 812434
Test: views_mus_unittests --gtest_filter=RemoteView*
Change-Id: I1c999bf07d16330cf8b97df5e7f55b5bbcaa377a
Reviewed-on: https://chromium-review.googlesource.com/989014Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548213}

Change-Id: Iefcc1aeee3ce71147d2d5fe8255ca61707feb12b
Reviewed-on: https://chromium-review.googlesource.com/994710Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: David Tu <dtu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548212}

For a non-self-painting layer having self-painting descendants, the
non-stacked layers are painted through the non-self-painting layer's
parent, which may be different from the non-self-painting layer's
container through which the non-self-painting layer is painted. We
need to invalidate both path to ensure correct subsequence caching.

Bug: 826659
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic0d0745a50f34b7b7e23da226e62e8599de68aa5
Reviewed-on: https://chromium-review.googlesource.com/990718Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548211}

There are a few further cleanups still to land, but this removes most of the
code needed to compute/draw infobar arrows, as well as code that is "fallout"
from having them.

Now that arrows are never drawn, all this complexity is unnecessary.

BUG=none
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib8d9f83c56e98321b8a7f65e5503d849cd2e0d9d
Reviewed-on: https://chromium-review.googlesource.com/991056Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548210}

Change TextInputClientMac from using NS types to using types that can
go through IPC.

The goal of this is to allow TextInputClientMac to exist in the
browser process, while the RenderWidgetHostViewCocoa exists in the
AppShim process. The problematic type here is NSAttributedString, which
will need to be kept in encoded form until it reaches the AppShim.

Change NSPoint, NSRect, and NSRange to the gfx types. This ends up
letting us delete lots of convert-then-convert-back code (in addition
to allowing IPC).

Change NSUInteger to uint32_t (and NSNotFound to UINT32_MAX, as is done
elsewhere).

Change objective C blocks to base::OnceCallbacks. This may end up not
being necessary, but seems a good fit (we will likely need to use weak
pointers for them in the future).

Change-Id: I32a1ef9017a089c26c20132dfc6843a1dbb6ace7
Reviewed-on: https://chromium-review.googlesource.com/991601
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548209}

Bug: 706795
Change-Id: I524a968de6e1d41d920fc8e70dcda0cdf778a380
Reviewed-on: https://chromium-review.googlesource.com/993239Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548208}

Bug: 776495,790130
Change-Id: Ib0e99ee9d6bf22d1ffcfd78e3ae85507368c4de2
Reviewed-on: https://chromium-review.googlesource.com/996409Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548207}

Bug: 827510
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a2f730de3ac0973c826672bfb9486e3630d7292
Reviewed-on: https://chromium-review.googlesource.com/988245Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548206}

Bug: 806996
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5ffa57b0a4231917e3d3a227cb986c8f5a5f3827
Reviewed-on: https://chromium-review.googlesource.com/996313Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548205}

The original version of the test used base::SimpleThread, which uses Chrome TLS
behind the scenes. This ends up tickling a difference between Fuchsia and other
POSIX implementations with respect to the order in which pthread keys are
destroyed.

The new version of the test uses pthread APIs to avoid this, which fixes the
bug.

Change-Id: I8eaf3230a31f96f9ee03afa88a1b7ee8b770bb42
BUG: 828897, 825218
Reviewed-on: https://chromium-review.googlesource.com/996038Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548204}

Bug: 820962
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6fba6413a7ad3668e792efd988304747a0e13701
Reviewed-on: https://chromium-review.googlesource.com/994234Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548203}

All other logging in that file is DVLOG(1), so be consistent

R=satorux@chromium.org

Change-Id: I1c0dc9128cc3c681b6c26dd169fe73a7323af97b
Reviewed-on: https://chromium-review.googlesource.com/975602Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548202}

Only record in OnError if callback_ is still set. Otherwise every
success case will also result in recording "Aborted", via the destructor
of the class calling OnError.

Bug: 712693
Change-Id: I0d73119017b6d88fca4378687d5187ed96919b49
Reviewed-on: https://chromium-review.googlesource.com/994232
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548201}