- 14 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d347b31c0e2e..1a585d5f75ba 2020-11-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia29dec2060b829715d7874f700d8133aa226bb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827567}
-
Alan Screen authored
The TestPrintBackend class has been a minimal implementation of a PrintBackend that could be used in a limited fashion for focused unit tests. It did not behave in a consistent fashion between the various interfaces; for example, setting a new default printer would not be reflected when getting PrinterBasicInfo. The out-of-process print driver feature is intending to use this class in a more general manner, for use of fake printer drivers in browser tests. This makes it desirable to make this class be better behaved. Introduce unit tests specifically for TestPrintBackend, to provide confidence for use by larger browser tests. Ensure that the same mapping of available printers is used across the PrintBackend APIs, so that calls to get printer info or capabilities would be guaranteed available for any printer identified by EnumeratePrinters(). Also ensure that the default printer is kept consistent when the environment is generated or later modified. Updated PrintBackend::PrinterBasicInfo class to have a fully-parameterized constructor and equality operator to assist with unit tests here as well as in the forthcoming tests for later OOPPD changes. Bug: 809738 Change-Id: Ia35e0c99bdb0eba8faa48dfc955d73a816e7d84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463559 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827566}
-
Alexander Dunaev authored
A few views tests are X11-specific, and they were completely skipped for Ozone. Here the skip logic is modified so these tests are no longer skipped for the X11 platform when Ozone is enabled. A helper SkipTestIfNotLinuxX11() function is introduced for convenience. Also GetPlatformName() is renamed to GetPlatformNameForTest(). The method is useful for tests where it lets us skipping tests for certain platforms. Hence renaming it and withdrawing its 'temporary' status. Change-Id: Id53bd92c36eadac11370697706e41bf836dac623 Bug: 1109112, 1109696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532458 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#827565}
-
Bartek Nowierski authored
PartitionDirectMap and AllocNewSlotSpan have been reporting things inconsistently. After this CL, the metrics will have the following (consistent) meaning: 1. total_size_of_super_pages - total virtual address space for normal bucket super pages 2. total_size_of_direct_mapped_pages - total virtual address space for direct map regions 3. total_size_of_committed_pages - total committed pages for slots (doesn't include metadata, bitmaps, or any data outside or regions described in #1 and #2) Change-Id: I1ac1b3044d15b33dcbd506f133d1fe7fa322277f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532542 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827564}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I14e0381d4b0a0f2d6e95029a28b5ffd117fe7d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538314Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827563}
-
Lijin Shen authored
1. Set a max width of message if the width is greater than the max 2. Show/hide container on animation start/end, handled by single action message Bug: 1123947 Change-Id: I72d717bc2d5fe15005c5cbf9c662e08d6357d8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526628 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#827562}
-
Samuel Huang authored
With crrev.com/c/2535582 changing how android-binary-size-generator bot results on gs:// can be invalidated, the "version" field in size config JSON files are no longer needed, and can be remove. This CL needs to wait on the downstream change https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3402103 to land first, to allow template "android_size_bot_config" change. Bug: 1040645 Change-Id: I4a6af0fce816c4994777db09f48a336b60be47b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536853Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#827561}
-
Leo Zhang authored
This will fix an init crash when shared library passes the MainEntry to Chrome Utility process, which is a CFI violation. This requires corresponding changes from decoder side to take effect. TEST=local build Chrome with use_cfi BUG=b:172527471 Change-Id: I6d9584533491be3e1fc489bc592075a49e90c5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537516 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#827560}
-
Emircan Uysaler authored
This CL addresses the crash that occurs when ScenicSurface is destructed before ScenicOverlayView. When that occurs raw pointer held by ScenicOverlayView is invalid, so we should check ScenicSurfaceFactory for a reference instead. Bug: 1148797 Change-Id: I7972a09227e72c212254044f8e6800d50cbe470f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536775 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827559}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605268075-daeeb1bc6080c8b4d9f48b3dab7bc22bf5a02dcb.profdata to chrome-win64-master-1605301167-f6c0732f2f3db66870746c695537723e836403a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7ba9d4850c3f5bdbf48ff0ec829dc2bcf0a9fbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537123Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01909e016604..fb999eb4b31d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141619 Tbr: Change-Id: Ifeef8d0e32b7ec761c0de09f66a365da55a9d5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538553Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827557}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iaf3557bdbe4a4e0fb1a8e68ad90b6b578a5e9d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538554Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f42a94a7f50d..ed95a75961bf 2020-11-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5cee6c65..482b6a1c (827322:827429) 2020-11-13 natim@webrtc.org VoipVolumeControl subAPI for VoIP API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I50b59c4e50add84dcca5951e97d81debea3227f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538498Reviewed-by:
-
Liquan (Max) Gu authored
This CL splits CPRService#retry() into two parts. The common part goes into PRService, while the Chrome specific part is left in CPRService. Bug: 1131059 Change-Id: I9a90c53f109c7f5224129904f3af22f92bcadf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536854 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827554}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 88b177ae. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: If0f1551a0c9bb8661fa85a9646dd448971b03d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537587Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827553}
-
Dave Tapuska authored
Move these testing APIs into the base implementation. BUG=1097816 Change-Id: I4e476c9d150cc204692bedf82d577c5e4909051c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536980 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827552}
-
Ken Rockot authored
ContentBrowserClient::WillStartServiceManager exists exclusively to initialize some Audio Service policy state very early in browser lifetime. This was necessary at one point because the Service Manager was a prerequisite for various service bits to be configured, and Service Manager bringup happens very early in startup. Because the Service Manager is no longer used to host the Audio Service, the service is free to manage its own configuration independently. It can instead now query the sandboxing policy on-demand when launching the service process, eliminating any need for a ContentBrowserClient API. This also deletes the unused ShouldTerminateOnServiceQuit ContentBrowserClient API, as well as its supporting code within Service Manager. Bug: 977637 Change-Id: I3fa148cf4ceb9bb26f56e2b736d20a6cce2170dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538333 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827551}
-
Xiaocheng Hu authored
This patch implements the parsing of the descriptors of @counter-style following spec: https://drafts.csswg.org/css-counter-styles-3/#the-counter-style-rule WPT verifying the parsing is also added. Bug: 687225 Change-Id: Ifecdfbdfb9efcb330453d0059a0f1e73c0f3e662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530523Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827550}
-
Alexander Cooper authored
This flag allows us to configure OpenXR features which, though shipped on Android/ARCore may not be ready to be shipped on Desktop/OpenXR, due to the slightly different permissions, or due to an inability for us to actually test on real hardware. Change-Id: I985f2e17119185053539f6c2671695c57081c24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537584Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#827549}
-
zhiyuancai authored
Add an item "Track prices" to the tab switcher toolbar menu. This CL only handles adding this item, and does not add the response part when clicking this item. Bug: 1144742 Change-Id: I01baa8961158b39216e790b99113d6dab980c1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518830 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#827548}
-
Sam Fortiner authored
The max overlap for fixed feature (crrev.com/766618) had an assumption that the overlap testing rect, as computed by BoundingBoxForCompositingOverlapTest, is in viewport space and includes the area that a fixed-pos layer can occupy given any valid scroll offset. This expansion was limited to just the fixed-pos layer and did not include out-of-flow composited children of the fixed-pos layer. This decision to use viewport space for the expanded rect caused an unrecognized embedding of the scroll offset into the rect position at compositing inputs time when the expanded bounding rect was computed. The dependency on scroll offset could cause incorrect overlap test results when the scroll offset changed and overlap testing re-ran without a compositing inputs update. This was addressed by moving the fixed-pos layer's expanded bounds to absolute space in crrev.com/807955. However, this later revision also caused the children of a fixed-pos element to change from storing their unexpanded overlap test bounding rects in viewport space to storing them in absolute space without expanding their bounds or otherwise compensating for no compositing inputs update on scroll offset. This effectively introduced a dependency on the scroll offset at bounds computation time for children of fixed-pos, leading to crbug.com/1137974 due to incorrect overlap testing results. This was addressed in m87 by reverting revision crrev.com/807955. This change addresses the issue in a different way. The new approach is as follows: 1. Fixed-pos (and their children) compute non-expanded bounds instead of expanded bounds in BoundingBoxForCompositingOverlapTest, now renamed to LocalBoundingBoxForCompositingOverlapTest. These bounds, for fixed-pos layers, are kept in viewport coords when stored on AncestorDependentCompositingInputs, keeping them scrolloffset agnostics as cached. Additionally, by avoiding expanding the bounds, the return values from (un)ClippedAbsoluteBoundingBox are no longer expanded. These return values are used by layer squashing sparsity calculations, meaning this change reverts that calculation to its previous behavior before the MaxOverlapBoundsForFixed feature was introduced. 2. Conversion to absolute coords and expansion happens at overlap testing time, instead of compositing inputs update time, avoiding the problem that was attempted to be addressed via crrev.com/807955. Additionally, children of fixed-pos elements are also converted from viewport to absolute space during overlap testing, avoiding the issue found in crbug.com/1137974. 3. Only the top-most fixed-pos element expands its bounds. Without this limitation, children of a fixed-pos element would also expand their bounds and could detect overlap with siblings that they couldn't actually overlap with. E.g. two absolutely positioned siblings with a common fixed-pos ancestor do not need to expand their bounds to determine if they can overlap. 4. Because of the change in number 3, it becomes important that the fixed-pos layer's bound for overlap includes all that area covered by the fixed-pos layer and any of its children that may have their own composition layer. Without this consideration, it's possible for a child to extend beyond the fixed-pos expanded bounds and not cause something to composite due to overlap even though it intersects when scroll offsets change. This would be fixed on a lifecycle update that re-ran compositing with the new scroll offsets, but is still incorrect behavior. To address this issue, the overlap testing bounds for the top-most fixed-pos layer is expanded to include its composited stacking children. All of these cases also have tests added to validate them. Bug: 1124753 Change-Id: I42b22892fb0040bde8cbabb7c85fe30f71f4ee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522407Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827547}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605290311-c0a8bccef266e50cf7d2fe9fae22d951549688a8.profdata to chrome-linux-master-1605311889-6aa079e52bcacb107b5b307931590de3ab576ff9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I827b4fc2fa57673e692bbc0eef000f4ddadde020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538552Reviewed-by:
-
Michael Hansen authored
A recent CL (crrev.com/c/2258897) updates the behavior of the <dialog> element. This adds CSS rules for the <dialog> element within cr-dialog to remove a resulting gray border. Fixed: 1148118 Change-Id: I6e6235f0202574374b184528810afe52b9f2d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538530Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#827545}
-
bttk authored
This lets us remove LocationBar#updateMicButtonState() which was a "poke" method on the interface. Do not submit before M88 branch point (Nov 12th) Bug: 1142883 Change-Id: If7564ac95e6ca69e28e6de7a609f0db9fa916c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518202 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827544}
-
Scott Violet authored
Removes unnecessary jni args. BUG=none TEST=none Change-Id: I19444fe8736577ac4544b0f3773ec20ffd678fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538284Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#827543}
-
Curt Clemens authored
The <nearby-device> items inside the <iron-list> of share targets on the discovery page weren't getting styled correctly on selection because their is-selected property wasn't getting set with the right value by the binding. This had to do with changes to the order in which the bindings update introduced when this list was moved into a dom-if. The list is also now aligned to the top of its div. It was mistakenly aligned to the center when the placeholder text was introduced, which had to be centered. Bug: b/163036847 Change-Id: I80798c02088f223ab3e76f2ac5797fb92a2522e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537999 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
-
Dale Curtis authored
This is required for WebCodecs and others to actually be able to get the last few frames out of the encoder. Note: A followup CL will actually enable hardware encoding on macOS once MojoVEA::Flush() support has landed. R=eugene Bug: 1110279 Test: Layout tests now pass. Change-Id: I9e1c7fa94e69c3214dcb92ea21157ec4bc267873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536353 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827541}
-
Yusuf Sengul authored
Bug: 1143836 Change-Id: I0c787bf1c663b28d94e67c8015910dbcb48a4779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508633 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#827540}
-
Thomas Lukaszewicz authored
This CL removes the default clear search icon that appears in Tab Search's input field to align with other search field examples in top chrome (Omnibox) and the NTP's WebUI Realbox. Before: https://drive.google.com/file/d/1Ts4JBBdPqD1IvNvD181VQVYFFm9bH4Kd/view?usp=sharing After: https://drive.google.com/file/d/1EYvqbL6OFB-672unHwZCIa21s6adAhvo/view?usp=sharing Bug: 1147817 Change-Id: Ie8333ce6797e0ece91827af7cb1eaba521175d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536139Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827539}
-
Hiroshige Hayashizaki authored
DedicatedWorker version of WPTs added in: https://chromium-review.googlesource.com/c/chromium/src/+/2046803 https://github.com/web-platform-tests/wpt/pull/21836 Bug: None Change-Id: Ic18e09f7855bc234b6179ae24b54a8d0473551aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462910 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#827538}
-
Gavin Williams authored
Clicking the cancel button tells the scanner to cancel the currently active scan job and immediately switches the UI back to ready state. In a future update, a "Canceling Scan" UI will be shown when the cancel button is clicked. http://screen/73tpTmXpt8ALqR6 Bug: 1059779 Change-Id: I0aa8df9e85ad56e2b2c6e15318448e25ef95ee5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533894 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#827537}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making WakeLock a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.wakeLock getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I7a56f1e71d6c8ec3e45bf163d726f8035b8cc70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537919 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#827536}
-
Gavin Williams authored
This change adds CancelScan to the Scanning mojo then calls it from ScanService. In ScanService, when the cancel completes and OnCancelCompleted is called, OnScanCompleted will not be called afterwards. And the same vice versa, if a cancel is requested but the scan finishes first and calls OnScanCompleted, we will not then call OnCancelCompleted. Bug: 1059779 Change-Id: Iabea43d9498f41d3f42633c2ac8601f27f3ec81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533193 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827535}
-
Hiroshige Hayashizaki authored
This CL adds WPT tests for: - Cross-origin importScripts() from classic service workers - Cross-origin static imports from module workers - Redirecting static imports from module workers - Failing on service workers on Chromium, while redirecting importScripts() also fails on Chromium due to https://crbug.com/889798. Bug: 1136767, 889798 Change-Id: I318275c7772ab2854c972774f5ba49ca22f0018a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463046 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: -
Khushal authored
This reverts commit c8c22806. Reason for revert: crbug.com/1144660 Original change's description: > gpu: Disable SurfaceControl on Samsung devices running Q. > > A platform bug can result in transaction acks getting dropped which > stalls all rendering. A fix for this will be released in an R update > soon so this changes disables using this API in Q. > > This also reverts an earlier workaround which was added for samsung dex > mode since its not necessary after this change. > > TBR=skyostil@chromium.org > > Bug: 1131081 > Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820511} TBR=nyquist@chromium.org,boliu@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1131081 Change-Id: I55a3a9e8329b062ffbd506650fd7aca483172908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538417 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827533}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and remove warning exemption Bug: 999886 Test: no errors building Change-Id: I0814e4c543eb7f6d25bb0dfc1990b30e0b0c2f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468299 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827532}
-
Clark DuVall authored
The nacl_test_data targets don't like deps on //base, so had to remove the #include from //base in pm_exit_status_test.cc. Bug: 949535 Change-Id: I9cbdd63dca2eb1147013d6747c265f3f3fe9916a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538042 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827531}
-
Clark DuVall authored
This is a reland of 858c31cc Pinpoint run: https://pinpoint-dot-chromeperf.appspot.com/job/17304503520000 Original change's description: > Use weblayerStartupMetric for system_health.weblayer_startup > > The metric was split out of the WebView version, so we should use this > now for WebLayer startup tests. > > Pinpoint job running: > https://pinpoint-dot-chromeperf.appspot.com/job/104b30a9520000 > > Bug: 1146438 > Change-Id: I9938614b94740a3222fb832ab994427b136bf1d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536797 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827339} Bug: 1146438 Change-Id: Ib12e05489961e32ecdaef110db3e0cbbea9294a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538252Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827530}
-
Sinan Sahin authored
Bug: 1137941 Change-Id: I1d9f7291f8ca5388667687d4bc2e5839837d3c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530199 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
-
S. Ganesh authored
This CL uses the feature added in Issue 1109612 to change all Updater COM Classes to have dynamic guids. Bug: 1148167 Change-Id: I8026a251e5cdc51692b4b37f76407c2fa67bd33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533865 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827528}
-
