- 23 Jan, 2020 40 commits
-
-
rbpotter authored
Autogenerate Polymer 3 versions of CrScrollableBehavior and its tests. This will be used by the chrome://settings page in future. Bug: 1042558 Change-Id: I13d0a675f2f11cd3ff31a6c9c57948a3e9ad386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014146Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#734595}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: Ibd527aec0c2d739bb73ff4d4d6d65cc5e2452ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017323 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734594}
-
Sebastien Lalancette authored
Change-Id: Icb43c0914edbae4d6920aefd3e0b36b6bf574429 Adding all bugs that pointed to these flaky tests. When fixing a flaky test, don't revert this change. Simple re-enable the stable test by removing the individual line from TestExpectations. Using chenwilliam as TBR as most of these tests are devtools related. TBR=chenwilliam@chromium.org Bug: 1043396 Bug: 1043381 Bug: 1043356 Bug: 1043354 Bug: 1043350 Bug: 1043310 Bug: 1043285 Bug: 1043398 Bug: 1043434 Bug: 1043449 Bug: 1043453 Bug: 1043454 Bug: 1043463 Bug: 1043488 Bug: 1043785 Bug: 1043792 Bug: 1043796 Bug: 1043893 Bug: 1043920 Bug: 1044350 Bug: 1044414 Bug: 1044415 Bug: 1044424 Bug: 1044425 Bug: 1044429 Bug: 1044430 Bug: 1044433 Bug: 1044454 Bug: 1044459 Bug: 1044505 Bug: 1044506 Bug: 1044516 Bug: 1044518 Bug: 1044519 Bug: 1044534 Bug: 1044538 Bug: 1044544 Bug: 1044545 Bug: 1044546 Bug: 1044561 Bug: 1044562 Bug: 1044563 Bug: 1044805 Bug: 1044822 Bug: 1044823 Bug: 1044825 Bug: 1044829 Bug: 1044830 Bug: 1043847 Bug: 1043901 Bug: 1044569 Bug: 1044535 Bug: 1044496 Bug: 1044418 Change-Id: Icb43c0914edbae4d6920aefd3e0b36b6bf574429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016857 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734593}
-
Gabriel Charette authored
R=fdoray@chromium.org, robliao@chromium.org, skyostil@chromium.org Bug: None Change-Id: I4db3f25779387307f85d01cff2f9dd1d53b08051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015180Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#734592}
-
Devlin Cronin authored
Instead of passing BucketMapper as a raw pointer and then taking ownership by wrapping it in a unique_ptr, pass it in as a unique_ptr directly. Bug: None Change-Id: I3357fe432651c9dcd7884d6f6d7e76040c70d806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015631Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734591}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I7d260c4e46fdfdcf445ee7a748250f41568c30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017485 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
This closely matches Android Download Manager's UI with the exception of skipping the "% downloaded" part since it seemed redundant with the progress bar. The embedder can disable the UI if they choose. The few UI strings need to be translated. The button strings can be reused from Chrome, but we need to figure out what the rest of the text should say and add translations if they're not shared. Bug: 1025603 Change-Id: I61ba3b821c417de13191a67a85487b61b5f9c86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002980Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#734589}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I5fe3c2717a2c4493756176dc5d2443ab87efd342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015253 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit 95d61b40. Reason for revert: This change introduced flakiness, as identified by Findit. Bug: 1045112 TBR=avi@chromium.org Original change's description: > Revert "Revert "Enable system perfetto producer on all posix builds."" > > This reverts commit 92ff17fd. > > Reason for revert: Keep SMB around forever. > > TBR=avi@chromium.org > > Change-Id: Ifc811f7aa420dc63a80dc62cb292c16e5fd40bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014930 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734465} TBR=avi@chromium.org,eseckler@chromium.org,findit-for-me@appspot.gserviceaccount.com,nuskos@chromium.org Change-Id: I0110f5bdd18c1789c635bf13a4c483e9c39502dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015409Reviewed-by:
-
Chris Harrelson authored
In such cases, the chosen anchor may change arbitrarily. Bug: 924256 Change-Id: I3f304450c59bc3e27b93089469d6fbee68a166e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008617Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734586}
-
Will Cassella authored
Clangd generates error messages for any files that include 'third_party/blink/renderer/core/style/computed_style_constants.h' due to it using the `|` operator between two instances of `InternalGridAutoFlowAlgorithm` and `InternalGridAutoFlowDirection`. Super annoying, so this CL explicitly casts them to integers to fix that. Change-Id: I79cc9f263ebfb8bd8ee5902741e857dac77138d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015550Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#734585}
-
Takumi Fujimoto authored
Set the expiry date of all the Media Router metrics to be a year from now, so that we wouldn't be getting pinged throughout the year for expiries. We expect all the metrics to be relevant for some time -- none of the metrics are only for components that we're retiring, like the extension Cast MRP. Bug: 1037602 Change-Id: I3ca59f3eaa9924f0beb24f817715b0d6f31c9eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012907Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#734584}
-
llin@chromium.org authored
Histogram recorded to understand user clicks with result type and duration between result fetch finish and user clicks: * QuickAnswers.Click (enum="QuickAnswersResultType") * QuickAnswers.Click.Duration - Aggregated duration across result types * QuickAnswers.Click.Duration.[result type] - Duration for each result type The result type is something like "UnitConversion". Bug: 1044413 Test: Manual Change-Id: I8fa8e9852400bf4945a576639724a3479488bdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969744Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734583}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b04d7c55bff1..e504fd6a5f25 git log b04d7c55bff1..e504fd6a5f25 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 aerotwist@chromium.org [Global] Updates refs to SDK.consoleModel 2020-01-23 almuthanna@chromium.org Remove tests that access private attributes 2020-01-23 aerotwist@chromium.org [Global] Update refs to UI.inspectorView Created with: gclient setdep -r src/third_party/devtools-frontend/src@e504fd6a5f25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8206933368b7411155750c9d3956f086fda20462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016336Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734582}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: Iaf4eb9527cdb075ddf9074e6efd7dfd7213cb9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014979 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ian Struiksma authored
A few other autofill tests that weren't explicitly called out in the initial bug have the same issue it seems, so filtering these out as well: AutofillRestrictUnownedFieldsTest AutofillCreditCardInteractiveTest AutofillInteractiveIsolationTest AutofillInteractiveTestWithHistogramTester Bug: 967588 Change-Id: I4bdace0563dbc80c492cf16bd7c6b370eb27c727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016341 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734580}
-
Brian Sheedy authored
This reverts commit e3ada6ea. Reason for revert: Workaround does not fully work. Original change's description: > Switch CrOS expectation to retry > > Switches the expectation for > conformance/textures/misc/texture-size-limit.html from "Skip" to > "RetryOnFailure", as the issue the test was causing for subsequent tests > has been worked around. > > TBR=ynovikov@chromium.org > > Bug: 1043953 > Change-Id: Iff573b37d981c8777e8373ebd8fd025ee2beac3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015982 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734330} TBR=ynovikov@chromium.org,bsheedy@chromium.org Change-Id: I4e41b33af4b79527e729306ef699edbd83e08a9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017089Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734579}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4101efae107..00bf4462314d Created with: gclient setdep -r src-internal@00bf4462314d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If71a52b448f35f9b90e1fb6d6b7e9cd3b9e8dbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016333Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734578}
-
Theresa Wellington authored
BUG=1003939 Change-Id: I78c6072c806e93a366dd3d5f10cf2c1b2029332a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016881Reviewed-by:
-
Ben Smith authored
It has been enabled by default on desktop for a while now. The feature is still required, since SharedArrayBuffer is still not enabled by default on Android. Bug: 821270 Change-Id: Ie58c4bb4118648391f533f310a8f093f9fa4e19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015564Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#734576}
-
Dan Harrington authored
- Restructure to match chrome/browser/java/res - Replace strings with references to existing .grd strings - I kept Piet resources separate, since piet may eventually be moved into a different library. - Move feed/library sources into chrome_java Strings changed: snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions snackbar_fetch_failed -> ntp_suggestions_fetch_failed snackbar_default_action -> undo It looks like chromium's strings are translated to more languages, so this might provide better localization. Some of these strings are translated differently between feed and zine. Bug: 1024945 Change-Id: If9862a4965756e28ba812bf315556d6b8db09e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956275Reviewed-by:Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#734575}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I402bf098fad7e7266b8e312ca013a8e375639bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016652 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Joshua Berenhaus authored
This is the first step to enabling the ukm service to reset the ukm client id when a cloned install is detected. By moving the responsibility of the pref, both services can call in to understand if we are in a cloned state. Bug: 981407 Change-Id: I0a27bc0f14f5458cf685ff5abf7ea792e73246d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992009 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734573}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jeffreycohen@chromium.org Bug: 1042208 Change-Id: Ib396345f37691f2b87d6596c5c96ce50ee913442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015091 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734572}
-
Ryan Daum authored
Now that internal is always passing this value it's safe to remove the default nullptr to avoid any possible future regressions for webview window corner placement. Bug: none Test: manual Change-Id: I465c888bc07eb6d339969ca0eefd8efdcc770df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016284Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#734571}
-
Toni Barzic authored
This is a reland of 97dfeb90 Original change was not the culprit for TabletModeControllerTest.VerticalHingeTest crashes on MSan bots (for which it was reverted). Original change's description: > Prepare shelf layout manager for shutdown earlier > > Starts shelf layout manager shutdown earlier at the beginning of shell > shutdown sequence (during OnShellDestroying call issued to shell > observers when the shell tear down starts). > > The main goal is to prevent shelf state updates that might happen during > shutdown. For example, tablet mode controller destruction, and overview > controller destruction might cause window stacking changes, that in > turn can cause shelf state updates - both of which happen before > Shell::CloseAllRootWindowChildWindows(), which is from where > ShelfLayoutManager::PrepareForShutdown is currently called (with some > indirection). > > NOTE: Calls to start shelf shutdown issued from > RootWindowController::CloseChildWindows() are kept around to handle root > window controller shutdowns that happen outside shell shutdown. > > BUG=1033343 > > Change-Id: I86211392b45bdafd5f095bd60c774fe88e8accce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015358 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734253} Bug: 1033343 Change-Id: I1d5535e7d2a0a35d5ec59e7755588d3745caae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016289Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.39-1578912426-benchmark-81.0.4019.0-r1 to 81-4025.0-1579517934-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic95aee3f1d0bb1ac3d27c483a06809aba331156d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017648Reviewed-by:
-
Armando Miraglia authored
This histogram are related to OutputController and are used to monitor how the lifetime of audio output controllers. For debugging and analysis of the audio pipeline we need such histograms indefinitely. Fixed: 1037594 Change-Id: I01ecbafa8fc6c549764114d0109bbdc0278b92e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012342Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I5511f8af83fe19a3df0a21071792650766b6d49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017224 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
yilkal authored
This CL makes sure that navigation has committed in SupervisedUserNavigationObserver::DidFinishNavigation before trying to access the RenderFrameHost that hosted the navigation. Bug: 1042620 Change-Id: I8258023537c769338c82e54927d38107759b1db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008317Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734566}
-
Anupam Snigdha authored
Previously we used to report the client rectangle instead of actual control bounds of the focused editable element. With this change, we are fetching this data from the focused editable element's bounding client rect and sending this info to TSF. Bug: 1043424 Change-Id: I20e18e3ec4e861311636ced9dc97d0a82f49838d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008774 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#734565}
-
Fernando Serboncini authored
Bug: 1044993 Change-Id: I14c8c09b04aba9c2e81f76792f6f9f9a8e7fbd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017042 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734564}
-
Trent Begin authored
Add TimezoneInfo to mojom file to keep it in sync with Chrome OS. Bug: 1030361 Test: browser_tests --gtest_filter=DeviceStatus* && chromeos_unittests Change-Id: Ide7cf1bdd7dcb1b17369125048bb4742298a14bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013218 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734563}
-
Jan Wilken Dörrie authored
This change adds a JNI bridge for the BiometricAuthenticator and implements BiometricAuthenticator::CanAuthenticate() in a backwards compatible way. Bug: 1031483 Change-Id: I273aa655879c4abfb0afedd841744a53f914c71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012024 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#734562}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: I1af5ea914f2e4ffef7069f53f984c8d69cb99eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015607Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734561}
-
Avery Musbach authored
Bug: None Change-Id: I51a8ef2deb6f9c569e03dd6d8680e896c7a24ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016340Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#734560}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cdd73e095cd4..48655cfdbfd9 git log cdd73e095cd4..48655cfdbfd9 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 minyue@webrtc.org Send absolute capture time through audio coding module. Created with: gclient setdep -r src/third_party/webrtc@48655cfdbfd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic3049f1ff76f02183d8114802cccce6f529d7539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016332Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 960116 Change-Id: I2e6868f2ec1873273614cfe1ae902714dd882df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015572 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#734558}
-
Sebastien Lalancette authored
This reverts commit 8fd76b23. Reason for revert: Failing on bots. Bug: 1045071 Original change's description: > Add browser tests for smart card SAML login > > Provide test coverage for the scenario where a new user authenticates > via SAML using a smart card (or, generally speaking, using a security > token via an extension using the chrome.certificateProvider API). > > This also provides some test coverage for the <security-token-pin> > Polymer element used on the Login Screen. > > Bug: 1033936 > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734510} TBR=antrim@chromium.org,alemate@chromium.org,emaxx@chromium.org,hendrich@chromium.org,fabiansommer@google.com Change-Id: Ibfff9d60cd3ed0d2470435e67b3fd563c98c888a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016971Reviewed-by:
-
Robert Sesek authored
Bug: 1042912 Change-Id: I64b0e5c0e9f6c36e9fdb7dd7d766e6a78a5f5734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015364 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734556}
-
