GitLab

BUG=481290
TBR=chirantan@chromium.org

Review URL: https://codereview.chromium.org/1107733007

Cr-Commit-Position: refs/heads/master@{#326951}

BUG=481286
TBR=davidben@chromium.org

Review URL: https://codereview.chromium.org/1100563003

Cr-Commit-Position: refs/heads/master@{#326950}

Looks like C++ compiler is able to figure out that this function is on
base namespace by deducing this from the dependent type base::MD5Digest.

For more reference on ADL:
http://en.wikipedia.org/wiki/Argument-dependent_name_lookup
http://stackoverflow.com/questions/8111677/what-is-argument-dependent-lookup-aka-adl-or-koenig-lookup

I found this while doing https://codereview.chromium.org/1099453002/.

The error is like the following:

../../chrome/browser/drive/drive_api_util.cc:171:10: error: use of
undeclared identifier 'MD5DigestToBase16'; did you mean
'base::MD5DigestToBase16'?
  return MD5DigestToBase16(digest);
           ^~~~~~~~~~~~~~~~~
           base::MD5DigestToBase16

Log:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/81070/steps/compile/logs/stdio

BUG=None
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/1088593005

Cr-Commit-Position: refs/heads/master@{#326949}

Previously most of the GN bots were explicitly building
"all", which is a lot more than we build on the (non-clobber)
GYP bots.

This patch syncs the lists so that we build the same targets the
GYP bots build as much as possible (in some cases the targets
don't work yet for GYP).

This also will workaround a bug in MB where building "all" bypasses
analyze.

R=phajdan.jr@chromium.org
BUG=461019,480643
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1106853002

Cr-Commit-Position: refs/heads/master@{#326948}

the same method that sends the request.

BUG=471928

Review URL: https://codereview.chromium.org/1049873007

Cr-Commit-Position: refs/heads/master@{#326947}

At the moment it CHECKs on false return from base::i18n::InitalizeICU.
Try to locate it to a particular failure in that function to have a
better idea what's failing.

R=jshin@chromium.org
BUG=445616

Review URL: https://codereview.chromium.org/1076623004

Cr-Commit-Position: refs/heads/master@{#326946}

When users pinch in Reader Mode, the page would zoom in or out as if it
is a normal web page allowing user-zoom. At the end of pinch gesture, the
page would do text reflow. These pinch-to-zoom and text reflow effects
are not native, but are emulated using CSS and JavaScript.

In order to achieve near-native zooming and panning frame rate, fake 3D
transform is used so that the layer doesn't repaint for each frame.

After the text reflow, the web content shown in the viewport should
roughly be the same paragraph before zooming.

The control point of font size is the html element, so that both "em" and
"rem" are adjusted. Accordingly, font size of body is no longer specified
in CSS in unit of pixel.

Some CSS styles and animations are updated to fix issues specific to
resizing.

BUG=445632

Review URL: https://codereview.chromium.org/1009703002

Cr-Commit-Position: refs/heads/master@{#326945}

Tasks without initial URLs weren't being counted as legitimate Tabs,
preventing them from being restored properly.

BUG=481109

Review URL: https://codereview.chromium.org/1109543003

Cr-Commit-Position: refs/heads/master@{#326944}

Try NtDuplicateObject instead of DuplicateHandle on Windows 8/8.1 for debugging AppContainer related failures.
This patch should be reverted as soon as we get some confirmation that NtDuplicateObject is working better compared to DuplicateHandle.
Theory behind this patch is that it might be possible that on machines which reporting this find of failure have some software like AV which might be intercepting calls to DuplciateHandle and may be failing somewhere in intercepted code path due to AppContainer.
Looking in IDA error code that we are receiving 0xC0000023 (Which translates INSUFFICIENT_BUFFER (0x7a) in win32 language) doesn't seem to be in NtDuplicateObject code path (At least not found easily.).

BUG=468922
R=jschuh@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1101913002

Cr-Commit-Position: refs/heads/master@{#326943}

Prior to this CL, if there were multiple targets ina GN build
with the name 'unit_tests', we would not generate a top-level
phony ninja target for them; you would have to specify either
the full path to the output or the label name.

This is confusing for things like 'browser_tests' and 'unit_tests',
where in Chromium we might have multiple targets with that name,
but only one of those is an executable (at least in the default
toolchain).

This CL adds logic to handle that case (so that 'unit_tests' does work).

R=brettw@chromium.org
BUG=480042

Review URL: https://codereview.chromium.org/1101323005

Cr-Commit-Position: refs/heads/master@{#326942}

This patch initializes one of the variables that is used in the fake
tiling client.

R=danakj

Review URL: https://codereview.chromium.org/1102133002

Cr-Commit-Position: refs/heads/master@{#326941}

base::ResetAndReturn() makes code shorter and simpler. Also in several
places callbacks were Reset() after Run(), which is dangerous for
callback that are allowed to delete the caller. base::ResetAndReturn()
helps to avoid this issue.

Review URL: https://codereview.chromium.org/1064863004

Cr-Commit-Position: refs/heads/master@{#326940}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d8992d97..9432a893

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1095203009

Cr-Commit-Position: refs/heads/master@{#326939}

Chromium provides PowerObserver and PowerMonitor objects to allow
subsystems to react to power suspend and resume events. On iOS this
actually tracks app lifecycle events for backgrounding.

The patch adds a power observer that destroys the compression session
on power suspend events and re-initializes the compression session on
power resume events. This allows the encoder to properly transition to
the background on iOS and resume when the app comes back to the
foreground.

Note that for this to work overall, the sender client must create a
background task to allow networking to continue. Otherwise the receiver
will timeout per spec.

R=miu@chromium.org
BUG=477895

Review URL: https://codereview.chromium.org/1094403002

Cr-Commit-Position: refs/heads/master@{#326938}

The native parts of dom_distiller will try to register jni methods on
startup. This fails if the apk doesn't contain the corresponding java
bits. So, even though chrome_shell_apk doesn't actually use the java
stuff in dom_distiller_content_java, it still needs to depend on it and
include it in the apk.

Review URL: https://codereview.chromium.org/1090153007

Cr-Commit-Position: refs/heads/master@{#326937}

BUG=452452

Review URL: https://codereview.chromium.org/1093153002

Cr-Commit-Position: refs/heads/master@{#326936}

BUG=b/19899195

Review URL: https://codereview.chromium.org/1073003005

Cr-Commit-Position: refs/heads/master@{#326935}

TBR=bruening@chromium.org,sebmarchand@chromium.org
BUG=481231

Review URL: https://codereview.chromium.org/1105523006

Cr-Commit-Position: refs/heads/master@{#326934}

ExtensionApiTest.Bookmarks
 was adding one bookmark per timer callback; changed to use an event test.
WindowOpenPanelTest.WindowOpenPanel was relying on the callback supplied to chrome.windows.create happening before the resource was actually loaded, when there's no such guarantee.

R=kalman
BUG=424661,253417,383452

Review URL: https://codereview.chromium.org/1094383005

Cr-Commit-Position: refs/heads/master@{#326933}

and associated field trial and delete unused strings.

While at it, rename
IDS_OMNIBOX_EMPTY_HINT_WITH_DEFAULT_SEARCH_PROVIDER
to
IDS_SEARCH_BOX_EMPTY_HINT_WITH_DEFAULT_SEARCH_PROVIDER

TBR=kmadhusu
(for trivial rename change in chrome/browser/search/...)

BUG=447809

Review URL: https://codereview.chromium.org/1104513003

Cr-Commit-Position: refs/heads/master@{#326932}

crrev.com/318812 switched our latency metrics from using
the end of GPU swap to the beginning. The abrupt switch
makes it difficult to compare latency in M43 to previous
versions.

This patch restores the old behavior for the existing
latency metrics and adds new metrics instead for the
new behavior.

Only UMA is affected. The abrupt switch for telemetry
remains in place.

BUG=476213

Review URL: https://codereview.chromium.org/1093923002

Cr-Commit-Position: refs/heads/master@{#326931}

This addresses code review comments from https://codereview.chromium.org/1104703004

TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1106843003

Cr-Commit-Position: refs/heads/master@{#326930}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d96fd0c..8440baa

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1095333005

Cr-Commit-Position: refs/heads/master@{#326929}

Layout tests can choose a frame by name to navigate, using
testRunner.queueLoad(url, name).  This frame should be
found in the browser process rather than RenderFrameImpl.

This is useful cleanup in general, but also makes it possible
for layout tests to target OOPIFs.

TBR=dcheng,sky
BUG=477150
TEST=Layout tests continue to pass

Review URL: https://codereview.chromium.org/1104603002

Cr-Commit-Position: refs/heads/master@{#326928}

From spec change:
Merge pull request #102 from jyasskin/contiguous-idl
https://github.com/WebBluetoothCG/web-bluetooth/commit/ffbd7c14b45d3db0be139fc0f106c9721a1be13a

Review URL: https://codereview.chromium.org/1108503002

Cr-Commit-Position: refs/heads/master@{#326927}

Prior to this CL, clicking cancel on the connecting dialog simply
returns the user to the home screen, without disconnecting the session or
cleaning up any related resources.

This CL provides a cleaner way to cancel a session with by implementing
remoting.ConnectingDialog which calls stop() on the activity.

BUG=477522

Review URL: https://codereview.chromium.org/1101613003

Cr-Commit-Position: refs/heads/master@{#326926}

We want to change activate so that rejecting the waitUntil promise
is the same as resolving it. Adding UMA to get an idea of the impact
of the change. It could be useful to have this data anyway, so also
adding it for Install.

BUG=480050

Review URL: https://codereview.chromium.org/1098953005

Cr-Commit-Position: refs/heads/master@{#326925}

Replace them with CapturedNetLogEntry.

BUG=none
TBR=bengr@chromium.org

Review URL: https://codereview.chromium.org/1109473003

Cr-Commit-Position: refs/heads/master@{#326924}

This adds SERVICE_WORKER_ERROR_DISK_CACHE to indicate
failure to read from the disk cache. It also re-enables
logging of StartWorker for redundant workers. This was
previously disabled because we got a lot of "failed" spam
for updates that get aborted when there is no script change,
so I've changed StartWorker to fail with SW_ERROR_EXISTS in
that case.

This patch is a step in the direction of evicting a SW
that can't be read from disk cache.

BUG=448003

Review URL: https://codereview.chromium.org/1054033004

Cr-Commit-Position: refs/heads/master@{#326923}

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1098253006

Cr-Commit-Position: refs/heads/master@{#326922}

BUG=481210
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/1090863005

Cr-Commit-Position: refs/heads/master@{#326921}

Tags "q" and "cite" were invisible in dark theme.

BUG=480646

Review URL: https://codereview.chromium.org/1054503003

Cr-Commit-Position: refs/heads/master@{#326920}

To bring in layout fix to display layer debug info in frame viewer tracing.

Summary of changes available at:
https://chromium.googlesource.com/external/trace-viewer/+log/f8f4efb..bd416ea

bd416ea  More min-height fixes
3e04994  Move RAIL scoring to rail_socre.html
35c48d0  Change pre-commit hooks to pre-submit hooks
6675831  Aggregate MemoryDumpAllocator attributes
4bf2eab  Update memory_dumps.json to use generic attributes
957fe59  Allow generic attributes of MemoryAllocatorDump objects
cbde6af  Quick fix for #930
a74372e  More min-height flexbox changes
38be559  Click & drag down from ruler to draw guide line and generate nav string
24e160f  Infer implicit ancestor memory allocator dumps in TraceEventImporter
078b908  tquery: Don't use polymer for non-visual classes

Size decrease for resources.pak:
60627 bytes (16666772 -> 16606145)

BUG=480554

Review URL: https://codereview.chromium.org/1086873006

Cr-Commit-Position: refs/heads/master@{#326919}

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1051763008

Cr-Commit-Position: refs/heads/master@{#326918}

This custom polymer element shows a list of media-router-sink elements. It is styled after the current cast extension's sinks.

BUG=464222

Review URL: https://codereview.chromium.org/1099723003

Cr-Commit-Position: refs/heads/master@{#326917}

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1095333004

Cr-Commit-Position: refs/heads/master@{#326916}

Debugging some tests that were unblocked by codereview.chromium.org/1084793002, I found that waiting for the password field to disappear sometimes fails. We need to wait for the OOBE page to disappear before continuing to the test logic.

BUG=480571

Review URL: https://codereview.chromium.org/1063853008

Cr-Commit-Position: refs/heads/master@{#326915}

Revert of [Android] Add an out-of-app instrumentation driver APK. (patchset #15 id:280001 of https://codereview.chromium.org/1034053002/)

Reason for revert:
Broke the "Android" bot:

http://build.chromium.org/p/chromium/builders/Android/builds/38661

Original issue's description:
> [Android] Add an out-of-app instrumentation driver APK.
>
> BUG=444049
>
> Committed: https://crrev.com/79d22ed2b74d0ff1082f6febfd3fd93c0574d130
> Cr-Commit-Position: refs/heads/master@{#326900}

TBR=tedchoc@chromium.org,klundberg@chromium.org,yfriedman@chromium.org,thestig@chromium.org,cjhopman@chromium.org,torne@chromium.org,jbudorick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444049

Review URL: https://codereview.chromium.org/1094903008

Cr-Commit-Position: refs/heads/master@{#326914}

Depend on https://codereview.chromium.org/999243003/.

BUG=466867

Review URL: https://codereview.chromium.org/1061133002

Cr-Commit-Position: refs/heads/master@{#326913}

This cleans up some of the damage rects code by converting the SkRegion
to a cc::Region, allowing use of gfx::Rects. It moves the recursion
over the Layer tree out to Compositor instead of on Layer.

And we keep the damaged_region_ valid until the layer is painted. This
will allow us to pass that damaged_region_ to the painting code with
impl-side slimming paint, because with impl-side painting, the paint
clip rect can be larger than the invalidations (as large as the whole
layer).

R=piman@chromium.org, sky
BUG=466426

Committed: https://crrev.com/a5e585868e16ce53c990f764d4943592f11749aa
Cr-Commit-Position: refs/heads/master@{#326547}

Review URL: https://codereview.chromium.org/1080633009

Cr-Commit-Position: refs/heads/master@{#326912}