- 11 Nov, 2019 40 commits
-
-
Alex Turner authored
We add a web platform test for the cache when it is partitioned by top- frame origin. The test caches a resource, then attempts to load it in a popup window. With the split cache, if the popup window is cross-origin, we would expect that request to be a cache miss. We compare the number of requests that hit the server to our expectations. To enable these tests, the existing framework is slightly refactored, including to respond to CORS preflight requests. The virtual test suites virtual/split-http-cache and virtual/not-split-http-cache explicitly test the cases of a split and not-split cache, respectively. The default test is disabled as its result depends on whether the split cache feature is enabled. Bug: 981970 Change-Id: I049fdaec4aebcbdeebdd3c77d13d6ca420d1bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890952Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714236}
-
Garrett Beaty authored
This reverts commit 428151a2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Move goma builders to their own bucket. > > The delegation for goma bucket into luci.chromium.ci pool has been > fixed. > > Change-Id: I08368f1db383e1b94f8f9bf731642e8d5f4a80f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887656 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714230} TBR=agable@chromium.org,jbudorick@chromium.org,gbeaty@chromium.org Change-Id: Ia8c6010881ba31c6785893a6f29601facfc94268 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910280Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#714235}
-
Miguel Casas authored
This CL continues substituting LOG_ASSERT()s to avoid crashing the test binary in Tast test runs. This last patch in the list intervenes image_processor-client.cc, by adding a local macro ASSERT_TRUE_OR_RETURN_NULLPTR. This CL also takes the chance to rename ASSERT_TRUE_AND_RETURN to ASSERT_TRUE_OR_RETURN in video_frame_helpers.cc, since that name makes more sense (it was introduced in this series of patches in crrev.com/c/1900559). Bug: 1020776 Change-Id: I7f2a9c19d3eba474e8f7551854b3ec6ebd0fc943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907130 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#714234}
-
Yao Xiao authored
Fixes the following tests: URLRequestHttpJobWithMockSocketsTest.TestSuccessfulCachedHeadRequest URLRequestTestHTTP.BasicAuth URLRequestTestHTTP.BasicAuthLoadTiming URLRequestTestHTTP.CacheRedirect URLRequestTestHTTP.HeadersCallbacks URLRequestTestHTTP.HeadersCallbacksAuthRetry URLRequestTestHTTP.NetworkAccessedClearOnCachedResponse URLRequestTestHTTP.NetworkErrorLogging_304Response URLRequestTestHTTP.NetworkErrorLogging_DontReportIfNetworkNotAccessed URLRequestTestHTTP.VaryHeader Bug: 1021617 Change-Id: I4fa9b35c8424d3da584e8f21d176cddba5a08113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900549 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
W. James MacLean authored
Disabling this test to reduce jank on the bots. TBR=domfc@chromium.org Bug: 1023391 Change-Id: I26243bb6acba2af947357222ac1fa5664601b1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908063Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714232}
-
Alex Turner authored
Following a VirtualTestSuites refactor, all not-site-per-process virtual tests were collapsed into one entry with the same flags. The isolated-code-cache tests had an additional flag disabling the partitioned HTTP cache. This flag was removed in the refactor so the tests now fail when this feature is enabled by default. We make the split more explicit by moving the isolated-code-cache tests from the not-site-per-process suite to their own with the additional flag. Bug: 1009628 Change-Id: Ib9f7c50509d969e86c60c0369147f0ea75a81c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904347 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714231}
-
Garrett Beaty authored
The delegation for goma bucket into luci.chromium.ci pool has been fixed. Change-Id: I08368f1db383e1b94f8f9bf731642e8d5f4a80f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887656 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#714230}
-
Shawn Gallea authored
This service allows control of webviews and cast apps via gRPC. Webview functionality will be added in a future change. Merge-With: eureka-internal/333992 Bug: Internal b/143945774 Bug: Internal b/143307560 Test: Build cast_shell Change-Id: I05d36a2bd8900afeee3a175c97d773428d482311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907108 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#714229}
-
Vladimir Levin authored
This patch is a result of running third_party/blink/renderer/build/scripts/update_css_ranking.py These rankings determine the autogrouping of fields (when field_group is "*"). The last update was a couple of years ago and rankings have changed since. R=futhark@chromium.org Change-Id: I1e04d56248004bc7dbf91a5cc0d94a7010538c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904491Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714228}
-
Joe Mason authored
They only test the OS's enforcement of ACL's, which is out of scope for a unit test, and the code to set up the ACL's is overcomplicated and fragile. R=proberge Bug: 1023062 Change-Id: I9f3062247e9b3544192ec1dcebdc23652ccf8446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906958Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#714227}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb98804e..de7c754b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If64e85497627adbc7ae73c9006550b521cb20307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714226}
-
Richard Knoll authored
This adds an enterprise policy to disable the Click to Call feature. This affects desktop platforms and allows administrators to disable the click to call dialogs on tel: links and devices in the context menu. The default value is set to True, which means the feature will be enabled. Bug: 1022404 Change-Id: I478f62cc414900dfa91097f8bf65e9349fc46189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904078 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714225}
-
Theresa Wellington authored
Adds a suite of tests to cover functionality in AppMenuButtonHelperImpl. Also adds more tests for AppMenu click, long-press and key event handling and a variety of tests to boost coverage of app menu classes. BUG=966644 Change-Id: I132b095cf576567052cacce7f7b60dbb8327c7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900653 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714224}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c40495063dba..0802bf500144 git log c40495063dba..0802bf500144 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 yangguo@chromium.org Fix running unit tests on Win and Mac Created with: gclient setdep -r src/third_party/devtools-frontend/src@0802bf500144 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I491397812f483085b0206c4166475a2728a1be42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714223}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/27521bd0f067..7980e5ea3e34 git log 27521bd0f067..7980e5ea3e34 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 fmayer@google.com Merge "Wait for app to stop in java hprof CTS." Created with: gclient setdep -r src/third_party/perfetto@7980e5ea3e34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie87cb81157ac031a5a593da9f62c2338423ac0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910160Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idd52628f06ce33fc8403593eba0ea12423ff4bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906427Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3de645cbca78..78441455a3f7 git log 3de645cbca78..78441455a3f7 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 mtklein@google.com don't allocate an interpreter register for stores 2019-11-11 rosasco@google.com Staging for Chromium to accept Skia-GL changes to come. Created with: gclient setdep -r src/third_party/skia@78441455a3f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I0ee32aec0ceb4c994314ceff2891ac2eae078b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908713Reviewed-by:
-
Mirko Bonadei authored
This is a reland of b4f53fc9 The problem with FYI bots should be solved by https://chromium-review.googlesource.com/c/chromium/src/+/1904196 Original change's description: > Stop building frame_analyzer in gn_all. > > Building WebRTC's frame_analyzer when is_component_build=true will > fail after [1] lands. It is possible to build it only for release > builds but this CL tries to remove it since probably this is not > needed. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 > > Bug: webrtc:9419 > Change-Id: I6da6973b8a50ea08b60f0eea0da57014cce830e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904072 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713590} TBR: dpranke@chromium.org Bug: webrtc:9419 Change-Id: Ia68467b8ee9abcae869056f3a2cafbbbd24bb198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905707 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#714219}
-
Joe Mason authored
Accept false positives in OnInfectedBrowserNotAvailable browsertest, as long as there are no false negatives R=proberge Bug: 753632 Change-Id: I40320606991cd416c30001ac7c5fb48701a023d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906811 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
This lets the Chrome WebRTC audio processors analyze playout audio of more than two channels, since they have switched to use the webrtc::AudioProcessing StreamConfig APIs. Bug: chromium:982276, chromium:1016708 Change-Id: I054b3c50a58537d2c684181e9298fdf4302336e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903347Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#714217}
-
ckitagawa authored
This CL creates a client to PaintPreviewRecorder.mojom that handles aggregation of information from the main frame and OOPIFs into a single data structure. On completion it invokes a callback to let the caller know that the captured data is complete. This is implemented as a WebContentsObserver with a 1:1 mapping to a WebContents such that OOPIFs will be able to access the same observer and state via WebContentsUserData. This does not support retrying. As long as the main frame is captured it is considered good-enough to return the result, even if some OOPIF captures failed. The observer is also smart enough to detect when a RenderFrameHost is killed and remove it from the list of waiting frames. Bug: 1009013 Change-Id: I089b67338023ec8007e0f79e99b705b9972e3e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829244 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714216}
-
Francois Beaufort authored
This CL will doesn't change any functionality. It will allow a follow-up CL to use ContentFeatureList without adding dependency. Change-Id: Iad7584f4eef86d666c1ecc7e4a85da8e6028288e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904081Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#714215}
-
Joe Mason authored
Add some sanity checks to the DeleteService implementation that return early, and send an invalid string so we can't trigger the actual service manager. This makes the test less dependent on the environment. R=proberge Bug: 945432 Change-Id: I6370c11b6a123023c3be629bfe6c5ad56953548d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906956Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c7097b69c50..1abb0dd1324b git log 1c7097b69c50..1abb0dd1324b --date=short --no-merges --format='%ad %ae %s' 2019-11-11 lehoangq@gmail.com Add Metal progress to README Created with: gclient setdep -r src/third_party/angle@1abb0dd1324b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I396cdbc9d4216bd0bb23870ccc15a6065b4da166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910159Reviewed-by:
-
Aya ElAttar authored
1. RelaunchNotificationPeriod = 7 days RelaunchHeadsUpPeriod = 3 days RelaunchGracePeriod = 60 mins This will reduce the number of forced reboots, and will them less disruptive. 2. Updating policy_tepmlates.json according to the new defaults. Bug: 1022419 Change-Id: Ia5ff007cc032a08f8e158e23874039561f1cda24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904166Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#714212}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit a4e1df98 ("Fix window compositing with alpha channels on HDR displays"): ../../ui/gl/gl_visual_picker_glx.cc:24:17: error: no member named 'bitset' in namespace 'std' return std::bitset<8 * sizeof(decltype(x))>(x).count(); ~~~~~^ ../../ui/gl/gl_visual_picker_glx.cc:27:29: error: invalid operands to binary expression ('void' and 'void') bits(visual.red_mask) + bits(visual.green_mask) + bits(visual.blue_mask); ~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~ Bug: 957519 Change-Id: If19a691d424ddd55475e673fe9cb733ba7a326f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910083 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714211}
-
Roman Sorokin authored
Make it white. See bug for the screenshot Bug: 1018143 Change-Id: I697af356b786f824ac53907e63b5cdcb92d37faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899382Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714210}
-
Omer Katz authored
Only treat a table as ephemeron if it's strong side is traceable. This changes eliminates table such as HepaHashMap>AtomicString, WeakMember<?>> and HeapHashMap<WeakMember<?>, int> from being treated as ephemeron. Specifically, such tables will no longer be iteratively iterated and traced as part of ephemeron handling. This optimization reduced overall speedometer2 time by 0.1% on pinpoint (https://pinpoint-dot-chromeperf.appspot.com/job/151ba44c220000). Also locally benchmarked v8.browsing_desktop. The number of traced ephemeron table on the story browse:social:facebook_infinite_scroll:2018 dropped from 22.14 to 2.60 on average and from a maximum of 93 to 6. Similarly, browse:news:cnn:2018 on average dropped from 45.76 to 2.06 and on maximum from 361 to 5. (measurements: https://docs.google.com/spreadsheets/d/1Uuvm-HCI-45_rpjLWpKEdk_P1RVX36yC4m9ZDd0zdWs/edit?usp=sharing) Bug: 1021991 Change-Id: Ie839d44dc43dfa26194112172616dd2a57d05794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906351Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#714209}
-
Dominique Fauteux-Chapleau authored
Migrate RetrieveDMToken call to use the new class. Bug: 1020296 Change-Id: I8ed31825288333623e0b4669600b9b97da89436f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903961Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This pure virtual class declaration is a left over of https://crrev.com/c/1904669, where its use was completely replaced by RTCStatsMember (from third_party/blink/renderer/platform/peerconnection/rtc_stats.h) BUG=919392, 787254 R=haraken@chromium.org Change-Id: Icaa3ade122f15d943060d32d5d2051827e3862ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909929 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714207}
-
Stephen Nusko authored
See attached bug for bisect (https://pinpoint-dot-chromeperf.appspot.com/job/11165d46220000). This has been failing since Saturday Nov 8th 2019. NOTRY=true TBR=charliea@chromium.org Bug: 1023366 Change-Id: Iabfcb9a588c30950e798f8a38b5d2e8b4cd47155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910092Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714206}
-
sandromaggi authored
Refactoring, such that iframes are treated en-bloc, expecting an iframe. This change is safe, because the main document never reaches this piece of code in OnDescribeNode. Adding an assertion that all IFrames have a FrameId (has shown to be safe so far). Removing the fallback resolution with name / url. Bug: b/143318024 Change-Id: I515436e8012ee36727f89acae3e43ae4e95b49b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901078 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714205}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0fd4f01b9b83..3de645cbca78 git log 0fd4f01b9b83..3de645cbca78 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d9ed1c2732ba..31edef751a8d (3 commits) Created with: gclient setdep -r src/third_party/skia@3de645cbca78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None Change-Id: Ie815303c75cd0d4e87274c011f6ed9601cec3bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909466Reviewed-by:
-
Thomas Tellier authored
Bug: 990844, 998330 Change-Id: I244ef0f810ecf2da2796c1ad6b3bce4ad772c772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906147Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#714203}
-
A Olsen authored
Sets the change-password page to an embedded test server, then simulates submitting a password-change form to that server, and the server redirects to other URLs in the same way that the real password change pages (Azure, ADFS or Ping) do, to make sure we can detect password change success in these cases. Bug: 930109 Change-Id: I489a94b05de3ca013704c3209586c1c11bcd0d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899383 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
-
Artem Titarenko authored
Building WebRTC's frame_analyzer when is_component_build=true will fail after [1] lands. It is possible to build it only for release builds but this CL tries to remove it since probably this is not needed. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 TBR=dpranke@chromium.org Bug: webrtc:9419 Change-Id: Idece8337dc9d33cf0478408f382d2187f2120f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904196 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Auto-Submit: Artem Titarenko <artit@chromium.org> Cr-Commit-Position: refs/heads/master@{#714201}
-
Rune Lillesveen authored
Moving an element between two shadow hosts may cause us to end up with a null SlotAssignments() walking a dirty flat tree ancestry. Add a null check in that case. The slot re-assignment of the dirty flat tree will make sure ancestors are marked appropriately. Bug: 1023082 Change-Id: Icb2fd03d91f5b020010bee6038d0ac0c72c6ab7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910080Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#714200}
-
Renato Silva authored
Improve the fingerprint setup tests by making OobeBaseTest the base class of FingerprintSetupTest. OobeBaseTest waits for the OOBE UI to be ready before any tests are run. Tested locally. Bug: 1009916 Change-Id: I6147a27d501ecf81f9ce15173af617afca24b3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863015Reviewed-by:
-
Keishi Hattori authored
Reverts r669571 and r687578 in an attempt to fix crash crbug.com/1003733 Bug: 1003733 Change-Id: I2ecd8bbb566da3ae1c5799b437cf86cbe5601136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888620 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/852f718b6ebe..126b6e947f19 Created with: gclient setdep -r src-internal@126b6e947f19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0936a7e469cb7e640fca3797bda6b91e828dfc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909464Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714197}
-
