GitLab

BUG=344769

Review URL: https://codereview.chromium.org/389983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282940 0039d316-1c4b-4281-b951-d872f2087c98

Cleaned up a couple of spaces and also make sure the local storage
mechanism handles first time visits by checking for null instead of 'undefined'
since localStorage.getItem(key) returns null when it cannot find the key[1]. 

[1]http://www.w3.org/TR/webstorage/#dom-storage-getitem

BUG=NONE
TEST=Manual, setup P2P call
NOTRY=TRUE

Review URL: https://codereview.chromium.org/384353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282939 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit_tests --gtest_filter="LocalFileChangeTracker.*"

Review URL: https://codereview.chromium.org/391653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282938 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282937 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178038:178042&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/386393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282936 0039d316-1c4b-4281-b951-d872f2087c98

In PasswordManager::ProvisionallySavePassword, PasswordFormManager instances are sought, which could be managing the form being saved. Some of those managers may not be ready, because they still did not complete matching against the PasswordStore. There might also be more form managers suitable for the form being saved, with some having completed the matching, and some not.

Currently, the code first finds the first suitable form manager, and then drops it if it has not completed matching. This ignores the fact that there might be a second choice form manager, which has completed matching. This happens currently on live.com (see the bug).

This CL ignores form managers which did not complete matching when looking for a suitable form manager for the form being saved.

This CL also improves a poorly phrased log message related to the situation when form managers have not completed matching.

BUG=367768

Review URL: https://codereview.chromium.org/331593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282935 0039d316-1c4b-4281-b951-d872f2087c98

This CL extends task throttling algorithm to multiple task case.
Comparing to previous algorithm, new one backs off the throttling duration by elapsed time.
So that consecutive failure doesn't throttle the next task too long time.


BUG=344769
TEST=unit_tests --gtest_filter="SyncProcessRunnerTest.*"

Review URL: https://codereview.chromium.org/386523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769
TEST=unit_tests --gtest_filter=LocalFileChangeTrackerTest.DemoteAndPromote

Review URL: https://codereview.chromium.org/386373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282933 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282932 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/389263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282931 0039d316-1c4b-4281-b951-d872f2087c98

The zoom is reset when it goes into the edit/mosaic/slideshow modes.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/392543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282930 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282929 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178021:178037&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/384553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282928 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393345
TBR=stevenjb@chromium.org,tbarzic@chromium.org

Review URL: https://codereview.chromium.org/389933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282926 0039d316-1c4b-4281-b951-d872f2087c98

The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users.

BUG=334584

Review URL: https://codereview.chromium.org/330843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282925 0039d316-1c4b-4281-b951-d872f2087c98

ServiceWorker is designed to delay stopping the worker thread (30 sec) when all
controlled documents are closed so that the next navigation can save the startup
time.

In the current code, this improvement also applies to the unregistration with no
controllees, but in that case we should immediately stop the thread because the
worker doesn't work anymore.


BUG=392735,393127
TEST=content_unittests --gtest_filter=ServiceWorker*

Review URL: https://codereview.chromium.org/385143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282922 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282921 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178013:178020&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/384033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282920 0039d316-1c4b-4281-b951-d872f2087c98

Gcc 4.9 has a bug in reporting false positive array out of bound
warning. This cl adds progma to disable the warning.

BUG=chromium:392872
TEST=The warning is gone.

Review URL: https://codereview.chromium.org/384843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282914 0039d316-1c4b-4281-b951-d872f2087c98

    
ScriptExecute has changed to ScriptLoader.
(crrev.com/18261015)
HTMLElement::setInnerHTML has changed to Element:setInnerHTML.
(crrev.com/44333002)
CachedResource has changed to ResourceFetcher with cached property.
Node::createRendererIfNeeded is deprecated and replaced to
[a-zA-Z0-9_]*Element::createRender.
    
Bug=None
NOTRY=True

Review URL: https://codereview.chromium.org/392443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282911 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282909 0039d316-1c4b-4281-b951-d872f2087c98

Unable to reproduce locally even on a Debug build. Reverting the revert and
monitoring carefully.

> Revert 282890 "[fsp] Add an option for mounting in R/W mode."
> 
> > [fsp] Add an option for mounting in R/W mode.
> > 
> > Files app fetches information whether a volume is read only or R/W from
> > file_manager::VolumeManager, which used to always have the isReadOnly option
> > set to true for any provided file system.
> > 
> > However, since R/W operations are now under development, we should be able to
> > mark a volume as R/W.
> > 
> > In order to achieve that, a "writable" option has been added to the File System
> > Provider API mount() call. The argument is by default false, so file systems
> > are by default read only.
> > 
> > TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
> > BUG=391362
> > 
> > Review URL: https://codereview.chromium.org/372163006
> 
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/391613002

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/389243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282908 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of this change is to disable the menu for write-protected
SD cards that anyhow fails to format.

Strictly speaking this is excessive, because there may be a volume with
read-only file system that still is formattable. We however assume that
the practical need for the case is low (see discussion in the BUG.)

BUG=334108

Review URL: https://codereview.chromium.org/386333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282907 0039d316-1c4b-4281-b951-d872f2087c98

A no-cache loaded page should still have registration capability. If
the document URL is not set, the registration will fail with "SecurityError".

BUG=392405

Review URL: https://codereview.chromium.org/362183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282906 0039d316-1c4b-4281-b951-d872f2087c98

The line was not consistent with the actual string defined in drive_backend_constants.cc.

BUG=None
TEST=None
NOTRY=true

Review URL: https://codereview.chromium.org/386343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383939

Review URL: https://codereview.chromium.org/331353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282904 0039d316-1c4b-4281-b951-d872f2087c98

> [fsp] Add an option for mounting in R/W mode.
> 
> Files app fetches information whether a volume is read only or R/W from
> file_manager::VolumeManager, which used to always have the isReadOnly option
> set to true for any provided file system.
> 
> However, since R/W operations are now under development, we should be able to
> mark a volume as R/W.
> 
> In order to achieve that, a "writable" option has been added to the File System
> Provider API mount() call. The argument is by default false, so file systems
> are by default read only.
> 
> TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
> BUG=391362
> 
> Review URL: https://codereview.chromium.org/372163006

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/391613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282900 0039d316-1c4b-4281-b951-d872f2087c98

When expanding the live tiles rect, we want to include border pixels
for all tiles that intersect the live tiles rect. It used to do this
by also including any tiles whose border pixels intersect the live
tiles rect, but that's excessive.

This adds ExpandRectIgnoringBordersToTileBoundsWithBordersEmpty and
uses it to expand the live tiles rect, the unit test
PictureLayerTilingIteratorTest.ResizeOverBorderPixelsDeletesTiles
covers this usage of the method.

The ExpandRectToTileBoundsWithBorders is no longer used, so remove it.

R=enne
BUG=386998

Review URL: https://codereview.chromium.org/385123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282896 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282893 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove media::VideoRenderer::SetPlaybackRate(). (https://codereview.chromium.org/384943002/)

Reason for revert:
Sorry to revert this change. It made the following layout tests flakily fail:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

Reverting locally healed the tests.

The image diffs show what appears to be a timestamp change (something like 0:18 to 0:19):
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/20779/layout-test-results/results.html

Original issue's description:
> Remove media::VideoRenderer::SetPlaybackRate().
> 
> Video renderers don't need the information as they are already making
> audio/video synchronization decisions based on a media timeline that
> already incorporates the current playback rate via the time callback.
> 
> In particular, VideoRendererImpl only used playback rate to estimate
> a better duration to sleep until the current frame was ready ...
> except that in most cases we'd sleep for kIdleTimeDelta and wait
> until the media timeline had progressed past the current frame's
> timestamp. In other words, there's absolutely no reason to even try
> to estimate the sleep duration based on the playback rate.
> 
> BUG=370634
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282797

TBR=xhwang@chromium.org,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370634

Review URL: https://codereview.chromium.org/390733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282891 0039d316-1c4b-4281-b951-d872f2087c98

Files app fetches information whether a volume is read only or R/W from
file_manager::VolumeManager, which used to always have the isReadOnly option
set to true for any provided file system.

However, since R/W operations are now under development, we should be able to
mark a volume as R/W.

In order to achieve that, a "writable" option has been added to the File System
Provider API mount() call. The argument is by default false, so file systems
are by default read only.

TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
BUG=391362

Review URL: https://codereview.chromium.org/372163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282890 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/367963003/

Fix use-after-free error

BUG=170544, 377538
R=jgraettinger@chromium.org

TEST=SpdySessionTest.PushedStreamShouldNotCountToClientConcurrencyLimit
SpdySessionTest.RejectPushedStreamExceedingConcurrencyLimit
SpdySessionTest.IgnoreReservedRemoteStreamsCount

Review URL: https://codereview.chromium.org/371273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282889 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/387853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=392949

Review URL: https://codereview.chromium.org/389863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282887 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282886 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178012:178012&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/388123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282885 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282880 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/390713002

Fixes issues from previous failed roll which included

https://codereview.chromium.org/375983002
https://codereview.chromium.org/376873009

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/387003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390346

Review URL: https://codereview.chromium.org/376663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282878 0039d316-1c4b-4281-b951-d872f2087c98