- 09 Apr, 2020 40 commits
-
-
Mike Dougherty authored
Replace the boolean return value of WebStatePolicyDecider::ShouldAllowRequest with a struct PolicyDecision. PolicyDecision will be extended in a follow-up CL to specify an error which will denote the specific failure of loading a given |request|. Additionally, PolicyDecision::RequestAction is an enum as it will also be extended with an additional rejection type to reject the load and present UI displaying an error page with details about the given error. Bug: 1065161 Change-Id: I4e7eabf7ed4055bbd1365dab05bda53b5aaf2e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130971 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#757955}
-
Lei Zhang authored
The default case in the switch statement allows for a NOTREACHED() to be invoked at runtime if a new ColorModel is added that isn't handled in the switch statement. By removing the default case, the target will not compile unless the new case is handled by the switch. https://crrev.com/737599 already does this for IsColorModelSelected(). This CL refactors the common code used by IsColorModelSelected() and GetColorModelForMode() into ColorModeToColorModel(). Bug: 1069266 Change-Id: I38287e828d48640d6a3eef9891bb7040bf7450b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142953Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#757954}
-
Antonio Gomes authored
This test moves feimage-reference-foreign-object-crash.html to wpt/. It also migrates the test into a regular crash test that waits long enough to check that the crash does not really happen using class="test-wait" (hence dropping the use of testharness.js and testharnessreport.js). Differently from [1], circular reference isn't used. [1] https://crrev.com/c/2144511 R=fs@opera.com, smcgruer@chromium.org Bug: 1063749 Change-Id: I936649812fb546265f9e278a8b42ed60a1fe5363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144512 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#757953}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1065314 Change-Id: I2de531bf5889f4d19afbb7d015ecec371bbf70c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143651Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757952}
-
Etienne Pierre-doray authored
Since old DoWork/DoDelayedWork() was removed, last_work_check_result_ can be removed. Bug: 885371 Change-Id: If975d306e3b50b406b728d0e2b3961e30dc4b344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130824Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#757951}
-
Jazz Xu authored
Bug: 1060291 Change-Id: I6c70eb25b9b8e3c9f675b0030a42fe712a89715d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129018Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757950}
-
Jon Mann authored
This allows shared networks that were added by the logged in user to be saved to sync while filtering out networks that were configured by other users. Bug: 966270 Change-Id: I31063c09300290671f0236e71706fd00fe1ca77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142579Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#757949}
-
Charlie Hu authored
This CL follows up CL(https://chromium-review.googlesource.com/c/chromium/src/+/2101707). This CL moves handling of empty resource url in |Document::ReportFeaturePolicyViolation| and |Document::ReportDocumentPolicyViolation| to |LocationReportBody| constructor. Change-Id: I34d68421daf3899fdf9063a800e2fa34e34e641b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119256 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757948}
-
chrome://appsDaniel Murphy authored
This change allows web apps that are populated in chrome://apps using WebAppProvider to be uninstalled. R=loyso@chromium.org Tested: Manually, with both BMO on and off. Bug: 1009302, 1068476 Change-Id: Ia80a546d4cff8c999ff2bc7a7541e672ce2b4e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117298Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#757947}
-
Varun Khaneja authored
Bug: 1044212 Change-Id: I68e11b7f06830b2d34c2bd5a48b0ef0c64bccae0 Fixed: 1069517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144671 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#757946}
-
Yi Xu authored
Fix size.attributes.parse.trailingjunk to match spec: offscreenCanvas.width = '100#!?' should shrow TypeError because 100#!? is NaN. Bug: 1067639 Change-Id: I5b9798cfb7d4f7ecfc77854fd1431c1df89f84a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142746Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#757945}
-
Evan Stade authored
When the app crashes, it can leave behind media streaming notifications. Track these in a pref and remove on next startup. We could use getActiveNotifications instead of storing a pref, but it's only available in API 23. Testing is still a todo and may be somewhat difficult as full integration testing requires crashing the app. For now this is manually tested by removing the cancel() calls that execute on stream/tab destruction and restarting the app. Bug: 1025622 Change-Id: Icdd475707ac1af0789968264c202e00fd8964d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142394 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#757944}
-
Ben Pastene authored
This reverts commit 320f9516. Reason for revert: deduping was reset, comment no longer needed Original change's description: > Add a whitespace change to test_env.py to reset swarming deduplication. > > Due to emergency server maintenance in crbug.com/1069091, we need all > tests to not be deduplicated into tests that ran prior to the > maintenance. Adding a trivial change to //testing/test_env.py will > prevent any task deduplication since most every test includes this file > in its inputs. > > TBR=johnchen > > No-Try: true > No-Tree-Checks: true > Bug: 1069091 > Change-Id: If99af96b6bce7b00cd982de0234b39dbb9a9ec89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142619 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757517} TBR=iannucci@chromium.org,bpastene@chromium.org,johnchen@chromium.org Change-Id: If0b620f3461efeef34ec7a0d24fcd813f585d00b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144360Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#757943}
-
sandromaggi authored
Before this change, the BottomSheet reset all paddings (except bottom) to 0 when showing/hiding the keyboard. This irreversibly reset some padding defined in XML. Keep the existing padding for left, top, right and only set bottom to a variable value. Bug: b/152947599 Change-Id: I31cfec4bf8c8509ef39b1d0dbca0c5c7913b8db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141927Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#757942}
-
Shawn Gallea authored
Allows user to test go forward functionality. Bug: 1011977 Test: Run client, use forward command. Change-Id: If59669f37e40f88f81edd57f30290fd7f7aaf382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142340 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#757941}
-
Anastasia Helfinstein authored
This change removes max_width, and renames min_width to preferred_width. Currently, if max_width is left at its default value (0), any attempt to set the bubble's width via SetWidth() is blocked, because the width is clamped to min_width, max_width. Further, there is only one case in which max_width is initialized to a different value than min_width, so the decision was made to move the clamping logic from the base class into that subclass. Relnotes: N/A Bug: 973719 Change-Id: I2a1512f5e955834529f4ed5fbb7d3926cfba5d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140591Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#757940}
-
danakj authored
TestRunnerForSpecificView can call the blink method directly. Add a TODO to move it over TestRunnerBindings, if it can know about the frame it's bound to. R=avi@chromium.org Bug: 866140 Change-Id: Idaef58ff1dafac9c4d625c9ae0a7f2d80aa8011a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140979 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#757939}
-
Sujie Zhu authored
Change set_nickname() method to SetNickname() for all existing usages. SetNickname() will first replace newlines and tabs with whitespaces, second trim all leading/trailing whitespaces, then set to nickname. Bug: 1059087 Change-Id: I87635e6c614ac2aca4507a2b0a6922482b9f5475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142329 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#757938}
-
Su Hong Koo authored
Add support for display identification by adding calls to highlightDisplay in display settings page. Remove display name string from display layout boxes. Bug: 1068252 Change-Id: Id3c0b786496848c0fd16af92ffbe64dee962fba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113085 Commit-Queue: Su Hong Koo <sukoo@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#757937}
-
Wei-Yin Chen (陳威尹) authored
Thumbnail-related checking became flaky, and we are not specifically testing thumbnails in the tests for search term chip. This CL removes the thumbnail-related checking in the following tests: - StartSurfaceLayoutTest#testSearchTermChip_noChip - StartSurfaceLayoutTest#testSearchTermChip_adaptiveIcon - StartSurfaceLayoutTest#testSearchTermChip_withChip Bug: 1064367 Change-Id: I73d5e1c29bc9e3c646fdec1bca610b395088f89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117646 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757936}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a992d9caec7..aad6472eff7b git log 5a992d9caec7..aad6472eff7b --date=short --first-parent --format='%ad %ae %s' 2020-04-09 simonmacm@google.com Add trace_trigger field to trace_metadata. Created with: gclient setdep -r src/third_party/perfetto@aad6472eff7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:153636784 Tbr: perfetto-bugs@google.com Change-Id: I0793c8f936459e11ef48dad0aaa815c64f8ea44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757935}
-
edchin authored
This CL installs the ManagedBookmarksPolicyHandler in policy handler list factory. This is guarded by a command-line switch: '--install-managed-bookmarks-handler' Bug: 1065187 Change-Id: Ie103fd92185b1397a3e5da30afd1da9b8384dd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142774 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757934}
-
David Bokan authored
Small cleanup to avoid sentinel value and make the semantics and lifetime clearer. Bug: NONE Change-Id: Icf22008e94aae436024d524a5d9eaeb5b9be63ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142514Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757933}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I5510715fa0889a96b6208209b92a857ebe773584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139440 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757932}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c72a211d0090..3999e2615f58 git log c72a211d0090..3999e2615f58 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sadrul@chromium.org rendering benchmark: Some no-op cleanups. Created with: gclient setdep -r src/third_party/catapult@3999e2615f58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058155 Tbr: oysteine@google.com Change-Id: Ic9e1330460b9810594fac9e4b98018852adf8994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144382Reviewed-by:
-
Connie Wan authored
The main fix for the flicker is the check for is_open(), but this caused another issue with the first context menu not showing up. See inline comment for the subsequent fix for the context menu. Bug: 1068934 Change-Id: Ib1269571b95de5624e0891501e8fb42e77d61611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144262Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#757930}
-
Yulun Wu authored
Bug: 1055694 Change-Id: I12f06d300aab873b8cf1a5b992a6c3bd0c412416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136101Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757929}
-
Dominic Farolino authored
This CL adds a kNonBlockingImage ImageRequestOptimization enum value to FetchParameters. ImageLoader::DoUpdateFromElement sets FetchParameters::image_request_optimization_ to this new value when requesting a once-deferred image. Finally, ResourceFetcher reacts to this by placing the ResourceLoader associated with the image Resource, in the |non_blocking_loaders_| set, as opposed to |loaders_| set. This ensures that when a `loading=lazy` image is fetched before the Document load event fires, the Document load event will not be blocked on this request. This matches the load event semantics that the HTML Standard mandates [1]. This follows the initial design proposed in https://docs.google.com/document/d/1QEp9zL8WPAthFlXcsyhhwDoDQd2STSh_Rex801LVQkA/edit#heading=h.4do48ac3us8v. [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:lazy-loading-attribute-2 R=kinuko@chromium.org, sclittle@chromium.org Bug: 992526,1033501 Change-Id: I8da2c3a6cfee8039d4dc353f9e9b679a04f2e302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133108 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#757928}
-
Sam Bowen authored
Bug: 1068748 Change-Id: I1354f7963254ab17570180ffca41b3764fc7890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140561 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#757927}
-
Kai Ninomiya authored
Deprecates GPUBindGroup(Layout)Descriptor.bindings. Bug: 1069302 Change-Id: I6c4cada0681d0417938d443a4dcd149072720c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143375Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#757926}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into a WPT-specific directory for crashtests, adding links to the relevant specs and a test assertion describing its purpose. This CL also creates a external/wpt/css/filter-effects/crashtests directory to place the new crashtest, in order to be able to add a multiple-references-id-crash-002.html in a follow-up CL, since otherwise (i.e. no crashtest dir) we would have to move the '-crash' substring after the '-001/-002' one part, right before the extension, or otherwise the test would not run (see the relevant RFC[1]). Besides, having a crashtest directory will be convenient to migrate more crash tests into css/filter-effects in the future. [1] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/load_test.md Bug: 1063749 Change-Id: I997fba360058d604698fab74ae84ee3b9893cb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144035 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Reilly Grant authored
This change configures UsbServiceWin to receive all new device notifications. Upon receiving a notification about a device that is not a USB device it is checked to see if it is the child of a USB device. In this case we have discovered a new USB function. This is necessary because when Windows enumerates a new USB device it will generate an event for the root device before it generates events for any of the functions and so the initial enumeration of children added in a previous patch will not discover them. With this code in place composite devices discovered while Chrome is running are now usable. Bug: 637404 Change-Id: I8ab0b4a92069d19ac8489febc8d62862903eda9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142767Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757924}
-
Kyle Horimoto authored
Update OsSettingsLocalizedStringsProvider to use the synchronous API provided by LocalSearchService. Bug: 1063505 Change-Id: I569215fd0149bd9912a82a66ba2c8d0eb509c4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140960Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757923}
-
Hailey Wang authored
Add calculation method for scoring of a tab depending on it's last visibility change time. This will be used for calculating tab score in future cl. Bug: 1059341 Change-Id: Ib6c9534bc6f47d73063a436a2a31f436c77ae872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136031 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#757922}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89fa61264af5..a8ab783931f9 Created with: gclient setdep -r src-internal@a8ab783931f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063948 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I8d7256d10ab0c5683d065a8772c4c94165ebd94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144385Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757921}
-
Sergey Ulanov authored
The test is trying to verify that WebEngine closes devtools port as expected. It was using URLFetcher to make an HTTP request to devtools. Due to a netstack bug (fxb/49779) sometimes that request was hanging indefinitely, so the test was timing out. Updated the tests to connect raw socket, which allows to verify that the port is closed without hitting that netstack bug. Bug: 1067727 Change-Id: Id07eefe490ca4e25cf6d9143636802f8115cd0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143380Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757920}
-
chrome://appsDaniel Murphy authored
This hooks up the 'Show App Info' option in the context menu to work for BMO-enabled apps. R=loyso@chromium.org Bug: 1009302 Change-Id: I18ce0848c7cddfa46137cd67bee9bff0e1d99771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121437Reviewed-by:
-
Peter Kasting authored
Because these host content including toolbar buttons, which read data off the ThemeProvider, they need to have one configured. Right now this will run, but likely not look correct (e.g. I imagine the reload button is red) because the ThemeProvider is the stub class Widget provides by default. In the future, I'll remove this stub, and this wouldn't run at all. Bug: none Change-Id: I0a5e404534098f6f0a82782bbe55346aee9f8066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143655 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#757918}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7db1491a85f6..9f6ff832d99a git log 7db1491a85f6..9f6ff832d99a --date=short --first-parent --format='%ad %ae %s' 2020-04-09 mmorrison@nvidia.com Do not trigger -Wimplicit-int-float-conversion Created with: gclient setdep -r src/third_party/webrtc@9f6ff832d99a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I97076d413b6cea715fcee00c7ae1b85408cc7b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144383Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da31061a..d23973d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I101df9069d8182790e38967e12a1e89764352ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144232Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757916}
-
