- 16 Jul, 2018 40 commits
-
-
Rohit Rao authored
These tweaks are based on feedback from UX. See the linked bug for details. BUG=863043 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I159c77e16c567b5b670ca727425253fc8a393ebe Reviewed-on: https://chromium-review.googlesource.com/1135289 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575358}
-
Koji Ishii authored
This patch supports NGLineBreaker to rewind unpositioned floats. When rewinding floats occurs, LayoutNG either position them incorrectly, or hit DCHECK in paint due to duplicated ID. This patch fixes it for unpositioned foats by matching to Edge and Gecko. Blink considers such floats as if it were committed (positioned in LayoutNG terminologies) and thus the position is incorrect. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I884879b2034d2f63ae248f70de3edeb27d71cafe Reviewed-on: https://chromium-review.googlesource.com/1136262 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#575357}
-
Georges Khalil authored
This is a reland for 1133315. A global function was mistakenly moved lower, and was not visible to calls that happened before it. Refactor BrowserDMTokenStorage for easier platform implementations. This CL refactors BrowserDMTokenStorage & BrowserDMTokenStorageWin to move code that is common to all platforms. After this CL, adding a new platform requires implementing the following methods: - virtual std::string InitClientId(); - virtual std::string InitEnrollmentToken(); - virtual std::string InitDMToken(); - virtual void SaveDMToken(const std::string& token); Note that this CL keeps the existing Windows implementation, it only refactors the code (no functional change). BUG=812641 TBR: pastarmovj Change-Id: I51d6b4efef6066d602a59c514e9db88e414e4337 Reviewed-on: https://chromium-review.googlesource.com/1138539Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575356}
-
Marc Treib authored
This should make no difference whatsoever in practice (in case of an unrecoverable error, we won't try to start up again anyway), it just makes things a bit simpler to reason about. Bug: 839834 Change-Id: Ie3ac83b172f9fab100b1a176421025aa1f3699dc Reviewed-on: https://chromium-review.googlesource.com/1138252 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575355}
-
Steven Valdez authored
Change-Id: I9d55f53735ab13fcc835673b9eef687d587128f1 Reviewed-on: https://chromium-review.googlesource.com/1137751 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#575354}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d80b0273. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21462 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/geolocation-API TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ic10b935af281a05a087702df437dae12fd1731f3 Reviewed-on: https://chromium-review.googlesource.com/1138541 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575353}
-
Xiaocheng Hu authored
Bug: 863945 Change-Id: I1708b8512bea5f86072030a8badb6d09ed261297 NoTry: True Tbr: takumif@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1138694Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575352}
-
Maks Orlovich authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This also removes the no-longer needed URLRequestContext-based methods in GCMRequestTestBase, and fixes the regression of CompleteFetch overrides being bypassed in the previous RegistrationRequest port. Bug: 844986, 844988 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icdb2e768b274618ce5c6d1fceda6ae9b76c4c275 Reviewed-on: https://chromium-review.googlesource.com/1135291Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#575351}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e79ac55dc0ea..4d831cea60c7 git log e79ac55dc0ea..4d831cea60c7 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 primiano@google.com Add bug link to docs Created with: gclient setdep -r src/third_party/perfetto@4d831cea60c7 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaf90cf9219667a865b9d61699f59372af667beef Reviewed-on: https://chromium-review.googlesource.com/1138553 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575350}
-
François Beaufort authored
Picture-in-Picture window should be closed after navigating away while same document navigations should not close Picture-in-Picture window. Bug: 726619 Change-Id: Ibd07dfd2f62af23573ab2221138b4776df26f22c Reviewed-on: https://chromium-review.googlesource.com/1137818 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#575349}
-
Thomas Tangl authored
A learn-more question mark is added to the syncSetup page. Bug: 863138 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3da65e76a7054c6c5256dc96f746c83968dc2e28 Reviewed-on: https://chromium-review.googlesource.com/1138247Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#575348}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/6eecfe927de9..000f2f686d60 $ git log 6eecfe927..000f2f686 --date=short --no-merges --format='%ad %ae %s' 2018-07-05 sanampudi.venkatarao Facilitate eob support in inverse transform for neon 2018-07-10 ddvfinite Add Masked sad avx2 code 2018-07-12 ddvfinite Add Wedge utils avx2 code 2018-06-12 kylesiefring x86: Add subpixel obmc variance 2018-07-12 binpengsmail Change allowed_tx_mask to bit mask 2018-07-13 anorkin film grain: set luma grain to 0 when num_y_point is zero 2018-07-12 yunqingwang ext_tile: allocate tile list buffer in example 2018-07-06 deepa.kg Implement row based multi-threading of decoding stage 2018-07-11 yunqingwang ext_tile: add image format support in example Created with: roll-dep src/third_party/libaom/source/libaom Change-Id: I33c92eb0f442e479c1201ef1f184622371b98e1d Reviewed-on: https://chromium-review.googlesource.com/1138398Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#575347}
-
Eric Karl authored
Data pointer must be 4-byte aligned for mipmap generation to succeed, add an alignment call to ensure this is always the case. Bug: 863659 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I64c3806c1d1bfcd34fff48baedc5abfc8fb37ef4 Reviewed-on: https://chromium-review.googlesource.com/1137922 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#575346}
-
Aaron Leventhal authored
Bug: 862099 Change-Id: Ia44305fa49a3605f0d5aa7fe09a6363730cf8ab9 Reviewed-on: https://chromium-review.googlesource.com/1138348 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#575345}
-
codeimpl authored
The 'immersive' is more intuitive term than 'exclusive'[1]. [1] https://github.com/immersive-web/webxr/pull/371 Bug: 852524 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If5c5ab6563df40a783f9d346d319dceed1f7cc58 Reviewed-on: https://chromium-review.googlesource.com/1101601 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575344}
-
Peter Kasting authored
Bug: none Change-Id: Ice0fed66fd7176a3b6ae5b356e20a01d839bb30e Reviewed-on: https://chromium-review.googlesource.com/1137484Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#575343}
-
Michael Thiessen authored
We were duplicating code to handle VR entry failing, so I de-duplicated and refactored some code here. Might fix issue 862829. TBR=yfriedman@chromium.org Bug: 862829 Change-Id: I357d40112f4d9a67e0b5206ff2dc2788e1d5d205 Reviewed-on: https://chromium-review.googlesource.com/1138400Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575342}
-
Owen Min authored
This reverts commit 3b9b2cca. Reason for revert: The test is flaky on Win 10 and Win 7 Original change's description: > Fix invalid password save offer in some cases. > > Here we fix few password save flaws: > 1. Invalid password save offer when a password form was filled and then a non > password form was submitted. > 2. A proper password form handling when a form is submitted into about:blank > iframe using "target" attribute. This is a valid flow which some websites use to send private information via iframe. > > The iframe test is implemented exactly for the #2 flaw. > > Bug: 854171 > Change-Id: I39aec0d9b1f5fcbda551efb145f0c3be2456c0da > Reviewed-on: https://chromium-review.googlesource.com/1106137 > Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575239} TBR=dvadym@chromium.org,kolos@chromium.org,sense@yandex-team.ru Change-Id: Ic89f7474943072def85f97f75033fa6ebe2ba736 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854171 Reviewed-on: https://chromium-review.googlesource.com/1138518Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575341}
-
akaba authored
Frame eviction shouldn't just reset the fallback to an unvalid surface but should reset the primary too. This is done by replacing the SurfaceLayer with a SolidColorLayer. Bug: 861764 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I18b9ee11c9d0132dd41eb34a8dc79bdae09af393 Reviewed-on: https://chromium-review.googlesource.com/1136847 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#575340}
-
Nico Weber authored
chromium_gtests_for_devices_with_graphical_output means "not cast". The cast build doesn't include anything at the //chrome level, and unit_tests lives at the //chrome level. Currently we have unit_tests in chromium_gtests which runs on all bots, and then an exception to remove it again on the cast bots. Instead, put it in chromium_gtests_for_devices_with_graphical_output so that it only runs on non-cast bots in the first place. (It also ends up removing unit_tests from linux-blink-heap-incremental-marking and linux-blink-heap-verification on the fyi waterfall, since these bots run chromium_gtests instead of chromium_linux_gtests -- that looks like a bot config bug, but it's only FYI bots anyways.) This removes the last "unclear why" comment from test_suite*.pyl! Bug: 843511,817779,812533 Change-Id: I76e0a2b30e0ca87c02c73cb46d8135d9ab7030d8 Reviewed-on: https://chromium-review.googlesource.com/1138333Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575339}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff508d10..d75ef78a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I765881f3c4a3ac1826dca2e46b8e73de42db3fc9 Reviewed-on: https://chromium-review.googlesource.com/1138393Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575338}
-
Xiaocheng Hu authored
Bug: 863971 Change-Id: I7401eaf54693c83145b5a67c17da1ca1e69c9184 Tbr: nasko@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1138376Reviewed-by:
-
Jennifer Apacible authored
The background is kept white. Bug: 863702 Change-Id: Ia8d0f2bb8f9c1a0263c527906f076a1fa78f5823 Reviewed-on: https://chromium-review.googlesource.com/1137752Reviewed-by:
-
Sophie Chang authored
. Bug: 857466 Change-Id: If8cede28c9dbe3ef95db1833a221f4d5e3687a48 Reviewed-on: https://chromium-review.googlesource.com/1138544Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#575335}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/be45355b46d9..f5342c4cf3d3 git log be45355b46d9..f5342c4cf3d3 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 charliea@chromium.org Delete remaining BattOr-related code in Catapult Created with: gclient setdep -r src/third_party/catapult@f5342c4cf3d3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859514 TBR=sullivan@chromium.org Change-Id: I300a70ed0222a645f762d4e8f8d89cd0877f034b Reviewed-on: https://chromium-review.googlesource.com/1138454Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575334}
-
Nathan Parker authored
Bug: 863968 Change-Id: If488c9b2e6f73451d9e72b623be9148dc75ffb29 Reviewed-on: https://chromium-review.googlesource.com/1138639Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#575333}
-
Jay Civelli authored
As part of the effort to move to the network service, changing the GaiaAuthFetcher to use network::SimpleURLLoader instead of using net::URLRequest. This changes the API to take in a SharedURLLoaderFactory instead of a net::URLRequestContextGetter and affects many callers. Many tests also had to be changed, as it is common to mock a URLRequest and this is now done using a TestURLLoaderFactory. Bug: 840396 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib93075b06855a0a5ba9349ae64e2ad43b02e0c6f Reviewed-on: https://chromium-review.googlesource.com/1091533 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575332}
-
chrome://flagsManu Cornet authored
Bug: 805612 Change-Id: I499ee8d1bc6c083272b8cb9da575173524b8bfa7 Reviewed-on: https://chromium-review.googlesource.com/1137059 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575331}
-
Tim Zheng authored
Some Linux apps create multiple desktop files that invoke the same binary and use the same icon but with different parameters. They have one main desktop file that doesn't include 'NoDisplay=true'. This change skip over the apps with no display set to true when matching using the app names. This change fixes the shelf integration for the following apps. okular calibre konqueror amarok BUG=chromium:854911 TEST=Manually tested on an eve device; Unit test cases added. Change-Id: I8615b0be08139243915f7e21f71fe61b2023b5a7 Reviewed-on: https://chromium-review.googlesource.com/1137331Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575330}
-
Peter Mayo authored
external/wpt/offscreen-canvas/fill-and-stroke-styles/ 2d.pattern.basic.nocontext.worker.html was disabled as crashing when the .any.js tests were added, but is now unexpectedly just failing. Highly likely that some fix in the last year and a half has rendered this less broken. https://test-results.appspot.com/dashboards/flakiness_dashboard.html# testType=webkit_layout_tests& tests=2d.pattern.basic.nocontext.worker.html and trybots for previous patchsets for reference and examples of the various behaviors. Notably, the test crashes (fails a DCHECK) on CQ and some debug bots. (Un)fortunately, the expectations language can't express the variance in this test's expectation. Each bot type in itself tends to be consistent. Bug: 709227 Change-Id: I6522468d656fd6a4dfcb56af9ce05a11e9bc9aa4 Reviewed-on: https://chromium-review.googlesource.com/1134022Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575329}
-
Becca Hughes authored
When we call UpdateLayerBounds in OverlaySurfaceEmbedder we should also update the pointer to |window_background_layer_| (like we do for |video_layer_|). BUG=863570 Change-Id: Id5b29db2c060705ce0df0cf44cd09fa43da9902f Reviewed-on: https://chromium-review.googlesource.com/1137062Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#575328}
-
Michael Thiessen authored
Cleans up our method ordering, public statics first, package/private below, followed by non-statics and fixes visibility on a bunch of functions. Also cleans up a bunch of functions for testing that really just wanted access to VrShellImpl. Change-Id: Ieb731d82f5633c8ec69d7b427c696b891b46cab2 Reviewed-on: https://chromium-review.googlesource.com/1136856Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ddd8eaa8dca0..419acc8f4f3b git log ddd8eaa8dca0..419acc8f4f3b --date=short --no-merges --format='%ad %ae %s' 2018-07-16 fjhenigman@chromium.org Vulkan: Convert streamed vertex data as needed. 2018-07-16 jmadill@chromium.org Vulkan: Store program textures cache. 2018-07-16 jmadill@chromium.org Vulkan: Add a create shader helper. Created with: gclient setdep -r src/third_party/angle@419acc8f4f3b The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I17aa73b11cb440bbe4412c71f99604adf399e497 Reviewed-on: https://chromium-review.googlesource.com/1138554Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575326}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html #testType=webkit_layout_tests&tests= http/tests/permissions/test-api-surface.html%20 http/tests/origin_trials/sample-api-workers.html indicates that these tests have been passing iconsistently for a while. Bug: 711529,863896 Change-Id: I409b11d70fb10309e473463fa7a4d61d7839c934 Reviewed-on: https://chromium-review.googlesource.com/1135647 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575325}
-
Tommy Nyquist authored
Currently whenever we add a new in-product help feature, the developer have to add six distinct <action> entries, which makes it easy to overlook something. Also, these actions are typically copy-pasted from an old entry, so they do not typically provide any good documentation for the particular in-product help feature either. This CL uses the new functionality introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1015293 which fixes the fan-out for user actions, making them usable for chromium. For all known in-product help entries, this CL moves them to the suffix list at the bottom of the file. This means that the action suffix list will be defined for a few extra, since not all of them was in use for the user actions that have already been moved to the new system. BUG=835454 Change-Id: I72847cda991413e85c6b6e990af1f2e9e0f0cd8e Reviewed-on: https://chromium-review.googlesource.com/1136976Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#575324}
-
John Delaney authored
The AdDelay historgram metrics aren't strictly used when AdDelay is on. Bug: 859077 Change-Id: I2ced2154a45e22cadf9f0ce48f9976ee9ecd2e49 Reviewed-on: https://chromium-review.googlesource.com/1120740Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575323}
-
Brian Salomon authored
This is a reland of 23370775 This reland undoes all the changes to start_x. start_X is now 10 as it was before the original change. Original change's description: > Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest." > > This is a reland of 841c0dde > > The updated change uses window.devicePixelRatio to determine the inset. > It also accounts for the absolute position used by the "WithDivs" > variations of this test. One additional device pixel of offset is used > to make this pass on mac_chromium_rel_ng. This is probably necessary > because either window.devicePixelRatio reports 1 incorrectly or the > edge antialiasing covers slightly more than one pixel. This wasn't > investigated. > > Original change's description: > > Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest. > > > > Skia currently has a driver workaround that performans antialiased > > rectangle edge equation evalution in the fragment shader rather than > > vertex shader on Adreno 3xx GPUs. This was done because the interpolation > > of values computed in the vertex shader lacks enough precision to pass > > these tests. However, doing so has a negative performance impact. Skia > > tests run with the workaround removed show that in practice the visual > > difference is insignificant. Moreover, cc::GLRenderer also incurs these > > same errors as it uses the same antialiasing approach without the > > workaround and has shipped on Adreno 3xx devices for years with no known > > complaints about antialiasing quality/accuracy. We're better off > > reclaiming the performance and accepting a small hit to antialiasing > > accuracy. > > > > Bug: 847984 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac > > Reviewed-on: https://chromium-review.googlesource.com/1129041 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: Brian Salomon <bsalomon@google.com> > > Cr-Commit-Position: refs/heads/master@{#573695} > > Bug: 847984 > Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1132574 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574369} Bug: 847984 Change-Id: I29a31001bd76436eba60df87ffe26fdb03d6d032 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1138293 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Owen Min authored
Tbr: skyostil@chromium.org Bug: 863676 Change-Id: I00165973f5135273938f5ca23362c7964c69c1fd Reviewed-on: https://chromium-review.googlesource.com/1138409Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a619d459b858..e7e3bb4d2006 git log a619d459b858..e7e3bb4d2006 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms ae6a7acc22e5..dad22fe0e646 (1 commits) 2018-07-16 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 76c1d14b8e21..ddd8eaa8dca0 (1 commits) 2018-07-16 bsalomon@google.com In GrContext::readSurfacePixels fail gracefully if temp pixmap allocation 2018-07-16 halcanary@google.com Whitespace cleanup again 2018-07-16 reed@google.com plumb through arenaalloc 2018-07-16 borenet@google.com Remove sign_cla entry from cq.cfg Created with: gclient setdep -r src/third_party/skia@e7e3bb4d2006 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860399,chromium:851750 TBR=bungeman@chromium.org Change-Id: Id8a9f55a13cabab893e62411e1d9aac546313e4c Reviewed-on: https://chromium-review.googlesource.com/1138433Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575320}
-
Yi Su authored
Change the view from LoadingAlertCoordinator(custom view in MDC style) to AlertCoordinator(using UIAlertController). Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2e90457294e0b9c02466f2b501c8d1a4780739b3 Reviewed-on: https://chromium-review.googlesource.com/1135308 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#575319}
-
